1. 20 Jul, 2020 40 commits
    • Lee Jones's avatar
      iio: adc: palmas_gpadc: Demote non-conforming kerneldoc header · 315482a5
      Lee Jones authored
      Very few of the struct attributes have been documented here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'dev' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'palmas' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq_auto_0' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq_auto_1' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'adc_info' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'conv_completion' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup1_data' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup2_data' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup1_enable' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup2_enable' not described in 'palmas_gpadc'
      
      Cc: Pradeep Goudagunta <pgoudagunta@nvidia.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      315482a5
    • Lee Jones's avatar
      iio: adc: max9611: Demote obvious misuse of kerneldoc to standard comment blocks · 922fdc19
      Lee Jones authored
      No attempt has been made to document any of the demoted structs here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/max9611.c:117: warning: cannot understand function prototype: 'const unsigned int max9611_mux_conf[][2] = '
       drivers/iio/adc/max9611.c:145: warning: cannot understand function prototype: 'const unsigned int max9611_gain_conf[][2] = '
      
      Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
      Cc: Geert Uytterhoeven <geert+renesas@glider.be>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      922fdc19
    • Lee Jones's avatar
      iio: adc: max1363: Fix kerneldoc attribute formatting for 'lock' · ea448671
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/max1363.c:190: warning: Function parameter or member 'lock' not described in 'max1363_state'
      
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Rohit Sarkar <rohitsarkar5398@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      ea448671
    • Lee Jones's avatar
      iio: imu: st_lsm6dsx: st_lsm6dsx: Reorder 'inline' declaration · deb38af4
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:487:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=]
      
      Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
      Cc: Denis Ciocca <denis.ciocca@st.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      deb38af4
    • Lee Jones's avatar
      iio: gyro: fxas21002c: Move 'fxas21002c_reg_fields' to the only file its used · bfec5753
      Lee Jones authored
      'fxas21002c_reg_fields' is only used in '*core*', meaning that '*i2c*'
      and '*spi*' complain of a defined but not used const variable.  Let's
      move it into the source file.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from drivers/iio/gyro/fxas21002c_i2c.c:14:
       drivers/iio/gyro/fxas21002c.h:79:31: warning: ‘fxas21002c_reg_fields’ defined but not used [-Wunused-const-variable=]
       79 | static const struct reg_field fxas21002c_reg_fields[] = {
       | ^~~~~~~~~~~~~~~~~~~~~
       In file included from drivers/iio/gyro/fxas21002c_spi.c:14:
       drivers/iio/gyro/fxas21002c.h:79:31: warning: ‘fxas21002c_reg_fields’ defined but not used [-Wunused-const-variable=]
       79 | static const struct reg_field fxas21002c_reg_fields[] = {
       | ^~~~~~~~~~~~~~~~~~~~~
      
      Cc: Rui Miguel Silva <rmfrfs@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      bfec5753
    • Lee Jones's avatar
      iio: accel: sca3000: Fix 2 misspellings and demote nonconforming kerneldocs · fb37b5f8
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/accel/sca3000.c:210: warning: Function parameter or member 'mot_det_mult_xz' not described in 'sca3000_chip_info'
       drivers/iio/accel/sca3000.c:210: warning: Function parameter or member 'mot_det_mult_y' not described in 'sca3000_chip_info'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'indio_dev' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'chan' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'type' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'dir' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'info' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'val' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'val2' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'indio_dev' not described in 'sca3000_read_event_config'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'chan' not described in 'sca3000_read_event_config'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'type' not described in 'sca3000_read_event_config'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'dir' not described in 'sca3000_read_event_config'
      
      Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      fb37b5f8
    • Lee Jones's avatar
      iio: adc: cpcap-adc: Demote seemingly unintentional kerneldoc header · 95d61a67
      Lee Jones authored
      None of the headers demoted here provide any descriptions.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'ato_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'adc_ps_factor_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_ps_factor_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'ato_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'adc_ps_factor_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_ps_factor_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD0' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTP' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_VBUS' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD3' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BPLUS_AD4' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_CHG_ISENSE' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTI' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_USB_ID' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD8' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD9' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_LICELL' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_HV_BATTP' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSX1_AD12' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSX2_AD13' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSY1_AD14' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSY2_AD15' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTP_PI16' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTI_PI17' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_CHANNEL_NUM' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_IMM' not described in enum 'cpcap_adc_timing'
       drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_IN' not described in enum 'cpcap_adc_timing'
       drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_OUT' not described in enum 'cpcap_adc_timing'
      
      Cc: Tony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      95d61a67
    • Lee Jones's avatar
      iio: adc: at91-sama5d2_adc: Struct kerneldoc titles need to start with 'struct ' · 62eebcb6
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/at91-sama5d2_adc.c:360: warning: cannot understand function prototype: 'struct at91_adc_dma '
       drivers/iio/adc/at91-sama5d2_adc.c:379: warning: cannot understand function prototype: 'struct at91_adc_touch '
      
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Cc: Eugen Hristev <eugen.hristev@microchip.com>
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      62eebcb6
    • Lee Jones's avatar
      iio: adc: at91_adc: Fix 'bad line' warning · 4ab559a6
      Lee Jones authored
      All lines should start with ' *'.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/at91_adc.c:160: warning: bad line:                         (Interruptions registers mostly)
      
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      4ab559a6
    • Lee Jones's avatar
      iio: dac: ad5504: Fix formatting errors and demote non-compliant kerneldoc · 57f335cf
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mask' not described in 'ad5504_state'
       drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5504_state'
       drivers/iio/dac/ad5504.c:64: warning: cannot understand function prototype: 'enum ad5504_supported_device_ids '
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      57f335cf
    • Lee Jones's avatar
      iio: adc: ad799x: Demote seemingly unintentional kerneldoc header · 7574f1b4
      Lee Jones authored
      This is the only use of function related kerneldoc in the sourcefile
      and no descriptions are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/ad799x.c:192: warning: Function parameter or member 'irq' not described in 'ad799x_trigger_handler'
       drivers/iio/adc/ad799x.c:192: warning: Function parameter or member 'p' not described in 'ad799x_trigger_handler'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      7574f1b4
    • Lee Jones's avatar
      iio: light: us5182d: Fix formatting in kerneldoc function block · f356615f
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/light/us5182d.c:457: warning: Function parameter or member 'data' not described in 'us5182d_update_dark_th'
       drivers/iio/light/us5182d.c:457: warning: Function parameter or member 'index' not described in 'us5182d_update_dark_th'
       drivers/iio/light/us5182d.c:479: warning: Function parameter or member 'data' not described in 'us5182d_apply_scale'
       drivers/iio/light/us5182d.c:479: warning: Function parameter or member 'index' not described in 'us5182d_apply_scale'
      
      Cc: Adriana Reus <adriana.reus@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      f356615f
    • Lee Jones's avatar
      iio: temperature: mlx90632: Function parameter descriptions must match exactly · 7390192b
      Lee Jones authored
      '*'s are not welcome in kerneldoc parameter names.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/temperature/mlx90632.c:175: warning: Function parameter or member 'data' not described in 'mlx90632_perform_measurement'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarCrt Mori <cmo@melexis.com>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      7390192b
    • Lee Jones's avatar
      iio: light: si1145: Demote obvious misuse of kerneldoc to standard comment blocks · 43b0f929
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/light/si1145.c:192: warning: Function parameter or member 'data' not described in '__si1145_command_reset'
       drivers/iio/light/si1145.c:228: warning: Function parameter or member 'data' not described in 'si1145_command'
       drivers/iio/light/si1145.c:228: warning: Function parameter or member 'cmd' not described in 'si1145_command'
       drivers/iio/light/si1145.c:1186: warning: Function parameter or member 'trig' not described in 'si1145_trigger_set_state'
       drivers/iio/light/si1145.c:1186: warning: Function parameter or member 'state' not described in 'si1145_trigger_set_state'
      
      Cc: Chuhong Yuan <hslester96@gmail.com>
      Cc: Dan Leonard <leonard.crestez@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      43b0f929
    • Lee Jones's avatar
      iio: dac: ltc2632: Fix formatting in kerneldoc struct header · 0f2a3461
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'powerdown_cache_mask' not described in 'ltc2632_state'
       drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vref_mv' not described in 'ltc2632_state'
       drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vref_reg' not described in 'ltc2632_state'
      
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
      Cc: Silvan Murer <silvan.murer@gmail.com>
      Cc: Maxime Roussin-Belanger <maxime.roussinbelanger@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      0f2a3461
    • Lee Jones's avatar
      iio: adc: twl6030-gpadc: Fix some misdocumentation and formatting issues · dd54f40a
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'ideal' not described in 'twl6030_gpadc_platform_data'
       drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'channel_to_reg' not described in 'twl6030_gpadc_platform_data'
      
      Cc: Stephen Boyd <swboyd@chromium.org>
      Cc: Nishant Kamat <nskamat@ti.com>
      Cc: Balaji T K <balajitk@ti.com>
      Cc: Graeme Gregory <gg@slimlogic.co.uk>
      Cc: Girish S Ghongdemath <girishsg@ti.com>
      Cc: Ambresh K <ambresh@ti.com>
      Cc: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
      Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      dd54f40a
    • Lee Jones's avatar
      iio: magnetometer: hmc5843: 'hmc5843_pm_ops' is unused in 1 of 3 files including hmc5843_core.h · 5e2b006d
      Lee Jones authored
      We know that it's okay for 'hmc5843_pm_ops' to be unused here.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from include/linux/device.h:25,
       from include/linux/iio/iio.h:10,
       from drivers/iio/magnetometer/hmc5843_core.c:16:
       drivers/iio/magnetometer/hmc5843.h:55:26: warning: ‘hmc5843_pm_ops’ defined but not used [-Wunused-const-variable=]
       55 | static SIMPLE_DEV_PM_OPS(hmc5843_pm_ops,
       | ^~~~~~~~~~~~~~
       include/linux/pm.h:354:25: note: in definition of macro ‘SIMPLE_DEV_PM_OPS’
       354 | const struct dev_pm_ops name = { | ^~~~
      
      Cc: Josef Gajdusek <atx@atx.name>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      5e2b006d
    • Lee Jones's avatar
      iio: adc: twl4030-madc: Fix misnamed struct attribute · 2006cf16
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/twl4030-madc.c:170: warning: Function parameter or member 'usb3v1' not described in 'twl4030_madc_data'
      
      Also drop a duplicate description of the lock.
      
      Cc: J Keerthy <j-keerthy@ti.com>
      Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com>
      Cc: Amit Kucheria <amit.kucheria@canonical.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      2006cf16
    • Lee Jones's avatar
      iio: adc: twl4030-madc: Remove set but unused variables 'len' · 8856d5c7
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/twl4030-madc.c: In function ‘twl4030_madc_threaded_irq_handler’:
       drivers/iio/adc/twl4030-madc.c:475:9: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
       475 | int i, len, ret;
       | ^~~
      
      Cc: Sebastian Reichel <sre@kernel.org>
      Cc: J Keerthy <j-keerthy@ti.com>
      Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com>
      Cc: Amit Kucheria <amit.kucheria@canonical.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      8856d5c7
    • Lee Jones's avatar
      iio: adc: ti_am335x_adc: Remove a couple of unused 'read' variables · f83d87a0
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/ti_am335x_adc.c: In function ‘tiadc_buffer_preenable’:
       drivers/iio/adc/ti_am335x_adc.c:297:21: warning: variable ‘read’ set but not used [-Wunused-but-set-variable]
       297 | int i, fifo1count, read;
       | ^~~~
       drivers/iio/adc/ti_am335x_adc.c: In function ‘tiadc_buffer_predisable’:
       drivers/iio/adc/ti_am335x_adc.c:346:21: warning: variable ‘read’ set but not used [-Wunused-but-set-variable]
       346 | int fifo1count, i, read;
       | ^~~~
      
      Cc: Rachna Patil <rachna@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      f83d87a0
    • Lee Jones's avatar
      iio: imu: kmx61: Fix formatting in kerneldoc function headers · 0d674449
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'data' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'mode' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'device' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'update' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'data' not described in 'kmx61_set_power_state'
       drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'on' not described in 'kmx61_set_power_state'
       drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'device' not described in 'kmx61_set_power_state'
      
      Cc: Daniel Baluta <daniel.baluta@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      0d674449
    • Lee Jones's avatar
      iio: magnetometer: mmc35240: Fix function header formatting · faa4540e
      Lee Jones authored
      All lines in the header must start with " *".
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/magnetometer/mmc35240.c:304: warning: bad line:                             compensation for output value.
      
      Cc: Daniel Baluta <daniel.baluta@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      faa4540e
    • Lee Jones's avatar
      iio: light: cm32181: Fix formatting and docrot issues in cm32181_acpi_get_cpm() · 61f3e708
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/light/cm32181.c:107: warning: Function parameter or member 'dev' not described in 'cm32181_acpi_get_cpm'
       drivers/iio/light/cm32181.c:107: warning: Function parameter or member 'obj_name' not described in 'cm32181_acpi_get_cpm'
       drivers/iio/light/cm32181.c:107: warning: Function parameter or member 'values' not described in 'cm32181_acpi_get_cpm'
       drivers/iio/light/cm32181.c:107: warning: Function parameter or member 'count' not described in 'cm32181_acpi_get_cpm'
      
      Cc: Kevin Tsai <ktsai@capellamicro.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      61f3e708
    • Lee Jones's avatar
      iio: dac: ad5791: Complete 'struct ad5791_chip_info' documentation · 3b1c0b12
      Lee Jones authored
      ... and remove seemingly pointless comment.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'ctrl' not described in 'ad5791_state'
       drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5791_state'
       drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down' not described in 'ad5791_state'
       drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'data' not described in 'ad5791_state'
       drivers/iio/dac/ad5791.c:103: warning: cannot understand function prototype: 'enum ad5791_supported_device_ids '
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      3b1c0b12
    • Lee Jones's avatar
      iio: dac: ad5764: Fix misdocumenting and formatting error · d808988e
      Lee Jones authored
      Attribute descriptions must match the name exactly.
      
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5764.c:42: warning: Function parameter or member 'channels' not described in 'ad5764_chip_info'
       drivers/iio/dac/ad5764.c:67: warning: Function parameter or member 'lock' not described in 'ad5764_state'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      d808988e
    • Lee Jones's avatar
      iio: dac: ad5761: Fix kerneldoc attribute formatting for 'lock' · 53001d55
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5761.c:80: warning: Function parameter or member 'lock' not described in 'ad5761_state'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Ricardo Ribalda <ribalda@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      53001d55
    • Lee Jones's avatar
      iio: dac: ad5758: Move and fix-up kerneldoc header and demote unworthy kerneldoc · ac09f3d5
      Lee Jones authored
      Kerneldoc headers need to come directly before the function/struct
      that they are documenting.  Also fix some missing descriptions and
      misspellings.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5758.c:111: warning: Function parameter or member 'reg' not described in 'ad5758_range'
       drivers/iio/dac/ad5758.c:111: warning: Function parameter or member 'min' not described in 'ad5758_range'
       drivers/iio/dac/ad5758.c:111: warning: Function parameter or member 'max' not described in 'ad5758_range'
       drivers/iio/dac/ad5758.c:122: warning: Function parameter or member 'gpio_reset' not described in 'ad5758_state'
       drivers/iio/dac/ad5758.c:122: warning: Function parameter or member 'd32' not described in 'ad5758_state'
       drivers/iio/dac/ad5758.c:137: warning: cannot understand function prototype: 'enum ad5758_output_range '
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Cc: Stefan Popa <stefan.popa@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      ac09f3d5
    • Lee Jones's avatar
      iio: dac: ad5755: Fix kerneldoc attribute formatting for 'lock' · f165a54e
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5755.c:105: warning: Function parameter or member 'lock' not described in 'ad5755_state'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      f165a54e
    • Lee Jones's avatar
      iio: dac: ad5449: Fix kerneldoc attribute formatting for 'lock' · 9cf23b6b
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5449.c:75: warning: Function parameter or member 'lock' not described in 'ad5449'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      9cf23b6b
    • Lee Jones's avatar
      iio: dac: ad5446: Complete 'struct ad5446_state' doc and demote unworthy kerneldocs · af390b8c
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'dev' not described in 'ad5446_state'
       drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'cached_val' not described in 'ad5446_state'
       drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5446_state'
       drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down' not described in 'ad5446_state'
       drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'lock' not described in 'ad5446_state'
       drivers/iio/dac/ad5446.c:323: warning: cannot understand function prototype: 'enum ad5446_supported_spi_device_ids '
       drivers/iio/dac/ad5446.c:545: warning: cannot understand function prototype: 'enum ad5446_supported_i2c_device_ids '
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      af390b8c
    • Lee Jones's avatar
      iio: dummy: iio_simple_dummy_buffer: Demote file header and correct misspelling · dd2e16cf
      Lee Jones authored
      File headers are not good candidates for kerneldoc.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dummy/iio_simple_dummy_buffer.c:27: warning: cannot understand function prototype: 'const s16 fakedata[] = '
       drivers/iio/dummy/iio_simple_dummy_buffer.c:185: warning: Function parameter or member 'indio_dev' not described in 'iio_simple_dummy_unconfigure_buffer'
       drivers/iio/dummy/iio_simple_dummy_buffer.c:185: warning: Excess function parameter 'indo_dev' description in 'iio_simple_dummy_unconfigure_buffer'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      dd2e16cf
    • Lee Jones's avatar
      iio: adc: ad7887: Demote seemingly unintentional kerneldoc header · 05eb6d32
      Lee Jones authored
      This is the only use of function related kerneldoc in the sourcefile
      and no descriptions are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/ad7887.c:119: warning: Function parameter or member 'irq' not described in 'ad7887_trigger_handler'
       drivers/iio/adc/ad7887.c:119: warning: Function parameter or member 'p' not described in 'ad7887_trigger_handler'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      05eb6d32
    • Lee Jones's avatar
      iio: dac: ad5064: Value returned by ad5064_vref_name may not be 'const * const' · d3c90aa7
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5064.c:790:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
       790 | static const char * const ad5064_vref_name(struct ad5064_state *st,
       | ^~~~~
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      d3c90aa7
    • Lee Jones's avatar
      iio: dummy: iio_simple_dummy_events: Demote file header and supply descriptions for val2 params · 5a0a8455
      Lee Jones authored
      File headers are not good candidates for kerneldoc.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dummy/iio_simple_dummy_events.c:21: warning: Incorrect use of kernel-doc format:  * iio_simple_dummy_read_event_config() - is event enabled?
       drivers/iio/dummy/iio_simple_dummy_events.c:34: warning: Function parameter or member 'indio_dev' not described in 'iio_simple_dummy_read_event_config'
       drivers/iio/dummy/iio_simple_dummy_events.c:34: warning: Function parameter or member 'chan' not described in 'iio_simple_dummy_read_event_config'
       drivers/iio/dummy/iio_simple_dummy_events.c:34: warning: Function parameter or member 'type' not described in 'iio_simple_dummy_read_event_config'
       drivers/iio/dummy/iio_simple_dummy_events.c:34: warning: Function parameter or member 'dir' not described in 'iio_simple_dummy_read_event_config'
       drivers/iio/dummy/iio_simple_dummy_events.c:123: warning: Function parameter or member 'val2' not described in 'iio_simple_dummy_read_event_value'
       drivers/iio/dummy/iio_simple_dummy_events.c:146: warning: Function parameter or member 'val2' not described in 'iio_simple_dummy_write_event_value'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      5a0a8455
    • Lee Jones's avatar
      iio: dac: ad5421: Fix kerneldoc attribute formatting for 'lock' · 140d5532
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5421.c:82: warning: Function parameter or member 'lock' not described in 'ad5421_state'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      140d5532
    • Lee Jones's avatar
      iio: dummy: iio_simple_dummy: Add newline after function-end · bc022cb7
      Lee Jones authored
      Fixes the following checkpatch.pl warning(s):
      
       CHECK: Please use a blank line after function/struct/union/enum declarations
       #46: FILE: drivers/iio/dummy/iio_simple_dummy.c:690:
        }
       +/*
       total: 0 errors, 0 warnings, 1 checks, 22 lines checked
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      bc022cb7
    • Lee Jones's avatar
      iio: dummy: iio_simple_dummy: Demote unworthy kerneldocs and correct wrong parameter in docs · 36d1368d
      Lee Jones authored
      File header comments are not good candidates for kerneldoc.  Neither
      are generic comment blocks.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dummy/iio_simple_dummy.c:26: warning: cannot understand function prototype: 'const struct config_item_type iio_dummy_type = '
       drivers/iio/dummy/iio_simple_dummy.c:564: warning: Function parameter or member 'name' not described in 'iio_dummy_probe'
       drivers/iio/dummy/iio_simple_dummy.c:564: warning: Excess function parameter 'index' description in 'iio_dummy_probe'
       drivers/iio/dummy/iio_simple_dummy.c:700: warning: cannot understand function prototype: 'const struct iio_sw_device_ops iio_dummy_device_ops = '
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      36d1368d
    • Lee Jones's avatar
      iio: dac: ad5380: Fix kerneldoc attribute formatting for 'lock' · 12630129
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5380.c:64: warning: Function parameter or member 'lock' not described in 'ad5380_state'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      12630129
    • Lee Jones's avatar
      iio: dac: ad5360: Fix kerneldoc attribute formatting for 'lock' · a73051fc
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5360.c:89: warning: Function parameter or member 'lock' not described in 'ad5360_state'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      a73051fc
    • Lee Jones's avatar
      iio: adc: ad7923: Demote obvious misuse of kerneldoc to standard comment blocks · 700b60e1
      Lee Jones authored
      No attempt has been made to document either of the demoted functions here
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/ad7923.c:159: warning: Function parameter or member 'indio_dev' not described in 'ad7923_update_scan_mode'
       drivers/iio/adc/ad7923.c:159: warning: Function parameter or member 'active_scan_mask' not described in 'ad7923_update_scan_mode'
       drivers/iio/adc/ad7923.c:202: warning: Function parameter or member 'irq' not described in 'ad7923_trigger_handler'
       drivers/iio/adc/ad7923.c:202: warning: Function parameter or member 'p' not described in 'ad7923_trigger_handler'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Cc: Patrick Vasseur <patrick.vasseur@c-s.fr>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      700b60e1