- 28 Aug, 2017 13 commits
-
-
Harish Chegondi authored
Clean up user_sdma.c by moving the structure and MACRO definitions into the header file user_sdma.h Reviewed-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Harish Chegondi <harish.chegondi@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Harish Chegondi authored
Clean up user_exp_rcv.c file by moving structure definitions into header file user_exp_rcv.h. Since these structure definitions depend on the structure definitions in mmu_rb.h, move #include "mmu_rb.h" above the include "user_exp_rcv.h" or include of header files that include user_exp_rcv.h Reviewed-by:
-
Harish Chegondi authored
num_user_pages() function has been defined in both user_exp_rcv.c file and user_sdma.c file. Move the function definition to a header file so there is only one definition in the source repo. Reviewed-by:
-
Harish Chegondi authored
In pin_vector_pages() function, if there is any error while pinning the pages or while adding a pinned buffer to the cache, the bail out code needs to unpin any pinned pages that are not in the cache and adjust the n_locked counter that counts the total pages pinned. The current bail out code doesn't seem to be doing it right in two cases: 1. Before pinning required pages for a buffer, the SDMA pinned buffer cache is searched to see if the virtual address range that needs to be pinned is already pinned. If there isn't a hit in the cache, a new node is created for the buffer and is added to the cache after the buffer is pinned. If adding the new node to the cache fails, the n_locked count is decremented properly but the pinned pages are not freed. This commit fixes this issue. 2. If there is a hit in the SDMA cache, but the cached buffer doesn't have enough pages to cover the entire address range that needs to be pinned, the node for the cached buffer is extracted from the cache, remaining pages needed are pinned and added to the node. The node is finally added back into the cache. If there is an error pinning the extra pages, the bail out code frees all the pages in the node but the n_locked count is not being decremented by the no of pages in the node that are freed. This commit fixes this issue. This commit fixes the above two issues by creating a new function that frees the pages in a node and decrements the n_locked count by the number of pages freed. Reviewed-by:
-
Harish Chegondi authored
Clean up pin_vector_pages() function by moving page pinning related code to a separate function since it really stands on its own. Reviewed-by:
-
Harish Chegondi authored
user_sdma_send_pkts() function is unnecessarily long. Clean it up by moving some of its code into separate functions. Reviewed-by:
-
Harish Chegondi authored
Clean up hfi1_user_exp_rcv_setup function by moving page pinning and unpinning related code to separate functions. In order to reduce the number of parameters passed between functions, a new data structure struct tid_user_buf is defined and used. Reviewed-by:
-
Michael J. Ruhl authored
Performance analysis shows that the cache callback function sdma_kmem_cache_ctor contributes to 1/2 of the kmem_cache_allocs time. Since all of the fields in the allocated data structure are initialized in the code path, remove the _ctor function. Reviewed-by:
Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by:
Michael J. Ruhl <michael.j.ruhl@intel.com> Signed-off-by:
-
Grzegorz Morys authored
Ratelimit error prints from sdma_interrupt function that could swarm dmesg otherwise. Reviewed-by:
Grzegorz Morys <grzegorz.morys@intel.com> Signed-off-by:
-
Kamenee Arumugam authored
Added checking on index value of array 'guids' in qib_ruc.c. Pass in corrrect size of array for memset operation in qib_mad.c. Reviewed-by:
Kamenee Arumugam <kamenee.arumugam@intel.com> Signed-off-by:
-
Kamenee Arumugam authored
Remove all the memory allocation implemented for boardname and directly assign the defined string literal. Reviewed-by:
-
Mike Marciniszyn authored
Section 9.7.7.2.5 of the 1.3 IBTA spec clearly says that receive credits should never apply to RDMA write. qib and hfi1 were doing that. The following situation will result in a QP hang: - A prior SEND or RDMA_WRITE with immmediate consumed the last credit for a QP using RC receive buffer credits - The prior op is acked so there are no more acks - The peer ULP fails to post receive for some reason - An RDMA write sees that the credits are exhausted and waits - The peer ULP posts receive buffers - The ULP posts a send or RDMA write that will be hung The fix is to avoid the credit test for the RDMA write operation. Cc: <stable@vger.kernel.org> Reviewed-by:
Kaike Wan <kaike.wan@intel.com> Signed-off-by:
-
Mike Marciniszyn authored
hfi1 and qib were converted in previous patches, do the same for rdmavt. Signed-off-by:
-
- 25 Aug, 2017 1 commit
-
-
Doug Ledford authored
Signed-off-by:
-
- 24 Aug, 2017 26 commits
-
-
Bodong Wang authored
Expose enhanced multi packet WQE capability to user space through query_device by uhw. Signed-off-by:
Bodong Wang <bodong@mellanox.com> Reviewed-by:
Daniel Jurgens <danielj@mellanox.com> Signed-off-by:
Leon Romanovsky <leon@kernel.org> Signed-off-by:
-
Bodong Wang authored
Set the field to allow posting multi packet send WQEs if hardware supports this feature. This doesn't mean the send WQEs will be for multi packet unless the send WQE was prepared according to multi packet send WQE format. User space shall use flag MLX5_IB_ALLOW_MPW to check if hardware supports MPW and allows MPW in SQ context. Signed-off-by:
-
Yishai Hadas authored
Set underlay QPN as part of flow rule when it's applicable. There is one root flow table in the NIC RX namespace and all the underlay QPs steer the traffic to this flow table. In order to prevent QP to get traffic which is not target to its underlay QP, we need to set the underlay QP number as part of the steering matching. Note: When multicast traffic is sent the QPN filtering is done by the firmware as some early step. Adding the QPN match on the flow table entry is wrong as by that time the target QPN holds the multicast address (e.g. FF(s)) and it won't match. Signed-off-by:
Yishai Hadas <yishaih@mellanox.com> Signed-off-by:
-
Ilya Lesokhin authored
Fix a bug where MR registration fails when mlx5_ib_cont_pages indicates that the MR can be mapped using 2GB pages (page_shift == 31). Fixes: e126ba97 ("mlx5: Add driver for Mellanox Connect-IB adapters") Signed-off-by:
Ilya Lesokhin <ilyal@mellanox.com> Signed-off-by:
-
Kamal Heib authored
In clean_mr error path the 'mr' should be freed. Fixes: e126ba97 ('mlx5: Add driver for Mellanox Connect-IB adapters') Signed-off-by:
Kamal Heib <kamalh@mellanox.com> Signed-off-by:
-
Ilya Lesokhin authored
mlx5 compatible devices have two ways of populating the MTT table of an MKEY: using a FW command and using a UMR WQE. A UMR is much faster, so it should be used whenever possible. Unfortunately the code today uses UMR only if the MKEY was allocated from the MR cache. Fix the code to use UMR even for MKEYs that were allocated using a FW command. Signed-off-by:
-
Ilya Lesokhin authored
This patch is the first step in decoupling UMR usage and allocation from the MR cache. The only functional change in this patch is to enables UMR for MRs created with reg_create. This change fixes a bug where ODP memory regions that were not allocated from the MR cache did not have UMR enabled. Signed-off-by:
-
Noa Osherovich authored
Software parsing (SWP) is a feature that can be used to instruct the device to stop using its internal parser and to parse packets on the transmit path according to offsets set for each packets. Through this feature, the device allows the handling of checksum and LSO by the hardware according to the location of IP and TCP/UDP headers. Enable SW parsing on Raw Ethernet send queue by default if firmware supports it and report these capabilities to user space. Signed-off-by:
Noa Osherovich <noaos@mellanox.com> Reviewed-by:
Maor Gottlieb <maorg@mellanox.com> Signed-off-by:
-
Yuval Shaia authored
None of the calls to i40iw_netdev_vlan_ipv6 are using mac so let's remove it from func's args-list. Signed-off-by:
Yuval Shaia <yuval.shaia@oracle.com> Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in DP_ERR error message Signed-off-by:
Colin Ian King <colin.king@canonical.com> Reviewed-by:
Leon Romanovsky <leonro@mellanox.com> Reviewed-by:
Ram Amrani <Ram.Amrani@cavium.com> Signed-off-by:
-
Selvin Xavier authored
IB CM calls ib_modify_port() irrespective of link layer. If the failure is returned, the mad agent gets unregistered for those devices. Recently, modify_port() hook was removed from some of the low level drivers as it was always returning success. This breaks rdma connection establishment over those devices. For ethernet devices, Qkey violation and port capabilities are not applicable. So returning success for RoCE when modify_port hook is is not implemented. Cc: Leon Romanovsky <leon@kernel.org> Signed-off-by:
Selvin Xavier <selvin.xavier@broadcom.com> Reviewed-by:
-
Adit Ranadive authored
Added support for two device caps - max_sge_rd, max_fast_reg_page_list_len and the IP_BASED_GIDS port cap flag. Reviewed-by:
Jorgen Hansen <jhansen@vmware.com> Reviewed-by:
Bryan Tan <bryantan@vmware.com> Reviewed-by:
Aditya Sarwade <asarwade@vmware.com> Signed-off-by:
Adit Ranadive <aditr@vmware.com> Reviewed-by:
-
Bryan Tan authored
The driver version is bumped for compatibility purposes. Also, send correct GID type during register to device. Added compatibility check macros for the device. Reviewed-by:
-
Feras Daoud authored
Adds support for ioctl callback in the RDMA netdevs to allow supporting functions not handled by the generic interface code. Signed-off-by:
Feras Daoud <ferasda@mellanox.com> Signed-off-by:
Eitan Rabin <rabin@mellanox.com> Signed-off-by:
-
Leon Romanovsky authored
There is no need to explicitly zero parameters, because the structure requested to be filled already initialized to zeros. Signed-off-by:
-
Leon Romanovsky authored
The rdma_port_get_link_layer() returns enum rdma_link_layer as a return value, hence it is better to store the return value in specially annotated variable and not in int. Signed-off-by:
-
Leon Romanovsky authored
The mlx5_ib_get_vector_affinity() call is local to main.c file and there is no need to be declared globally visible. Fixes: 40b24403 ("mlx5: support ->get_vector_affinity") Signed-off-by:
-
Kamal Heib authored
rxe_counter_name is used in rxe_hw_counters.c only. Make it static. Fixes: 0b1e5b99 ('IB/rxe: Add port protocol stats') Signed-off-by:
Yonatan Cohen <yonatanc@mellanox.com> Signed-off-by:
-
Erez Shitrit authored
In order to avoid deadlock between sysfs functions (like create/delete child) and remove_one (both of them are using the sysfs lock and rtnl_lock) the driver will use a state mutex for sync. That will fix traces as the following: schedule+0x3e/0x90 kernfs_drain+0x75/0xf0 ? wait_woken+0x90/0x90 __kernfs_remove+0x12e/0x1c0 kernfs_remove+0x25/0x40 sysfs_remove_dir+0x57/0x90 kobject_del+0x22/0x60 device_del+0x195/0x230 pm_runtime_set_memalloc_noio+0xac/0xf0 netdev_unregister_kobject+0x71/0x80 rollback_registered_many+0x205/0x2f0 rollback_registered+0x31/0x40 unregister_netdevice_queue+0x58/0xb0 unregister_netdev+0x20/0x30 ipoib_remove_one+0xb7/0x240 [ib_ipoib] ib_unregister_device+0xbc/0x1b0 [ib_core] ib_unregister_mad_agent+0x29/0x30 [ib_core] mlx4_ib_remove+0x67/0x280 [mlx4_ib] INFO: task echo:24082 blocked for more than 120 seconds. Tainted: G OE 4.1.12-37.5.1.el6uek.x86_64 #2 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. Call Trace: schedule+0x3e/0x90 schedule_preempt_disabled+0xe/0x10 __mutex_lock_slowpath+0x95/0x110 ? _rcu_barrier+0x177/0x220 mutex_lock+0x23/0x40 rtnl_lock+0x15/0x20 netdev_run_todo+0x81/0x1f0 rtnl_unlock+0xe/0x10 ipoib_vlan_delete+0x12f/0x1c0 [ib_ipoib] delete_child+0x69/0x80 [ib_ipoib] dev_attr_store+0x20/0x30 sysfs_kf_write+0x41/0x50 Signed-off-by:
Erez Shitrit <erezsh@mellanox.com> Reviewed-by:
Alex Vesker <valex@mellanox.com> Signed-off-by:
-
Guy Levi authored
According to mlx4 convention, need to fail the command due to a non-zero value in the user data which is expected to be zero. Fixes: 3078f5f1 ("IB/mlx4: Add support for RSS QP") Signed-off-by:
Guy Levi <guyle@mellanox.com> Signed-off-by:
-
Guy Levi authored
rx_key_len is not in use and needs to be removed. Fixes: 3078f5f1 ("IB/mlx4: Add support for RSS QP") Signed-off-by:
-
Guy Levi authored
The mlx4 ABI defines to have structures with alignment of 64B. Fixes: 400b1ebc ("IB/mlx4: Add support for WQ related verbs") Signed-off-by:
-
Guy Levi authored
The mlx4 was designed to support QP type of MLX4_IB_QPT_RAW_PACKET. Fixes: 3078f5f1 ("IB/mlx4: Add support for RSS QP") Signed-off-by:
-
Maor Gottlieb authored
Assign the statistics and configuration structure pointer on success. Fixes: fe248c3a ('IB/mlx5: Add delay drop configuration and statistics') Signed-off-by:
-
Talat Batheesh authored
Fix spelling mistakes in remarks "retrun"->"return" "Decalring"->"Declaring" Signed-off-by:Talat Batheesh <talatb@mellanox.com> Signed-off-by:
-
Talat Batheesh authored
Fix spelling mistakes in remarks "retrun"->"return" "cancell"->"cancel" Signed-off-by:
-
