- 29 Aug, 2011 40 commits
-
-
Emmanuel Grumbach authored
Move all the iwlXXX_abgn_cfg forward declaration to a separate file so that iwl-pci.c doesn't need to include iwl-agn.h that includes all iwl-dev.h This allows to provide real encapsulation. Dereferencing iwl_priv in the bus layer will now lead to a compilation error. Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by:
Wey-Yi Guy <wey-yi.w.guy@intel.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Daniel Halperin authored
CC [M] drivers/net/wireless/iwlwifi/iwl-pci.o drivers/net/wireless/iwlwifi/iwl-pci.c:506: warning: iwl_pci_suspend defined but not used drivers/net/wireless/iwlwifi/iwl-pci.c:519: warning: iwl_pci_resume defined but not used These are only used if CONFIG_PM_SLEEP is enabled. CONFIG_PM depends (CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME), so it can be set without CONFIG_PM_SLEEP selected. Signed-off-by:
Daniel Halperin <dhalperi@cs.washington.edu> Signed-off-by:
-
Emmanuel Grumbach authored
Which means that iwl-io.c doesn't need to include iwl-dev.h any more. Signed-off-by:
-
Emmanuel Grumbach authored
a few h files weren't self contained. Fix that. Move iwl_dma_ptr to transport layer since it is not used by the upper layer any more. Signed-off-by:
-
Emmanuel Grumbach authored
It is relevant for PCIe only. Signed-off-by:
-
Emmanuel Grumbach authored
Since iwl-fh.h contains transport related data, it shouldn't be included by the upper layer. Only the transport layer and iwl-agn-ucode.c includes it. Signed-off-by:
-
Emmanuel Grumbach authored
Some of them weren't used at all, the others always had the same value since the driver split. Signed-off-by:
-
Emmanuel Grumbach authored
Continue to the clean up of the priv dereferencing from the transport layer. Signed-off-by:
-
Emmanuel Grumbach authored
These are transport layer related. Move also the corresponding debugfs handlers. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is needed for host commands only, it is needed in transport layer only Signed-off-by:
-
Emmanuel Grumbach authored
Change a lot of functions to have them receive iwl_trans and not iwl_priv. Signed-off-by:
-
Emmanuel Grumbach authored
This helper is used by the transport and the upper layer. Kill __iwl_free_pages which was used in the transport only. Signed-off-by:
-
Emmanuel Grumbach authored
Logic move after all priv->status moved to struct iwl_shared Signed-off-by:
-
Emmanuel Grumbach authored
BUILD_BUG_ON(ARRAY_SIZE(iwlagn_ipan_queue_to_tx_fifo) != IWLAGN_FIRST_AMPDU_QUEUE); This check can be buggy. IWLAGN_FIRST_AMPDU_QUEUE has to be greater than the ARRAY_SIZE of iwlagn_ipan_queue_to_tx_fifo. Signed-off-by:
-
Emmanuel Grumbach authored
Needed for PCIe only Signed-off-by:
-
Emmanuel Grumbach authored
Now that the reclaim flow has been moved to the transport layer, a lot of functions can be made static or don't need to be exported outside the transport layer. Signed-off-by:
-
Emmanuel Grumbach authored
The reclaim flow is really transport related. Define a simple API to allow the upper layer to request from the transport layer to reclaim packets until an index written in the Tx response / BA notification. The transport layer prepares a list of the packets that are being freed and passes this list to the upper layer. Between the two layers, the CB of the skb is used to pass a pointer to the context (BSS / PAN) in which the skb was sent. Signed-off-by:
-
Emmanuel Grumbach authored
It is accessed by the transport layer only, hence the move. The debugfs handlers that accessed it moved to the transport layer too. The rx_handlers part of it stayed in the upper layer and a special debugfs has been added for it Also add missing includes to iwl-commands.h. Signed-off-by:
-
Wey-Yi Guy authored
Add more comments to iwl_mod_params Signed-off-by:
-
Wey-Yi Guy authored
Add comments for better description Signed-off-by:
-
Wey-Yi Guy authored
Different subsystem ID Signed-off-by:
-
Wey-Yi Guy authored
Enable HT aggregation when it reach reasonable traffic without checking traffic load which delay enabling the aggregation and lower the throughput but this behavior can be overwrite by module parameter this address https://bugzilla.kernel.org/show_bug.cgi?id=40042Signed-off-by:
-
Emmanuel Grumbach authored
It is transport dependent, move to the PCIe transport layer. Signed-off-by:
-
Emmanuel Grumbach authored
Since the ISR is entirely in the transport layer, its data should be in the pcie specific region. Change sync_irq to first disable and then synchronize the IRQ. iwl_isr and iwl_isr_ict now receive iwl_trans. Signed-off-by:
-
Emmanuel Grumbach authored
These flows needs to access the APM and a few other registers that can differ between different transports. Signed-off-by:
-
Emmanuel Grumbach authored
Since this struct is specific to pcie transport, move it the the pcie specific transport layer. Signed-off-by:
-
Emmanuel Grumbach authored
Add a handler in iwl_trans_ops to allow it to add entries under debugfs dir given by the upper level. Signed-off-by:
-
Emmanuel Grumbach authored
Rename the recursive inclusion protection in iwl-bus.h while we are at it. Signed-off-by:
-
Emmanuel Grumbach authored
Remove iwl_transport_register which was a W/A. The bus layer knows what transport to use. So now, the bus layer gives the upper layer a pointer to the iwl_trans_ops struct that it wants to use. The upper layer then, allocates the desired transport layer using iwl_trans_ops->alloc function. As a result of this, priv->trans, no longer exists, priv holds a pointer to iwl_shared, which holds a pointer to iwl_trans. This required to change all the calls to the transport layer from upper layer. While we were at it, trans_X inlines have been renamed to iwl_trans_X to avoid confusions, which of course required to rename the functions inside the transport layer because of conflicts in names. So the static API functions inside the transport layer implementation have been renamed to iwl_trans_pcie_X. Until now, the IRQ / Tasklet were initialized in iwl_transport_layer. This is confusing since the registration doesn't mean to request IRQ, so I added a handler for that. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is used by all the layers, it needs to move to iwl_shared. Signed-off-by:
-
Emmanuel Grumbach authored
instead of IWL_DEBUG(priv, IWL_DL_FW_ERRORS Signed-off-by:
-
Emmanuel Grumbach authored
Since all the layers need to print debug message, the debug macro cannot suppose that they will be given iwl_priv as a parameter and then dereference it. Use iwl_shared instead. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is used by all the layers, it needs to move to iwl_shared. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is used by all the layers, it needs to move to iwl_shared. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is used by all the layers, it needs to move to iwl_shared. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is used by all the layers, it needs to move to iwl_shared. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is used by all the layers, it needs to move to iwl_shared. Signed-off-by:
-
Emmanuel Grumbach authored
Since it is used by all the layers, it needs to move to iwl_shared. Signed-off-by:
-
Emmanuel Grumbach authored
This will allow all the modules to look at it. Signed-off-by:
-
Emmanuel Grumbach authored
This struct will hold pointers to all the layers, so that every layer will find the pointers it needs when calling another layer. Note that the drv_data set to struct device is now a pointer to struct iwl_shared. This solves of bug that I introduced in iwlagn: simplify the bus architecture Bug description: sysfs gets the the driver data from struct device. Till the aforementioned patch, dev_get_drvdata would return iwl_priv. After the patch, dev_get_drvdata return iwl_bus which is buggy since the sysfs handlers rely on this value, and sysfs handlers need iwl_priv. Now, dev_get_drvdata return iwl-shared. Since we have pointers to all the layers in iwl_shared, every layer will be able to get the pointer it needs: bus layer will gets iwl_bus from the PCI suspend callbacks, and the sysfs handlers will get the iwl_priv they need. In order to keep good encapsulation, we need to avoid to dereference iwl_priv from a different layer. This is why instead of including iwl-dev.h from iwl-shared.h, I added a forward declaration to iwl_priv. Moreover we keep type safety while providing encapsulation. Signed-off-by:
-
