1. 10 Jan, 2004 9 commits
    • Hirofumi Ogawa's avatar
      [PATCH] 8139too warning fix (1/2) · 3a7b6443
      Hirofumi Ogawa authored
       drivers/net/8139too.c |    2 ++
       1 files changed, 2 insertions(+)
      3a7b6443
    • Hirofumi Ogawa's avatar
      [PATCH] 8139too NAPI for net-drivers-2.5-exp · 108e0d19
      Hirofumi Ogawa authored
      Jeff Garzik <jgarzik@pobox.com> writes:
      
      > Stephen Hemminger wrote:
      > > Here is the 8139too version in net-drivers-2.5-exp modified for NAPI.
      > > Also:
      > > 	64k receive ring - has to handle wrap for that case;
      > > 	   the NoWrap flag does nothing if using this big ring.
      > > 	assert() -> BUG_ON()
      > >
      > > To deal with the races with tx_timeout, put back in the rx_lock from earlier versions.
      
      > +		local_irq_disable();
      > +		netif_rx_complete(dev);
      > +		RTL_W16_F(IntrMask, rtl8139_intr_mask);
      > +		local_irq_enable();
      
      Probably, by my mistake in previous mail. Sorry.  This still has the
      races condition. It can trigger the same problem by shared interrupt
      on SMP.
      
      Probably the following ISR style should use the below combination.
      
         in ISR
      	if (netif_rx_schedule_prep(dev)) {
      		RTL_W16 (IntrMask, rtl8139_norx_intr_mask);
      		__netif_rx_schedule(dev);
      	}
      
         in ->poll
      	local_irq_disable();
      	RTL_W16_F(IntrMask, rtl8139_intr_mask);
      	__netif_rx_complete(dev);
      	local_irq_enable();
      
      
      And another one should use the below combination.  (this style can
      change the flags of __LINK_STATE_RX_SCHED or __LINK_STATE_START anytime)
      
         in ISR
      	if (status & RxAckBits) {
      		RTL_W16_F (IntrMask, rtl8139_norx_intr_mask);
      		netif_rx_schedule (dev);
      	}
      
         in ->poll
      	local_irq_disable();
      	__netif_rx_complete(dev);
      	RTL_W16_F(IntrMask, rtl8139_intr_mask);
      	local_irq_enable();
      
         If happen the shared interrupt, the this ISR style may lose a
         chance of netif_rx_schedule().
      
      
      Anyway, the following patch should fix the problem. Please apply.
      
      Thanks.
      --
      OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
      
       drivers/net/8139too.c |    2 +-
       1 files changed, 1 insertion(+), 1 deletion(-)
      108e0d19
    • Stephen Hemminger's avatar
      [PATCH] (3/3) 8139too -- poll_controller · dda9a209
      Stephen Hemminger authored
      For net-drivers-2.5-exp, add a poll_controller hook to allow use of netconsole
      with this driver.
      
      jeff, don't have netconsole setup to test this so please give it a try before
      including it.
      dda9a209
    • Stephen Hemminger's avatar
      [PATCH] (2/3) 8139too -- configurable receive ring · bcb30967
      Stephen Hemminger authored
      For net-drivers-2.5-exp:  Make the receive window configurable and go
      back to the original 32K by default.
      bcb30967
    • Stephen Hemminger's avatar
      [PATCH] (1/3) 8139too -- put back old assert · 62a15a0f
      Stephen Hemminger authored
      For net-drivers-2.5-exp:
      Minimize code changes -- put back assert() macro with similar properties
      to the original.  Added unlikely() and KERN_ERR tag.
      62a15a0f
    • Stephen Hemminger's avatar
      [PATCH] 8139too NAPI for net-drivers-2.5-exp · d59bf697
      Stephen Hemminger authored
      Here is the 8139too version in net-drivers-2.5-exp modified for NAPI.
      Also:
      	64k receive ring - has to handle wrap for that case;
      	   the NoWrap flag does nothing if using this big ring.
      	assert() -> BUG_ON()
      
      To deal with the races with tx_timeout, put back in the rx_lock from earlier versions.
      d59bf697
    • Xose Vazquez Perez's avatar
      [PATCH] more RTL-8139 clone boards · da270830
      Xose Vazquez Perez authored
      da270830
    • Jeff Garzik's avatar
      [netdrvr] remove Documentation/networking/8139too.txt · 3dc6eb82
      Jeff Garzik authored
      All sections of the document are woefully outdated.
      3dc6eb82
    • Krishna Kumar's avatar
      fae44683
  2. 09 Jan, 2004 3 commits
  3. 08 Jan, 2004 28 commits