1. 25 Mar, 2023 2 commits
  2. 24 Mar, 2023 6 commits
    • Josua Mayer's avatar
      net: phy: dp83869: fix default value for tx-/rx-internal-delay · 82e2c39f
      Josua Mayer authored
      dp83869 internally uses a look-up table for mapping supported delays in
      nanoseconds to register values.
      When specific delays are defined in device-tree, phy_get_internal_delay
      does the lookup automatically returning an index.
      
      The default case wrongly assigns the nanoseconds value from the lookup
      table, resulting in numeric value 2000 applied to delay configuration
      register, rather than the expected index values 0-7 (7 for 2000).
      Ultimately this issue broke RX for 1Gbps links.
      
      Fix default delay configuration by assigning the intended index value
      directly.
      
      Cc: stable@vger.kernel.org
      Fixes: 736b25af ("net: dp83869: Add RGMII internal delay configuration")
      Co-developed-by: default avatarYazan Shhady <yazan.shhady@solid-run.com>
      Signed-off-by: default avatarYazan Shhady <yazan.shhady@solid-run.com>
      Signed-off-by: default avatarJosua Mayer <josua@solid-run.com>
      Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
      Link: https://lore.kernel.org/r/20230323102536.31988-1-josua@solid-run.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      82e2c39f
    • Íñigo Huguet's avatar
      sfc: ef10: don't overwrite offload features at NIC reset · ca4a80e4
      Íñigo Huguet authored
      At NIC reset, some offload features related to encapsulated traffic
      might have changed (this mainly happens if the firmware-variant is
      changed with the sfboot userspace tool). Because of this, features are
      checked and set again at reset time.
      
      However, this was not done right, and some features were improperly
      overwritten at NIC reset:
      - Tunneled IPv6 segmentation was always disabled
      - Features disabled with ethtool were reenabled
      - Features that becomes unsupported after the reset were not disabled
      
      Also, checking if the device supports IPV6_CSUM to enable TSO6 is no
      longer necessary because all currently supported devices support it.
      Additionally, move the assignment of some other features to the
      EF10_OFFLOAD_FEATURES macro, like it is done in ef100, leaving the
      selection of features in efx_pci_probe_post_io a bit cleaner.
      
      Fixes: ffffd245 ("sfc: correctly advertise tunneled IPv6 segmentation")
      Fixes: 24b2c375 ("sfc: advertise encapsulated offloads on EF10")
      Reported-by: default avatarTianhao Zhao <tizhao@redhat.com>
      Suggested-by: default avatarJonathan Cooper <jonathan.s.cooper@amd.com>
      Tested-by: default avatarJonathan Cooper <jonathan.s.cooper@amd.com>
      Signed-off-by: default avatarÍñigo Huguet <ihuguet@redhat.com>
      Acked-by: default avatarEdward Cree <ecree.xilinx@gmail.com>
      Link: https://lore.kernel.org/r/20230323083417.7345-1-ihuguet@redhat.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      ca4a80e4
    • Jiawen Wu's avatar
      net: wangxun: Fix vector length of interrupt cause · 59513714
      Jiawen Wu authored
      There is 64-bit interrupt cause register for txgbe. Fix to clear upper
      32 bits.
      
      Fixes: 3f703186 ("net: libwx: Add irq flow functions")
      Signed-off-by: default avatarJiawen Wu <jiawenwu@trustnetic.com>
      Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      Link: https://lore.kernel.org/r/20230322103632.132011-1-jiawenwu@trustnetic.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      59513714
    • Linus Torvalds's avatar
      Merge tag 'net-6.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 608f1b13
      Linus Torvalds authored
      Pull networking fixes from Jakub Kicinski:
       "Including fixes from bpf, wifi and bluetooth.
      
        Current release - regressions:
      
         - wifi: mt76: mt7915: add back 160MHz channel width support for
           MT7915
      
         - libbpf: revert poisoning of strlcpy, it broke uClibc-ng
      
        Current release - new code bugs:
      
         - bpf: improve the coverage of the "allow reads from uninit stack"
           feature to fix verification complexity problems
      
         - eth: am65-cpts: reset PPS genf adj settings on enable
      
        Previous releases - regressions:
      
         - wifi: mac80211: serialize ieee80211_handle_wake_tx_queue()
      
         - wifi: mt76: do not run mt76_unregister_device() on unregistered hw,
           fix null-deref
      
         - Bluetooth: btqcomsmd: fix command timeout after setting BD address
      
         - eth: igb: revert rtnl_lock() that causes a deadlock
      
         - dsa: mscc: ocelot: fix device specific statistics
      
        Previous releases - always broken:
      
         - xsk: add missing overflow check in xdp_umem_reg()
      
         - wifi: mac80211:
            - fix QoS on mesh interfaces
            - fix mesh path discovery based on unicast packets
      
         - Bluetooth:
            - ISO: fix timestamped HCI ISO data packet parsing
            - remove "Power-on" check from Mesh feature
      
         - usbnet: more fixes to drivers trusting packet length
      
         - wifi: iwlwifi: mvm: fix mvmtxq->stopped handling
      
         - Bluetooth: btintel: iterate only bluetooth device ACPI entries
      
         - eth: iavf: fix inverted Rx hash condition leading to disabled hash
      
         - eth: igc: fix the validation logic for taprio's gate list
      
         - dsa: tag_brcm: legacy: fix daisy-chained switches
      
        Misc:
      
         - bpf: adjust insufficient default bpf_jit_limit to account for
           growth of BPF use over the last 5 years
      
         - xdp: bpf_xdp_metadata() use EOPNOTSUPP as unique errno indicating
           no driver support"
      
      * tag 'net-6.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (84 commits)
        Bluetooth: HCI: Fix global-out-of-bounds
        Bluetooth: mgmt: Fix MGMT add advmon with RSSI command
        Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work
        Bluetooth: L2CAP: Fix responding with wrong PDU type
        Bluetooth: btqcomsmd: Fix command timeout after setting BD address
        Bluetooth: btinel: Check ACPI handle for NULL before accessing
        net: mdio: thunder: Add missing fwnode_handle_put()
        net: dsa: mt7530: move setting ssc_delta to PHY_INTERFACE_MODE_TRGMII case
        net: dsa: mt7530: move lowering TRGMII driving to mt7530_setup()
        net: dsa: mt7530: move enabling disabling core clock to mt7530_pll_setup()
        net: asix: fix modprobe "sysfs: cannot create duplicate filename"
        gve: Cache link_speed value from device
        tools: ynl: Fix genlmsg header encoding formats
        net: enetc: fix aggregate RMON counters not showing the ranges
        Bluetooth: Remove "Power-on" check from Mesh feature
        Bluetooth: Fix race condition in hci_cmd_sync_clear
        Bluetooth: btintel: Iterate only bluetooth device ACPI entries
        Bluetooth: ISO: fix timestamped HCI ISO data packet parsing
        Bluetooth: btusb: Remove detection of ISO packets over bulk
        Bluetooth: hci_core: Detect if an ACL packet is in fact an ISO packet
        ...
      608f1b13
    • Linus Torvalds's avatar
      Merge tag 'for-6.3-rc3-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux · 28506304
      Linus Torvalds authored
      Pull btrfs fixes from David Sterba:
       "A few more fixes, the zoned accounting fix is spread across a few
        patches, preparatory and the actual fixes:
      
         - zoned mode:
            - fix accounting of unusable zone space
            - fix zone activation condition for DUP profile
            - preparatory patches
      
         - improved error handling of missing chunks
      
         - fix compiler warning"
      
      * tag 'for-6.3-rc3-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
        btrfs: zoned: drop space_info->active_total_bytes
        btrfs: zoned: count fresh BG region as zone unusable
        btrfs: use temporary variable for space_info in btrfs_update_block_group
        btrfs: rename BTRFS_FS_NO_OVERCOMMIT to BTRFS_FS_ACTIVE_ZONE_TRACKING
        btrfs: zoned: fix btrfs_can_activate_zone() to support DUP profile
        btrfs: fix compiler warning on SPARC/PA-RISC handling fscrypt_setup_filename
        btrfs: handle missing chunk mapping more gracefully
      28506304
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 6dd74c51
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "Four small fixes, three in drivers.
      
        The core fix adds a UFS device to an existing quirk to avoid a huge
        delay on boot"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: scsi_dh_alua: Fix memleak for 'qdata' in alua_activate()
        scsi: qla2xxx: Synchronize the IOCB count to be in order
        scsi: qla2xxx: Perform lockless command completion in abort path
        scsi: core: Add BLIST_SKIP_VPD_PAGES for SKhynix H28U74301AMR
      6dd74c51
  3. 23 Mar, 2023 23 commits
  4. 22 Mar, 2023 9 commits
    • Brian Gix's avatar
      Bluetooth: Remove "Power-on" check from Mesh feature · 52dd5e96
      Brian Gix authored
      The Bluetooth mesh experimental feature enable was requiring the
      controller to be powered off in order for the Enable to work. Mesh is
      supposed to be enablable regardless of the controller state, and created
      an unintended requirement that the mesh daemon be started before the
      classic bluetoothd daemon.
      
      Fixes: af6bcc19 ("Bluetooth: Add experimental wrapper for MGMT based mesh")
      Signed-off-by: default avatarBrian Gix <brian.gix@gmail.com>
      Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
      52dd5e96
    • Min Li's avatar
      Bluetooth: Fix race condition in hci_cmd_sync_clear · 1c66bee4
      Min Li authored
      There is a potential race condition in hci_cmd_sync_work and
      hci_cmd_sync_clear, and could lead to use-after-free. For instance,
      hci_cmd_sync_work is added to the 'req_workqueue' after cancel_work_sync
      The entry of 'cmd_sync_work_list' may be freed in hci_cmd_sync_clear, and
      causing kernel panic when it is used in 'hci_cmd_sync_work'.
      
      Here's the call trace:
      
      dump_stack_lvl+0x49/0x63
      print_report.cold+0x5e/0x5d3
      ? hci_cmd_sync_work+0x282/0x320
      kasan_report+0xaa/0x120
      ? hci_cmd_sync_work+0x282/0x320
      __asan_report_load8_noabort+0x14/0x20
      hci_cmd_sync_work+0x282/0x320
      process_one_work+0x77b/0x11c0
      ? _raw_spin_lock_irq+0x8e/0xf0
      worker_thread+0x544/0x1180
      ? poll_idle+0x1e0/0x1e0
      kthread+0x285/0x320
      ? process_one_work+0x11c0/0x11c0
      ? kthread_complete_and_exit+0x30/0x30
      ret_from_fork+0x22/0x30
      </TASK>
      
      Allocated by task 266:
      kasan_save_stack+0x26/0x50
      __kasan_kmalloc+0xae/0xe0
      kmem_cache_alloc_trace+0x191/0x350
      hci_cmd_sync_queue+0x97/0x2b0
      hci_update_passive_scan+0x176/0x1d0
      le_conn_complete_evt+0x1b5/0x1a00
      hci_le_conn_complete_evt+0x234/0x340
      hci_le_meta_evt+0x231/0x4e0
      hci_event_packet+0x4c5/0xf00
      hci_rx_work+0x37d/0x880
      process_one_work+0x77b/0x11c0
      worker_thread+0x544/0x1180
      kthread+0x285/0x320
      ret_from_fork+0x22/0x30
      
      Freed by task 269:
      kasan_save_stack+0x26/0x50
      kasan_set_track+0x25/0x40
      kasan_set_free_info+0x24/0x40
      ____kasan_slab_free+0x176/0x1c0
      __kasan_slab_free+0x12/0x20
      slab_free_freelist_hook+0x95/0x1a0
      kfree+0xba/0x2f0
      hci_cmd_sync_clear+0x14c/0x210
      hci_unregister_dev+0xff/0x440
      vhci_release+0x7b/0xf0
      __fput+0x1f3/0x970
      ____fput+0xe/0x20
      task_work_run+0xd4/0x160
      do_exit+0x8b0/0x22a0
      do_group_exit+0xba/0x2a0
      get_signal+0x1e4a/0x25b0
      arch_do_signal_or_restart+0x93/0x1f80
      exit_to_user_mode_prepare+0xf5/0x1a0
      syscall_exit_to_user_mode+0x26/0x50
      ret_from_fork+0x15/0x30
      
      Fixes: 6a98e383 ("Bluetooth: Add helper for serialized HCI command execution")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarMin Li <lm0963hack@gmail.com>
      Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
      1c66bee4
    • Kiran K's avatar
      Bluetooth: btintel: Iterate only bluetooth device ACPI entries · 294d749b
      Kiran K authored
      Current flow interates over entire ACPI table entries looking for
      Bluetooth Per Platform Antenna Gain(PPAG) entry. This patch iterates
      over ACPI entries relvant to Bluetooth device only.
      
      Fixes: c585a92b ("Bluetooth: btintel: Set Per Platform Antenna Gain(PPAG)")
      Signed-off-by: default avatarKiran K <kiran.k@intel.com>
      Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
      294d749b
    • Pauli Virtanen's avatar
      Bluetooth: ISO: fix timestamped HCI ISO data packet parsing · 2f10e40a
      Pauli Virtanen authored
      Use correct HCI ISO data packet header struct when the packet has
      timestamp. The timestamp, when present, goes before the other fields
      (Core v5.3 4E 5.4.5), so the structs are not compatible.
      
      Fixes: ccf74f23 ("Bluetooth: Add BTPROTO_ISO socket type")
      Signed-off-by: default avatarPauli Virtanen <pav@iki.fi>
      Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
      2f10e40a
    • Luiz Augusto von Dentz's avatar
      Bluetooth: btusb: Remove detection of ISO packets over bulk · efe375b7
      Luiz Augusto von Dentz authored
      This removes the code introduced by
      14202eff as hci_recv_frame is now able
      to detect ACL packets that are in fact ISO packets.
      
      Fixes: 14202eff ("Bluetooth: btusb: Detect if an ACL packet is in fact an ISO packet")
      Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
      efe375b7
    • Luiz Augusto von Dentz's avatar
      Bluetooth: hci_core: Detect if an ACL packet is in fact an ISO packet · 876e7810
      Luiz Augusto von Dentz authored
      Because some transports don't have a dedicated type for ISO packets
      (see 14202eff) they may use ACL type
      when in fact they are ISO packets.
      
      In the past this was left for the driver to detect such thing but it
      creates a problem when using the likes of btproxy when used by a VM as
      the host would not be aware of the connection the guest is doing it
      won't be able to detect such behavior, so this make bt_recv_frame
      detect when it happens as it is the common interface to all drivers
      including guest VMs.
      
      Fixes: 14202eff ("Bluetooth: btusb: Detect if an ACL packet is in fact an ISO packet")
      Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
      876e7810
    • Zhengping Jiang's avatar
      Bluetooth: hci_sync: Resume adv with no RPA when active scan · 3c44a431
      Zhengping Jiang authored
      The address resolution should be disabled during the active scan,
      so all the advertisements can reach the host. The advertising
      has to be paused before disabling the address resolution,
      because the advertising will prevent any changes to the resolving
      list and the address resolution status. Skipping this will cause
      the hci error and the discovery failure.
      
      According to the bluetooth specification:
      "7.8.44 LE Set Address Resolution Enable command
      
      This command shall not be used when:
      - Advertising (other than periodic advertising) is enabled,
      - Scanning is enabled, or
      - an HCI_LE_Create_Connection, HCI_LE_Extended_Create_Connection, or
        HCI_LE_Periodic_Advertising_Create_Sync command is outstanding."
      
      If the host is using RPA, the controller needs to generate RPA for
      the advertising, so the advertising must remain paused during the
      active scan.
      
      If the host is not using RPA, the advertising can be resumed after
      disabling the address resolution.
      
      Fixes: 9afc675e ("Bluetooth: hci_sync: allow advertise when scan without RPA")
      Signed-off-by: default avatarZhengping Jiang <jiangzp@google.com>
      Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
      3c44a431
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm · fff5a5e7
      Linus Torvalds authored
      Pull ARM fix from Russell King:
       "Just one fix for now to eliminate a KASAN false positive"
      
      * tag 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm:
        ARM: 9290/1: uaccess: Fix KASAN false-positives
      fff5a5e7
    • Linus Torvalds's avatar
      Merge tag 'bootconfig-fixes-v6.3-rc3' of... · c13e02d3
      Linus Torvalds authored
      Merge tag 'bootconfig-fixes-v6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
      
      Pull bootconfig fixes from Masami Hiramatsu:
      
       - Fix bootconfig test script to test increased maximum number (8192)
         node correctly
      
       - Change the console message if there is no bootconfig data and the
         kernel is compiled with CONFIG_BOOT_CONFIG_FORCE=y
      
      * tag 'bootconfig-fixes-v6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace:
        bootconfig: Change message if no bootconfig with CONFIG_BOOT_CONFIG_FORCE=y
        bootconfig: Fix testcase to increase max node
      c13e02d3