1. 05 Jan, 2024 1 commit
  2. 03 Jan, 2024 1 commit
  3. 02 Jan, 2024 2 commits
    • Randy Dunlap's avatar
      drm/imagination: pvr_device.h: fix all kernel-doc warnings · eee70683
      Randy Dunlap authored
      Correct all kernel-doc notation on pvr_device.h so that there are no
      kernel-doc warnings remaining.
      
      pvr_device.h:292: warning: Excess struct member 'active' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'idle' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'lock' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'work' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'old_kccb_cmds_executed' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'kccb_stall_count' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'ccb' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'rtn_q' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'rtn_obj' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'rtn' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'slot_count' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'reserved_count' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'waiters' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'fence_ctx' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'id' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'seqno' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'lock' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'active' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'idle' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'lock' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'work' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'old_kccb_cmds_executed' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'kccb_stall_count' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'ccb' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'rtn_q' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'rtn_obj' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'rtn' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'slot_count' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'reserved_count' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'waiters' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'fence_ctx' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'id' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'seqno' description in 'pvr_device'
      pvr_device.h:292: warning: Excess struct member 'lock' description in 'pvr_device'
      Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Cc: Frank Binns <frank.binns@imgtec.com>
      Cc: Donald Robson <donald.robson@imgtec.com>
      Cc: Matt Coster <matt.coster@imgtec.com>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Maxime Ripard <mripard@kernel.org>
      Cc: Thomas Zimmermann <tzimmermann@suse.de>
      Cc: David Airlie <airlied@gmail.com>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Cc: Jonathan Corbet <corbet@lwn.net>
      Cc: Vegard Nossum <vegard.nossum@oracle.com>
      Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231231054910.31805-1-rdunlap@infradead.org
      eee70683
    • Randy Dunlap's avatar
      drm/gpuvm: fix all kernel-doc warnings in include/drm/drm_gpuvm.h · 200a6b3a
      Randy Dunlap authored
      Update kernel-doc comments in <drm/drm_gpuvm.h> to correct all
      kernel-doc warnings:
      
      drm_gpuvm.h:148: warning: Excess struct member 'addr' description in 'drm_gpuva'
      drm_gpuvm.h:148: warning: Excess struct member 'offset' description in 'drm_gpuva'
      drm_gpuvm.h:148: warning: Excess struct member 'obj' description in 'drm_gpuva'
      drm_gpuvm.h:148: warning: Excess struct member 'entry' description in 'drm_gpuva'
      drm_gpuvm.h:148: warning: Excess struct member '__subtree_last' description in 'drm_gpuva'
      drm_gpuvm.h:192: warning: No description found for return value of 'drm_gpuva_invalidated'
      drm_gpuvm.h:331: warning: Excess struct member 'tree' description in 'drm_gpuvm'
      drm_gpuvm.h:331: warning: Excess struct member 'list' description in 'drm_gpuvm'
      drm_gpuvm.h:331: warning: Excess struct member 'list' description in 'drm_gpuvm'
      drm_gpuvm.h:331: warning: Excess struct member 'local_list' description in 'drm_gpuvm'
      drm_gpuvm.h:331: warning: Excess struct member 'lock' description in 'drm_gpuvm'
      drm_gpuvm.h:331: warning: Excess struct member 'list' description in 'drm_gpuvm'
      drm_gpuvm.h:331: warning: Excess struct member 'local_list' description in 'drm_gpuvm'
      drm_gpuvm.h:331: warning: Excess struct member 'lock' description in 'drm_gpuvm'
      drm_gpuvm.h:352: warning: No description found for return value of 'drm_gpuvm_get'
      drm_gpuvm.h:545: warning: Excess struct member 'fn' description in 'drm_gpuvm_exec'
      drm_gpuvm.h:545: warning: Excess struct member 'priv' description in 'drm_gpuvm_exec'
      drm_gpuvm.h:597: warning: missing initial short description on line:
       * drm_gpuvm_exec_resv_add_fence()
      drm_gpuvm.h:616: warning: missing initial short description on line:
       * drm_gpuvm_exec_validate()
      drm_gpuvm.h:623: warning: No description found for return value of 'drm_gpuvm_exec_validate'
      drm_gpuvm.h:698: warning: Excess struct member 'gpuva' description in 'drm_gpuvm_bo'
      drm_gpuvm.h:698: warning: Excess struct member 'entry' description in 'drm_gpuvm_bo'
      drm_gpuvm.h:698: warning: Excess struct member 'gem' description in 'drm_gpuvm_bo'
      drm_gpuvm.h:698: warning: Excess struct member 'evict' description in 'drm_gpuvm_bo'
      drm_gpuvm.h:726: warning: No description found for return value of 'drm_gpuvm_bo_get'
      drm_gpuvm.h:738: warning: missing initial short description on line:
       * drm_gpuvm_bo_gem_evict()
      drm_gpuvm.h:740: warning: missing initial short description on line:
       * drm_gpuvm_bo_gem_evict()
      drm_gpuvm.h:698: warning: Excess struct member 'evict' description in 'drm_gpuvm_bo'
      drm_gpuvm.h:844: warning: Excess struct member 'addr' description in 'drm_gpuva_op_map'
      drm_gpuvm.h:844: warning: Excess struct member 'range' description in 'drm_gpuva_op_map'
      drm_gpuvm.h:844: warning: Excess struct member 'offset' description in 'drm_gpuva_op_map'
      drm_gpuvm.h:844: warning: Excess struct member 'obj' description in 'drm_gpuva_op_map'
      Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Maxime Ripard <mripard@kernel.org>
      Cc: Thomas Zimmermann <tzimmermann@suse.de>
      Cc: David Airlie <airlied@gmail.com>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Cc: Jonathan Corbet <corbet@lwn.net>
      Cc: Vegard Nossum <vegard.nossum@oracle.com>
      Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231231054856.31786-1-rdunlap@infradead.org
      200a6b3a
  4. 26 Dec, 2023 2 commits
    • Lucas De Marchi's avatar
      drm/xe: Fix warning on impossible condition · 315acff5
      Lucas De Marchi authored
      Having a different value for op is not possible: this is already kept
      out of user-visible warning by the check in xe_wait_user_fence_ioctl()
      if op > MAX_OP. The warning is useful as if this switch() is not update
      when a new op is added, it should be triggered.
      
      Fix warning as reported by 0-DAY CI Kernel:
      
      	drivers/gpu/drm/xe/xe_wait_user_fence.c:46:2: warning: variable 'passed' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
      
      Closes: https://lore.kernel.org/oe-kbuild-all/202312170357.KPSinwPs-lkp@intel.com/
      Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
      Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
      Link: https://lore.kernel.org/r/20231218163301.3453285-1-lucas.demarchi@intel.comSigned-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
      315acff5
    • Matthew Brost's avatar
      drm/xe: Fix UBSAN splat in add_preempt_fences() · 75cbe49f
      Matthew Brost authored
      add_preempt_fences() calls dma_resv_reserve_fences() with num_fences ==
      0 resulting in the below UBSAN splat. Short circuit add_preempt_fences()
      if num_fences == 0.
      
      [   58.652241] ================================================================================
      [   58.660736] UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:13
      [   58.667281] shift exponent 64 is too large for 64-bit type 'long unsigned int'
      [   58.674539] CPU: 2 PID: 1170 Comm: xe_gpgpu_fill Not tainted 6.6.0-rc3-guc+ #630
      [   58.674545] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.R00.3243.A01.2006102133 06/10/2020
      [   58.674547] Call Trace:
      [   58.674548]  <TASK>
      [   58.674550]  dump_stack_lvl+0x92/0xb0
      [   58.674555]  __ubsan_handle_shift_out_of_bounds+0x15a/0x300
      [   58.674559]  ? rcu_is_watching+0x12/0x60
      [   58.674564]  ? software_resume+0x141/0x210
      [   58.674575]  ? new_vma+0x44b/0x600 [xe]
      [   58.674606]  dma_resv_reserve_fences.cold+0x40/0x66
      [   58.674612]  new_vma+0x4b3/0x600 [xe]
      [   58.674638]  xe_vm_bind_ioctl+0xffd/0x1e00 [xe]
      [   58.674663]  ? __pfx_xe_vm_bind_ioctl+0x10/0x10 [xe]
      [   58.674680]  drm_ioctl_kernel+0xc1/0x170
      [   58.674686]  ? __pfx_xe_vm_bind_ioctl+0x10/0x10 [xe]
      [   58.674703]  drm_ioctl+0x247/0x4c0
      [   58.674709]  ? find_held_lock+0x2b/0x80
      [   58.674716]  __x64_sys_ioctl+0x8c/0xb0
      [   58.674720]  do_syscall_64+0x3c/0x90
      [   58.674723]  entry_SYSCALL_64_after_hwframe+0x6e/0xd8
      [   58.674727] RIP: 0033:0x7fce4bd1aaff
      [   58.674730] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <41> 89 c0 3d 00 f0 ff ff 77 1f 48 8b 44 24 18 64 48 2b 04 25 28 00
      [   58.674731] RSP: 002b:00007ffc57434050 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
      [   58.674734] RAX: ffffffffffffffda RBX: 00007ffc574340e0 RCX: 00007fce4bd1aaff
      [   58.674736] RDX: 00007ffc574340e0 RSI: 0000000040886445 RDI: 0000000000000003
      [   58.674737] RBP: 0000000040886445 R08: 0000000000000002 R09: 00007ffc574341b0
      [   58.674739] R10: 000055de43eb3780 R11: 0000000000000246 R12: 00007ffc574340e0
      [   58.674740] R13: 0000000000000003 R14: 00007ffc574341b0 R15: 0000000000000001
      [   58.674747]  </TASK>
      [   58.674748] ================================================================================
      
      Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
      Cc: Lucas De Marchi <lucas.demarchi@intel.com>
      Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
      Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Link: https://lore.kernel.org/r/20231215230203.719244-1-matthew.brost@intel.comSigned-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
      75cbe49f
  5. 24 Dec, 2023 2 commits
  6. 23 Dec, 2023 2 commits
  7. 22 Dec, 2023 4 commits
  8. 21 Dec, 2023 26 commits