Commits · 3e588e3afb5780005605c7f4e3dc4ca61c8dbaec · Kirill Smelkov / linux

03 Jan, 2017 40 commits

staging: rtl8712: changed struct members to __le32 · 3e588e3a

Jannik Becher authored Dec 18, 2016

Fixed sparse warning "cast to restricted __le32".
struct recv_stat and struct phy_stat have always little endian members.
Signed-off-by: Jannik Becher <becher.jannik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3e588e3a

staging: greybus: svc_watchdog: replace printk() with pr_err() · 62730c95

Emmanuil Chatzipetru authored Dec 22, 2016

Fix coding style issue caught by checkpatch.pl related to the following
warning:
	- "WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ."
Signed-off-by: Emmanuil Chatzipetru <chatzi.emanuel@gmail.com>
Acked-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

62730c95

staging: greybus: svc_watchdog: Fix spaces on a single definition statement · 28cf2035

Emmanuil Chatzipetru authored Dec 22, 2016

Fix coding style issue caught by checkpatch.pl related to the following
warning:
	- "CHECK: spaces preferred around that '*' (ctx:VxV) "
Signed-off-by: Emmanuil Chatzipetru <chatzi.emanuel@gmail.com>
Acked-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

28cf2035

staging: greybus: arche-apb-ctrl: fix unused warnings on resume/suspend · 6da80863

Jérémy Lefaure authored Dec 16, 2016

When CONFIG_PM_SLEEP is disabled, SIMPLE_DEV_PM_OPS does not use
arche_apb_ctrl_resume and arche_apb_ctrl_suspend functions:

drivers/staging/greybus/arche-apb-ctrl.c:478:12: warning:
‘arche_apb_ctrl_resume’ defined but not used [-Wunused-function]
 static int arche_apb_ctrl_resume(struct device *dev)
            ^~~~~~~~~~~~~~~~~~~~~
drivers/staging/greybus/arche-apb-ctrl.c:464:12: warning:
‘arche_apb_ctrl_suspend’ defined but not used [-Wunused-function]
 static int arche_apb_ctrl_suspend(struct device *dev)
            ^~~~~~~~~~~~~~~~~~~~~~

Adding __maybe_unused to the declaration of these functions removes the
warnings.
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Acked-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6da80863

staging: greybus: add host device function pointer checks · f05a88a3

Jason Hrycay authored Dec 20, 2016

Add sanity checks for cport_quiesce and cport_clear before invoking the
callbacks as these function pointers are not required during the host
device registration. This follows the logic implemented elsewhere for
various other function pointers.
Signed-off-by: Jason Hrycay <jhrycay@gmail.com>
Reviewed-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Acked-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f05a88a3

staging: greybus: loopback: use gb_loopback_async_wait_all don't spin · a072a72d

Bryan O'Donoghue authored Dec 22, 2016

Currently the greybus-loopback thread logic spins around waiting for
send_count == iteration_max which on real hardware doesn't make a
difference to us but in simulation is excruciatingly slow, anti-social and
bad manners. Use the existing gb_loopback_async_wait_all() function to gate
continuing when the send_count == iteration_max and go to sleep until
there's something worthwhile to-do.
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a072a72d

staging: emxx_udc: Fix CamelCase variable name · af1550cc

Afonso Bordado authored Dec 20, 2016

Changes from CamelCase to a kernel format
Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

af1550cc

staging: emxx_udc: Remove unecessary temporary variable · 7e026bfa

Afonso Bordado authored Dec 20, 2016

This improves code readability.
Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7e026bfa

staging: emxx_udc: Rename CamelCase variable · 86e2ba1c

Afonso Bordado authored Dec 20, 2016

The new name complies with the kernel styling guidelines and is more descriptive.
Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

86e2ba1c

staging: emxx_udc: Fix CamelCase function name · 34e89dd1

Afonso Bordado authored Dec 20, 2016

Change EP0_out_PIO to use the kernel convention.
Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

34e89dd1

staging: emxx_udc: remove incorrect __init annotations · 4f344506

Arnd Bergmann authored Dec 16, 2016

The probe function is not marked __init, but some other functions
are. This leads to a warning on older compilers (e.g. gcc-4.3),
and can cause executing freed memory when built with those
compilers:

WARNING: drivers/staging/emxx_udc/emxx_udc.o(.text+0x2d78): Section mismatch in reference from the function nbu2ss_drv_probe() to the function .init.text:nbu2ss_drv_contest_init()

This removes the annotations.

Fixes: 33aa8d45 ("staging: emxx_udc: Add Emma Mobile USB Gadget driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4f344506

staging: vc04_services: Fix bracing on single statement blocks · eeee8b17

Aaron Moore authored Dec 18, 2016

Fix coding style issue caught by checkpatch.pl relating to braces on
single statement blocks. This issue was corrected in 3 locations.
Signed-off-by: Aaron Moore <aaron@atamisk.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

eeee8b17

staging: vc04_services: Fix NULL ptr sparse warnings · c322160a

Mike Kofron authored Dec 09, 2016

In calls to queue_message() in vchiq_core.c, the "void *context"
parameter is set as 0 rather than NULL. This patch amends each call to
use the proper NULL pointer. The following sparse warnings are fixed:

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:1623:23: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:1976:47: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:2075:47: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:2095:47: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:2907:39: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:2929:39: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:3059:72: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:3860:31: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:3870:31: warning: Using plain integer as NULL pointer
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:3880:31: warning: Using plain integer as NULL pointer
Signed-off-by: Mike Kofron <mpkofron@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c322160a

Staging: ks7010: ks7010_sdio.h: Trailing whitespace · 7048e254

Manoj Sawai authored Dec 12, 2016

Removed trailing whitespace.
Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7048e254

Staging: ks7010: ks7010_sdio.h: Complex macro not in parentheses · 64d94cd3

Manoj Sawai authored Dec 12, 2016

Fixed coding style error. Complex macro not inside parentheses.
Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

64d94cd3

Staging: skein: checkpatch: fix comment aligning in skein_base.c · 8315388d

Tobias Heineken authored Dec 22, 2016

This is a patch to the skein_base.c file that fixes up a
comment aligning warning found by the checkpatch.pl tool at line 2
Signed-off-by: Tobias Heineken <tobias.heineken+kernel@robotics-erlangen.de>
Signed-off-by: Florian Schleicher <florian.schleicher@fau.de>
CC: linux-kernel@i4.cs.fau.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

8315388d

staging: fbtft: fix code alignment with open parenthesis · 6b5f707c

Scott Matheina authored Dec 20, 2016

These changes where identified by checkpatch.pl as needed changes to
align the code with the linux development coding style. The several
lines of text where aligned with the precending parenthesis.
Signed-off-by: Scott Matheina <scott@matheina.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6b5f707c

staging: dgnc: update TODO file · c7591a26

Fernando Apesteguia authored Dec 11, 2016

Remove reference to checkpatch warnings since its output is now clean.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c7591a26

staging: fixed spelling error in TODO file for dgnc driver · 298afff0

Scott Matheina authored Dec 21, 2016

fixed a missing letter in the TODO file 'unneeded'
Signed-off-by: Scott Matheina <scott@matheina.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

298afff0

Staging: comedi: proc: Warn if unable to create proc entry · 2e4b5cd6

Cheah Kok Cheong authored Dec 30, 2016

The proc entry is not essential for the comedi system as
evident by the support for !CONFIG_PROC_FS. So for failure
to create, just warn and continue loading.
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2e4b5cd6

Staging: comedi: proc: Add module owner · 6bd68e29

Cheah Kok Cheong authored Dec 30, 2016

Since this is a loadable kernel module, add module ownership
to follow LKM semantics.
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6bd68e29

Staging: comedi: proc: Add __init prefix · ec0bff06

Cheah Kok Cheong authored Dec 30, 2016

Add __init prefix so that symbol will be discarded after
module loading.
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ec0bff06

Staging: comedi: proc: Change file permission to read only · 5f52f319

Cheah Kok Cheong authored Dec 30, 2016

As there's no write operation, change to read only.
Was inadvertantly switched to 0644 in commit 1f817b86
("comedi: Don't use create_proc_read_entry()").
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5f52f319

Staging: comedi: comedi_fops: Avoid orphaned proc entry · bf279ece

Cheah Kok Cheong authored Dec 30, 2016

Move comedi_proc_init to the end to avoid orphaned proc entry
if module loading failed.
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

bf279ece

Staging: comedi: comedidev.h: Drop old style zero-length array · 3358a0ca

Cheah Kok Cheong authored Dec 22, 2016

According to Documentation/Changes, the minimum gcc version required
to compile the kernel is 3.2 (this is probably outdated too).
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3358a0ca

staging: comedi: ni_670x: using the BIT(x) macro · 3c4a2d9e

Saber Rezvani authored Dec 16, 2016

Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro
replacing bit shifting on 1 with the BIT(x) macro.
Signed-off-by: Saber Rezvani <irsaber@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3c4a2d9e

staging: comedi: ni_at_ao: using the BIT(x) macro · 8f2ee912

Saber Rezvani authored Dec 16, 2016

Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro
replacing bit shifting on 1 with the BIT(x) macro.
Signed-off-by: Saber Rezvani <irsaber@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

8f2ee912

staging: comedi: cb_pcidas64: use preferred kernel type u32 · db30e33f

Saber Rezvani authored Dec 16, 2016

Fix the checkpatch.pl issue:
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Saber Rezvani <irsaber@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

db30e33f

staging: comedi: cb_pcidas64: use preferred kernel type u16 · 9e23afed

Saber Rezvani authored Dec 16, 2016

Fix the checkpatch.pl issue:
CHECK: Prefer kernel type 'u16' over 'uint16_t'
Signed-off-by: Saber Rezvani <irsaber@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9e23afed

staging: comedi: cb_pcidas64: use preferred kernel type u8 · 7afd6d21

Saber Rezvani authored Dec 16, 2016

Fix the checkpatch.pl issue:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Saber Rezvani <irsaber@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7afd6d21