1. 09 Sep, 2009 4 commits
    • Tejun Heo's avatar
      dmi: extend dmi_get_year() to dmi_get_date() · 3e5cd1f2
      Tejun Heo authored
      There are cases where full date information is required instead of
      just the year.  Add month and day parsing to dmi_get_year() and rename
      it to dmi_get_date().
      
      As the original function only required '/' followed by any number of
      parseable characters at the end of the string, keep that behavior to
      avoid upsetting existing users.
      
      The new function takes dates of format [mm[/dd]]/yy[yy].  Year, month
      and date are checked to be in the ranges of [1-9999], [1-12] and
      [1-31] respectively and any invalid or out-of-range component is
      returned as zero.
      
      The dummy implementation is updated accordingly but the return value
      is updated to indicate field not found which is consistent with how
      other dummy functions behave.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      3e5cd1f2
    • Tejun Heo's avatar
      dmi: fix date handling in dmi_get_year() · 02c24fa8
      Tejun Heo authored
      Year parsing in dmi_get_year() had the following two bugs.
      
      * "00" is treated as invalid instead of 2000 because zero return from
        simple_strtoul() is treated as error.
      
      * "0N" where N >= 8 is treated as invalid of 200N because the leading
        0 is considered to specify octal.
      
      Fix the above two bugs by using endptr to detect invalid number and
      forcing decimal.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      02c24fa8
    • Tejun Heo's avatar
      libata: unbreak TPM filtering by reorganizing ata_scsi_pass_thru() · bd30add8
      Tejun Heo authored
      ata_scsi_pass_thru() was checking for input sanity and disallowed
      commands while initializaing qc from scmd.  TPM filtering was added
      right after protocol check at which point tf wasn't initialized
      properly.  This means that TPM filtering has never really worked.
      
      This patch fixes the bug by reorganizing ata_scsi_pass_thru() such
      that qc is fully initialized before checking for invalid conditions
      which is way less error prone.
      
      Discovered while Thilo-Alexander Ginkel was trying debug patches for
      bko#13416.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Cc: Thilo-Alexander Ginkel <thilo@ginkel.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      bd30add8
    • Tejun Heo's avatar
      sata_sis: convert to slave_link · 72fee382
      Tejun Heo authored
      During introduction of slave_link, sata_sis slipped through the crack
      and left with ad-hoc merged SCR access.  As SCR status was shared for
      both the master and slave devices, when only one of the device is
      online, libata EH would think both are online but would only get valid
      device signature for the actually present one, which in turn trigger
      the probing safety net mechanism and make EH retry causing large delay
      during boot.  This patch converts sata_sis to slave_link mechanism.
      
      This bug was reported by TAXI in bko#14075.
      
       http://bugzilla.kernel.org/show_bug.cgi?id=14075Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Reported-by: default avatarTAXI <taxi@a-city.de>
      Cc: Uwe Koziolek <uwe.koziolek@gmx.net>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      72fee382
  2. 01 Sep, 2009 17 commits
  3. 31 Aug, 2009 10 commits
  4. 30 Aug, 2009 2 commits
  5. 29 Aug, 2009 6 commits
  6. 28 Aug, 2009 1 commit