1. 09 Jul, 2020 40 commits
    • Lee Jones's avatar
      usb: host: fotg210-hcd: Remove unused variable 'hcc_params' · 522514e5
      Lee Jones authored
      The result is actually read into fotg210->caps->hcc_params.  No
      need to popuate an unused varible with the unchecked return value
      from fotg210_readl().
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’:
       drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable]
       5013 | u32 hcc_params;
       | ^~~~~~~~~~
      
      Cc: Yuan-Hsin Chen <yhchen@faraday-tech.com>
      Cc: Feng-Hsin Chiang <john453@faraday-tech.com>
      Cc: Po-Yu Chuang <ratbert.chuang@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-19-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      522514e5
    • Lee Jones's avatar
      usb: host: ehci-fsl: Fix incorrectly named function argument · 1a896833
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/ehci-fsl.c:694: warning: Function parameter or member 'pdev' not described in 'fsl_ehci_drv_remove'
       drivers/usb/host/ehci-fsl.c:694: warning: Excess function parameter 'dev' description in 'fsl_ehci_drv_remove'
      
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Randy Vinson <rvinson@mvista.com>
      Cc: Dave Liu <daveliu@freescale.com>
      Cc: Jerry Huang <Chang-Ming.Huang@freescale.com>
      Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-18-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1a896833
    • Lee Jones's avatar
      usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc · 709ba38e
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'imx21' not described in 'copy_to_dmem'
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'dmem_offset' not described in 'copy_to_dmem'
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'src' not described in 'copy_to_dmem'
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'count' not described in 'copy_to_dmem'
      
      Cc: Shawn Guo <shawnguo@kernel.org>
      Cc: Sascha Hauer <s.hauer@pengutronix.de>
      Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
      Cc: Fabio Estevam <festevam@gmail.com>
      Cc: NXP Linux Team <linux-imx@nxp.com>
      Cc: Stephen Boyd <swboyd@chromium.org>
      Cc: Jay Monkman <jtm@lopingdog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-17-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      709ba38e
    • Lee Jones's avatar
      usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues · 4ef2dfbd
      Lee Jones authored
      Ranging from missing descriptions and formatting mishaps to over-documenting
      of missing arguments, likely due to bitrot.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/pch_udc.c:239: warning: Function parameter or member 'request' not described in 'pch_udc_stp_dma_desc'
       drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_fall' not described in 'pch_vbus_gpio_data'
       drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_rise' not described in 'pch_vbus_gpio_data'
       drivers/usb/gadget/udc/pch_udc.c:482: warning: Function parameter or member 'ep' not described in 'pch_udc_write_csr'
       drivers/usb/gadget/udc/pch_udc.c:482: warning: Excess function parameter 'addr' description in 'pch_udc_write_csr'
       drivers/usb/gadget/udc/pch_udc.c:498: warning: Function parameter or member 'ep' not described in 'pch_udc_read_csr'
       drivers/usb/gadget/udc/pch_udc.c:498: warning: Excess function parameter 'addr' description in 'pch_udc_read_csr'
       drivers/usb/gadget/udc/pch_udc.c:662: warning: Function parameter or member 'ep_in' not described in 'pch_udc_ep_set_bufsz'
       drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_enable'
       drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'cfg' not described in 'pch_udc_ep_enable'
       drivers/usb/gadget/udc/pch_udc.c:977: warning: Excess function parameter 'regs' description in 'pch_udc_ep_enable'
       drivers/usb/gadget/udc/pch_udc.c:1010: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_disable'
       drivers/usb/gadget/udc/pch_udc.c:1010: warning: Excess function parameter 'regs' description in 'pch_udc_ep_disable'
       drivers/usb/gadget/udc/pch_udc.c:1030: warning: Function parameter or member 'ep' not described in 'pch_udc_wait_ep_stall'
       drivers/usb/gadget/udc/pch_udc.c:1030: warning: Excess function parameter 'dev' description in 'pch_udc_wait_ep_stall'
       drivers/usb/gadget/udc/pch_udc.c:1341: warning: Function parameter or member 'data' not described in 'pch_vbus_gpio_irq'
       drivers/usb/gadget/udc/pch_udc.c:1341: warning: Excess function parameter 'dev' description in 'pch_vbus_gpio_irq'
       drivers/usb/gadget/udc/pch_udc.c:1365: warning: Function parameter or member 'vbus_gpio_port' not described in 'pch_vbus_gpio_init'
       drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'dev' not described in 'pch_udc_free_dma_chain'
       drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'req' not described in 'pch_udc_free_dma_chain'
       drivers/usb/gadget/udc/pch_udc.c:1717: warning: Function parameter or member 'usbep' not described in 'pch_udc_pcd_ep_disable'
       drivers/usb/gadget/udc/pch_udc.c:2006: warning: Excess function parameter 'halt' description in 'pch_udc_pcd_set_wedge'
       drivers/usb/gadget/udc/pch_udc.c:2756: warning: Function parameter or member 'pdev' not described in 'pch_udc_isr'
       drivers/usb/gadget/udc/pch_udc.c:2756: warning: Excess function parameter 'dev' description in 'pch_udc_isr'
       drivers/usb/gadget/udc/pch_udc.c:2906: warning: Function parameter or member 'dev' not described in 'init_dma_pools'
       drivers/usb/gadget/udc/pch_udc.c:2906: warning: Excess function parameter 'pdev' description in 'init_dma_pools'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Chuhong Yuan <hslester96@gmail.com>
      Cc: LAPIS Semiconductor <tomoya-linux@dsn.lapis-semi.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-16-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4ef2dfbd
    • Lee Jones's avatar
      usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc' · 6327bf75
      Lee Jones authored
      Looks as though it's never been used.  Driver was introduced in 2014.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/mv_udc_core.c:56:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=]
       56 | static const char driver_desc[] = DRIVER_DESC;
       | ^~~~~~~~~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Chao Xie <chao.xie@marvell.com>
      Cc: Neil Zhang <zhangwm@marvell.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-15-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6327bf75
    • Lee Jones's avatar
      usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' · 33a4eeb1
      Lee Jones authored
      Looks like it's been this way since the driver's inception in 2007.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’:
       drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
       478 | u16 tmp;
       | ^~~
      
      Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-14-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      33a4eeb1
    • Lee Jones's avatar
      usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions · 120d91da
      Lee Jones authored
      These are not used outside of this sourcefile, so make them static.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/lpc32xx_udc.c:1929:6: warning: no previous prototype for ‘udc_send_in_zlp’ [-Wmissing-prototypes]
       1929 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
       | ^~~~~~~~~~~~~~~
       drivers/usb/gadget/udc/lpc32xx_udc.c:1943:6: warning: no previous prototype for ‘udc_handle_eps’ [-Wmissing-prototypes]
       1943 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
       | ^~~~~~~~~~~~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Sylvain Lemieux <slemieux.tyco@gmail.com>
      Cc: Kevin Wells <kevin.wells@nxp.com>
      Cc: Roland Stigge <stigge@antcom.de>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Link: https://lore.kernel.org/r/20200706133341.476881-13-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      120d91da
    • Lee Jones's avatar
      usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc · 8f9a0e10
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'type' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'h' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'data' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'len' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'priv' not described in '__ffs_data_do_os_desc'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: David Howells <dhowells@redhat.com>
      Cc: Michal Nazarewicz <mina86@mina86.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-12-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8f9a0e10
    • Lee Jones's avatar
      usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia' · 5d1d4818
      Lee Jones authored
      Looks as though it's never been used.  Driver was introduced in 2010.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/legacy/nokia.c:65:19: warning: ‘product_nokia’ defined but not used [-Wunused-const-variable=]
       65 | static const char product_nokia[] = NOKIA_LONG_NAME;
       | ^~~~~~~~~~~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Al Borchers <alborchers@steinerpoint.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-11-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5d1d4818
    • Lee Jones's avatar
      usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp' · 14602c55
      Lee Jones authored
      Commit e78355b5 ("usb: gadget: udc: atmel: Don't use DT to
      configure end point") pulled out all functionality dealing with 'pp'.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘atmel_udc_of_init’:
       drivers/usb/gadget/udc/atmel_usba_udc.c:2106:22: warning: variable ‘pp’ set but not used [-Wunused-but-set-variable]
       2106 | struct device_node *pp;
       | ^~
      
      Cc: Cristian Birsan <cristian.birsan@microchip.com>
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-10-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      14602c55
    • Lee Jones's avatar
      usb: misc: legousbtower: Demote function header which is clearly not kerneldoc · 4ac2c460
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data'
      
      Cc: Juergen Stuber <starblue@users.sourceforge.net>
      Cc: David Glance <davidgsf@sourceforge.net>
      Cc: david <david@csse.uwa.edu.au>
      Cc: legousb-devel@lists.sourceforge.net
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-8-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4ac2c460
    • Lee Jones's avatar
      usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues · 4ee383c7
      Lee Jones authored
      Mostly bitrotted argument descriptions/names.  Also the removal
      of a blank line in the middle of a kerneldoc header, which is
      not allowed.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Function parameter or member 'ep' not described in 'ep_write_UDCCSR'
       drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Excess function parameter 'udc' description in 'ep_write_UDCCSR'
       drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Function parameter or member 'udc' not described in 'set_ep0state'
       drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Excess function parameter 'dev' description in 'set_ep0state'
       drivers/usb/gadget/udc/pxa27x_udc.c:506: warning: Excess function parameter 'req' description in 'inc_ep_stats_reqs'
       drivers/usb/gadget/udc/pxa27x_udc.c:1476: warning: bad line:
       drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Function parameter or member 'udc' not described in 'udc_enable'
       drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Excess function parameter 'dev' description in 'udc_enable'
       drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Function parameter or member 'g' not described in 'pxa27x_udc_start'
       drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Excess function parameter 'bind' description in 'pxa27x_udc_start'
       drivers/usb/gadget/udc/pxa27x_udc.c:1784: warning: Excess function parameter 'driver' description in 'stop_activity'
       drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Function parameter or member 'g' not described in 'pxa27x_udc_stop'
       drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Excess function parameter 'driver' description in 'pxa27x_udc_stop'
       drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Function parameter or member 'pdev' not described in 'pxa_udc_probe'
       drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Excess function parameter '_dev' description in 'pxa_udc_probe'
      
      Cc: Daniel Mack <daniel@zonque.org>
      Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
      Cc: Robert Jarzmik <robert.jarzmik@free.fr>
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-7-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4ee383c7
    • Lee Jones's avatar
      usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark · b1e4d550
      Lee Jones authored
      Kerneldoc expects all function arguments to be documented.  If any
      are missed it will complain.  Downgrade one header with 3 missing
      argument descriptions and one which makes no attempt.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'dev_addr' not described in 'gether_setup_name'
       drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'host_addr' not described in 'gether_setup_name'
       drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'qmult' not described in 'gether_setup_name'
       drivers/usb/gadget/function/u_ether.c:1022: warning: Function parameter or member 'dev' not described in 'gether_cleanup'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-6-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b1e4d550
    • Lee Jones's avatar
      usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc' · 53070115
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/amd5536udc_pci.c:52:19: warning: ‘mod_desc’ defined but not used [-Wunused-const-variable=]
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-5-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      53070115
    • Lee Jones's avatar
      usb: gadget: legacy: printer: Remove unused variable 'driver_desc' · 89dd9a8c
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/legacy/printer.c:24:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=]
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-4-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      89dd9a8c
    • Lee Jones's avatar
      usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format · f2db5f20
      Lee Jones authored
      No attempt has been made to document any of the structure's properties here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/ci_hdrc_pci.c:132: warning: cannot understand function prototype: 'const struct pci_device_id ci_hdrc_pci_id_table[] = '
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Cc: David Lopo <dlopo@chipidea.mips.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-3-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f2db5f20
    • Lee Jones's avatar
      usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks · 464b7d0e
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:290: warning: Function parameter or member 'dev' not described in 'tower_delete'
       drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'inode' not described in 'tower_open'
       drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'file' not described in 'tower_open'
       drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'inode' not described in 'tower_release'
       drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'file' not described in 'tower_release'
       drivers/usb/misc/legousbtower.c:452: warning: Function parameter or member 'dev' not described in 'tower_check_for_read_packet'
       drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'file' not described in 'tower_poll'
       drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'wait' not described in 'tower_poll'
       drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'file' not described in 'tower_llseek'
       drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'off' not described in 'tower_llseek'
       drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'whence' not described in 'tower_llseek'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'file' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'buffer' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'count' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'ppos' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'file' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'buffer' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'count' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'ppos' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:669: warning: Function parameter or member 'urb' not described in 'tower_interrupt_in_callback'
       drivers/usb/misc/legousbtower.c:724: warning: Function parameter or member 'urb' not described in 'tower_interrupt_out_callback'
       drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'interface' not described in 'tower_probe'
       drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'id' not described in 'tower_probe'
       drivers/usb/misc/legousbtower.c:863: warning: Function parameter or member 'interface' not described in 'tower_disconnect'
      
      Cc: Juergen Stuber <starblue@users.sourceforge.net>
      Cc: David Glance <davidgsf@sourceforge.net>
      Cc: david <david@csse.uwa.edu.au>
      Cc: legousb-devel@lists.sourceforge.net
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-2-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      464b7d0e
    • Lee Jones's avatar
      usb: gadget: udc: dummy_hcd: Repair misspelled function argument 'dummy_hcd' · 66f84901
      Lee Jones authored
      An attempt was made to document the functions in 'dummy_hcd',
      but a simple spelling mistake was made.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/dummy_hcd.c:1597: warning: Function parameter or member 'dum_hcd' not described in 'handle_control_request'
       drivers/usb/gadget/udc/dummy_hcd.c:1597: warning: Excess function parameter 'dum' description in 'handle_control_request'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Andrey Konovalov <andreyknvl@gmail.com>
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-31-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      66f84901
    • Lee Jones's avatar
      usb: musb: musb_dsps: Demote obvious misuse of kerneldoc to standard comment blocks · 09e03a89
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/musb/musb_dsps.c:44: warning: cannot understand function prototype: 'struct dsps_musb_wrapper '
       drivers/usb/musb/musb_dsps.c:102: warning: cannot understand function prototype: 'struct dsps_glue '
       drivers/usb/musb/musb_dsps.c:169: warning: Function parameter or member 'musb' not described in 'dsps_musb_enable'
       drivers/usb/musb/musb_dsps.c:195: warning: Function parameter or member 'musb' not described in 'dsps_musb_disable'
      
      Cc: Bin Liu <b-liu@ti.com>
      Cc: Ravi B <ravibabu@ti.com>
      Cc: Kumar Gupta <ajay.gupta@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-29-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      09e03a89
    • Lee Jones's avatar
      usb: misc: ldusb: Demote obvious misuse of kerneldoc to standard comment blocks · 7e8455b1
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/ldusb.c:192: warning: Function parameter or member 'dev' not described in 'ld_usb_abort_transfers'
       drivers/usb/misc/ldusb.c:206: warning: Function parameter or member 'dev' not described in 'ld_usb_delete'
       drivers/usb/misc/ldusb.c:220: warning: Function parameter or member 'urb' not described in 'ld_usb_interrupt_in_callback'
       drivers/usb/misc/ldusb.c:281: warning: Function parameter or member 'urb' not described in 'ld_usb_interrupt_out_callback'
       drivers/usb/misc/ldusb.c:301: warning: Function parameter or member 'inode' not described in 'ld_usb_open'
       drivers/usb/misc/ldusb.c:301: warning: Function parameter or member 'file' not described in 'ld_usb_open'
       drivers/usb/misc/ldusb.c:372: warning: Function parameter or member 'inode' not described in 'ld_usb_release'
       drivers/usb/misc/ldusb.c:372: warning: Function parameter or member 'file' not described in 'ld_usb_release'
       drivers/usb/misc/ldusb.c:414: warning: Function parameter or member 'file' not described in 'ld_usb_poll'
       drivers/usb/misc/ldusb.c:414: warning: Function parameter or member 'wait' not described in 'ld_usb_poll'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'file' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'buffer' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'count' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'ppos' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'file' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'buffer' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'count' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'ppos' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:651: warning: Function parameter or member 'intf' not described in 'ld_usb_probe'
       drivers/usb/misc/ldusb.c:651: warning: Function parameter or member 'id' not described in 'ld_usb_probe'
       drivers/usb/misc/ldusb.c:754: warning: Function parameter or member 'intf' not described in 'ld_usb_disconnect'
      
      Cc: Johan Hovold <johan@kernel.org>
      Cc: Michael Hund <mhund@ld-didactic.de>
      Cc: David Glance <advidgsf@sourceforge.net>
      Cc: Juergen Stuber <starblue@users.sourceforge.net>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-28-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7e8455b1
    • Lee Jones's avatar
      usb: gadget: function: u_serial: Repair misdocumented function argument · 1ba1f141
      Lee Jones authored
      Looks as though this has been an issue since the driver's
      inception back in 2014.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/function/u_serial.c:538: warning: Function parameter or member 'port' not described in 'gs_start_io'
       drivers/usb/gadget/function/u_serial.c:538: warning: Excess function parameter 'dev' description in 'gs_start_io'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
      Cc: Al Borchers <alborchers@steinerpoint.com>
      Cc: Peter Berger <pberger@brimson.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-27-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1ba1f141
    • Lee Jones's avatar
      usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks · c16700ed
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/iowarrior.c:251: warning: Function parameter or member 'dev' not described in 'iowarrior_delete'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'file' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'buffer' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'count' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'ppos' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'file' not described in 'iowarrior_ioctl'
       drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'cmd' not described in 'iowarrior_ioctl'
       drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'arg' not described in 'iowarrior_ioctl'
       drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'inode' not described in 'iowarrior_open'
       drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'file' not described in 'iowarrior_open'
       drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'inode' not described in 'iowarrior_release'
       drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'file' not described in 'iowarrior_release'
       drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'interface' not described in 'iowarrior_probe'
       drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'id' not described in 'iowarrior_probe'
       drivers/usb/misc/iowarrior.c:879: warning: Function parameter or member 'interface' not described in 'iowarrior_disconnect'
      
      Cc: Johan Hovold <johan@kernel.org>
      Cc: Christian Lucht <lucht@codemercs.com>
      Cc: Stephane Dalton <sdalton@videotron.ca>
      Cc: Stephane Doyon <s.doyon@videotron.ca>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-26-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c16700ed
    • Lee Jones's avatar
      usb: misc: iowarrior: Fix odd corruption issue in the file header · 2ba277a0
      Lee Jones authored
      Looks although Stephane's name was corrupted somehow.
      
      Cc: Johan Hovold <johan@kernel.org>
      Cc: Christian Lucht <lucht@codemercs.com>
      Cc: Stephane Dalton <sdalton@videotron.ca>
      Cc: Stephane Doyon <s.doyon@videotron.ca>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-25-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2ba277a0
    • Lee Jones's avatar
      usb: chipidea: usbmisc_imx: Demote obvious misuse of kerneldoc to standard comment block · 20f81da9
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/usbmisc_imx.c:801: warning: Function parameter or member 'data' not described in 'imx7d_charger_detection'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Cc: Shawn Guo <shawnguo@kernel.org>
      Cc: Sascha Hauer <s.hauer@pengutronix.de>
      Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
      Cc: Fabio Estevam <festevam@gmail.com>
      Cc: NXP Linux Team <linux-imx@nxp.com>
      Cc: Richard Zhao <richard.zhao@freescale.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-24-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      20f81da9
    • Lee Jones's avatar
      usb: typec: tcpm: fusb302: Use 'gnu_printf' format notation · 71be1a8a
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/typec/tcpm/fusb302.c: In function ‘fusb302_log’:
       drivers/usb/typec/tcpm/fusb302.c:186:2: warning: function ‘fusb302_log’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
       186 | _fusb302_log(chip, fmt, args);
       | ^~~~~~~~~~~~
      
      Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
      Cc: Yueyao Zhu <yueyao.zhu@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Link: https://lore.kernel.org/r/20200703174148.2749969-23-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      71be1a8a
    • Lee Jones's avatar
      usb: typec: altmodes: displayport: Supply missing displayport.h include file · 318ebed2
      Lee Jones authored
      If the header file containing a function's prototype isn't included by
      the sourcefile containing the associated function, the build system
      complains of missing prototypes.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/typec/altmodes/displayport.c:511:5: warning: no previous prototype for ‘dp_altmode_probe’ [-Wmissing-prototypes]
       drivers/usb/typec/altmodes/displayport.c:551:6: warning: no previous prototype for ‘dp_altmode_remove’ [-Wmissing-prototypes]
      
      Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-22-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      318ebed2
    • Lee Jones's avatar
      usb: typec: altmodes: displayport: File headers are not good candidates for kerneldoc · 50c9bd05
      Lee Jones authored
      Demote displayport's file header to a standard comment block.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/typec/altmodes/displayport.c:18: warning: Function parameter or member '_dp' not described in 'DP_HEADER'
       drivers/usb/typec/altmodes/displayport.c:18: warning: Function parameter or member 'cmd' not described in 'DP_HEADER'
      
      Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-21-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      50c9bd05
    • Lee Jones's avatar
      usb: storage: alauda: Remove set but unchecked variable · 7565fce1
      Lee Jones authored
      The return value of alauda_get_media_status() hasn't been checked
      since the driver's inception back in 2005.  If nothing have gone
      wrong/been detected until this point, it's probably safe to just
      remove the variable.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/storage/alauda.c: In function ‘alauda_check_media’:
       drivers/usb/storage/alauda.c:456:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
       456 | int rc;
       | ^~
      
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Daniel Drake <dsd@gentoo.org>
      Cc: usb-storage@lists.one-eyed-alien.net
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-20-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7565fce1
    • Lee Jones's avatar
      usb: host: xhci-debugfs: Use 'gnu_printf' format notation · 142c8bb6
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/xhci-debugfs.c:128:2: warning: function ‘xhci_debugfs_regset’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
       128 | vsnprintf(rgs->name, sizeof(rgs->name), fmt, args);
       | ^~~~~~~~~
      
      Cc: Mathias Nyman <mathias.nyman@intel.com>
      Cc: Lu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-19-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      142c8bb6
    • Lee Jones's avatar
      usb: chipidea: udc: Fix a few kerneldoc issues · f2926dd5
      Lee Jones authored
      Descriptions were missing for 'ci' almost throughout.  There was
      one instance of over-documenting.  Finally one function argument
      was incorrectly documented (probably down to bitrot).
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/udc.c:245: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed'
       drivers/usb/chipidea/udc.c:271: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active'
       drivers/usb/chipidea/udc.c:285: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard'
       drivers/usb/chipidea/udc.c:296: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard'
       drivers/usb/chipidea/udc.c:321: warning: Function parameter or member 'ci' not described in 'hw_usb_reset'
       drivers/usb/chipidea/udc.c:628: warning: Excess function parameter 'ci' description in 'free_pending_td'
       drivers/usb/chipidea/udc.c:655: warning: Function parameter or member 'hwep' not described in '_hardware_dequeue'
       drivers/usb/chipidea/udc.c:655: warning: Excess function parameter 'gadget' description in '_hardware_dequeue'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-18-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f2926dd5
    • Lee Jones's avatar
      usb: host: xhci-dbgtty: File headers are not good candidates for kerneldoc · 0e1aceca
      Lee Jones authored
      Demote xhci-dbgtty's file header to a standard comment block.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/xhci-dbgtty.c:19: warning: Function parameter or member 'port' not described in 'dbc_send_packet'
       drivers/usb/host/xhci-dbgtty.c:19: warning: Function parameter or member 'packet' not described in 'dbc_send_packet'
       drivers/usb/host/xhci-dbgtty.c:19: warning: Function parameter or member 'size' not described in 'dbc_send_packet'
      
      Cc: Mathias Nyman <mathias.nyman@intel.com>
      Cc: Lu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-17-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0e1aceca
    • Lee Jones's avatar
      usb: host: xhci-dbgcap: File headers are not good candidates for kerneldoc · e57bde58
      Lee Jones authored
      Demote xhci-dbgcap's file header to a standard comment block.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'xhci' not described in 'dbc_dma_alloc_coherent'
       drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'size' not described in 'dbc_dma_alloc_coherent'
       drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'dma_handle' not described in 'dbc_dma_alloc_coherent'
       drivers/usb/host/xhci-dbgcap.c:20: warning: Function parameter or member 'flags' not described in 'dbc_dma_alloc_coherent'
      
      Cc: Mathias Nyman <mathias.nyman@intel.com>
      Cc: Lu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-16-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      e57bde58
    • Lee Jones's avatar
      usb: host: xhci-mem: Demote obvious misuse of kerneldoc to standard comment block · c3fa4e04
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'xhci' not described in 'xhci_ring_alloc'
       drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'num_segs' not described in 'xhci_ring_alloc'
       drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'cycle_state' not described in 'xhci_ring_alloc'
       drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'type' not described in 'xhci_ring_alloc'
       drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'max_packet' not described in 'xhci_ring_alloc'
       drivers/usb/host/xhci-mem.c:365: warning: Function parameter or member 'flags' not described in 'xhci_ring_alloc'
      
      Cc: Mathias Nyman <mathias.nyman@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-15-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c3fa4e04
    • Lee Jones's avatar
      usb: host: xhci: Demote obvious misuse of kerneldoc to standard comment block · f3a9492b
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/xhci.c:1285: warning: Function parameter or member 'desc' not described in 'xhci_get_endpoint_index'
      
      Cc: Mathias Nyman <mathias.nyman@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-14-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f3a9492b
    • Lee Jones's avatar
      usb: chipidea: udc: Help out kerneldoc headers that have tried, demote the others · 92d08e07
      Lee Jones authored
      Help with adding the odd description where they have been omitted or
      where the format isn't quite right.  Demote all function headers which
      are lacking any attempt of describing their arguments.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/udc.c:645: warning: Function parameter or member 'hwreq' not described in '_hardware_dequeue'
       drivers/usb/chipidea/udc.c:645: warning: Excess function parameter 'gadget' description in '_hardware_dequeue'
       drivers/usb/chipidea/udc.c:1326: warning: Function parameter or member 'ep' not described in 'ep_enable'
       drivers/usb/chipidea/udc.c:1326: warning: Function parameter or member 'desc' not described in 'ep_enable'
       drivers/usb/chipidea/udc.c:1393: warning: Function parameter or member 'ep' not described in 'ep_disable'
       drivers/usb/chipidea/udc.c:1433: warning: Function parameter or member 'ep' not described in 'ep_alloc_request'
       drivers/usb/chipidea/udc.c:1433: warning: Function parameter or member 'gfp_flags' not described in 'ep_alloc_request'
       drivers/usb/chipidea/udc.c:1454: warning: Function parameter or member 'ep' not described in 'ep_free_request'
       drivers/usb/chipidea/udc.c:1454: warning: Function parameter or member 'req' not described in 'ep_free_request'
       drivers/usb/chipidea/udc.c:1488: warning: Function parameter or member 'ep' not described in 'ep_queue'
       drivers/usb/chipidea/udc.c:1488: warning: Function parameter or member 'req' not described in 'ep_queue'
       drivers/usb/chipidea/udc.c:1488: warning: Function parameter or member 'gfp_flags' not described in 'ep_queue'
       drivers/usb/chipidea/udc.c:1512: warning: Function parameter or member 'ep' not described in 'ep_dequeue'
       drivers/usb/chipidea/udc.c:1512: warning: Function parameter or member 'req' not described in 'ep_dequeue'
       drivers/usb/chipidea/udc.c:1556: warning: Function parameter or member 'ep' not described in 'ep_set_halt'
       drivers/usb/chipidea/udc.c:1556: warning: Function parameter or member 'value' not described in 'ep_set_halt'
       drivers/usb/chipidea/udc.c:1566: warning: Function parameter or member 'ep' not described in 'ep_set_wedge'
       drivers/usb/chipidea/udc.c:1586: warning: Function parameter or member 'ep' not described in 'ep_fifo_flush'
       drivers/usb/chipidea/udc.c:1610: warning: cannot understand function prototype: 'const struct usb_ep_ops usb_ep_ops = '
       drivers/usb/chipidea/udc.c:1629: warning: Function parameter or member '_gadget' not described in 'ci_hdrc_gadget_connect'
       drivers/usb/chipidea/udc.c:1629: warning: Function parameter or member 'is_active' not described in 'ci_hdrc_gadget_connect'
       drivers/usb/chipidea/udc.c:1780: warning: cannot understand function prototype: 'const struct usb_gadget_ops usb_gadget_ops = '
       drivers/usb/chipidea/udc.c:1931: warning: Function parameter or member 'gadget' not described in 'ci_udc_stop'
       drivers/usb/chipidea/udc.c:1965: warning: Function parameter or member 'ci' not described in 'udc_irq'
       drivers/usb/chipidea/udc.c:2095: warning: Function parameter or member 'ci' not described in 'ci_hdrc_gadget_destroy'
       drivers/usb/chipidea/udc.c:2144: warning: Function parameter or member 'ci' not described in 'ci_hdrc_gadget_init'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-13-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      92d08e07
    • Lee Jones's avatar
      usb: chipidea: udc: Add missing descriptions for function arg 'ci' · 22dfe657
      Lee Jones authored
      Looks like a very popular argument to omit descriptions for.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/udc.c:80: warning: Function parameter or member 'ci' not described in 'hw_device_state'
       drivers/usb/chipidea/udc.c:100: warning: Function parameter or member 'ci' not described in 'hw_ep_flush'
       drivers/usb/chipidea/udc.c:121: warning: Function parameter or member 'ci' not described in 'hw_ep_disable'
       drivers/usb/chipidea/udc.c:136: warning: Function parameter or member 'ci' not described in 'hw_ep_enable'
       drivers/usb/chipidea/udc.c:170: warning: Function parameter or member 'ci' not described in 'hw_ep_get_halt'
       drivers/usb/chipidea/udc.c:185: warning: Function parameter or member 'ci' not described in 'hw_ep_prime'
       drivers/usb/chipidea/udc.c:215: warning: Function parameter or member 'ci' not described in 'hw_ep_set_halt'
       drivers/usb/chipidea/udc.c:238: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed'
       drivers/usb/chipidea/udc.c:251: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_complete'
       drivers/usb/chipidea/udc.c:263: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active'
       drivers/usb/chipidea/udc.c:277: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard'
       drivers/usb/chipidea/udc.c:288: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard'
       drivers/usb/chipidea/udc.c:300: warning: Function parameter or member 'ci' not described in 'hw_usb_set_address'
       drivers/usb/chipidea/udc.c:312: warning: Function parameter or member 'ci' not described in 'hw_usb_reset'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-12-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      22dfe657
    • Lee Jones's avatar
      usb: chipidea: debug: Demote obvious misuse of kerneldoc to standard comment blocks · 5722a8ef
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/debug.c:25: warning: Function parameter or member 's' not described in 'ci_device_show'
       drivers/usb/chipidea/debug.c:25: warning: Function parameter or member 'data' not described in 'ci_device_show'
       drivers/usb/chipidea/debug.c:54: warning: Function parameter or member 's' not described in 'ci_port_test_show'
       drivers/usb/chipidea/debug.c:54: warning: Function parameter or member 'data' not described in 'ci_port_test_show'
       drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'file' not described in 'ci_port_test_write'
       drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'ubuf' not described in 'ci_port_test_write'
       drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'count' not described in 'ci_port_test_write'
       drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'ppos' not described in 'ci_port_test_write'
       drivers/usb/chipidea/debug.c:122: warning: Function parameter or member 's' not described in 'ci_qheads_show'
       drivers/usb/chipidea/debug.c:122: warning: Function parameter or member 'data' not described in 'ci_qheads_show'
       drivers/usb/chipidea/debug.c:154: warning: Function parameter or member 's' not described in 'ci_requests_show'
       drivers/usb/chipidea/debug.c:154: warning: Function parameter or member 'data' not described in 'ci_requests_show'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-11-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5722a8ef
    • Lee Jones's avatar
      usb: chipidea: otg: Fix kerneldoc issues relating to description of 'ci' · 6a005f0f
      Lee Jones authored
      Firstly we add some missing descriptions.  Then we fix some formatting
      issues.  Kerneldoc expects arguments to be in the format '@.*: '.  If
      either the '@' or ':' is omitted, kerneldoc gets confused.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/otg.c:29: warning: Function parameter or member 'ci' not described in 'hw_read_otgsc'
       drivers/usb/chipidea/otg.c:82: warning: Function parameter or member 'ci' not described in 'hw_write_otgsc'
       drivers/usb/chipidea/otg.c:235: warning: Function parameter or member 'ci' not described in 'ci_hdrc_otg_init'
       drivers/usb/chipidea/otg.c:254: warning: Function parameter or member 'ci' not described in 'ci_hdrc_otg_destroy'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-10-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6a005f0f
    • Lee Jones's avatar
      usb: gadget: udc: core: Fix a bunch of kerneldoc misdemeanours · e21cd08f
      Lee Jones authored
      Firstly, file headers should not be in kerneldoc format.  Function
      args should be in the format '@.*: '.  We also take the time to
      add some descriptions for various argument which have been
      previously left out.  Finally we remove descriptions for absent
      arguments.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/core.c:25: warning: Incorrect use of kernel-doc format:  * struct usb_udc - describes one usb device controller
       drivers/usb/gadget/udc/core.c:36: warning: cannot understand function prototype: 'struct usb_udc '
       drivers/usb/gadget/udc/core.c:901: warning: Function parameter or member 'ep' not described in 'usb_gadget_giveback_request'
       drivers/usb/gadget/udc/core.c:901: warning: Function parameter or member 'req' not described in 'usb_gadget_giveback_request'
       drivers/usb/gadget/udc/core.c:1098: warning: Function parameter or member 'udc' not described in 'usb_gadget_udc_stop'
       drivers/usb/gadget/udc/core.c:1098: warning: Excess function parameter 'gadget' description in 'usb_gadget_udc_stop'
       drivers/usb/gadget/udc/core.c:1098: warning: Excess function parameter 'driver' description in 'usb_gadget_udc_stop'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-9-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      e21cd08f
    • Lee Jones's avatar
      usb: chipidea: core: Document hw_port_test_set()'s missing 'ci' argument · 8ac326ff
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/core.c:163: warning: Function parameter or member 'ci' not described in 'hw_port_test_set'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Cc: David Lopo <dlopo@chipidea.mips.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-8-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8ac326ff