- 22 Dec, 2015 9 commits
-
-
James Smart authored
Make write check error processing more resilient. Checks to catch writes that fw reports weren't fully complete yet SCSI status indicated fine needed correction. Signed-off-by:
Dick Kennedy <dick.kennedy@avagotech.com> Signed-off-by:
James Smart <james.smart@avagotech.com> Reviewed-by:
Hannes Reinicke <hare@suse.de> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
James Smart authored
Fix RDP ACC being too long. Signed-off-by:
-
James Smart authored
Fix RDP Speed reporting. Signed-off-by:
-
James Smart authored
Modularize, cleanup, add comments - for FDMI code in driver Note: I don't like the comments with leading # - but as we have a lot if present, I'm deferring to handle it in one big fix later. Signed-off-by:
-
James Smart authored
Fix crash in fcp command completion path. Missed null check. Signed-off-by:
-
James Smart authored
Fix driver crash when module parameter lpfc_fcp_io_channel set to 16 Signed-off-by:
-
James Smart authored
Fix RegLogin failed error seen on Lancer FC during port bounce Fix the statemachine and ref counting. Signed-off-by:
-
James Smart authored
Fix the FLOGI discovery logic to comply with T11 standards We weren't properly setting fabric parameters, such as R_A_TOV and E_D_TOV, when we registered the vfi object in default configs and pt2pt configs. Revise to now pass service params with the values to the firmware and ensure they are reset on link bounce. Required reworking the call sequence in the discovery threads. Signed-off-by:
-
James Smart authored
Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Signed-off-by:
-
- 17 Dec, 2015 1 commit
-
-
John Garry authored
It is preferred that drivers use platform_get_irq() instead of irq_of_parse_and_map(), so replace. Signed-off-by:
John Garry <john.garry@huawei.com> Acked-by:
Rob Herring <robh@kernel.org> Reviewed-by:
Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by:
-
- 10 Dec, 2015 6 commits
-
-
Dan Carpenter authored
There were a couple cases where the error codes weren't set and also I changed the success return to "return 0;" which is the same as "return rc;" but more explicit. Fixes: 42e7a693 ('hisi_sas: Add ssp command functio') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Tested-by:
-
Rasmus Villemoes authored
If char is signed and one of these bytes happen to have a value outside the ascii range, the corresponding output will consist of "ffffff" followed by the two hex chars that were actually intended. One way to fix it would be to change the casts to (u8*) aka (unsigned char*), but it is much simpler (and generates smaller code) to use the %ph extension which was created for such short hexdumps. Signed-off-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Acked-by:
Boaz Harrosh <ooo@electrozaur.com> Signed-off-by:
-
Long Li authored
Introduce a logging level for storvsc to log certain error/warning messages. Those messages are helpful in some environments, e.g. Microsoft Azure, for customer support and troubleshooting purposes. Signed-off-by:
Long Li <longli@microsoft.com> Acked-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
-
Josh Boyer authored
The driver is missing calls to pci_dma_mapping_error() after performing the DMA mapping, which caused DMA-API warning to show up in dmesg's output. Though that happens only when DMA_API_DEBUG option is enabled. This change fixes the issue and makes pvscsi_map_buffers() function more robust. Signed-off-by:
Arvind Kumar <arvindkumar@vmware.com> Cc: Josh Boyer <jwboyer@fedoraproject.org> Reviewed-by:
Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by:
Josh Boyer <jwboyer@fedoraproject.org> Reviewed-by:
-
Geliang Tang authored
IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by:
Geliang Tang <geliangtang@163.com> Acked-by:
Manoj Kumar <manoj@linux.vnet.ibm.com> Acked-by:
Matthew R. Ochs <mrochs@linux.vnet.ibm.com> Signed-off-by:
-
Dan Carpenter authored
The "> MAX_CONTEXT" should be ">= MAX_CONTEXT". Otherwise we go one step beyond the end of the cfg->ctx_tbl[] array. Signed-off-by:
-
- 08 Dec, 2015 1 commit
-
-
Hannes Reinecke authored
With commit 83ea0e5e ("scsi_dh_alua: use scsi_vpd_tpg_id()") these variables became obsolete, but weren't removed. [mkp: Fixed checkpatch warning] Signed-off-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
-
- 02 Dec, 2015 22 commits
-
-
Anil Gurumurthy authored
Signed-off-by:
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com> Signed-off-by:
Anil Gurumurthy <anil.gurumurthy@qlogic.com> Reviewed-by:
-
Anil Gurumurthy authored
Signed-off-by:
-
Anil Gurumurthy authored
Fix a very corner case when the port gets disconnected and the BFA and FCS layers clean up references to the IT nexus. During this window if a task management command is issued by the SCSI-ML and ends up referencing a NULL itnim, it could lead to a crash. Signed-off-by:
-
Anil Gurumurthy authored
Signed-off-by:
-
Hannes Reinecke authored
Use the common function 'scsi_vpd_tpg_id()' instead of open-coding it in scsi_dh_alua. [mkp: Applied by hand] Signed-off-by:
Johannes Thumshirn <jthumshirn@suse.com> Reviewed-by:
-
Hannes Reinecke authored
Implement scsi_vpd_tpg_id() to extract the target port group id and the relative port id from SCSI VPD page 0x83. Reviewed-by:
-
Hannes Reinecke authored
Use scsi_vpd_lun_id() to export the world-wide unique id (wwid) to sysfs. Note that this is the 'best' wwid according to the rules in scsi_vpd_lun_id(), not every possible wwid presented by the drive. Signed-off-by:
-
Hannes Reinecke authored
Add a function scsi_vpd_lun_id() to return a unique device identifcation based on the designation descriptors of VPD page 0x83. As devices might implement several descriptors the order of preference is: - NAA IEE Registered Extended - EUI-64 based 16-byte - EUI-64 based 12-byte - NAA IEEE Registered - NAA IEEE Extended A SCSI name string descriptor is preferred to all of them if the identification is longer than 16 bytes. The returned unique device identification will be formatted as a SCSI Name string to avoid clashes between different designator types. [mkp: Fixed up kernel doc comment from Johannes] Signed-off-by:
Ewan Milne <emilne@redhat.com> Reviewed-by:
-
Hannes Reinecke authored
Most sense code is already handled in the generic code, so we shouldn't be adding special cases here. However, when doing so we need to check for unit attention whenever we're sending an internal command. Signed-off-by:
-
Hannes Reinecke authored
Instead of returning an error code in alua_check_tpgs() we should rather return the tpgs mode directly and have a cleaner syntax. Signed-off-by:
-
Hannes Reinecke authored
Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of open-coding it. Signed-off-by:
-
Hannes Reinecke authored
We should be using a flag when RTPG extended header is not supported, that saves us sending RTPG twice for older arrays. Signed-off-by:
Bart Van Assche <bart.vanassche@sandisk.com> Reviewed-by:
-
Hannes Reinecke authored
Last caller is gone, so remove it. Signed-off-by:
-
Hannes Reinecke authored
Fixup copy-and-paste error in the description of stpg_endio(). Signed-off-by:
-
Hannes Reinecke authored
Fixup submit_rtpg() to always return a standard SCSI return code. Signed-off-by:
-
Hannes Reinecke authored
Use standard logging functions instead of hand-crafted ones. Signed-off-by:
Bart Van Assche <bvanassche@sandisk.com> Reviewed-by:
-
Hannes Reinecke authored
The only check for a valid sense code is calling scsi_normalize_sense() and check the return value. So drop the pointless checks and rely on scsi_normalize_sense() to figure out if the sense code is valid. With that we can also remove the 'senselen' field. Signed-off-by:
-
Hannes Reinecke authored
Issue different logging messages if ALUA is not supported or the TPGS setting is invalid. Signed-off-by:
-
Hannes Reinecke authored
The SCSI device now has the VPD page 0x83 information attached, so there is no need to query it again. [mkp: Fixed a checkpatch warning] Signed-off-by:
-
Hannes Reinecke authored
Non-disk devices might support ALUA, but the firmware implementation is untested and frequently broken. As we're don't actually need it disable ALUA support for non-disk device for now. Signed-off-by:
-
Hannes Reinecke authored
device handler initialisation might fail due to a number of reasons. But as device_handlers are optional this shouldn't cause us to disable the device entirely. So just ignore errors from scsi_dh_add_device(). Reviewed-by:
-
Hannes Reinecke authored
As scsi_dh.c is now always compiled in we should be moving the 'dh_state' attribute to the generic code. Reviewed-by:
-
- 01 Dec, 2015 1 commit
-
-
Luis de Bethencourt authored
Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended? The code is correct, the indention is misleading. When the device is not ready we want to return SAS_PHY_DOWN. But current indentation makes it look like we only do so in the else branch of if (mvi_dev). Signed-off-by:
Luis de Bethencourt <luisbg@osg.samsung.com> Reviewed-by:
-
