- 27 Jun, 2014 40 commits
-
-
Alexander.Boyko authored
Race between ptlrpc_resend_req() and ptlrpc_check_set(). 1 thread do ptlrpc_check_set()->after_reply() 2 thread do ptlrpc_resend_req() The result is request with rq_resend = 1 and MSG_REPLY flag. When this request will came to server it will cause client eviction. The patch skip ptlrpc_resend_req logic if rq_replied is set, and clear rq_resend flag at reply_in_callback() when client got reply. Signed-off-by:
Alexander Boyko <alexander_boyko@xyratex.com> Xyratex-bug-id: MRP-1888 Reviewed-on: http://review.whamcloud.com/10471 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5116Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
Mike Pershin <mike.pershin@intel.com> Reviewed-by:
Chris Horn <hornc@cray.com> Signed-off-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bobi Jam authored
Old code residue assumes initial checksum value as ~0, and relies on that to check whether OST server has calculated bulk data checksum. That is not the case anymore. Signed-off-by:
Bobi Jam <bobijam.xu@intel.com> Reviewed-on: http://review.whamcloud.com/10354 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4937Reviewed-by:
Bob Glossman <bob.glossman@intel.com> Signed-off-by:
-
Andriy Skulysh authored
mgc import can be reconnected by pinger or ptlrpc_reconnect_import(). ptlrpc_invalidate_import() isn't protected against alteration of imp_invalid state. Import can be reconnected by pinger which makes imp_invalid equal to false. Thus LASSERT(imp->imp_invalid) fails in ptlrpc_invalidate_import(). It is safe to call ptlrpc_invalidate_import() when import is deactivated, but ptlrpc_reconnect_import() doesn't deactivate it. Let's use only pinger when available to reconnect import Signed-off-by:
Andriy Skulysh <Andriy_Skulysh@xyratex.com> Reviewed-on: http://review.whamcloud.com/9967 Xyratex-bug-id: MRP-1746 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4913Reviewed-by:
Lai Siyao <lai.siyao@intel.com> Signed-off-by:
-
Dmitry Eremin authored
Pointer 'obd' checked for NULL at line 694 may be dereferenced at line 813. Pointer 'req->rq_export->exp_obd' checked for NULL at line 1155 may be dereferenced at line 1164. Also there is one similar error on line 1170. Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-on: http://review.whamcloud.com/10062 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
-
Dmitry Eremin authored
Fixed implicit conversion from 'unsigned long long' to 'int'. Signed-off-by:
-
Nathaniel Clark authored
Check that attr mode is valid before using it when determining if to clear SGID and SUID bits in ll_setattr. Signed-off-by:
Nathaniel Clark <nathaniel.l.clark@intel.com> Reviewed-on: http://review.whamcloud.com/10153 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4924Reviewed-by:
-
Oleg Drokin authored
*_enlarge_reqbuf class of functions can change request body location for a request that's already in replay list, as such a parallel traverser of the list (after_reply -> ptlrpc_free_committed) might access freed and scrambled memory causing assertion. Since all such users only can get to this request under imp_lock, take imp_lock to protect against them in *_enlarge_reqbuf Signed-off-by:
-
Oleg Drokin authored
Changes introduced by 80db2734 unfortunately totally break lustre, we use this function to access not only socket proto obs, but also device ioctl like SIOCGIFCONF that now fail. Reverting part of the previous patch to regain the needed functionality. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> CC: Fredrick John Berchmans <fredrickprashanth@gmail.com> Signed-off-by:
-
Ben Chan authored
This patch fixes the following checkpatch warning: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by:Ben Chan <benchan@chromium.org> Signed-off-by:
-
Ben Chan authored
This patch fixes the following checkpatch warnings, which are issued when the gdm72xx driver is moved out of staging into drivers/net/wimax: WARNING: networking block comments don't use an empty /* line, use /* Comment... WARNING: networking block comments start with * on subsequent lines WARNING: networking block comments put the trailing */ on a separate line Signed-off-by:
-
Ben Chan authored
Signed-off-by:
-
Pawel Lebioda authored
This patch fixes the following sparse warning: drivers/staging/cxt1e1/sbecrc.c:86:1: warning: symbol 'sbeCrc' was not declared. Should it be static? Furthermore it fixes wring sbeCrc return type in function declaration. Signed-off-by:
Pawel Lebioda <pawel.lebioda89@gmail.com> Signed-off-by:
-
Cheng-Wei Lee authored
This patch fixes the following checkpatch.pl issue in ft1000/ft1000-pcmcia/ft1000_dnld.c ERROR: code indent should use tabs where possible Signed-off-by:
Quentin Lee <lee.rhapsody@gmail.com> Signed-off-by:
-
Seunghun Lee authored
This patch fixes below warning. drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in assignment (different address spaces) drivers/staging/ced1401/ced_ioc.c:703:30: expected void *[usertype] lpvBuff drivers/staging/ced1401/ced_ioc.c:703:30: got char [noderef] <asn:1>*puBuf Signed-off-by:
Seunghun Lee <waydi1@gmail.com> Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
No point carrying a bunch of code around that is never going to get called. Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
This fixes a minor sparse warning. Reported-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
Clément Calmels authored
Found running sparse on the rtl8723au driver. CHECK drivers/staging/rtl8723au/core/rtw_cmd.c drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: expected int [signed] gfp drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: got restricted gfp_t Signed-off-by:
Clement Calmels <clement.calmels@free.fr> Signed-off-by:
-
James A Shackleford authored
Signed-off-by:
James A Shackleford <shack@linux.com> Signed-off-by:
-
James A Shackleford authored
_queue_empty is an inline wrapper around list_empty. This patch removes this wrapper function and instead calls list_empty directly. Signed-off-by:
-
James A Shackleford authored
get_list_head is an inline that returns &list->head. This patch removes this inline and directly applies &list->head where applicable. Signed-off-by:
-
James A Shackleford authored
get_next is just an inline wrapper around return list->next. This patch removes the wrapper and directly uses list->next where applicable. Signed-off-by:
-
James A Shackleford authored
list_delete is just an inline wrapper around list_del_init. This patch removes the wrapper and directly uses list_del_init. Signed-off-by:
-
James A Shackleford authored
list_insert_tail is just an inline wrapper around list_add_tail. This patch removes the wrapper and directly uses list_add_tail. Signed-off-by:
-
James A Shackleford authored
is_list_empty is just an inline wrapper around list_empty. This patch removes the wrapper and directly uses list_empty instead. Signed-off-by:
-
James A Shackleford authored
_init_listhead is just an inline wrapper around INIT_LIST_HEAD. This patch removes the wrapper and directly uses INIT_LIST_HEAD instead. Signed-off-by:
-
Rickard Strandqvist authored
For consistency with other drivers, replace a magic number by a macro. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Reviewed-by:
Peter Wu <peter@lekensteyn.nl> Signed-off-by:
-
James A Shackleford authored
Signed-off-by:
-
James A Shackleford authored
Signed-off-by:
-
James A Shackleford authored
Signed-off-by:
-
James A Shackleford authored
Signed-off-by:
-
Rasmus Villemoes authored
This is all #if 0'ed out, and it contains some rather weird stuff (post-increment of a bool, for example). Nuke it. Signed-off-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by:
-
navin patidar authored
Signed-off-by:
navin patidar <navin.patidar@gmail.com> Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
