- 20 Apr, 2017 40 commits
-
-
Trond Myklebust authored
It is not used outside the NFSv4 module. Signed-off-by:Trond Myklebust <trond.myklebust@primarydata.com>
-
Trond Myklebust authored
They are not used outside the NFSv4 module. Signed-off-by: -
Trond Myklebust authored
encode_layoutreturn and encode_layoutcommit are now unused. Let's remove them. Signed-off-by: -
Christoph Hellwig authored
The objlayout code has been in the tree, but it's been unmaintained and no server product for it actually ever shipped. Signed-off-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
-
Trond Myklebust authored
The check in nfs4_ff_layout_prepare_ds() seems to be missing. Signed-off-by:
-
Trond Myklebust authored
If the server fails to return the attributes as part of an OPEN reply, and then reboots, we can end up hanging. The reason is that the client attempts to send a GETATTR in order to pick up the missing OPEN call, but fails to release the slot first, causing reboot recovery to deadlock. Signed-off-by:
-
Benjamin Coddington authored
Let's try to have it in a cacheline in nfs4_proc_pgio_rpc_prepare(). Signed-off-by:
Benjamin Coddington <bcodding@redhat.com> Signed-off-by:
-
Benjamin Coddington authored
Since commit 00bfa30a ("NFS: Create a common pgio_alloc and pgio_release function"), nfs_pgarray_set() has only a single caller. Let's open code it. Signed-off-by:
-
Benjamin Coddington authored
Prevent a deadlock that can occur if we wait on allocations that try to write back our pages. Signed-off-by:
-
Fred Isaman authored
Signed-off-by:
Fred Isaman <fred.isaman@gmail.com> Fixes: 0bcbf039 ("nfs: handle request add failure properly") Cc: stable@vger.kernel.org # v4.5+ Signed-off-by:
-
Benjamin Coddington authored
Commit a7d42ddb ("nfs: add mirroring support to pgio layer") moved pg_cleanup out of the path when there was non-sequental I/O that needed to be flushed. The result is that for layouts that have more than one layout segment per file, the pg_lseg is not cleared, so we can end up hitting the WARN_ON_ONCE(req_start >= seg_end) in pnfs_generic_pg_test since the pg_lseg will be pointing to that previously-flushed layout segment. Signed-off-by:
-
NeilBrown authored
When mempool_alloc() is allowed to sleep (GFP_NOIO allows sleeping) it cannot fail. So rpc_alloc_task() cannot fail, so rpc_new_task doesn't need to test for failure. Consequently rpc_new_task() cannot fail, so the callers don't need to test. Signed-off-by:
NeilBrown <neilb@suse.com> Signed-off-by:
-
NeilBrown authored
When passed GFP flags that allow sleeping (such as GFP_NOIO), mempool_alloc() will never return NULL, it will wait until memory is available. This means that we don't need to handle failure, but that we do need to ensure one thread doesn't call mempool_alloc() twice on the one pool without queuing or freeing the first allocation. If multiple threads did this during times of high memory pressure, the pool could be exhausted and a deadlock could result. pnfs_generic_alloc_ds_commits() attempts to allocate from the nfs_commit_mempool while already holding an allocation from that pool. This is not safe. So change nfs_commitdata_alloc() to take a flag that indicates whether failure is acceptable. In pnfs_generic_alloc_ds_commits(), accept failure and handle it as we currently do. Else where, do not accept failure, and do not handle it. Even when failure is acceptable, we want to succeed if possible. That means both - using an entry from the pool if there is one - waiting for direct reclaim is there isn't. We call mempool_alloc(GFP_NOWAIT) to achieve the first, then kmem_cache_alloc(GFP_NOIO|__GFP_NORETRY) to achieve the second. Each of these can fail, but together they do the best they can without blocking indefinitely. The objects returned by kmem_cache_alloc() will still be freed by mempool_free(). This is safe as mempool_alloc() uses exactly the same function to allocate objects (since the mempool was created with mempool_create_slab_pool()). The object returned by mempool_alloc() and kmem_cache_alloc() are indistinguishable so mempool_free() will handle both identically, either adding to the pool or calling kmem_cache_free(). Also, don't test for failure when allocating from nfs_wdata_mempool. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Returning errors directly even lets us remove the goto Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
If we cut out the dprintk()s, then we can return error codes directly and cut out the goto. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
This puts all the common code in a single place for the walk_client_list() functions. Signed-off-by:
-
Anna Schumaker authored
Once again, we can remove the function and compare integer values directly. Signed-off-by:
-
Anna Schumaker authored
If we cut out the dprintk()s, then we don't even need this to be a separate function. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Just remove the function and have the caller use nfs_release_request() instead. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
We always call nfs_mark_client_ready() even if nfs_create_rpc_client() returns an error, so we can rearrange nfs_init_client() to mark the client ready from a single place. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Let's cut out the goto and return any errors immedately Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Additionally, this change lets us cut out the goto by returning errors immediately. Signed-off-by:
-
Anna Schumaker authored
Removing the dprintk() lets us simplify the function by returning status codes directly, rather than using a goto. Signed-off-by:
-
Anna Schumaker authored
Removing the dprintk() lets us return the status value directly, rather than jumping to a label if an error occurs. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
