1. 16 Jun, 2017 13 commits
  2. 15 Jun, 2017 16 commits
  3. 14 Jun, 2017 11 commits
    • Rafael J. Wysocki's avatar
      Merge branch 'acpica-fixes' · 95229334
      Rafael J. Wysocki authored
      * acpica-fixes:
        ACPICA: Tables: Mechanism to handle late stage acpi_get_table() imbalance
        Revert "ACPICA: Disassembler: Enhance resource descriptor detection"
      95229334
    • Rafael J. Wysocki's avatar
      Merge branches 'pm-cpufreq', 'pm-cpuidle' and 'pm-devfreq' · f63e4f7d
      Rafael J. Wysocki authored
      * pm-cpufreq:
        cpufreq: conservative: Allow down_threshold to take values from 1 to 10
        Revert "cpufreq: schedutil: Reduce frequencies slower"
      
      * pm-cpuidle:
        cpuidle: dt: Add missing 'of_node_put()'
      
      * pm-devfreq:
        PM / devfreq: exynos-ppmu: Staticize event list
        PM / devfreq: exynos-ppmu: Handle return value of clk_prepare_enable
        PM / devfreq: exynos-nocp: Handle return value of clk_prepare_enable
      f63e4f7d
    • Jesper Dangaard Brouer's avatar
      net: don't global ICMP rate limit packets originating from loopback · 849a44de
      Jesper Dangaard Brouer authored
      Florian Weimer seems to have a glibc test-case which requires that
      loopback interfaces does not get ICMP ratelimited.  This was broken by
      commit c0303efe ("net: reduce cycles spend on ICMP replies that
      gets rate limited").
      
      An ICMP response will usually be routed back-out the same incoming
      interface.  Thus, take advantage of this and skip global ICMP
      ratelimit when the incoming device is loopback.  In the unlikely event
      that the outgoing it not loopback, due to strange routing policy
      rules, ICMP rate limiting still works via peer ratelimiting via
      icmpv4_xrlim_allow().  Thus, we should still comply with RFC1812
      (section 4.3.2.8 "Rate Limiting").
      
      This seems to fix the reproducer given by Florian.  While still
      avoiding to perform expensive and unneeded outgoing route lookup for
      rate limited packets (in the non-loopback case).
      
      Fixes: c0303efe ("net: reduce cycles spend on ICMP replies that gets rate limited")
      Reported-by: default avatarFlorian Weimer <fweimer@redhat.com>
      Reported-by: default avatar"H.J. Lu" <hjl.tools@gmail.com>
      Signed-off-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      849a44de
    • Bart Van Assche's avatar
      block: Fix a blk_exit_rl() regression · dc9edc44
      Bart Van Assche authored
      Avoid that the following complaint is reported:
      
       BUG: sleeping function called from invalid context at kernel/workqueue.c:2790
       in_atomic(): 1, irqs_disabled(): 0, pid: 41, name: rcuop/3
       1 lock held by rcuop/3/41:
        #0:  (rcu_callback){......}, at: [<ffffffff8111f9a2>] rcu_nocb_kthread+0x282/0x500
       Call Trace:
        dump_stack+0x86/0xcf
        ___might_sleep+0x174/0x260
        __might_sleep+0x4a/0x80
        flush_work+0x7e/0x2e0
        __cancel_work_timer+0x143/0x1c0
        cancel_work_sync+0x10/0x20
        blk_throtl_exit+0x25/0x60
        blkcg_exit_queue+0x35/0x40
        blk_release_queue+0x42/0x130
        kobject_put+0xa9/0x190
      
      This happens since we invoke callbacks that need to block from the
      queue release handler. Fix this by pushing the final release to
      a workqueue.
      Reported-by: default avatarRoss Zwisler <zwisler@gmail.com>
      Fixes: commit b425e504 ("block: Avoid that blk_exit_rl() triggers a use-after-free")
      Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
      Tested-by: default avatarRoss Zwisler <ross.zwisler@linux.intel.com>
      
      Updated changelog
      Signed-off-by: default avatarJens Axboe <axboe@fb.com>
      dc9edc44
    • Raju Rangoju's avatar
      rdma/cxgb4: Fix memory leaks during module exit · d4702645
      Raju Rangoju authored
      Fix memory leaks of iw_cxgb4 module in the exit path
      Signed-off-by: default avatarRaju Rangoju <rajur@chelsio.com>
      Reviewed-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
      d4702645
    • Dan Carpenter's avatar
      net/act_pedit: fix an error code · c4f65b09
      Dan Carpenter authored
      I'm reviewing static checker warnings where we do ERR_PTR(0), which is
      the same as NULL.  I'm pretty sure we intended to return ERR_PTR(-EINVAL)
      here.  Sometimes these bugs lead to a NULL dereference but I don't
      immediately see that problem here.
      
      Fixes: 71d0ed70 ("net/act_pedit: Support using offset relative to the conventional network headers")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Acked-by: default avatarAmir Vadai <amir@vadai.me>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c4f65b09
    • Feras Daoud's avatar
      IB/ipoib: Fix memory leak in create child syscall · 4542d66b
      Feras Daoud authored
      The flow of creating a new child goes through ipoib_vlan_add
      which allocates a new interface and checks the rtnl_lock.
      
      If the lock is taken, restart_syscall will be called to restart
      the system call again. In this case we are not releasing the
      already allocated interface, causing a leak.
      
      Fixes: 9baa0b03 ("IB/ipoib: Add rtnl_link_ops support")
      Signed-off-by: default avatarFeras Daoud <ferasda@mellanox.com>
      Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
      Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
      4542d66b
    • Alex Vesker's avatar
      IB/ipoib: Fix access to un-initialized napi struct · 560b7c3f
      Alex Vesker authored
      There is no need to re-enable napi since we set the initialized
      flag before calling ipoib_ib_dev_stop which will disable napi,
      disabling napi twice is harmless in case it was already disabled.
      
      One more reason for this fix is that when using IPoIB new device
      driver napi is not added to priv, this can lead to kernel panic
      when rn_ops ndo_open fails.
      
      [ 289.755840] invalid opcode: 0000 [#1] SMP
      [ 289.757111] task: ffff880036964440 ti: ffff880178ee8000 task.ti: ffff880178ee8000
      [ 289.757111] RIP: 0010:[<ffffffffa05368d6>] [<ffffffffa05368d6>] napi_enable.part.24+0x4/0x6 [ib_ipoib]
      [ 289.757111] RSP: 0018:ffff880178eeb6d8 EFLAGS: 00010246
      [ 289.757111] RAX: 0000000000000000 RBX: ffff880177a80010 RCX: 000000007fffffff
      [ 289.757111] RDX: ffffffff81d5f118 RSI: 0000000000000000 RDI: ffff880177a80010
      [ 289.757111] RBP: ffff880178eeb6d8 R08: 0000000000000082 R09: 0000000000000283
      [ 289.757111] R10: 0000000000000000 R11: 0000000000000000 R12: ffff880175a00000
      [ 289.757111] R13: ffff880177a80080 R14: 0000000000000000 R15: 0000000000000001
      [ 289.757111] FS: 00007fe2ee346880(0000) GS:ffff88017fc00000(0000) knlGS:0000000000000000
      [ 289.757111] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [ 289.757111] CR2: 00007fffca979020 CR3: 00000001792e4000 CR4: 00000000000006f0
      [ 289.757111] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      [ 289.757111] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      [ 289.757111] Stack:
      [ 289.796027] ffff880178eeb6f0 ffffffffa05251f5 ffff880177a80000 ffff880178eeb718
      [ 289.796027] ffffffffa0528505 ffff880175a00000 ffff880177a80000 0000000000000000
      [ 289.796027] ffff880178eeb748 ffffffffa051f0ab ffff880175a00000 ffffffffa0537d60
      [ 289.796027] Call Trace:
      [ 289.796027] [<ffffffffa05251f5>] napi_enable+0x25/0x30 [ib_ipoib]
      [ 289.796027] [<ffffffffa0528505>] ipoib_ib_dev_open+0x175/0x190 [ib_ipoib]
      [ 289.796027] [<ffffffffa051f0ab>] ipoib_open+0x4b/0x160 [ib_ipoib]
      [ 289.796027] [<ffffffff814fe33f>] _dev_open+0xbf/0x130
      [ 289.796027] [<ffffffff814fe62d>] __dev_change_flags+0x9d/0x170
      [ 289.796027] [<ffffffff814fe729>] dev_change_flags+0x29/0x60
      [ 289.796027] [<ffffffff8150caf7>] do_setlink+0x397/0xa40
      
      Fixes: cd565b4b ('IB/IPoIB: Support acceleration options callbacks')
      Signed-off-by: default avatarAlex Vesker <valex@mellanox.com>
      Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
      Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
      560b7c3f
    • Alex Vesker's avatar
      IB/ipoib: Delete napi in device uninit default · b53d4566
      Alex Vesker authored
      This patch mekas init_default and uninit_default symmetric
      with a call to delete napi. Additionally, the uninit_default
      gained delete napi call in case of init_default fails.
      
      Fixes: 515ed4f3 ('IB/IPoIB: Separate control and data related initializations')
      Signed-off-by: default avatarAlex Vesker <valex@mellanox.com>
      Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
      Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
      b53d4566
    • Alex Vesker's avatar
      IB/ipoib: Limit call to free rdma_netdev for capable devices · 022d038a
      Alex Vesker authored
      Limit calls to free_rdma_netdev() for capable devices only.
      
      Fixes: cd565b4b ('IB/IPoIB: Support acceleration options callbacks')
      Signed-off-by: default avatarAlex Vesker <valex@mellanox.com>
      Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
      Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
      022d038a
    • Alex Vesker's avatar
      IB/ipoib: Fix memory leaks for child interfaces priv · ab156afd
      Alex Vesker authored
      There is a need to free priv explicitly and not just to release
      the device, child priv is freed explicitly on remove flow and this
      patch also includes priv free on error flow in P_key creation
      and also in add_port.
      
      Fixes: cd565b4b ('IB/IPoIB: Support acceleration options callbacks')
      Signed-off-by: default avatarAlex Vesker <valex@mellanox.com>
      Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
      Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
      ab156afd