1. 14 Dec, 2015 3 commits
    • Tadeusz Struk's avatar
      crypto: qat - uint8_t is not large enough for accel_id · 81b312f1
      Tadeusz Struk authored
      accel_id has to be large enough to hold ADF_MAX_DEVICES + 1
      (which is > 1025) so uint8_t is too small.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarTadeusz Struk <tadeusz.struk@intel.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      81b312f1
    • Sam Protsenko's avatar
      crypto: omap-des - Fix "schedule while atomic" bug · 50eca256
      Sam Protsenko authored
      When using DES module the next bug appears:
      
          BUG: scheduling while atomic: kworker/0:1/63/0x00000102
      
      With backtrace as follows:
      
      <<<<<<<<<<<<<<<<<<<<<<<<<<<<<< cut here >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
      
      [<c0012294>] (dump_backtrace) from [<c00124ac>] (show_stack+0x18/0x1c)
      [<c0012494>] (show_stack) from [<c0752554>] (dump_stack+0x84/0xc4)
      [<c07524d0>] (dump_stack) from [<c0750218>] (__schedule_bug+0x54/0x64)
      [<c07501c4>] (__schedule_bug) from [<c07548a4>] (__schedule+0x4ac/0x53c)
      [<c07543f8>] (__schedule) from [<c075496c>] (schedule+0x38/0x88)
      [<c0754934>] (schedule) from [<c03c3984>] (rpm_resume+0x158/0x59c)
      [<c03c382c>] (rpm_resume) from [<c03c3e1c>] (__pm_runtime_resume+0x54/0x6c)
      [<c03c3dc8>] (__pm_runtime_resume) from [<c0568ff8>] (omap_des_handle_queue+0x154/0x7bc)
      [<c0568ea4>] (omap_des_handle_queue) from [<c05696b8>] (omap_des_crypt+0x58/0xbc)
      [<c0569660>] (omap_des_crypt) from [<c0569730>] (omap_des_cbc_decrypt+0x14/0x18)
      [<c056971c>] (omap_des_cbc_decrypt) from [<c0297534>] (authenc_verify_ahash_done+0xe0/0xe8)
      [<c0297454>] (authenc_verify_ahash_done) from [<c056a330>] (omap_sham_finish_req+0x58/0xa8)
      [<c056a2d8>] (omap_sham_finish_req) from [<c056b714>] (omap_sham_done_task+0x1c0/0x1e0)
      [<c056b554>] (omap_sham_done_task) from [<c003e53c>] (tasklet_action+0x80/0x118)
      [<c003e4bc>] (tasklet_action) from [<c003e740>] (__do_softirq+0x11c/0x260)
      [<c003e624>] (__do_softirq) from [<c003eb64>] (irq_exit+0xc0/0xfc)
      [<c003eaa4>] (irq_exit) from [<c000f1c4>] (handle_IRQ+0x4c/0x98)
      [<c000f178>] (handle_IRQ) from [<c0008568>] (gic_handle_irq+0x34/0x64)
      [<c0008534>] (gic_handle_irq) from [<c0758540>] (__irq_svc+0x40/0x70)
      
      <<<<<<<<<<<<<<<<<<<<<<<<<<<<<< cut here >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
      
      Insight was seen in drivers/crypto/omap-sham.c driver.
      All credits for this patch go to Grygorii Strashko.
      Signed-off-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      50eca256
    • Zeng Xin's avatar
      crypto: qat - enable VF irq after guest exits ungracefully · 40c18a59
      Zeng Xin authored
      The VF bundle interrupt is not triggered any more in
      the case when guest is shut down with sample app running.
      Need to clear the flag interrupt bit when restarting to fix
      this irrecoverable state.
      Signed-off-by: default avatarZeng Xin <xin.zeng@intel.com>
      Signed-off-by: default avatarTadeusz Struk <tadeusz.struk@intel.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      40c18a59
  2. 11 Dec, 2015 4 commits
  3. 10 Dec, 2015 3 commits
    • Arnd Bergmann's avatar
      crypto: sahara - fix debug output for 64-bit dma_addr_t · d4b98f20
      Arnd Bergmann authored
      The sahara_dump_descriptors and sahara_dump_links functions attempt
      to print a dma_addr_t value with a 0x%08x format string, which
      produces a warning when dma_addr_t is 64-bit wide:
      
      drivers/crypto/sahara.c:419:120: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
      
      This changes the code to use the %pad format string that is meant
      for dma_addr_t, which avoids the warning and gives us the correct
      output in all configurations.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      d4b98f20
    • Arnd Bergmann's avatar
      crypto: sahara - fix 64-bit dma_addr_t compilation · 75d3f811
      Arnd Bergmann authored
      The sahara hardware uses DMA descriptors with 32-bit addresses, but
      dma_addr_t is variable size depending on whether we want to support
      any devices that use 64-bit DMA addresses in hardware.
      This means that the definition of the DMA descriptor structure is wrong,
      and we helpfully get a compiler warning about them too:
      
      drivers/crypto/sahara.c:423:372: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
      
      This changes the definition of the sahara_hw_desc and sahara_hw_link
      structures to only contain fixed-length members, which is required
      to make the driver work on ARM LPAE mode, and avoids most of the
      gcc warnings we get.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      75d3f811
    • Julia Lawall's avatar
      crypto: drbg - constify drbg_state_ops structures · e4bc02ac
      Julia Lawall authored
      The drbg_state_ops structures are never modified, so declare them as const.
      
      Done with the help of Coccinelle.
      Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      e4bc02ac
  4. 09 Dec, 2015 11 commits
  5. 04 Dec, 2015 8 commits
  6. 27 Nov, 2015 3 commits
  7. 24 Nov, 2015 3 commits
  8. 23 Nov, 2015 5 commits