1. 09 Apr, 2010 1 commit
  2. 08 Apr, 2010 1 commit
  3. 06 Apr, 2010 3 commits
  4. 02 Apr, 2010 3 commits
    • Zhu Yi's avatar
      iwlwifi: avoid Tx queue memory allocation in interface down · de0f60ea
      Zhu Yi authored
      We used to free all the Tx queues memory when interface is brought
      down and reallocate them again in interface up. This requires
      order-4 allocation for txq->cmd[]. In situations like s2ram, this
      usually leads to allocation failure in the memory subsystem. The
      patch fixed this problem by allocating the Tx queues memory only at
      the first time. Later iwl_down/iwl_up only initialize but don't
      free and reallocate them. The memory is freed at the device removal
      time. BTW, we have already done this for the Rx queue.
      
      This fixed bug https://bugzilla.kernel.org/show_bug.cgi?id=15551Signed-off-by: default avatarZhu Yi <yi.zhu@intel.com>
      Acked-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      de0f60ea
    • Shanyu Zhao's avatar
      iwlwifi: use consistent table for tx data collect · 04f2dec1
      Shanyu Zhao authored
      When collecting tx data for non-aggregation packets in rate scaling, if
      the tx data matches "other table", it still uses current table to update
      the stats and calculate average throughput in function rs_collect_tx_data().
      This can mess up the rate scaling data structure and cause a kernel panic
      in a BUG_ON statement in rs_rate_scale_perform().
      
      To fix this bug, we pass table pointer instead of window pointer (pointed
      to by table pointer) to function rs_collect_tx_data() so that the table
      being used is consistent.
      Signed-off-by: default avatarShanyu Zhao <shanyu.zhao@intel.com>
      Signed-off-by: default avatarHenry Zhang <hongx.c.zhang@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      04f2dec1
    • Zhu Yi's avatar
      iwlwifi: fix DMA allocation warnings · dd487449
      Zhu Yi authored
      Below warning is triggered sometimes at module removal time when
      CONFIG_DMA_API_DEBUG is enabled. This should be caused by we didn't
      unmap pending commands (enqueued, but no complete notification
      received) for the Tx command queue.
      
      [ 1583.107469] ------------[ cut here ]------------
      [ 1583.107539] WARNING: at lib/dma-debug.c:688
      dma_debug_device_change+0x13c/0x180()
      [ 1583.107617] Hardware name: ...
      [ 1583.107664] pci 0000:04:00.0: DMA-API: device driver has pending DMA
      allocations while released from device [count=1]
      [ 1583.107713] Modules linked in: ...
      [ 1583.111661] Pid: 16970, comm: modprobe Tainted: G        W
      2.6.34-rc1-wl #33
      [ 1583.111727] Call Trace:
      [ 1583.111779]  [<c02a281c>] ? dma_debug_device_change+0x13c/0x180
      [ 1583.111833]  [<c02a281c>] ? dma_debug_device_change+0x13c/0x180
      [ 1583.111908]  [<c0138e11>] warn_slowpath_common+0x71/0xd0
      [ 1583.111963]  [<c02a281c>] ? dma_debug_device_change+0x13c/0x180
      [ 1583.112016]  [<c0138ebb>] warn_slowpath_fmt+0x2b/0x30
      [ 1583.112086]  [<c02a281c>] dma_debug_device_change+0x13c/0x180
      [ 1583.112142]  [<c03e6c33>] notifier_call_chain+0x53/0x90
      [ 1583.112198]  [<c03e1ebe>] ? down_read+0x6e/0x90
      [ 1583.112271]  [<c015b229>] __blocking_notifier_call_chain+0x49/0x70
      [ 1583.112326]  [<c015b26f>] blocking_notifier_call_chain+0x1f/0x30
      [ 1583.112380]  [<c031931c>] __device_release_driver+0x8c/0xa0
      [ 1583.112451]  [<c03193bf>] driver_detach+0x8f/0xa0
      [ 1583.112538]  [<c0318382>] bus_remove_driver+0x82/0x100
      [ 1583.112595]  [<c0319ad9>] driver_unregister+0x49/0x80
      [ 1583.112671]  [<c024feb2>] ? sysfs_remove_file+0x12/0x20
      [ 1583.112727]  [<c02aa292>] pci_unregister_driver+0x32/0x80
      [ 1583.112791]  [<fc13a3c1>] iwl_exit+0x12/0x19 [iwlagn]
      [ 1583.112848]  [<c017940a>] sys_delete_module+0x15a/0x210
      [ 1583.112870]  [<c015a5db>] ? up_read+0x1b/0x30
      [ 1583.112893]  [<c029600c>] ? trace_hardirqs_off_thunk+0xc/0x10
      [ 1583.112924]  [<c0295ffc>] ? trace_hardirqs_on_thunk+0xc/0x10
      [ 1583.112947]  [<c03e6a1f>] ? do_page_fault+0x1ff/0x3c0
      [ 1583.112978]  [<c03e36f6>] ? restore_all_notrace+0x0/0x18
      [ 1583.113002]  [<c016aa70>] ? trace_hardirqs_on_caller+0x20/0x190
      [ 1583.113025]  [<c0102d58>] sysenter_do_call+0x12/0x38
      [ 1583.113054] ---[ end trace fc23e059cc4c2ced ]---
      Signed-off-by: default avatarZhu Yi <yi.zhu@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      dd487449
  5. 30 Mar, 2010 15 commits
  6. 16 Mar, 2010 3 commits
    • Adel Gadllah's avatar
      iwlwifi: Silence tfds_in_queue message · c8406ea8
      Adel Gadllah authored
      Commit a239a8b4 introduced a
      noisy message, that fills up the log very fast.
      
      The error seems not to be fatal (the connection is stable and
      performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.
      Signed-off-by: default avatarAdel Gadllah <adel.gadllah@gmail.com>
      Cc: stable@kernel.org
      Acked-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      c8406ea8
    • Felix Fietkau's avatar
      ath9k: fix BUG_ON triggered by PAE frames · 4fdec031
      Felix Fietkau authored
      When I initially stumbled upon sequence number problems with PAE frames
      in ath9k, I submitted a patch to remove all special cases for PAE
      frames and let them go through the normal transmit path.
      Out of concern about crypto incompatibility issues, this change was
      merged instead:
      
      commit 6c8afef5
      Author: Sujith <Sujith.Manoharan@atheros.com>
      Date:   Tue Feb 9 10:07:00 2010 +0530
      
          ath9k: Fix sequence numbers for PAE frames
      
      After a lot of testing, I'm able to reliably trigger a driver crash on
      rekeying with current versions with this change in place.
      It seems that the driver does not support sending out regular MPDUs with
      the same TID while an A-MPDU session is active.
      This leads to duplicate entries in the TID Tx buffer, which hits the
      following BUG_ON in ath_tx_addto_baw():
      
          index  = ATH_BA_INDEX(tid->seq_start, bf->bf_seqno);
          cindex = (tid->baw_head + index) & (ATH_TID_MAX_BUFS - 1);
      
          BUG_ON(tid->tx_buf[cindex] != NULL);
      
      I believe until we actually have a reproducible case of an
      incompatibility with another AP using no PAE special cases, we should
      simply get rid of this mess.
      
      This patch completely fixes my crash issues in STA mode and makes it
      stay connected without throughput drops or connectivity issues even
      when the AP is configured to a very short group rekey interval.
      Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
      Cc: stable@kernel.org
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      4fdec031
    • Grazvydas Ignotas's avatar
      wl1251: fix potential crash · 3f60ebc9
      Grazvydas Ignotas authored
      In case debugfs does not init for some reason (or is disabled
      on older kernels) driver does not allocate stats.fw_stats
      structure, but tries to clear it later and trips on a NULL
      pointer:
      
      Unable to handle kernel NULL pointer dereference at virtual address
      00000000
      PC is at __memzero+0x24/0x80
      Backtrace:
      [<bf0ddb88>] (wl1251_debugfs_reset+0x0/0x30 [wl1251])
      [<bf0d6a2c>] (wl1251_op_stop+0x0/0x12c [wl1251])
      [<bf0bc228>] (ieee80211_stop_device+0x0/0x74 [mac80211])
      [<bf0b0d10>] (ieee80211_stop+0x0/0x4ac [mac80211])
      [<c02deeac>] (dev_close+0x0/0xb4)
      [<c02deac0>] (dev_change_flags+0x0/0x184)
      [<c031f478>] (devinet_ioctl+0x0/0x704)
      [<c0320720>] (inet_ioctl+0x0/0x100)
      
      Add a NULL pointer check to fix this.
      Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
      Acked-by: default avatarKalle Valo <kalle.valo@iki.fi>
      Cc: stable@kernel.org
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      3f60ebc9
  7. 10 Mar, 2010 13 commits
  8. 08 Mar, 2010 1 commit