1. 17 Mar, 2020 3 commits
  2. 16 Mar, 2020 4 commits
  3. 15 Mar, 2020 1 commit
  4. 14 Mar, 2020 1 commit
  5. 13 Mar, 2020 8 commits
  6. 12 Mar, 2020 5 commits
  7. 11 Mar, 2020 16 commits
  8. 10 Mar, 2020 2 commits
    • Chris Wilson's avatar
      drm/i915/execlists: Mark up data-races in virtual engines · 3a55dc89
      Chris Wilson authored
      The virtual engine passes tokens back and forth to its backing physical
      engines.
      
      [   57.372993] BUG: KCSAN: data-race in execlists_dequeue [i915] / virtual_submission_tasklet [i915]
      [   57.373012]
      [   57.373023] write to 0xffff8881f47324c0 of 4 bytes by interrupt on cpu 2:
      [   57.373241]  execlists_dequeue+0x6fa/0x2150 [i915]
      [   57.373458]  __execlists_submission_tasklet+0x48/0x60 [i915]
      [   57.373677]  execlists_submission_tasklet+0xd3/0x170 [i915]
      [   57.373694]  tasklet_action_common.isra.0+0x42/0xa0
      [   57.373709]  __do_softirq+0xd7/0x2cd
      [   57.373723]  irq_exit+0xbe/0xe0
      [   57.373735]  do_IRQ+0x51/0x100
      [   57.373748]  ret_from_intr+0x0/0x1c
      [   57.373963]  engine_retire+0x89/0xe0 [i915]
      [   57.373977]  process_one_work+0x3b1/0x690
      [   57.373990]  worker_thread+0x80/0x670
      [   57.374004]  kthread+0x19a/0x1e0
      [   57.374017]  ret_from_fork+0x1f/0x30
      [   57.374027]
      [   57.374038] read to 0xffff8881f47324c0 of 4 bytes by interrupt on cpu 3:
      [   57.374256]  virtual_submission_tasklet+0x27/0x5a0 [i915]
      [   57.374273]  tasklet_action_common.isra.0+0x42/0xa0
      [   57.374288]  __do_softirq+0xd7/0x2cd
      [   57.374302]  run_ksoftirqd+0x15/0x20
      [   57.374315]  smpboot_thread_fn+0x1ab/0x300
      [   57.374329]  kthread+0x19a/0x1e0
      [   57.374342]  ret_from_fork+0x1f/0x30
      Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200310141320.24149-3-chris@chris-wilson.co.uk
      3a55dc89
    • Chris Wilson's avatar
      drm/i915: Mark up racy read of active rq->engine · 326611dd
      Chris Wilson authored
      As a virtual engine may change the rq->engine to point to the active
      request in flight, we need to warn the compiler that an active request's
      engine is volatile.
      
      [   95.017686] write (marked) to 0xffff8881e8386b10 of 8 bytes by interrupt on cpu 2:
      [   95.018123]  execlists_dequeue+0x762/0x2150 [i915]
      [   95.018539]  __execlists_submission_tasklet+0x48/0x60 [i915]
      [   95.018955]  execlists_submission_tasklet+0xd3/0x170 [i915]
      [   95.018986]  tasklet_action_common.isra.0+0x42/0xa0
      [   95.019016]  __do_softirq+0xd7/0x2cd
      [   95.019043]  irq_exit+0xbe/0xe0
      [   95.019068]  irq_work_interrupt+0xf/0x20
      [   95.019491]  i915_request_retire+0x2c5/0x670 [i915]
      [   95.019937]  retire_requests+0xa1/0xf0 [i915]
      [   95.020348]  engine_retire+0xa1/0xe0 [i915]
      [   95.020376]  process_one_work+0x3b1/0x690
      [   95.020403]  worker_thread+0x80/0x670
      [   95.020429]  kthread+0x19a/0x1e0
      [   95.020454]  ret_from_fork+0x1f/0x30
      [   95.020476]
      [   95.020498] read to 0xffff8881e8386b10 of 8 bytes by task 8909 on cpu 3:
      [   95.020918]  __i915_request_commit+0x177/0x220 [i915]
      [   95.021329]  i915_gem_do_execbuffer+0x38c4/0x4e50 [i915]
      [   95.021750]  i915_gem_execbuffer2_ioctl+0x2c3/0x580 [i915]
      [   95.021784]  drm_ioctl_kernel+0xe4/0x120
      [   95.021809]  drm_ioctl+0x297/0x4c7
      [   95.021832]  ksys_ioctl+0x89/0xb0
      [   95.021865]  __x64_sys_ioctl+0x42/0x60
      [   95.021901]  do_syscall_64+0x6e/0x2c0
      [   95.021927]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
      Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200310142403.5953-1-chris@chris-wilson.co.uk
      326611dd