1. 29 Nov, 2016 4 commits
  2. 25 Nov, 2016 7 commits
    • Arnd Bergmann's avatar
      [media] DaVinci-VPFE-Capture: fix error handling · d3d83ee2
      Arnd Bergmann authored
      A recent cleanup had the right idea to remove the initialization
      of the error variable, but missed the actual benefit of that,
      which is that we get warnings if there is a bug in it. Now
      we get a warning about a bug that was introduced by this cleanup:
      
      drivers/media/platform/davinci/vpfe_capture.c: In function 'vpfe_probe':
      drivers/media/platform/davinci/vpfe_capture.c:1992:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      
      This adds the missing initialization that the warning is about,
      and another one that was preexisting and that we did not get
      a warning for. That second bug has existed since the driver
      was first added.
      
      Fixes: efb74461 ("[media] DaVinci-VPFE-Capture: Delete an unnecessary variable initialisation in vpfe_probe()")
      Fixes: 7da8a6cb ("V4L/DVB (12248): v4l: vpfe capture bridge driver for DM355 and DM6446")
      
      [mchehab@s-opensource.com: fix a merge conflict]
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d3d83ee2
    • Mauro Carvalho Chehab's avatar
      [media] cx88: make checkpatch.pl happy · 399426ca
      Mauro Carvalho Chehab authored
      Usually, I don't like fixing coding style issues on non-staging
      drivers, as it could be a mess pretty easy, and could become like
      a snow ball. That's the case of recent changes on two changesets:
      they disalign some statements. Yet, a care a lot with cx88 driver,
      as it was the first driver I touched at the Kernel, and I've been
      maintaining it since 2005. So, several of the coding style issues
      were due to my code.
      
      Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
      fixed several other issues, did some function alinments, but broke
      other alinments.
      
      So, I had to manually apply another round of manual fixes to make
      sure that everything is ok, and to make checkpatch happy with
      this patch.
      
      With this patch, checkpatch.pl is now happy when called with:
      	./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
      
      Also, the 80-cols violations that made sense were fixed.
      
      Checkpatch would be happier if we convert it to use dev_foo(),
      but this is a more complex change.
      
      NOTE: there are some places with msleep(1). As this driver was
      written at the time that the default was to sleep at least 10ms
      on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
      usleep_range(10000, 20000), with should be safe to avoid breakages.
      
      Fixes: 65bc2fe8 ("[media] cx88: convert it to use pr_foo() macros")
      Fixes: 7b61ba8f ("[media] cx88: make checkpatch happier")
      Suggested-by: default avatarAndrey Utkin <andrey_utkin@fastmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      Reviewed-by: default avatarAndrey Utkin <andrey_utkin@fastmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      399426ca
    • Arnd Bergmann's avatar
      [media] v4l: rcar_fdp1: add FCP dependency · 1d389714
      Arnd Bergmann authored
      Commit 4710b752 ("[media] v4l: Add Renesas R-Car FDP1 Driver") in the
      v4l-dvb tree adds CONFIG_VIDEO_RENESAS_FDP1.
      
      It calls into the FCP driver, but when there is no dependency, FCP might
      be a module while FDP1 is built-in.
      
      We have the same logic in VIDEO_RENESAS_VSP1, which also depends on
      FCP not being a module when it is built-in itself.
      
      drivers/media/platform/rcar_fdp1.o: In function `fdp1_pm_runtime_resume':
      rcar_fdp1.c:(.text.fdp1_pm_runtime_resume+0x78): undefined reference to `rcar_fcp_enable'
      drivers/media/platform/rcar_fdp1.o: In function `fdp1_pm_runtime_suspend':
      rcar_fdp1.c:(.text.fdp1_pm_runtime_suspend+0x14): undefined reference to `rcar_fcp_disable'
      drivers/media/platform/rcar_fdp1.o: In function `fdp1_probe':
      rcar_fdp1.c:(.text.fdp1_probe+0x15c): undefined reference to `rcar_fcp_get'
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      1d389714
    • Arnd Bergmann's avatar
      [media] v4l: rcar_fdp1: mark PM functions as __maybe_unused · fa4a2fd1
      Arnd Bergmann authored
      The new driver produces a warning when CONFIG_PM is disabled:
      
      platform/rcar_fdp1.c:2408:12: error: 'fdp1_pm_runtime_resume' defined but not used [-Werror=unused-function]
      platform/rcar_fdp1.c:2399:12: error: 'fdp1_pm_runtime_suspend' defined but not used [-Werror=unused-function]
      
      This marks the two functions as __maybe_unused.
      
      Fixes: 4710b752 ("[media] v4l: Add Renesas R-Car FDP1 Driver")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      fa4a2fd1
    • Shuah Khan's avatar
      [media] media: remove obsolete Media Device Managed resource interfaces · 8c2ebcf1
      Shuah Khan authored
      Remove obsolete media_device_get_devres(), media_device_find_devres(),
      and media_device_release_devres() interfaces. These interfaces are now
      obsolete.
      Signed-off-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      8c2ebcf1
    • Mauro Carvalho Chehab's avatar
      [media] dvb-net: split the logic at dvb_net_ule() into other functions · 8b0041db
      Mauro Carvalho Chehab authored
      This function is too big and too complex, making really hard
      to understand what's there.
      
      Split it into sub-routines, in order to make it easier to be
      understood, and to allow gcc to better parse it.
      
      As a bonus, it gets rid of a goto in the middle of a routine.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      8b0041db
    • Mauro Carvalho Chehab's avatar
      [media] dvb_net: prepare to split a very complex function · efb9ab67
      Mauro Carvalho Chehab authored
      The dvb_net code has a really complex function, meant to handle
      DVB network packages: it is long, has several loops and ifs
      inside, and even cause warnings with gcc5.
      
      Prepare it to be split into smaller functions by storing all
      arguments and internal vars inside a struct.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      efb9ab67
  3. 23 Nov, 2016 21 commits
  4. 22 Nov, 2016 8 commits