- 05 Dec, 2023 33 commits
-
-
Dmitry Baryshkov authored
Use devm_kzalloc to create HW block structure. This allows us to remove corresponding kfree and drop all dpu_hw_*_destroy() functions as well as dpu_rm_destroy(), which becomes empty afterwards. Reviewed-by:
Jessica Zhang <quic_jesszhan@quicinc.com> Signed-off-by:
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/570041/ Link: https://lore.kernel.org/r/20231201211845.1026967-7-dmitry.baryshkov@linaro.org
-
Dmitry Baryshkov authored
Use devm_kzalloc to create MDP TOP structure. This allows us to remove corresponding kfree and drop dpu_hw_mdp_destroy() function. Reviewed-by:
-
Dmitry Baryshkov authored
Use devm_kzalloc to create VBIF data structure. This allows us to remove corresponding kfree and drop dpu_hw_vbif_destroy() function. Reviewed-by:
-
Dmitry Baryshkov authored
Use devm_kzalloc to create interrupts data structure. This allows us to remove corresponding kfree and drop dpu_hw_intr_destroy() function. Reviewed-by:
-
Dmitry Baryshkov authored
Using IS_ERR_OR_NULL() together with PTR_ERR() is a typical mistake. If the value is NULL, then the function will return 0 instead of a proper return code. Replace IS_ERR_OR_NULL() with IS_ERR() in the dpu_hw_intr_init() error check. Reviewed-by:
-
Dmitry Baryshkov authored
It was noticed that dpu_kms_hw_init()'s error path contains several labels which point to the same code path. Replace all of them with a single label. Suggested-by:
Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by:
-
Dmitry Baryshkov authored
Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there's another path that needs to be handled to ensure MDSS functions properly, namely the "reg bus", a.k.a the CPU-MDSS interconnect. Gating that path may have a variety of effects, from none to otherwise inexplicable DSI timeouts. Provide a way for MDSS driver to vote on this bus. A note regarding vote values. Newer platforms have corresponding bandwidth values in the vendor DT files. For the older platforms there was a static vote in the mdss_mdp and rotator drivers. I choose to be conservative here and choose this value as a default. Co-developed-by:
Abhinav Kumar <quic_abhinavk@quicinc.com> Patchwork: https://patchwork.freedesktop.org/patch/570164/ Link: https://lore.kernel.org/r/20231202224247.1282567-5-dmitry.baryshkov@linaro.org
-
Dmitry Baryshkov authored
There are just two places where we set the bandwidth: in the resume and in the suspend paths. Drop the wrapping function msm_mdss_icc_request_bw() and call icc_set_bw() directly. Signed-off-by:
-
Konrad Dybcio authored
The DPU1 driver needs to handle all MDPn<->DDR paths, as well as CPU<->SLAVE_DISPLAY_CFG. The former ones share how their values are calculated, but the latter one has static predefines spanning all SoCs. In preparation for supporting the CPU<->SLAVE_DISPLAY_CFG path, rename the path-related struct members to include "mdp_". Signed-off-by:
-
Dmitry Baryshkov authored
Stop using hand-written reset function for ICC release, use devm_of_icc_get() instead. Signed-off-by:
-
Neil Armstrong authored
Add DSI Controller version 2.8.0 support for the SM8650 platform. Reviewed-by:
Neil Armstrong <neil.armstrong@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/564977/ Link: https://lore.kernel.org/r/20231030-topic-sm8650-upstream-mdss-v2-8-43f1887c82b8@linaro.orgSigned-off-by:
-
Neil Armstrong authored
Add DSI PHY support for the SM8650 platform. Reviewed-by:
-
Neil Armstrong authored
Add Mobile Display Subsystem (MDSS) support for the SM8650 platform. Reviewed-by:
-
Neil Armstrong authored
Add DPU version 10.0 support for the SM8650 platform. Signed-off-by:
-
Neil Armstrong authored
Document the Mobile Display Subsystem (MDSS) on the SM8650 Platform. Reviewed-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by:
-
Neil Armstrong authored
Document the DPU Display Controller on the SM8650 Platform. Reviewed-by:
-
Neil Armstrong authored
Document the DSI Controller on the SM8650 Platform. Reviewed-by:
-
Neil Armstrong authored
Document the DSI PHY on the SM8650 Platform. Reviewed-by:
-
Richard Acayan authored
The Snapdragon 670 uses similar clocks (with one frequency added) to the Snapdragon 845 but reports DPU revision 4.1. Add support for this DPU with configuration from the Pixel 3a downstream kernel. Since revision 4.0 is SDM845, reuse some configuration from its catalog entry. Link: https://android.googlesource.com/kernel/msm/+/368478b0ae76566927a2769a2bf24dfe7f38bb78/arch/arm64/boot/dts/qcom/sdm670-sde.dtsiSigned-off-by:
Richard Acayan <mailingradian@gmail.com> Reviewed-by:
-
Richard Acayan authored
Add support for the MDSS block on the SDM670 platform. Reviewed-by:
-
Richard Acayan authored
Add documentation for the SDM670 display subsystem, adapted from the SDM845 and SM6125 documentation. Reviewed-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Richard Acayan authored
The SDM670 display controller has the same requirements as the SDM845 display controller, despite having distinct properties as described in the catalog. Add the compatible for SDM670 to the SDM845 controller. Acked-by:
-
Richard Acayan authored
The SDM670 has DSI ports. Add the compatible for the controller. Acked-by:
-
Dmitry Baryshkov authored
After folding QSEED3LITE and QSEED4 feature bits into QSEED3_COMPATIBLE several VIG feature masks became equal. Drop these duplicates. Signed-off-by:
-
Dmitry Baryshkov authored
Three different features, DPU_SSPP_SCALER_QSEED3, QSEED3LITE and QSEED4 are all related to different versions of the same HW scaling block. Corresponding driver parts use scaler_blk.version to identify the correct way to program the hardware. In order to simplify the driver codepath, merge these three feature bits into QSEED3_COMPATIBLE bin. Signed-off-by:
-
Dmitry Baryshkov authored
In order to check whether the SSPP block has scaler and CSC subblocks the funcion dpu_plane_atomic_check_pipe() uses macros which enumerate all possible scaler and CSC features. Replace those checks with the scaler and CSC subblock length checks in order to be able to drop those two macros. Suggested-by:
-
Dmitry Baryshkov authored
As the subblock info is now mostly gone, inline and drop the macro DPU_HW_SUBBLK_INFO. Reviewed-by:
-
Dmitry Baryshkov authored
As we have dropped the variadic parts of SSPP sub-blocks declarations, deduplicate them now, reducing memory cruft. Reviewed-by:
-
Dmitry Baryshkov authored
In preparation to deduplicating SSPP subblocks, drop the (unused) `smart_dma_priority' field from struct dpu_sspp_sub_blks. If it is needed later (e.g. for SmartDMA v1), it should be added to the SSPP declarations themselves. Reviewed-by:
-
Dmitry Baryshkov authored
The field `id' is not used for subblocks. The handling code usually knows, which sub-block it is now looking at. Drop the field completely. Reviewed-by:
-
Marijn Suijten authored
The SSPP scaler subblk is responsible for reporting its version (via the .id field, feature bits on the parent SSPP block, and since recently also from reading a register to supersede a read-but-unset version field in the catalog), leaving this global qseed_type field logically unused. Remove this dead code to lighten the catalog and bringup-overhead. Signed-off-by:
Marijn Suijten <marijn.suijten@somainline.org> Reviewed-by:
-
Marijn Suijten authored
This pointer callback is never used and should be removed. Signed-off-by:
-
Dmitry Baryshkov authored
The function _dpu_hw_sspp_setup_scaler3() passes and dpu_hw_setup_scaler3() uses scaler_blk.version to determine in which way the scaler (QSEED3) block should be programmed. However up to now we were not setting this field. Set it now, splitting the vig_sblk data which has different version fields. Reported-by:
-
- 04 Dec, 2023 1 commit
-
-
Harshit Mogalapalli authored
When pm_runtime_resume_and_get() fails, unlock before returning. Fixes: 5814b8bf ("drm/msm/dp: incorporate pm_runtime framework into DP driver") Signed-off-by:
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Reviewed-by:
-
- 03 Dec, 2023 6 commits
-
-
Konrad Dybcio authored
Some devices power the DSI PHY/PLL through a power rail that we model as a GENPD. Enable runtime PM to make it suspendable. Signed-off-by:
-
Konrad Dybcio authored
This helper has been introduced to avoid programmer errors (missing _put calls leading to dangling refcnt) when using pm_runtime_get, use it. While at it, start checking the return value. Signed-off-by:
-
Bjorn Andersson authored
Similar to SC8280XP, the misconfigured SAFE logic causes rather significant delays in __arm_smmu_tlb_sync(), resulting in poor performance for things such as USB. Introduce appropriate SAFE values for SC8180X to correct this. Fixes: f3af2d6e ("drm/msm/dpu: Add SC8180x to hw catalog") Signed-off-by:
Bjorn Andersson <quic_bjorande@quicinc.com> Reported-by:
Anton Bambura <jenneron@postmarketos.org> Reviewed-by:
-
Paloma Arellano authored
Trigger a devcoredump to dump dpu registers and capture the drm atomic state when the frame_done_timer timeouts. v2: Optimize the format in which frame_done_timeout_cnt is incremented v3: Describe parameter frame_done_timeout_cnt in dpu_encoder_virt Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202312010225.2OJWLKmA-lkp@intel.com/Reviewed-by:
Paloma Arellano <quic_parellan@quicinc.com> Reviewed-by:
-
Rob Clark authored
The UBWC settings need to match between the display and GPU. When we updated the GPU settings, we forgot to make the corresponding update on the display side. Reported-by:
Steev Klimaszewski <steev@kali.org> Fixes: 07e6de73 ("drm/msm/a690: Fix reg values for a690") Signed-off-by:
Rob Clark <robdclark@chromium.org> Tested-by:
-
Kuogee Hsieh authored
Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe deferral cases can be handled effectively. wait_for_hpd_asserted callback is added during drm_dp_aux_init() to ensure eDP's HPD is up before proceeding eDP population. Changes in v5: -- inline dp_display_auxbus_population() and delete it Changes in v4: -- delete duplicate initialize code to dp_aux before drm_dp_aux_register() -- delete of_get_child_by_name(dev->of_node, "aux-bus") and inline the function -- not initialize rc = 0 Changes in v3: -- add done_probing callback into devm_of_dp_aux_populate_bus() Signed-off-by:
Kuogee Hsieh <quic_khsieh@quicinc.com> Reviewed-by:
-
