- 04 Oct, 2011 32 commits
-
-
Mark Einon authored
In several places in the code, the pm_csr register is read and the PHY_SW_COMA bit checked. Move this check into its own small function to make the code more readable. Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Mark Einon authored
Removing this as I'm pretty sure its not true, and alloc_etherdev isn't provided by this driver anyway. Alternatively, its a badly written comment and I don't understand it. This drivers use of alloc_etherdev() is within keeping with other net devices, so I'm happy. Signed-off-by:
-
David Kilroy authored
The message is in the wrong place. We definitely don't want to return at this point, as we may need to turn off encryption. Reported-by:
Henk de Groot <pe1dnn@amsat.org> Signed-off-by:
David Kiroy <kilroyd@googlemail.com> Signed-off-by:
-
David Kilroy authored
The function no longer compiles, so we just remove it. Reported-by:
-
David Kilroy authored
in DBG machinery so you don't have to declare DBG_FUNC at the start of all functions. This just makes it easy to add DBG conforming to existing code. The patch reformats the changed #defines to satisfy checkstyle.pl Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of unnecessary comments. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
-
K. Y. Srinivasan authored
Now that the mouse driver is functional, enable the auto-loading of the driver. Signed-off-by:
-
K. Y. Srinivasan authored
Cleanup mousevsc_on_device_add(). Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of mousevsc_on_receive_input_report() by inlining the code. Signed-off-by:
-
K. Y. Srinivasan authored
Cleanup all camel cased names. Signed-off-by:
-
K. Y. Srinivasan authored
Now get rid of the machinery for managing the life-cycle of the mousevsc_dev as this is not needed. Signed-off-by:
-
K. Y. Srinivasan authored
Now, cleanup mousevsc_remove(). The mouse driver once initialized only receives data from the host. So, by closing the channel first in the unload path, we can properly deal with inflight packets. So, we don't need the machinery for managing the life-cycle of the mousevsc_dev object. Get rid of the unnecessary code. Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of mousevsc_on_device_remove() by inlining code. Signed-off-by:
-
K. Y. Srinivasan authored
Cleanup mousevsc_connect_to_vsp(). There is no need to take reference on the mousevsc device object when we are setting up the device. As part of this cleanup get rid of get_input_device() as this function is only used here. Signed-off-by:
-
K. Y. Srinivasan authored
We don't need to handle the "send complete" callback - nothing needs to be done here; get rid of the code. Signed-off-by:
-
K. Y. Srinivasan authored
Cleanup alloc_input_device(); you can directly set the reference count. Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of the unused state: num_outstanding_req in struct mousevsc_dev. Signed-off-by:
-
K. Y. Srinivasan authored
Free all allocated memory in free_input_device(). Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of unnecessary pr_* calls. Signed-off-by:
-
K. Y. Srinivasan authored
Cleanup error handling in this driver; use standard Linux error codes. Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of unnecessary DPRINT calls. Signed-off-by:
-
K. Y. Srinivasan authored
Cleanup and properly implement reportdesc_callback(); properly allocate the hid_device and properly initialize the hid device structure. Signed-off-by:
-
K. Y. Srinivasan authored
Use completion primitive to synchronize. Signed-off-by:
-
K. Y. Srinivasan authored
Correctly initialize the header size. Signed-off-by:
-
K. Y. Srinivasan authored
Handle the case where we may get bogus report desc size from the host. Signed-off-by:
-
K. Y. Srinivasan authored
Change the allocation flags to reflect interrupt context. Signed-off-by:
-
K. Y. Srinivasan authored
Fix the bogus WARN_ON() calls. Signed-off-by:
-
K. Y. Srinivasan authored
The state maintained in struct input_device_context can easily be included in the struct mousevsc_dev structure. Simplify the code by consolidating the state. Signed-off-by:
-
K. Y. Srinivasan authored
This structure is protocol defined structure and must match the definition on the host side. Make appropriate adjustments. Signed-off-by:
-
Jonathan Cameron authored
Unsuprisingly this symbol isn't defined on big endian systems. Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
Stephen Rothwell authored
Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Stephen Rothwell authored
fixes these build problems: drivers/staging/iio/adc/ad7746.c:345:8: error: 'S_IWUSR' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:436:8: error: 'S_IRUGO' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:681:19: error: 'THIS_MODULE' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:778:1: warning: data definition has no type or storage class [enabled by default] drivers/staging/iio/adc/ad7746.c:778:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int] drivers/staging/iio/adc/ad7746.c:778:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/staging/iio/adc/ad7746.c:799:15: error: expected declaration specifiers or '...' before string constant drivers/staging/iio/adc/ad7746.c:800:20: error: expected declaration specifiers or '...' before string constant drivers/staging/iio/adc/ad7746.c:801:16: error: expected declaration specifiers or '...' before string constant Signed-off-by:
-
- 03 Oct, 2011 8 commits
-
-
Roland Vossen authored
NVRAM contains a parameter that can disable N mode. This functionality is not needed. As a consequence, brcms_c_protection_upd() could be simplified. Reviewed-by:
Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
Franky Lin <frankyl@broadcom.com> Signed-off-by:
-
Roland Vossen authored
Code cleanup. Replaced identical definition BRCMF_C_DCMD_MAXLEN by BRCMF_DCMD_MAXLEN. Renamed related buffer len definitions. Signed-off-by:
-
Roland Vossen authored
The fullmac dongle communicates with the driver using certain codes. These codes were named 'ioctls' in the code, but this term is confusing since it is used in kernel<->driver context. The term 'ioctl' has been replaced with 'dcmd' for 'dongle command'. Reported-by:
Johannes Berg <johannes@sipsolutions.net> Reviewed-by:
-
Roland Vossen authored
Parameter was always called with the value 'true'. Reviewed-by:
-
Roland Vossen authored
Function is not called anymore. Reviewed-by:
-
Roland Vossen authored
No element in array locale_bn[] has the 'no mimo' flag bit set. Reviewed-by:
-
Roland Vossen authored
Usage of spinlock depended on module parameters that are going to be removed in a subsequent patch. Parameter wlc->threads_only is always 'true'. Reviewed-by:
-
Arend van Spriel authored
Some functions in the source file had a lot of indentation levels forcing statements to be spread over multiple lines impairing the readability of the code. Reported-by:
Joe Perches <joe@perches.com> Reviewed-by:
Roland Vossen <rvossen@broadcom.com> Signed-off-by:
-
