- 09 Aug, 2024 2 commits
-
-
Takashi Iwai authored
The recent cleanup of caiaq driver forgot to remove the unused loop variable: sound/usb/caiaq/audio.c: In function 'snd_usb_caiaq_pcm_prepare': sound/usb/caiaq/audio.c:179:41: error: unused variable 'i' [-Werror=unused-variable] Fixes: e95b9f7f ("ALSA: snd-usb-caiaq: use snd_pcm_rate_to_rate_bit") Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/20240809112252.5af8025f@canb.auug.org.au Link: https://patch.msgid.link/20240809074254.5290-1-tiwai@suse.deSigned-off-by:
Takashi Iwai <tiwai@suse.de>
-
Takashi Iwai authored
There was a stupid typo left that broke the build. Fix it. Fixes: d41abde8 ("ALSA: sparc: Use standard print API") Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202408090648.J2EAijjH-lkp@intel.com/ Link: https://patch.msgid.link/20240809073923.3735-1-tiwai@suse.deSigned-off-by:
-
- 08 Aug, 2024 38 commits
-
-
Takashi Iwai authored
There was a typo in the previous conversion to dev_*() that caused a build error. Fix it. Fixes: 2acbb5e5 ("ALSA: vxpocket: Use standard print API") Reported-by:
-
Jerome Brunet authored
Use snd_pcm_rate_to_rate_bit() helper provided by Alsa instead re-implementing it. This reduce code duplication and helps when changing some Alsa definition is necessary. Signed-off-by:
Jerome Brunet <jbrunet@baylibre.com> Link: https://patch.msgid.link/20240808134857.86749-1-jbrunet@baylibre.comSigned-off-by:
-
Takashi Iwai authored
In the previous change for swapping the power_ref and controls_rwsem lock order, the code path for the compat layer was forgotten. This patch covers the remaining code. Fixes: fcc62b19 ("ALSA: control: Take power_ref lock primarily") Link: https://patch.msgid.link/20240808163128.20383-1-tiwai@suse.deSigned-off-by:
-
Takashi Iwai authored
The recent cleanup change for vx_core overlooked the code in vxpocket pcmcia driver. Kill the superfluous line as well. Fixes: b426b3ba ("ALSA: vx_core: Drop unused dev field") Reported-by:
-
Takashi Iwai authored
The call of usb_set_interface() and a delay are superfluous when the device has been already disconnected. Add a disconnection check before doing it. Link: https://patch.msgid.link/20240808091522.31415-1-tiwai@suse.deSigned-off-by:
-
Takashi Iwai authored
The current MIDI input flush on HDSP and HDSPM drivers relies on the hardware reporting the right value. If the hardware doesn't give the proper value but returns -1, it may be stuck at an infinite loop. Add a counter and break if the loop is unexpectedly too long. Link: https://patch.msgid.link/20240808091513.31380-1-tiwai@suse.deSigned-off-by:
-
Takashi Iwai authored
ASIHPI driver stores some values in the static array upon a response from the driver, and its index depends on the firmware. We shouldn't trust it blindly. This patch adds a sanity check of the array index to fit in the array size. Link: https://patch.msgid.link/20240808091454.30846-1-tiwai@suse.deSigned-off-by:
-
Takashi Iwai authored
Now that all users of snd_print*() are gone, let's drop the functions completely. This also makes CONFIG_SND_VERBOSE_PRINTK redundant, and it's dropped, too. Reviewed-by:
Jaroslav Kysela <perex@perex.cz> Signed-off-by:
-
Takashi Iwai authored
The legacy snd_print*() helpers will be dropped now. Clean up the corresponding documentation, too. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. The debug prints with a special macro snd_printddd() are replaced with the conditional pr_debug(). Unfortunately dev_dbg() can't be applied well due to the lack of the reference to the device pointer. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
There are commented out debug prints, which are utterly superfluous. Let's drop them. Reviewed-by:
-
Takashi Iwai authored
Use pr_*() instead of open-coded printk() for code simplicity. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Some superfluous debug prints are dropped, and some ambiguous messages are slightly rephrased. The sk.dev pointer is set properly for allowing to call dev_*() functions, too. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Some functions are changed to receive snd_card object for calling dev_*() functions, too. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Replace an open-coded printk warning with dev_warn() for code simplicity and consistency. Reviewed-by:
-
Takashi Iwai authored
Replace with the standard print API from the home-baked one. Reviewed-by:
-
Takashi Iwai authored
Use pr_debug() instead of open-coded printk(). Also drop a few snd_printdd() calls that can be better done via ftrace. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. The device pointer is stored in struct cmdif for calling dev_*() functions. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. The device pointer is stored in struct soundscape for calling dev_*(). Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Some functions are changed to receive a device pointer to be passed to dev_*() calls. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API instead of open-coded printk(). Reviewed-by:
-
Takashi Iwai authored
Use the standard print API instead of open-coded printk(). Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Some functions are changed to receive snd_card pointer for referring to the device pointer for dev_*() calls, too. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. The card pointer is stored in struct snd_opti9xx and snd_miro to be referred for dev_*() calls. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. The card pointer is stored in struct snd_opl3sa2 to be referred for dev_*() calls. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. Some commented-out debug prints and dead code are dropped as well. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. For referring to the device, introduce snd_card pointer to struct snd_es18xx. Reviewed-by:
-
Takashi Iwai authored
Use the standard print API with dev_*() instead of the old house-baked one. It gives better information and allows dynamically control of debug prints. For referring to the device, introduce snd_card pointer to struct snd_es1688. Reviewed-by:
-
