- 03 Dec, 2006 40 commits
-
-
Al Viro authored
Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
... switched to taking and returning pointers to net-endian sctp_addr resp. Together, since the only user of sctp_find_unmatch_addr() just passes its value to sctp_make_asconf_update_ip(). sctp_make_asconf_update_ip() is actually endian-agnostic. Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
kill it Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
all instances are actually endian-agnostic... Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
both are done in one go since almost always we have result of the latter immediately passed to the former. Possibly non-obvious note: sctp_process_param() is endian-agnostic Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Ditto for its only caller (sctp_endpoint_is_peeled_off) Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
All instances switched, callers updated. Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Caller adjusted. Signed-off-by:
-
Al Viro authored
Along with it, statics in input.c that end up calling it (__sctp_lookup_association, sctp_lookup_association, __sctp_rcv_init_lookup, __sctp_rcv_lookup). Callers are adjusted. Signed-off-by:
-
Al Viro authored
The only caller (__sctp_rcv_lookup_endpoint()) also switched, its caller adjusted Signed-off-by:
-
Al Viro authored
Callers adjusted. Signed-off-by:
-
Al Viro authored
Its only use happens on the same host, when it gets quoted back to us. So we are free to flip to net-endian and avoid extra PITA. Signed-off-by:
-
Al Viro authored
Callers updated. Signed-off-by:
-
Al Viro authored
Callers adjusted. Signed-off-by:
-
Al Viro authored
switched to taking a pointer to net-endian sctp_addr and a net-endian port number. Instances and callers adjusted; interestingly enough, the only calls are direct calls of specific instances - the method is not used at all. Signed-off-by:
-
Al Viro authored
Users adjusted. Signed-off-by:
-
Al Viro authored
Callers adjusted. Signed-off-by:
-
Al Viro authored
instances of ->cmp_addr() are fine with switching both arguments to net-endian; callers other than in sctp_cmp_addr_exact() (both as ->cmp_addr(...) and direct calls of instances) adjusted; sctp_cmp_addr_exact() switched to net-endian itself and adjustment is done in its callers Signed-off-by:
-
Al Viro authored
No actual modifications of method instances are needed - they don't look at port numbers. Switch callers... Signed-off-by:
-
Al Viro authored
Add sctp_chunk->source, sctp_sockaddr_entry->a, sctp_transport->ipaddr and sctp_transport->saddr, maintain them as net-endian mirrors of their host-endian counterparts. Signed-off-by:
-
Al Viro authored
Part 1: rename sctp_chunk->source, sctp_sockaddr_entry->a, sctp_transport->ipaddr and sctp_transport->saddr (to ..._h) The next patch will reintroduce these fields and keep them as net-endian mirrors of the original (renamed) ones. Split in two patches to make sure that we hadn't forgotten any instanes. Later in the series we'll eliminate uses of host-endian variants (basically switching users to net-endian counterparts as we progress through that mess). Then host-endian ones will die. Other embedded host-endian sctp_addr will be easier to switch directly, so we leave them alone for now. Signed-off-by:
-
Al Viro authored
Again, invalid sockaddr passed to userland - host-endiand sin_port. Potential leak, again, but less dramatic than in previous case. Signed-off-by:
-
Al Viro authored
a) struct sockaddr_storage * passed to sctp_ulpevent_make_peer_addr_change() actually points at union sctp_addr field in a structure. Then that sucker gets copied to userland, with whatever junk we might have there. b) it's actually having host-endian sin_port. Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
It expects (and gets) laddr with net-endian sin_port. And then it calls sctp_bind_addr_match(), which *does* care about port numbers in case of ipv6 and expects them to be host-endian. Signed-off-by:
-
Al Viro authored
That's going to be a long series. Introduced temporary helpers doing copy-and-convert for sctp_addr; they are used to kill flip-in-place in global data structures and will be used to gradually push host-endian uses of sctp_addr out of existence. Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
