- 01 Mar, 2005 7 commits
-
-
takis@lumumba.luc.ac.be authored
Remember to release the PCI regions on an error path. Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Chris Wright authored
Audit inode filter drops high bits on inode number by cut 'n paste mistake. Signed-off-by:
Chris Wright <chrisw@osdl.org> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Andrew Morton authored
Avoid a possible null-pointer deref. Found by the Coverity tool Signed-off-by:
Alexander Nyberg <alexn@dsv.su.se> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Alexander Nyberg authored
The 'bad' label will call function that unconditionally dereferences the NULL pointer. Found by the Coverity tool Signed-off-by:
Alexander Nyberg <alexn@dsv.su.se> Acked-by:
James Morris <jmorris@redhat.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Alexander Nyberg authored
There's a leak here in the first error path. Found by the Coverity tool. Signed-off-by:
Alexander Nyberg <alexn@dsv.su.se> Acked-by:
James Morris <jmorris@redhat.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Kenji Kaneshige authored
This patch fix the error check in acpi_pci_irq_disable(). Signed-off-by:
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> Signed-off-by:
Tony Luck <tony.luck@intel.com>
-
Andrew Morton authored
With CONFIG_AUDITSYSCALL=n: arch/ia64/kernel/ptrace.c: In function `syscall_trace_enter': arch/ia64/kernel/ptrace.c:1615: warning: implicit declaration of function `audit_syscall_entry' arch/ia64/kernel/ptrace.c: In function `syscall_trace_leave': arch/ia64/kernel/ptrace.c:1631: warning: implicit declaration of function `audit_syscall_exit' And the link fails, due to audit_syscall_entry() not being present. Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Tony Luck <tony.luck@intel.com>
-
- 28 Feb, 2005 10 commits
-
-
Randy Dunlap authored
rrunner: references __initdata in a __devinit function; data should be __devinitdata; Error: ./drivers/net/rrunner.o .text refers to 00000000000002b2 R_X86_64_32S .init.data Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Jes Sorensen <jes@wildopensource.com> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
hp100: references __init code that should be marked as __devinit; Error: ./drivers/net/hp100.o .text refers to 0000000000000f7f R_X86_64_PC32 .init.text+0x00000000000000b8 Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
dc395x scsi driver makes many references to __init functions & __initdata that should be __devinit & __devinitdata. Error: ./drivers/scsi/dc395x.o .text refers to 00000000000021ef R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 000000000000220e R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000222e R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000022f4 R_X86_64_PC32 .init.text+0x0000000000000177 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002301 R_X86_64_32S .init.data Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002307 R_X86_64_32S .init.data+0x0000000000000004 Error: ./drivers/scsi/dc395x.o .text refers to 000000000000230f R_X86_64_32S .init.data+0x0000000000000008 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002317 R_X86_64_32S .init.data+0x000000000000000c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000231d R_X86_64_32S .init.data Error: ./drivers/scsi/dc395x.o .text refers to 000000000000232d R_X86_64_PC32 .init.text+0xfffffffffffffffc Error: ./drivers/scsi/dc395x.o .text refers to 000000000000237a R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 000000000000238c R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023ac R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023d6 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023e6 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023fe R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000240b R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002418 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000242f R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000243f R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002469 R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002476 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002489 R_X86_64_PC32 .init.data+0x0000000000000060 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002494 R_X86_64_PC32 .init.text+0x0000000000000177 Error: ./drivers/scsi/dc395x.o .text refers to 00000000000024a3 R_X86_64_32S .init.data+0x0000000000000078 Error: ./drivers/scsi/dc395x.o .text refers to 00000000000024ac R_X86_64_PC32 .init.text+0xfffffffffffffffc Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
ICCVersion() is only used by init code & can be marked __init; Error: ./drivers/isdn/hisax/icc.o .text refers to 000000000000014a R_X86_64_32S .init.data Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
sound/oss/opl3sa2: calls __init function during probe, which may be after init for PNP devices; Error: ./sound/oss/opl3sa2.o .text refers to 0000000000000204 R_X86_64_PC32 .init.text+0xfffffffffffffffc Error: ./sound/oss/opl3sa2.o .text refers to 0000000000000210 R_X86_64_PC32 .init.text+0xfffffffffffffffc Error: ./sound/oss/opl3sa2.o .text refers to 000000000000021c R_X86_64_PC32 .init.text+0xfffffffffffffffc Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
sonicvibes: _devinit function was referencing __initdata (2x), which should be __devinitdata; Error: ./sound/oss/sonicvibes.o .text refers to 0000000000003ca7 R_X86_64_32S .init.data+0x0000000000000080 Error: ./sound/oss/sonicvibes.o .text refers to 00000000000043eb R_X86_64_32S .init.data+0x0000000000000024 Error: ./sound/oss/sonicvibes.o .text refers to 00000000000043f2 R_X86_64_32S .init.data+0x0000000000000020 Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
Exit-only function uninit_aedsp16() was marked __init instead of __exit; ae_config data was marked __initdata but used during exit; several cleanup functions were marked _init but used for init or exit cleanups; Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000004 R_X86_64_PC32 .init.data+0x000000000000003b Error: ./sound/oss/aedsp16.o .exit.text refers to 000000000000000c R_X86_64_PC32 .init.text+0x00000000000001e4 Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000013 R_X86_64_PC32 .init.text+0x0000000000000034 Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000019 R_X86_64_PC32 .init.data+0x000000000000003f Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000023 R_X86_64_PC32 .init.text+0x00000000000001b4 Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Jens Axboe authored
Make sure that a bio doesn't contain NULL pages in the front of its vec, if a device bounces a bio that doesn't start from 0. Problem noted by Mark Haverkamp. Signed-off-by:
Jens Axboe <axboe@suse.de> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Andrea Arcangeli authored
The new pipe buffer merging doesn't check for the "no readers" case, so with small writes that coalesce, we may not get a timely SIGPIPE/EPIPE notification to the writer. Signed-off-by:
Andrea Arcangeli <andrea@suse.de> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Linus Torvalds authored
The pipe code has traditionally not cared about which end-point of the pipe you are polling, meaning that if you poll the write-only end of a pipe, it will still set the "this pipe is readable" bits if there is data to be read on the read side. That makes no sense, and together with the new bigger buffers breaks python-twisted. Based on debugging/patch by Andrea Arcangeli and testcase from Thomas Crhak
-
- 27 Feb, 2005 5 commits
-
-
Randy Dunlap authored
srat's node_to_pxm() references pxm2node[] after init. so pxm2node[] should not be __initdata. Error: ./arch/x86_64/mm/srat.o .text refers to 0000000000000008 R_X86_64_32S .init.data Error: ./arch/x86_64/mm/srat.o .text refers to 0000000000000015 R_X86_64_32S .init.data Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
bk://kernel.bkbits.net/davem/net-2.6Linus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
David S. Miller authored
We should report the total bytes in the whole receive queue, not just the first packet, in these cases. Reported by Uwe Bonnes. Signed-off-by:
David S. Miller <davem@davemloft.net>
-
David S. Miller authored
Spotted by itkes@fat.imed.msu.ru, the fn_hash_dump_bucket() main loop does not increment 'i' properly, and thus routes will not be listed, when the test 'i < s_i' passes. The bug was added when the code was converted over to hlist_for_each_entry() by your's truly. Signed-off-by:
David S. Miller <davem@davemloft.net>
-
-
- 26 Feb, 2005 7 commits
-
-
bk://kernel.bkbits.net/davem/net-2.6Linus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
Linus Torvalds authored
It can only be set by root, but let's not tempt people to do things that can't work.
-
Andries E. Brouwer authored
setup_APIC_timer is only called in __init context and uses __initdata
-
Andries E. Brouwer authored
wait_timer_tick refers to the __init functions wait_8254_wraparound or wait_hpet_tick, hence must be __initdata.
-
Andries E. Brouwer authored
scsi_dev_flags is referred to in module_param_string(dev_flags, scsi_dev_flags, sizeof(scsi_dev_flags), 0);
-
Andries E. Brouwer authored
cfq_init() calls __init cfq_slab_setup and hence must be __init itself also made it static
-
Andries E. Brouwer authored
parport_init_mode is referred to in int __devinit sio_via_probe().
-
- 25 Feb, 2005 10 commits
-
-
Aurelien Jarno authored
I have just tested kernel version 2.6.11-rc5 and noticed it is not possible to do an USB transfer by submitting an URB to an output endpoint. This breaks newest versions of libusb and thus SANE, gphoto2, and a lot of software. The bug was introduced in version 2.6.11-rc1 and is due to a wrong comparison. Signed-off-by:
Aurelien Jarno <aurelien@aurel32.net> Signed-off-by:
Greg Kroah-Hartman <greg@kroah.com> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Linus Torvalds authored
This ain't pretty. Real fix under discussion.
-
Olaf Hering authored
modedb can not be __init because fb_find_mode() (which is not __init) may get db == NULL. fb_find_mode() is called from modules. Signed-off-by:
Olaf Hering <olh@suse.de> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
David S. Miller authored
into nuts.davemloft.net:/disk1/BK/net-2.6
-
bk://bk.arm.linux.org.uk/linux-2.6-rmkLinus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
Russell King authored
We were passing the size of the region in pages, where as remap_pfn_range expected the size in bytes. Signed-off-by:
Russell King <rmk@arm.linux.org.uk>
-
Andrew Morton authored
The cast to void still triggers the gcc "warning: ignoring return value" warning, which is dumb of it. So ignore the return value differently. Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Greg Kroah-Hartman authored
Here's a patch for 2.6.11-rc5 that a lot of cdc-acm driver users are clamoring for. There's a bug introduced in a cleanup which will lead to a race making reopenings fail. This fix is by Alexander Lykanov. Signed-off-by:
Oliver Neukum <oliver@neukum.name> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
David Howells authored
The attached patch makes keyctl() use the correct argument when invoking the KEYCTL_JOIN_SESSION_KEYRING function. I'm not sure how this evaded testing before, but I suspect the compiler was kind and made both argument registers hold the same value. Thanks to Kevin Coffman <kwc@citi.umich.edu> for spotting this. Signed-Off-By:
David Howells <dhowells@redhat.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
David Gibson authored
This fixes a potentially bad (although very rarely triggered) bug in the ppc64 hugepage code. hpte_update() did not correctly calculate the address for hugepages, so pte_clear() (which we use for hugepage ptes as well as normal ones) would not correctly flush the hash page table entry. Under the right circumstances this could potentially lead to duplicate hash entries, which is very bad. davem's upcoming patch to pass the virtual address directly to set_pte() and its ilk will obsolete this, but this is bad enough it should probably be fixed in the meantime. Signed-off-by:
David Gibson <dwg@au1.ibm.com> Acked-by:
William Irwin <wli@holomorphy.com> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
- 24 Feb, 2005 1 commit
-
-
Bartlomiej Zolnierkiewicz authored
Revert to previous way of handling masked_irq argument. Reported to fix problems with shared PCI IRQs. Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-