- 30 Apr, 2013 40 commits
-
-
Bertrand Achard authored
The rtc-ds1307 driver does not properly handle block operations bigger than 32 bytes in either of the two modes supported (SMbus native, or emulated if not supported by the SMbus platform driver). It also does not properly handle userland-supplied input (block operation length) through sysfs and may suffer a type of buffer overrun. The driver has been modified with proper input validation, buffer sizes, and now splits block transfers bigger than 32 bytes into separate transfers. Explanation : Buffer size allocated is I2C_SMBUS_BLOCK_MAX which equals to 32 as per the SMbus spec. Reads and write may be up to 56 bytes (to the NVRAM). This patch allocated a 255 byte buffer, the maximum allowable (address is an u8). It's not only a buffer problem, SMbus only supports up to 32 bytes transfer at once, so it's needed to split bigger transfers. Patch successfully tested on 3.2.27; cleanly applies on 3.7-rc4. [akpm@linux-foundation.org: rework code to avoid 80-column overflows] Signed-off-by:
Bertrand Achard <ba@cykian.net> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Laxman Dewangan authored
Use devm_rtc_device_register() for registering RTC device. This will reduce the code for unregistering RTC device in cleanup path and remove the implementation of remove callback of platform driver. Signed-off-by:
Laxman Dewangan <ldewangan@nvidia.com> Reviewed-by:
Thierry Reding <thierry.reding@avionic-design.de> Reviewed-by:
Stephen Warren <swarren@nvidia.com> Cc: Jingoo Han <jg1.han@samsung.com> Signed-off-by:
-
Laxman Dewangan authored
The irq name of tegra rtc shows as "rtc alarm" which actually does not reflect the name related to driver. Passing the device name to have the irq names with driver name. Signed-off-by:
-
Laxman Dewangan authored
Make the Tegra RTC controller driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct platform_driver. Signed-off-by:
-
Laxman Dewangan authored
CONFIG_PM doesn't actually enable any of the PM callbacks, it only allows to enable CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME. This means if CONFIG_PM is used to protect system sleep callbacks then it may end up unreferenced if only runtime PM is enabled. Hence protecting sleep callbacks with CONFIG_PM_SLEEP. Signed-off-by:
-
Devendra Naga authored
below is the warning reported with the gcc (gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)) with make W=1: drivers/rtc/rtc-ds1286.c: In function `ds1286_read_alarm': drivers/rtc/rtc-ds1286.c:273:16: warning: variable `cmd' set but not used [-Wunused-but-set-variable] fixed by removing the variable Signed-off-by:
Devendra Naga <devendra.aaru@gmail.com> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Alessandro Zummo <a.zummo@towertech.it> Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Also, use devm_request_threaded_irq() to make cleanup paths more simple. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Also, this patch uses devm_request_threaded_irq(). Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by:
-
Jingoo Han authored
Use module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by:
-
Jingoo Han authored
Use module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by:
-
Jingoo Han authored
Use module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by:
-
Jingoo Han authored
Use module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by:
Paul Mundt <lethal@linux-sh.org> Signed-off-by:
-
