Commits · be471fe332f7f14aa6828010b220d7e6902b91a0 · Kirill Smelkov / linux

12 Jun, 2021 3 commits

ALSA: n64: check return value after calling platform_get_resource() · be471fe3

Yang Yingliang authored Jun 10, 2021

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210610124958.116142-1-yangyingliang@huawei.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

be471fe3

ALSA: hda/tegra: Use devm_platform_get_and_ioremap_resource() · 01893553

Yang Yingliang authored Jun 10, 2021

Use devm_platform_get_and_ioremap_resource() to simplify
code.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210610131922.134788-1-yangyingliang@huawei.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

01893553

ALSA: trident: Fix build error · fd498bba

YueHaibing authored Jun 12, 2021

sound/pci/trident/trident_memory.c: In function ‘set_tlb_bus’:
sound/pci/trident/trident_memory.c:85:35: error: ‘pagetr’ undeclared (first use in this function); did you mean ‘page’?
  for (i = 0; i < UNIT_PAGES; i++, pagetr++) {
                                   ^~~~~~
                                   page

Fixes: 74fb9831 ("ALSA: trident: Drop shadow TLB pointer table")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20210612033458.42928-1-yuehaibing@huawei.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

fd498bba

11 Jun, 2021 3 commits

ALSA: bebob: code refactoring for model-dependent quirks · 93cd12d6

Takashi Sakamoto authored Jun 11, 2021

This commit adds enumeration and structure member as code refactoring
regarding to model-dependent quirks.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210611035003.26852-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

93cd12d6

ALSA: bebob: delete workaround for protocol version 3 · 82fb3bf9

Takashi Sakamoto authored Jun 11, 2021

In a commit c4d860a0 ("ALSA: bebob: loosen up severity of checking
continuity for BeBoB v3 quirk"), a workaround was added for the quirk in
BeBoB protocol version 3 against the discontinuity of data block counter.
As long as seeing with sequence replay for media clock recovery, such
quirk disappears.

This commit deletes the workaround.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210611035003.26852-3-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

82fb3bf9

ALSA: bebob: dismiss sleep after breaking connections · c66c6304

Takashi Sakamoto authored Jun 11, 2021

In a commit d3eabe93 ("ALSA: bebob: expand sleep just after breaking
connections for protocol version 1"), a workaround was added for a quirk
of freeze in BeBoB protocol version 1. As long as seeing with sequence
replay for media clock recovery, the quirk disappears.

This commit removes the workaround.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210611035003.26852-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

c66c6304

10 Jun, 2021 12 commits

ALSA: core: Fix build error due to missing PAGE_SIZE · 83fbcaed

Takashi Iwai authored Jun 10, 2021

The recent refactoring of memalloc stuff removed the inclusion of
asm/page.h for simplicity, but it turned out this caused a compile
error due the lack of PAGE_SIZE definition on some architectures.
Do a partial revert for recovering from that.

Fixes: 37af81c5 ("ALSA: core: Abstract memory alloc helpers")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/202106101858.PfXMMuAa-lkp@intel.com
Link: https://lore.kernel.org/r/20210610110935.10393-1-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

83fbcaed

ALSA: usb-audio: Add support for Denon DN-X1600 · 7fdabab8

Damien Zammit authored Jun 10, 2021

This provides support for Denon DN-X1600 hardware mixer.

The device itself supports 44100, 48000 and 96000 (Hz)
sample rates, but switching rates via software is currently not working.
Therefore, this patch hardcodes the sample rate to 48000Hz which
enables all 8 channels to function correctly when the correct
sample rate is selected on the hardware itself.

MIDI also tested and works.
Signed-off-by: Damien Zammit <damien@zamaudio.com>
Tested-by: xalmoxis@gmail.com
Link: https://lore.kernel.org/r/20210610083528.603942-2-damien@zamaudio.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

7fdabab8

ALSA: core: Add continuous and vmalloc mmap ops · 30b7ba69

Takashi Iwai authored Jun 09, 2021

The mmap of continuous pages and vmalloc'ed pages are relatively
easily done in a shot with the existing helper functions.
Implement the mmap ops for those types, so that the mmap works without
relying on the page fault handling.

Link: https://lore.kernel.org/r/20210609162551.7842-6-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

30b7ba69

ALSA: core: Move mmap handler into memalloc ops · a202bd1a

Takashi Iwai authored Jun 09, 2021

This patch moves the mmap handling code into the common memalloc
handler. It allows us to reduce the memory-type specific code in PCM
code gracefully.

Link: https://lore.kernel.org/r/20210609162551.7842-5-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

a202bd1a

ALSA: core: Abstract memory alloc helpers · 37af81c5

Takashi Iwai authored Jun 09, 2021

This patch introduces the ops table to each memory allocation type
(SNDRV_DMA_TYPE_XXX) and abstract the handling for the better code
management.  Then we get separate the page allocation, release and
other tasks for each type, especially for the SG buffer.

Each buffer type has now callbacks in the struct snd_malloc_ops, and
the common helper functions call those ops accordingly.  The former
inline code that is specific to SG-buffer is moved into the local
sgbuf.c, and we can simplify the PCM code without details of memory
handling.

Link: https://lore.kernel.org/r/20210609162551.7842-4-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

37af81c5

ALSA: core: Drop snd_sgbuf_get_ptr() · 84a03740

Takashi Iwai authored Jun 09, 2021

snd_sgbuf_get_ptr() and its sibling snd_pcm_sgbuf_get_ptr() are no
longer used by any drivers. Let's drop them.

Link: https://lore.kernel.org/r/20210609162551.7842-3-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

84a03740

ALSA: trident: Drop shadow TLB pointer table · 74fb9831

Takashi Iwai authored Jun 09, 2021

The shadow TLB pointer table is allocated and set up, but never really
used any longer by the driver. Let's drop it.

Since this is the only user of snd_pcm_sgbuf_get_ptr(), we can clean
up the API after this change.

Link: https://lore.kernel.org/r/20210609162551.7842-2-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

74fb9831

ALSA: doc: Fix spelling mistakes · 25c794cd

huangjianghui authored Jun 10, 2021

correct Reatek to Realtek
Signed-off-by: huangjianghui <huangjianghui@uniontech.com>
Link: https://lore.kernel.org/r/20210610062036.30300-1-huangjianghui@uniontech.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

25c794cd

ALSA: arm: Remove unnecessary variables · f4a85e00

zuoqilin authored Jun 10, 2021

There is no need to define the variable "ret" to receive.
Signed-off-by: zuoqilin <zuoqilin@yulong.com>
Link: https://lore.kernel.org/r/20210610024053.1217-1-zuoqilin1@163.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

f4a85e00

ALSA: firewire-lib: obsolete workqueue for period update · b5b51996

Takashi Sakamoto authored Jun 10, 2021

The workqueue to notify PCM period elapse is not used anymore.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210610031733.56297-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

b5b51996

ALSA: firewire-lib: operate for period elapse event in process context · 7ba5ca32

Takashi Sakamoto authored Jun 10, 2021

All of drivers in ALSA firewire stack processes two chances to process
isochronous packets in any isochronous context; in software IRQ context
for 1394 OHCI, and in process context of ALSA PCM application.

In the process context, callbacks of .pointer and .ack are utilized. The
callbacks are done by ALSA PCM core under acquiring lock of PCM substream,

In design of ALSA PCM core, call of snd_pcm_period_elapsed() is used for
drivers to awaken user processes from waiting for available frames. The
function voluntarily acquires lock of PCM substream, therefore it is not
called in the process context since it causes dead lock.

As a workaround to avoid the dead lock, all of drivers in ALSA firewire
stack uses workqueue to delegate the call. A variant of
snd_pcm_period_elapsed() without lock acquisition can obsolete the
workqueue.

An extra care is needed for the callback of .pointer since it's called
from snd_pcm_period_elapsed(). The isochronous context in Linux FireWire
subsystem is safe mostly for nested call except in software IRQ context.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210610031733.56297-3-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

7ba5ca32

ALSA: pcm: add snd_pcm_period_elapsed() variant without acquiring lock of PCM substream · 47271b1b

Takashi Sakamoto authored Jun 10, 2021

Current implementation of ALSA PCM core has a kernel API,
snd_pcm_period_elapsed(), for drivers to queue event to awaken processes
from waiting for available frames. The function voluntarily acquires lock
of PCM substream, therefore it is not called in process context for any
PCM operation since the lock is already acquired.

It is convenient for packet-oriented driver, at least for drivers to audio
and music unit in IEEE 1394 bus. The drivers are allowed by Linux
FireWire subsystem to process isochronous packets queued till recent
isochronous cycle in process context in any time.

This commit adds snd_pcm_period_elapsed() variant,
snd_pcm_period_elapsed_without_lock(), for drivers to queue the event in
the process context.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210610031733.56297-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

47271b1b

09 Jun, 2021 22 commits

ALSA: parisc: Fix assignment in if condition · 6ea9a2b8

Takashi Iwai authored Jun 08, 2021

PARISC harmony driver code contains an assignment in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.