- 20 Feb, 2016 40 commits
-
-
Bhaktipriya Shridhar authored
The macro ARRAY_SIZE is more concise to use instead of dividing size of the array by the size of its type. Changes were made using Coccinelle. @@ type T; T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Janani Ravichandran authored
Remove unnecessary else when there is a return statement in the corresponding if block. Coccinelle patch used: @rule1@ expression e1; @@ if (e1) { ... return ...; } - else{ ... - } @rule2@ expression e2; statement s1; @@ if(e2) { ... return ...; } - else s1 Signed-off-by:Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Geliang Tang authored
This patch cleans whitespaces and blank lines involved with previous two patchs in this patch set. Signed-off-by:
Geliang Tang <geliangtang@163.com> Acked-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Geliang Tang authored
There are some useless codes in rtw_free_recvframe23a_queue() and recvframe_defrag(), so remove them. Signed-off-by:
-
Geliang Tang authored
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by:
-
Bhumika Goyal authored
The macros PlatformProcessHCICommands and PlatformTxBTQueuedPackets are not used anywhere in the kernel so remove them. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
With concurrency managed workqueues, use of dedicated workqueues can be replaced by using system_wq. Drop schedule_usb_work by using system_wq. Since there is only one work item per buf_anchor and most_dev and they do not need to be ordered, increase of concurrency by switching to system_wq should not break anything. Both work items are sync canceled before the driver can be unregistered, to ensure no work item is pending or executing on any CPU by the time exit path is in flight. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace pr_err with dev_err when a appropriate device structure is present. Signed-off-by:
-
Amitoj Kaur Chawla authored
Devm_ functions allocate memory that is released when a driver detaches. Replace request_irq with devm_request_irq to get the interrupt for device which is automatically freed on exit. Remove corresponding free_irq from probe and remove functions of a platform device. Also, remove an unnecessary label. Signed-off-by:
-
Amitoj Kaur Chawla authored
Devm_ functions allocate memory that is released when a driver detaches. Replace request_mem_region and ioremap with devm_ioremap_resource and remove corresponding freeing functions release_mem_region and iounmap from probe and remove functions of a platform device. Also, an unnecessary platform_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. Lastly, unnecessary labels have been removed. Signed-off-by:
-
Amitoj Kaur Chawla authored
Devm_ functions allocate memory that is released when a driver detaches. Replace kzalloc with devm_kzalloc and remove corresponding kfrees from probe and remove functions of a platform device. Also, an unnecessary label has been removed. Signed-off-by:
-
Laura Garcia Liebana authored
Return a ZERO_SIZE_PTR in the xlr_config_spill function if the kmalloc returns an invalid value. This change prevents a possible segmentation fault as the invalid pointer is fed into PTR_ALIGN macro. Signed-off-by:
Laura Garcia Liebana <nevola@gmail.com> Signed-off-by:
-
Laura Garcia Liebana authored
Insert code indent for conditional statements. Checkpatch detected this issue. Signed-off-by:
-
Laura Garcia Liebana authored
Spaces preferred around that '/' (ctx:VxV). Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of comparison to NULL, use !<variable> instead. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of CamelCase for constants. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of multiple assignments in a single line. Checkpatch found this issue. Signed-off-by:
-
Laura Garcia Liebana authored
Remove uneeded blank spaces after a cast. Checkpatch found these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Align arguments with the open parenthesis. Checkpatch found these issues. Signed-off-by:
-
Thaissa Falbo authored
Remove ret variable in functions that used it to determine the return. Simplified the return logic for these functions. Found with Coccinelle script: @@ local idexpression ret; expression c,d; identifier label; @@ switch ( ... ) { case label : ... - ret = c; - break; + return c; ... default: ... - ret = d; + return d; ... } ... when != ret - return ret; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by:Thaissa Falbo <thaissa.falbo@gmail.com> Signed-off-by:
-
Thaissa Falbo authored
Simplified return of funcions by removing assignment of ret variable. Coccinelle script used: @@ local idexpression ret; expression e; @@ - ret = e; - if(ret) - return ret; + if(e) + return e; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ local idexpression ret; expression e; @@ - ret = e; - if(ret){ + if(e){ ... when != ret - return ret; + return e; } @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: -
Thaissa Falbo authored
Fix "line over 80 characters" checkpatch warnings WARNING: line over 80 characters Signed-off-by:
-
Thaissa Falbo authored
Fixed code indentation warning as detected by checkpatch. WARNING: suspect code indent for conditional statements (24, 40) #1672: FILE: drivers/staging/media/davinci_vpfe/dm365_resizer.c:1672: Signed-off-by:
-
Thaissa Falbo authored
WARNING: Comparisons should place the constant on the right side of the test Fixed warnings by moving the constants to the right side of the comparisons. Signed-off-by:
-
Thaissa Falbo authored
Fixed block comments by following the checkpatch warnings WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on separate line Signed-off-by:
-
Amitoj Kaur Chawla authored
Use offset_in_page macro instead of (var & ~PAGE_MASK) The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ unsigned long p; @@ - p & ~PAGE_MASK + offset_in_page(p) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)) but is perhaps more readable. The Coccinelle script used is as follows: // <smpl> @@ expression n,d; @@ ( - (n + d - 1) / d + DIV_ROUND_UP(n,d) | - (n + (d - 1)) / d + DIV_ROUND_UP(n,d) ) @@ expression n,d; @@ - DIV_ROUND_UP((n),d) + DIV_ROUND_UP(n,d) @@ expression n,d; @@ - DIV_ROUND_UP(n,(d)) + DIV_ROUND_UP(n,d) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace kmalloc and memcpy with kmemdup. Found using Coccinelle. The semantic patch used to make this change can be found here: scripts/coccinelle/api/memdup.cocci Signed-off-by:
-
Fu Yong Quah authored
Fix NULL equality comparision by changing it with exclamation mark, as suggested by Documentation/CodingStyle Signed-off-by:
Fu Yong Quah <fuyong@linux.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
flush_scheduled_work() is scheduled for deprecation. Use cancel_work_sync() instead to ensure that there is no pending or running work item. Signed-off-by:
Tejun Heo <tj@kernel.org> Signed-off-by:
-
Bhumika Goyal authored
hfa384x_drvr_getconfig_async is not used anywhere in the kernel so remove it. Also remove its prototype from the header file. Also the function hfa384x_cb_rrid was only used by hfa384x_drvr_getconfig_async so remove its definition and prototype as well. Signed-off-by:
-
Bhumika Goyal authored
The function hfa384x_drvr_commtallies is not used anywhere in the kernel so remove it. Also remove its prototype from the header file. Signed-off-by:
-
Eva Rachel Retuya authored
Remove comparison of spi->dev.platform_data to NULL by replacing it with '!spi->dev.platform_data' as checkpatch suggested: CHECK: Comparison to NULL could be written "!spi->dev.platform_data" Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Delete the excess newline. Issue found by checkpatch. CHECK: Please don't use multiple blank lines Signed-off-by:
-
Eva Rachel Retuya authored
Delete unwanted whitespace after casting. Issue pointed out by checkpatch. Signed-off-by:
-
Eva Rachel Retuya authored
Add braces around the else clause to adhere to kernel coding style. This clears the following checkpatch issue: CHECK: braces {} should be used on all arms of this statement Signed-off-by: -
Eva Rachel Retuya authored
Add a blank line after array declaration. This clears the checkpatch check: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by:
-
Eva Rachel Retuya authored
Add spaces around operators to improve readability and to address the checkpatch issue: CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by:
-
Eva Rachel Retuya authored
Use a combination of tabs and spaces to align parameters to its corresponding open parenthesis. Checkpatch found this issue. Signed-off-by:
-
Eva Rachel Retuya authored
Rewrite the multiple assignments to clear checkpatch check: CHECK: multiple assignments should be avoided Signed-off-by:
-
