- 29 Mar, 2014 2 commits
-
-
Jiri Kosina authored
The 3rd argument is pointer to the buffer, not a single __u8. This has no bad sideeffect, as the stub is not using any of its argument, but better have it correct. Signed-off-by:Jiri Kosina <jkosina@suse.cz>
-
K. Y. Srinivasan authored
commit 3c86726c ("HID: make .raw_request mandatory") made .raw_request mandatory and broke the Hyper-V mouse driver. This patch fixes the problem. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Reviewed-by:
Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by:
-
- 14 Mar, 2014 6 commits
-
-
Benjamin Tissoires authored
Nobody calls hid_output_raw_report anymore, and nobody should. We can now remove the various implementation in the different transport drivers and the declarations. Reviewed-by:
David Herrmann <dh.herrmann@gmail.com> Signed-off-by:
-
Benjamin Tissoires authored
hid_out_raw_report is going to be obsoleted as it is not part of the unified HID low level transport documentation (Documentation/hid/hid-transport.txt) To do so, we need to introduce two new quirks: * HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP: this quirks prevents the transport driver to use the interrupt channel to send output report (and thus force to use HID_REQ_SET_REPORT command) * HID_QUIRK_SKIP_OUTPUT_REPORT_ID: this one forces usbhid to not include the report ID in the buffer it sends to the device through HID_REQ_SET_REPORT in case of an output report This also fixes a regression introduced in commit 3a75b249 (HID: hidraw: replace hid_output_raw_report() calls by appropriates ones). The hidraw API was not able to communicate with the PS3 SixAxis controllers in USB mode. Reviewed-by:
Antonio Ospite <ao2@ao2.it> Signed-off-by:
-
Jiri Kosina authored
-
Benjamin Tissoires authored
tests have shown that output reports use hid_hw_output_report(). Reviewed-by:
-
Benjamin Tissoires authored
hid_out_raw_report is going to be obsoleted as it is not part of the unified HID low level transport documentation (Documentation/hid/hid-transport.txt) hid_output_raw_report(hdev, buf, sizeof(buf), HID_FEATURE_REPORT); is strictly equivalent to: hid_hw_raw_request(hdev, buf[0], buf, sizeof(buf), HID_FEATURE_REPORT, HID_REQ_SET_REPORT); Then replace buf[0] by the appropriate define. So use the new api. Reviewed-by:
-
Jiri Kosina authored
-
- 24 Feb, 2014 8 commits
-
-
Frank Praznik authored
Add a comment noting that some devices depend on the destination address being stored in uniq. Signed-off-by:
Frank Praznik <frank.praznik@oh.rr.com> Reviewed-by:
-
Frank Praznik authored
If a Sixaxis or Dualshock 4 controller is connected via USB while already connected via Bluetooth it will cause duplicate devices to be added to the input device list. To prevent this a global list of controllers and their MAC addresses is maintained and new controllers are checked against this list. If a duplicate is found, the probe function will exit with -EEXIST. On USB the MAC is retrieved via a feature report. On Bluetooth neither controller reports the MAC address in a feature report so the MAC is parsed from the uniq string. As uniq cannot be guaranteed to be a MAC address in every case (uHID or the behavior of HIDP changing) a parsing failure will not prevent the connection. Signed-off-by:
-
Frank Praznik authored
Make sure that an out-of-bounds read doesn't occur in the Sixaxis battery level lookup table in the event that the controller sends an invalid battery status value in the report. Signed-off-by:
-
Frank Praznik authored
Only initialize force feedback for devices that actually support it (Sixaxis and Dualshock 4) to prevent calls to schedule_work() with an uninitialized work queue. Move the cancel_work_sync() call out of sony_destroy_ff() since the state worker is used for the LEDs even when force-feedback is disabled. Remove the sony_destroy_ff() function since it is no longer used. Signed-off-by:
-
Frank Praznik authored
Convert multi-line comments to comply with the kernel coding style. Signed-off-by:
-
Benjamin Tissoires authored
Remove hid_output_raw_report() call as it is not a ll_driver callbacj, and switch to the hid_hw_* implementation. USB-HID used to fallback into SET_REPORT when there were no output interrupt endpoint, so emulating this if hid_hw_output_report() returns -ENOSYS. Reviewed-by:
-
Benjamin Tissoires authored
SET_REPORT and GET_REPORT are mandatory in the HID specification. Make the corresponding API in hid-core mandatory too, which removes the need to test against it in some various places. Signed-off-by:
-
Benjamin Tissoires authored
hid_output_raw_report() is not a ll_driver callback and should not be used. To keep the same code path than before, we are forced to play with the different hid_hw_* calls: if the usb or i2c device does not support direct output reports, then we will rely on the SET_REPORT HID call. Signed-off-by:
-
- 20 Feb, 2014 1 commit
-
-
Frank Praznik authored
Add a SIXAXIS_CONTROLLER macro to simplify conditionals where the connection type is irrelevant. Enable the LED and force feedback controls for Sixaxis controllers connected via Bluetooth. Send Sixaxis Bluetooth output reports on the control channel. Signed-off-by:
-
- 18 Feb, 2014 2 commits
-
-
Jiri Kosina authored
Both cp2112_read_req() and cp2112_write_req() are returning negative value in cases of error, but cp2112_xfer() is storing the return value into unsigned size_t-typed 'count'. Fix this by making 'count' signed type. Reported-by: fengguang.wu@intel.com Signed-off-by: -
Jiri Kosina authored
Add Kconfig driver dependency on GPIOLIB. Reported-by: fengguang.wu@intel.com Signed-off-by:
-
- 17 Feb, 2014 21 commits
-
-
Jiri Kosina authored
Commit cafebc05 ("HID: remove hid_get_raw_report in struct hid_device") obsoletes the use of hdev->hid_get_raw_report(), as calling hid_hw_raw_request() is functionally equivalent. Convert cp2112 to use this notation. Reported-by: fengguang.wu@intel.com Signed-off-by:
-
Jiri Kosina authored
-
Jiri Kosina authored
%zd is a proper format string specifier for size_t Signed-off-by: -
Jiri Kosina authored
No need to pollute namespace with dev_attr_*. Signed-off-by: -
David Barksdale authored
This patch adds support for the Silicon Labs CP2112 "Single-Chip HID USB to SMBus Master Bridge." This is a HID device driver which registers as an i2c adapter and gpiochip to expose these functions of the CP2112. The customizable USB descriptor fields are exposed as sysfs attributes. The SMBus byte-read, byte-data-read/write, and word-data-read transfer modes have been tested by talking to an i2c sensor. The GPIO functions and USB descriptor field programming have also been tested. Signed-off-by:
David Barksdale <dbarksdale@uplogix.com> Signed-off-by:
-
Frank Praznik authored
The battery_charging and cable_state flags were backwards on the Sixaxis. The low bit of report byte 30 is 0 when charging and 1 when not. Bit 5 of byte 31 is 0 when a USB cable is connected and 1 when not. Signed-off-by:
-
Benjamin Tissoires authored
It is better to check them soon enough before triggering any kernel panic. Signed-off-by:
-
Benjamin Tissoires authored
For BT transport layer, ret = hid_output_raw_report(A, B, C, HID_OUTPUT_REPORT); is equivalent to ret = hid_hw_output_report(A, B, C); So use the new API where available Signed-off-by:
-
Benjamin Tissoires authored
ret = hid_output_raw_report(A, B, C, HID_FEATURE_REPORT); is equivalent to ret = hid_hw_raw_request(A, B[0], B, C, HID_FEATURE_REPORT, HID_REQ_SET_REPORT); whatever the transport layer is. So use the new API where available Signed-off-by:
-
Benjamin Tissoires authored
hid-input do not use anymore hid_output_raw_report() to set the LEDs. Use the correct implementation now and make them working again. Signed-off-by:
-
Benjamin Tissoires authored
If there is no urbout when sending a output report, ENOSYS (Function not implemented) is a better error than EIO (I/O error). Signed-off-by:
-
Benjamin Tissoires authored
Having our own .request() implementation does not give anything, so use the generic binding. Signed-off-by:
-
Benjamin Tissoires authored
Add output_report and raw_request to i2c-hid. The current implementation of i2c_hid_output_raw_report decides by itself if it should use a direct send of the output report or use the data register (SET_REPORT). Split that by reimplement the logic in __i2c_hid_output_raw_report() which will be dropped soon. Signed-off-by:
-
Benjamin Tissoires authored
.request() can be emulated through .raw_request() we can implement this emulation in hid-core, and make .request not mandatory for transport layer drivers. Signed-off-by:
-
Benjamin Tissoires authored
uHID is missing a SET_REPORT protocol implementation, but as .hid_get_raw_report() as been removed from struct hid_device, there were no means to access GET_REPORT in uhid. Signed-off-by:
-
Jiri Kosina authored
This reverts commit 4a76d370. Removing it was a mistake, as we need a means to access GET_REPORT. Reported-by:
-
Benjamin Tissoires authored
uhid_hid_output_report() can be implemented through a simple call to uhid_hid_output_raw(). Signed-off-by:
-
Jiri Kosina authored
This function is now unused since cafebc05 ("HID: remove hid_get_raw_report in struct hid_device"). Signed-off-by:
-
Frank Praznik authored
Add the conditionals to enable rumble, battery reporting, LED and touchpad support for the Dualshock 4 in Bluetooth mode. Add dualshock4_set_operational_bt to initialize the controller to the proper operational state. Signed-off-by:
-
Frank Praznik authored
Set the initial battery level to 100% to avoid false low battery warnings if the battery state is polled before a report with the actual battery level is received. Signed-off-by:
-
Frank Praznik authored
Add Dualshock 4 battery and touchpad parsing for Bluetooth reports. Signed-off-by:
-
