- 07 Jul, 2021 12 commits
-
-
Chuck Lever authored
Signed-off-by:
Chuck Lever <chuck.lever@oracle.com> Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
Chuck Lever authored
Add a .h file containing xdr_stream-based XDR helpers common to both NLMv3 and NLMv4. Signed-off-by:
-
Chuck Lever authored
To enable xdr_stream-based encoding and decoding, create a bespoke RPC dispatch function for the lockd service. Signed-off-by:
-
Chuck Lever authored
Signed-off-by:
-
J. Bruce Fields authored
I'm not even sure cl_xprt can change here, but we're getting "suspicious RCU usage" warnings, and other rpc_peeraddr2str callers are taking the rcu lock. Signed-off-by: -
Colin Ian King authored
The variable status is being initialized with a value that is never read, the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
ChenXiaoSong authored
Fix gcc W=1 warning: fs/nfs_common/grace.c:91: warning: Function parameter or member 'net' not described in 'locks_in_grace' Signed-off-by:
ChenXiaoSong <chenxiaosong2@huawei.com> Signed-off-by:
-
Wei Yongjun authored
'status' has been overwritten to 0 after nfsd4_ssc_setup_dul(), this cause 0 will be return in vfs_kern_mount() error case. Fix to return nfserr_nodev in this error. Fixes: f4e44b39 ("NFSD: delay unmount source's export after inter-server copy completed.") Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by:
-
Dai Ngo authored
Fix by initializing pointer nfsd4_ssc_umount_item with NULL instead of 0. Replace return value of nfsd4_ssc_setup_dul with __be32 instead of int. Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
Dai Ngo <dai.ngo@oracle.com> Signed-off-by:
-
Dave Wysochanski authored
In addition to the client's address, display the callback channel state and address in the 'info' file. Signed-off-by:
Dave Wysochanski <dwysocha@redhat.com> Signed-off-by:
-
Zheng Yongjun authored
Fix some spelling mistakes in comments: succes ==> success Signed-off-by:
Zheng Yongjun <zhengyongjun3@huawei.com> Signed-off-by:
-
J. Bruce Fields authored
This was causing a "sleeping function called from invalid context" warning. I don't think we need the set_and_test_bit() here; clients move from unconfirmed to confirmed only once, under the client_lock. The (conf == unconf) is a way to check whether we're in that confirming case, hopefully that's not too obscure. Fixes: 472d155a "nfsd: report client confirmation status in "info" file" Signed-off-by:
-
- 25 May, 2021 4 commits
-
-
Dai Ngo authored
Currently the source's export is mounted and unmounted on every inter-server copy operation. This patch is an enhancement to delay the unmount of the source export for a certain period of time to eliminate the mount and unmount overhead on subsequent copy operations. After a copy operation completes, a work entry is added to the delayed unmount list with an expiration time. This list is serviced by the laundromat thread to unmount the export of the expired entries. Each time the export is being used again, its expiration time is extended and the entry is re-inserted to the tail of the list. The unmount task and the mount operation of the copy request are synced to make sure the export is not unmounted while it's being used. Signed-off-by:
-
Olga Kornievskaia authored
Currently, the server does all copies as NFS_UNSTABLE. For synchronous copies linux client will append a COMMIT to the COPY compound but for async copies it does not (because COMMIT needs to be done after all bytes are copied and not as a reply to the COPY operation). However, in order to save the client doing a COMMIT as a separate rpc, the server can reply back with NFS_FILE_SYNC copy. This patch proposed to add vfs_fsync() call at the end of the async copy. Signed-off-by:
Olga Kornievskaia <kolga@netapp.com> Signed-off-by:
-
J. Bruce Fields authored
The commit may be time-consuming and there's no need to hold the lock for it. More of these are possible, these were just some easy ones. Signed-off-by: -
Yu Hsiang Huang authored
Truncation of an unlinked inode may take a long time for I/O waiting, and it doesn't have to prevent access to the directory. Thus, let truncation occur outside the directory's mutex, just like do_unlinkat() does. Signed-off-by:
Yu Hsiang Huang <nickhuang@synology.com> Signed-off-by:
Bing Jing Chang <bingjingc@synology.com> Signed-off-by:
Robbie Ko <robbieko@synology.com> Signed-off-by:
-
- 18 May, 2021 24 commits
-
-
Chuck Lever authored
Clean-up: Re-order the display of IP address and client ID to be consistent with other _cb_ tracepoints. Signed-off-by:
-
Chuck Lever authored
Clean up: These are noise in properly working systems. If you really need to observe the operation of the callback mechanism, use the sunrpc:rpc\* tracepoints along with the workqueue tracepoints. Signed-off-by:
-
Chuck Lever authored
Record a tracepoint event when the server performs a callback probe. This event can be enabled as a group with other nfsd_cb tracepoints. Signed-off-by:
-
Chuck Lever authored
Renamed so it can be enabled as a set with the other nfsd_cb_ tracepoints. And, consistent with those tracepoints, report the address of the client, the client ID the server has given it, and the state ID being recalled. Signed-off-by:
-
Chuck Lever authored
Record the arguments of CB_OFFLOAD callbacks so we can better observe asynchronous copy-offload behavior. For example: nfsd-995 [008] 7721.934222: nfsd_cb_offload: addr=192.168.2.51:0 client 6092a47c:35a43fc1 fh_hash=0x8739113a count=116528 status=0 Signed-off-by: -
Chuck Lever authored
When the server kicks off a CB_LM_NOTIFY callback, record its arguments so we can better observe asynchronous locking behavior. For example: nfsd-998 [002] 1471.705873: nfsd_cb_notify_lock: addr=192.168.2.51:0 client 6092a47c:35a43fc1 fh_hash=0x8950b23a Signed-off-by: -
Chuck Lever authored
Display the transport protocol and authentication flavor so admins can see what they might be getting wrong. Signed-off-by:
-
Chuck Lever authored
This path is not really an error path, so the tracepoint I added there is just noise. Signed-off-by:
-
Chuck Lever authored
Show when the upper layer requested a shutdown. RPC tracepoints can already show when rpc_shutdown_client() is called. Signed-off-by:
-
Chuck Lever authored
Provide more clarity about when the callback channel is in trouble. Signed-off-by:
-
Chuck Lever authored
TRACE_DEFINE_ENUM() is necessary for enum {} but not for C macros. Signed-off-by: -
Chuck Lever authored
We were missing one. As a clean-up, add a helper that sets the new CB state and fires a tracepoint. The tracepoint fires only when the state changes, to help reduce trace log noise. Signed-off-by:
-
Chuck Lever authored
Enable knfsd_fh_hash() to be invoked in functions where the filehandle pointer is a const. Signed-off-by:
-
Chuck Lever authored
Some of the most common cases are traced. Enough infrastructure is now in place that more can be added later, as needed. Signed-off-by:
-
Chuck Lever authored
Signed-off-by:
-
Chuck Lever authored
Improve observation of NFSv4 lease expiry. Signed-off-by:
-
Chuck Lever authored
Record client-requested termination of client IDs. Signed-off-by:
-
Chuck Lever authored
Signed-off-by:
-
Chuck Lever authored
This replaces a dprintk call site in order to get greater visibility on when client IDs are confirmed or re-used. Simple example: nfsd-995 [000] 126.622975: nfsd_compound: xid=0x3a34e2b1 opcnt=1 nfsd-995 [000] 126.623005: nfsd_cb_args: addr=192.168.2.51:45901 client 60958e3b:9213ef0e prog=1073741824 ident=1 nfsd-995 [000] 126.623007: nfsd_compound_status: op=1/1 OP_SETCLIENTID status=0 nfsd-996 [001] 126.623142: nfsd_compound: xid=0x3b34e2b1 opcnt=1 >>>> nfsd-996 [001] 126.623146: nfsd_clid_confirmed: client 60958e3b:9213ef0e nfsd-996 [001] 126.623148: nfsd_cb_probe: addr=192.168.2.51:45901 client 60958e3b:9213ef0e state=UNKNOWN nfsd-996 [001] 126.623154: nfsd_compound_status: op=1/1 OP_SETCLIENTID_CONFIRM status=0 Signed-off-by: -
Chuck Lever authored
This tracepoint has been replaced by nfsd_clid_cred_mismatch and nfsd_clid_verf_mismatch, and can simply be removed. Signed-off-by:
-
Chuck Lever authored
Record when a client presents a different boot verifier than the one we know about. Typically this is a sign the client has rebooted, but sometimes it signals a conflicting client ID, which the client's administrator will need to address. Signed-off-by:
-
Chuck Lever authored
Record when a client tries to establish a lease record but uses an unexpected credential. This is often a sign of a configuration problem. Signed-off-by:
-
Chuck Lever authored
To be used in subsequent patches. Signed-off-by:
-
Chuck Lever authored
Since commit 9a6944fe ("tracing: Add a verifier to check string pointers for trace events"), which was merged in v5.13-rc1, TP_printk() no longer tacitly supports the "%.*s" format specifier. These are low value tracepoints, so just remove them. Reported-by:
-
