Commits · ccb7b08fbbb85e9b0bb2867497d98172a5737ad5 · Kirill Smelkov / linux

01 Jan, 2024 40 commits

bcachefs: trans_for_each_path() no longer uses path->idx · ccb7b08f

Kent Overstreet authored Dec 10, 2023

path->idx is now a code smell: we should be using path_idx_t, since it's
stable across btree path reallocation.

This is also a bit faster, using the same loop counter vs. fetching
path->idx from each path we iterate over.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

ccb7b08f

bcachefs: kill trans_for_each_path_from() · 4c5289e6
Kent Overstreet authored Dec 10, 2023
```
dead code
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4c5289e6
bcachefs: bch2_btree_path_to_text() -> btree_path_idx_t · 311e446a
Kent Overstreet authored Dec 10, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
311e446a
bcachefs: struct trans_for_each_path_inorder_iter · 1f75ba4e
Kent Overstreet authored Dec 10, 2023
```
reducing our usage of path->idx
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
1f75ba4e
bcachefs: btree_insert_entry -> btree_path_idx_t · 7f9821a7
Kent Overstreet authored Dec 10, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
7f9821a7
bcachefs: btree_iter -> btree_path_idx_t · 07f383c7
Kent Overstreet authored Dec 04, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
07f383c7
bcachefs: btree_path_alloc() -> btree_path_idx_t · 788cc25d
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
788cc25d
bcachefs: bch2_btree_path_traverse() -> btree_path_idx_t · 96ed47d1
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
96ed47d1
bcachefs: bch2_btree_path_make_mut() -> btree_path_idx_t · f6363aca
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
f6363aca
bcachefs: bch2_btree_path_set_pos() -> btree_path_idx_t · 4617d946
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4617d946
bcachefs; bch2_path_put() -> btree_path_idx_t · 74e600c1
Kent Overstreet authored Dec 10, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
74e600c1
bcachefs: bch2_path_get() -> btree_path_idx_t · 255ebbbf
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
255ebbbf
bcachefs: minor bch2_btree_path_set_pos() optimization · 5ce8b92d
Kent Overstreet authored Dec 08, 2023
```
bpos_eq() is cheaper than bpos_cmp()
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
5ce8b92d
bcachefs: Kill GFP_NOFAIL usage in readahead path · 4753bdeb
Kent Overstreet authored Dec 20, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4753bdeb

bcachefs: Convert split_devs() to darray · 806ebf2a

Kent Overstreet authored Dec 22, 2023

Bit of cleanup & modernization: also moving this code to util.c, it'll
be used by userspace as well.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

806ebf2a

bcachefs: skip journal more often in key cache reclaim · 0c0ba8e9
Kent Overstreet authored Dec 19, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
0c0ba8e9
bcachefs: for_each_keylist_key() declares loop iter · 1a2a9f9f
Kent Overstreet authored Dec 21, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
1a2a9f9f
bcachefs: bkey_for_each_ptr() now declares loop iter · 0beebd92
Kent Overstreet authored Dec 21, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
0beebd92
bcachefs: kill __bch2_btree_iter_peek_upto_and_restart() · 0bc64d7e
Kent Overstreet authored Dec 17, 2023
```
dead code
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
0bc64d7e
bcachefs: fsck -> bch2_trans_run() · 4eb3877e
Kent Overstreet authored Dec 17, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4eb3877e
bcachefs: vstruct_for_each() now declares loop iter · cea07a7b
Kent Overstreet authored Dec 17, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
cea07a7b
bcachefs: for_each_member_device_rcu() now declares loop iter · 41b84fb4
Kent Overstreet authored Dec 17, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
41b84fb4
bcachefs: for_each_member_device() now declares loop iter · 9fea2274
Kent Overstreet authored Dec 16, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
9fea2274
bcachefs: for_each_btree_key() now declares loop iter · 80eab7a7
Kent Overstreet authored Dec 16, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
80eab7a7
bcachefs: kill for_each_btree_key_norestart() · c47e8bfb
Kent Overstreet authored Dec 16, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
c47e8bfb
bcachefs: kill for_each_btree_key_old_upto() · 44ddd8ad
Kent Overstreet authored Dec 16, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
44ddd8ad
bcachefs: for_each_btree_key_upto() -> for_each_btree_key_old_upto() · 3a860b5a
Kent Overstreet authored Dec 16, 2023
```
And for_each_btree_key2_upto -> for_each_btree_key_upto
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
3a860b5a
bcachefs: bch2_dirent_lookup() -> lockrestart_do() · c8ef2dc2
Kent Overstreet authored Dec 17, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
c8ef2dc2
bcachefs: bch2_trans_srcu_lock() should be static · 79904fa2
Kent Overstreet authored Dec 11, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
79904fa2
bcachefs: use track_event_change() for allocator blocked stats · 6d5c606c
Kent Overstreet authored Dec 11, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
6d5c606c
bcachefs: fix warning about uninitialized time_stats · ef23397c
Kent Overstreet authored Dec 23, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
ef23397c
bcachefs: add more verbose logging · e34ec13a
Kent Overstreet authored Dec 23, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
e34ec13a
bcachefs: better error message in btree_node_write_work() · 53b67d8d
Kent Overstreet authored Dec 23, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
53b67d8d
bcachefs: simplify bch_devs_list · 037a2d9f
Kent Overstreet authored Dec 23, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
037a2d9f
bcachefs: darray_for_each() now declares loop iter · defd9e39
Kent Overstreet authored Dec 16, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
defd9e39
bcachefs: trans_for_each_update() now declares loop iter · 559e6c23
Kent Overstreet authored Dec 16, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
559e6c23
bcachefs: Improve the nopromote tracepoint · cee0a8ea
Kent Overstreet authored Dec 20, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
cee0a8ea

bcachefs: Use GFP_KERNEL for promote allocations · 1ad36a01

Kent Overstreet authored Dec 20, 2023

We already have btree locks dropped here - no need for GFP_NOFS.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

1ad36a01

bcachefs: mean and variance: fix kernel-doc for function params · 92038825

Randy Dunlap authored Dec 19, 2023

Add missing function parameter descriptions in mean_and_variance.c.
The also eliminates the "Excess function parameter" warnings.

Prevents these kernel-doc warnings:

mean_and_variance.c:67: warning: Function parameter or member 's' not described in 'mean_and_variance_get_mean'
mean_and_variance.c:78: warning: Function parameter or member 's1' not described in 'mean_and_variance_get_variance'
mean_and_variance.c:94: warning: Function parameter or member 's' not described in 'mean_and_variance_get_stddev'
mean_and_variance.c:108: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_update'
mean_and_variance.c:108: warning: Function parameter or member 'x' not described in 'mean_and_variance_weighted_update'
mean_and_variance.c:108: warning: Excess function parameter 's1' description in 'mean_and_variance_weighted_update'
mean_and_variance.c:108: warning: Excess function parameter 's2' description in 'mean_and_variance_weighted_update'
mean_and_variance.c:134: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_get_mean'
mean_and_variance.c:143: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_get_variance'
mean_and_variance.c:153: warning: Function parameter or member 's' not described in 'mean_and_variance_weighted_get_stddev'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Brian Foster <bfoster@redhat.com>
Cc: linux-bcachefs@vger.kernel.org
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

92038825

bcachefs: check for failure to downgrade · 447c1c01

Kent Overstreet authored Dec 22, 2023

With the upcoming member seq patch, it's now critical that we don't ever
write to a superblock that hasn't been version downgraded - failure to
update member seq fields will cause split brain detection to fire
erroniously.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

447c1c01