1. 22 Jul, 2020 3 commits
  2. 20 Jul, 2020 37 commits
    • Artur Rojek's avatar
      IIO: Ingenic JZ47xx: Add touchscreen mode. · b96952f4
      Artur Rojek authored
      The SADC component in JZ47xx SoCs provides support for touchscreen
      operations (pen position and pen down pressure) in single-ended and
      differential modes.
      
      The touchscreen component of SADC takes a significant time to stabilize
      after first receiving the clock and a delay of 50ms has been empirically
      proven to be a safe value before data sampling can begin.
      
      Of the known hardware to use this controller, GCW Zero and Anbernic RG-350
      utilize the touchscreen mode by having their joystick(s) attached to the
      X/Y positive/negative input pins.
      
      JZ4770 and later SoCs introduce a low-level command feature. With it, up
      to 32 commands can be programmed, each one corresponding to a sampling
      job. It allows to change the low-voltage reference, the high-voltage
      reference, have them connected to VCC, GND, or one of the X-/X+ or Y-/Y+
      pins.
      
      This patch introduces support for 6 stream-capable channels:
      - channel #0 samples X+/GND
      - channel #1 samples Y+/GND
      - channel #2 samples X-/GND
      - channel #3 samples Y-/GND
      - channel #4 samples X+/X-
      - channel #5 samples Y+/Y-
      
      Being able to sample X-/GND and Y-/GND is useful on some devices, where
      one joystick is connected to the X+/Y+ pins, and a second joystick is
      connected to the X-/Y- pins.
      
      All the boards which probe this driver have the interrupt provided from
      Device Tree, with no need to handle a case where the IRQ was not provided.
      Co-developed-by: default avatarPaul Cercueil <paul@crapouillou.net>
      Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
      Signed-off-by: default avatarArtur Rojek <contact@artur-rojek.eu>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      b96952f4
    • Artur Rojek's avatar
      dt-bindings: iio/adc: Add touchscreen idx for JZ47xx SoC ADC · 84224720
      Artur Rojek authored
      Introduce support for touchscreen channels found in JZ47xx SoCs.
      Signed-off-by: default avatarArtur Rojek <contact@artur-rojek.eu>
      Tested-by: default avatarPaul Cercueil <paul@crapouillou.net>
      Acked-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      84224720
    • Paul Cercueil's avatar
      iio/adc: ingenic: Retrieve channels list from soc data struct · 6a294b41
      Paul Cercueil authored
      Instead of having one array of struct iio_chan_spec for all SoCs, and
      have some SoCs remove the last item of the array as they can't use it,
      have each SoC define its array of supported channels.
      Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
      Tested-by: default avatarArtur Rojek <contact@artur-rojek.eu>
      Signed-off-by: default avatarArtur Rojek <contact@artur-rojek.eu>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      6a294b41
    • Artur Rojek's avatar
      IIO: Ingenic JZ47xx: Add xlate cb to retrieve correct channel idx · 155e41ef
      Artur Rojek authored
      Provide an of_xlate callback in order to retrieve the correct channel
      specifier index from the IIO channels array.
      Signed-off-by: default avatarArtur Rojek <contact@artur-rojek.eu>
      Tested-by: default avatarPaul Cercueil <paul@crapouillou.net>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      155e41ef
    • Artur Rojek's avatar
      IIO: Ingenic JZ47xx: Error check clk_enable calls. · 1a99dc46
      Artur Rojek authored
      Introduce error checks for the clk_enable calls used in this driver.
      As part of the changes, move clk_enable/clk_disable calls out of
      ingenic_adc_set_config and into respective logic of its callers.
      Signed-off-by: default avatarArtur Rojek <contact@artur-rojek.eu>
      Tested-by: default avatarPaul Cercueil <paul@crapouillou.net>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      1a99dc46
    • Jonathan Cameron's avatar
      dt-bindings: iio: ti,ads8688 yaml conversion · 79233bdc
      Jonathan Cameron authored
      Fairly simple binding.  Most of the changes were filling in information
      not previously found in the binding.  I dropped the previous explicit
      mention of spi-max-frequency as that is covered by the generic SPI
      binding.
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      Acked-by: default avatarSean Nyekjaer <sean@geanix.com>
      Reviewed-by: default avatarRob Herring <robh@kernel.org>
      79233bdc
    • Icenowy Zheng's avatar
      iio: light: stk3310: add chip id for STK3311-X variant · 5ef8f84a
      Icenowy Zheng authored
      The STK3311 chip has a variant called STK3311-X, which has a different
      chip id of 0x12.
      
      Add the chip id to the driver.
      Signed-off-by: default avatarIcenowy Zheng <icenowy@aosc.io>
      Signed-off-by: default avatarOndrej Jirman <megous@megous.com>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      5ef8f84a
    • Jonathan Cameron's avatar
      dt-bindings: iio: accel: kionix,kxsd9 yaml conversion. · 2f545257
      Jonathan Cameron authored
      Convert and flesh out a bit the binding docs for this simple 3 axis
      accelerometer.
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      Reviewed-by: default avatarRob Herring <robh@kernel.org>
      2f545257
    • Alexandru Ardelean's avatar
      iio: adc: ad7192: move ad7192_of_match table closer to the end of the file · 3eca1d26
      Alexandru Ardelean authored
      The change is more cosmetic. There is no need to reference this table in
      the probe function since 'of_device_get_match_data' is used, which obtains
      this information from the driver object.
      Signed-off-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      3eca1d26
    • Lee Jones's avatar
      iio: adc: rockchip_saradc: Demote seemingly unintentional kerneldoc header · 2c7c8dce
      Lee Jones authored
      This is the only use of kerneldoc in the source file and no
      descriptions are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller'
      
      Cc: Philipp Zabel <p.zabel@pengutronix.de>
      Cc: linux-rockchip@lists.infradead.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      2c7c8dce
    • Lee Jones's avatar
      iio: imu: st_lsm6dsx: st_lsm6dsx: Mark 'st_lsm6dsx_accel_ext_info' as __maybe_unused · 82cf139f
      Lee Jones authored
      It doesn't make sense to move it into '*core*' as it's co-located with
      other, similar definitions which are used in multiple locations.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c:17:
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=]
       497 | static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = {
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       In file included from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c:17:
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=]
       497 | static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = {
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       In file included from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c:16:
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=]
       497 | static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = {
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
      Cc: Denis Ciocca <denis.ciocca@st.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      82cf139f
    • Lee Jones's avatar
      iio: imu: st_lsm6dsx: st_lsm6dsx_shub: Demote obvious misuse of kerneldoc to... · 83625def
      Lee Jones authored
      iio: imu: st_lsm6dsx: st_lsm6dsx_shub: Demote obvious misuse of kerneldoc to standard comment blocks
      
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:174: warning: Function parameter or member 'hw' not described in 'st_lsm6dsx_shub_read_output'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:174: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_read_output'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:174: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_read_output'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'hw' not described in 'st_lsm6dsx_shub_write_reg'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'addr' not described in 'st_lsm6dsx_shub_write_reg'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_write_reg'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:205: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_write_reg'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'sensor' not described in 'st_lsm6dsx_shub_read'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'addr' not described in 'st_lsm6dsx_shub_read'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_read'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:285: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_read'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'sensor' not described in 'st_lsm6dsx_shub_write'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'addr' not described in 'st_lsm6dsx_shub_write'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'data' not described in 'st_lsm6dsx_shub_write'
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:335: warning: Function parameter or member 'len' not described in 'st_lsm6dsx_shub_write'
      
      Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      83625def
    • Lee Jones's avatar
      iio: magnetometer: ak8974: Add description for ak8974's 'scan' attribute · 5497523e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/magnetometer/ak8974.c:200: warning: Function parameter or member 'scan' not described in 'ak8974'
      
      Cc: Linus Walleij <linus.walleij@linaro.org>
      Cc: Samu Onkalo <samu.p.onkalo@nokia.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      5497523e
    • Lee Jones's avatar
      iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description · 8f0f0f2c
      Lee Jones authored
      Kerneldoc is only suitable for documenting functions and struct/enums.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL'
       drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL'
       drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL'
       drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL'
       drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc'
      
      Cc: Andy Gross <agross@kernel.org>
      Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
      Cc: Linus Walleij <linus.walleij@linaro.org>
      Cc: linux-arm-msm@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      8f0f0f2c
    • Lee Jones's avatar
      iio: imu: inv_mpu6050: inv_mpu_ring: Demote seemingly unintentional kerneldoc header · 3c979784
      Lee Jones authored
      This is the only use of kerneldoc in the source file and no
      descriptions are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:118: warning: Function parameter or member 'irq' not described in 'inv_mpu6050_read_fifo'
       drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:118: warning: Function parameter or member 'p' not described in 'inv_mpu6050_read_fifo'
      
      Cc: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      3c979784
    • Lee Jones's avatar
      iio: imu: inv_mpu6050: inv_mpu_core: Demote obvious misuse of kerneldoc to standard comment blocks · ecf8d08f
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf_regs'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'val' not described in 'inv_mpu6050_set_lpf_regs'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:480: warning: Function parameter or member 'indio_dev' not described in 'inv_mpu6050_init_config'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'rate' not described in 'inv_mpu6050_set_lpf'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'dev' not described in 'inv_mpu6050_fifo_rate_store'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'attr' not described in 'inv_mpu6050_fifo_rate_store'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'buf' not described in 'inv_mpu6050_fifo_rate_store'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'count' not described in 'inv_mpu6050_fifo_rate_store'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'dev' not described in 'inv_fifo_rate_show'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'attr' not described in 'inv_fifo_rate_show'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'buf' not described in 'inv_fifo_rate_show'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'dev' not described in 'inv_attr_show'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'attr' not described in 'inv_attr_show'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'buf' not described in 'inv_attr_show'
       drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:1282: warning: Function parameter or member 'st' not described in 'inv_check_and_setup_chip'
      
      Cc: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      ecf8d08f
    • Lee Jones's avatar
      iio: adc: palmas_gpadc: Demote non-conforming kerneldoc header · 315482a5
      Lee Jones authored
      Very few of the struct attributes have been documented here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'dev' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'palmas' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq_auto_0' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'irq_auto_1' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'adc_info' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'conv_completion' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup1_data' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup2_data' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup1_enable' not described in 'palmas_gpadc'
       drivers/iio/adc/palmas_gpadc.c:114: warning: Function parameter or member 'wakeup2_enable' not described in 'palmas_gpadc'
      
      Cc: Pradeep Goudagunta <pgoudagunta@nvidia.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      315482a5
    • Lee Jones's avatar
      iio: adc: max9611: Demote obvious misuse of kerneldoc to standard comment blocks · 922fdc19
      Lee Jones authored
      No attempt has been made to document any of the demoted structs here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/max9611.c:117: warning: cannot understand function prototype: 'const unsigned int max9611_mux_conf[][2] = '
       drivers/iio/adc/max9611.c:145: warning: cannot understand function prototype: 'const unsigned int max9611_gain_conf[][2] = '
      
      Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
      Cc: Geert Uytterhoeven <geert+renesas@glider.be>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      922fdc19
    • Lee Jones's avatar
      iio: adc: max1363: Fix kerneldoc attribute formatting for 'lock' · ea448671
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/max1363.c:190: warning: Function parameter or member 'lock' not described in 'max1363_state'
      
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Rohit Sarkar <rohitsarkar5398@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      ea448671
    • Lee Jones's avatar
      iio: imu: st_lsm6dsx: st_lsm6dsx: Reorder 'inline' declaration · deb38af4
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:487:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
       drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:497:44: warning: ‘st_lsm6dsx_accel_ext_info’ defined but not used [-Wunused-const-variable=]
      
      Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
      Cc: Denis Ciocca <denis.ciocca@st.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      deb38af4
    • Lee Jones's avatar
      iio: gyro: fxas21002c: Move 'fxas21002c_reg_fields' to the only file its used · bfec5753
      Lee Jones authored
      'fxas21002c_reg_fields' is only used in '*core*', meaning that '*i2c*'
      and '*spi*' complain of a defined but not used const variable.  Let's
      move it into the source file.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from drivers/iio/gyro/fxas21002c_i2c.c:14:
       drivers/iio/gyro/fxas21002c.h:79:31: warning: ‘fxas21002c_reg_fields’ defined but not used [-Wunused-const-variable=]
       79 | static const struct reg_field fxas21002c_reg_fields[] = {
       | ^~~~~~~~~~~~~~~~~~~~~
       In file included from drivers/iio/gyro/fxas21002c_spi.c:14:
       drivers/iio/gyro/fxas21002c.h:79:31: warning: ‘fxas21002c_reg_fields’ defined but not used [-Wunused-const-variable=]
       79 | static const struct reg_field fxas21002c_reg_fields[] = {
       | ^~~~~~~~~~~~~~~~~~~~~
      
      Cc: Rui Miguel Silva <rmfrfs@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      bfec5753
    • Lee Jones's avatar
      iio: accel: sca3000: Fix 2 misspellings and demote nonconforming kerneldocs · fb37b5f8
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/accel/sca3000.c:210: warning: Function parameter or member 'mot_det_mult_xz' not described in 'sca3000_chip_info'
       drivers/iio/accel/sca3000.c:210: warning: Function parameter or member 'mot_det_mult_y' not described in 'sca3000_chip_info'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'indio_dev' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'chan' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'type' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'dir' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'info' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'val' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:871: warning: Function parameter or member 'val2' not described in 'sca3000_read_event_value'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'indio_dev' not described in 'sca3000_read_event_config'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'chan' not described in 'sca3000_read_event_config'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'type' not described in 'sca3000_read_event_config'
       drivers/iio/accel/sca3000.c:1110: warning: Function parameter or member 'dir' not described in 'sca3000_read_event_config'
      
      Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      fb37b5f8
    • Lee Jones's avatar
      iio: adc: cpcap-adc: Demote seemingly unintentional kerneldoc header · 95d61a67
      Lee Jones authored
      None of the headers demoted here provide any descriptions.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'ato_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'adc_ps_factor_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_ps_factor_in' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'ato_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'adc_ps_factor_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:100: warning: Function parameter or member 'atox_ps_factor_out' not described in 'cpcap_adc_ato'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD0' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTP' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_VBUS' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD3' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BPLUS_AD4' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_CHG_ISENSE' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTI' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_USB_ID' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD8' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_AD9' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_LICELL' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_HV_BATTP' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSX1_AD12' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSX2_AD13' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSY1_AD14' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_TSY2_AD15' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTP_PI16' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_BATTI_PI17' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:153: warning: Enum value 'CPCAP_ADC_CHANNEL_NUM' not described in enum 'cpcap_adc_channel'
       drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_IMM' not described in enum 'cpcap_adc_timing'
       drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_IN' not described in enum 'cpcap_adc_timing'
       drivers/iio/adc/cpcap-adc.c:165: warning: Enum value 'CPCAP_ADC_TIMING_OUT' not described in enum 'cpcap_adc_timing'
      
      Cc: Tony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      95d61a67
    • Lee Jones's avatar
      iio: adc: at91-sama5d2_adc: Struct kerneldoc titles need to start with 'struct ' · 62eebcb6
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/at91-sama5d2_adc.c:360: warning: cannot understand function prototype: 'struct at91_adc_dma '
       drivers/iio/adc/at91-sama5d2_adc.c:379: warning: cannot understand function prototype: 'struct at91_adc_touch '
      
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Cc: Eugen Hristev <eugen.hristev@microchip.com>
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      62eebcb6
    • Lee Jones's avatar
      iio: adc: at91_adc: Fix 'bad line' warning · 4ab559a6
      Lee Jones authored
      All lines should start with ' *'.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/at91_adc.c:160: warning: bad line:                         (Interruptions registers mostly)
      
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      4ab559a6
    • Lee Jones's avatar
      iio: dac: ad5504: Fix formatting errors and demote non-compliant kerneldoc · 57f335cf
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mask' not described in 'ad5504_state'
       drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5504_state'
       drivers/iio/dac/ad5504.c:64: warning: cannot understand function prototype: 'enum ad5504_supported_device_ids '
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      57f335cf
    • Lee Jones's avatar
      iio: adc: ad799x: Demote seemingly unintentional kerneldoc header · 7574f1b4
      Lee Jones authored
      This is the only use of function related kerneldoc in the sourcefile
      and no descriptions are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/ad799x.c:192: warning: Function parameter or member 'irq' not described in 'ad799x_trigger_handler'
       drivers/iio/adc/ad799x.c:192: warning: Function parameter or member 'p' not described in 'ad799x_trigger_handler'
      
      Cc: Michael Hennerich <Michael.Hennerich@analog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      7574f1b4
    • Lee Jones's avatar
      iio: light: us5182d: Fix formatting in kerneldoc function block · f356615f
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/light/us5182d.c:457: warning: Function parameter or member 'data' not described in 'us5182d_update_dark_th'
       drivers/iio/light/us5182d.c:457: warning: Function parameter or member 'index' not described in 'us5182d_update_dark_th'
       drivers/iio/light/us5182d.c:479: warning: Function parameter or member 'data' not described in 'us5182d_apply_scale'
       drivers/iio/light/us5182d.c:479: warning: Function parameter or member 'index' not described in 'us5182d_apply_scale'
      
      Cc: Adriana Reus <adriana.reus@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      f356615f
    • Lee Jones's avatar
      iio: temperature: mlx90632: Function parameter descriptions must match exactly · 7390192b
      Lee Jones authored
      '*'s are not welcome in kerneldoc parameter names.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/temperature/mlx90632.c:175: warning: Function parameter or member 'data' not described in 'mlx90632_perform_measurement'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarCrt Mori <cmo@melexis.com>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      7390192b
    • Lee Jones's avatar
      iio: light: si1145: Demote obvious misuse of kerneldoc to standard comment blocks · 43b0f929
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/light/si1145.c:192: warning: Function parameter or member 'data' not described in '__si1145_command_reset'
       drivers/iio/light/si1145.c:228: warning: Function parameter or member 'data' not described in 'si1145_command'
       drivers/iio/light/si1145.c:228: warning: Function parameter or member 'cmd' not described in 'si1145_command'
       drivers/iio/light/si1145.c:1186: warning: Function parameter or member 'trig' not described in 'si1145_trigger_set_state'
       drivers/iio/light/si1145.c:1186: warning: Function parameter or member 'state' not described in 'si1145_trigger_set_state'
      
      Cc: Chuhong Yuan <hslester96@gmail.com>
      Cc: Dan Leonard <leonard.crestez@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      43b0f929
    • Lee Jones's avatar
      iio: dac: ltc2632: Fix formatting in kerneldoc struct header · 0f2a3461
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'powerdown_cache_mask' not described in 'ltc2632_state'
       drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vref_mv' not described in 'ltc2632_state'
       drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vref_reg' not described in 'ltc2632_state'
      
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
      Cc: Silvan Murer <silvan.murer@gmail.com>
      Cc: Maxime Roussin-Belanger <maxime.roussinbelanger@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      0f2a3461
    • Lee Jones's avatar
      iio: adc: twl6030-gpadc: Fix some misdocumentation and formatting issues · dd54f40a
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'ideal' not described in 'twl6030_gpadc_platform_data'
       drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'channel_to_reg' not described in 'twl6030_gpadc_platform_data'
      
      Cc: Stephen Boyd <swboyd@chromium.org>
      Cc: Nishant Kamat <nskamat@ti.com>
      Cc: Balaji T K <balajitk@ti.com>
      Cc: Graeme Gregory <gg@slimlogic.co.uk>
      Cc: Girish S Ghongdemath <girishsg@ti.com>
      Cc: Ambresh K <ambresh@ti.com>
      Cc: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
      Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      dd54f40a
    • Lee Jones's avatar
      iio: magnetometer: hmc5843: 'hmc5843_pm_ops' is unused in 1 of 3 files including hmc5843_core.h · 5e2b006d
      Lee Jones authored
      We know that it's okay for 'hmc5843_pm_ops' to be unused here.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from include/linux/device.h:25,
       from include/linux/iio/iio.h:10,
       from drivers/iio/magnetometer/hmc5843_core.c:16:
       drivers/iio/magnetometer/hmc5843.h:55:26: warning: ‘hmc5843_pm_ops’ defined but not used [-Wunused-const-variable=]
       55 | static SIMPLE_DEV_PM_OPS(hmc5843_pm_ops,
       | ^~~~~~~~~~~~~~
       include/linux/pm.h:354:25: note: in definition of macro ‘SIMPLE_DEV_PM_OPS’
       354 | const struct dev_pm_ops name = { | ^~~~
      
      Cc: Josef Gajdusek <atx@atx.name>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      5e2b006d
    • Lee Jones's avatar
      iio: adc: twl4030-madc: Fix misnamed struct attribute · 2006cf16
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/twl4030-madc.c:170: warning: Function parameter or member 'usb3v1' not described in 'twl4030_madc_data'
      
      Also drop a duplicate description of the lock.
      
      Cc: J Keerthy <j-keerthy@ti.com>
      Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com>
      Cc: Amit Kucheria <amit.kucheria@canonical.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      2006cf16
    • Lee Jones's avatar
      iio: adc: twl4030-madc: Remove set but unused variables 'len' · 8856d5c7
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/twl4030-madc.c: In function ‘twl4030_madc_threaded_irq_handler’:
       drivers/iio/adc/twl4030-madc.c:475:9: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
       475 | int i, len, ret;
       | ^~~
      
      Cc: Sebastian Reichel <sre@kernel.org>
      Cc: J Keerthy <j-keerthy@ti.com>
      Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com>
      Cc: Amit Kucheria <amit.kucheria@canonical.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      8856d5c7
    • Lee Jones's avatar
      iio: adc: ti_am335x_adc: Remove a couple of unused 'read' variables · f83d87a0
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/adc/ti_am335x_adc.c: In function ‘tiadc_buffer_preenable’:
       drivers/iio/adc/ti_am335x_adc.c:297:21: warning: variable ‘read’ set but not used [-Wunused-but-set-variable]
       297 | int i, fifo1count, read;
       | ^~~~
       drivers/iio/adc/ti_am335x_adc.c: In function ‘tiadc_buffer_predisable’:
       drivers/iio/adc/ti_am335x_adc.c:346:21: warning: variable ‘read’ set but not used [-Wunused-but-set-variable]
       346 | int fifo1count, i, read;
       | ^~~~
      
      Cc: Rachna Patil <rachna@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      f83d87a0
    • Lee Jones's avatar
      iio: imu: kmx61: Fix formatting in kerneldoc function headers · 0d674449
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'data' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'mode' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'device' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'update' not described in 'kmx61_set_mode'
       drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'data' not described in 'kmx61_set_power_state'
       drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'on' not described in 'kmx61_set_power_state'
       drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'device' not described in 'kmx61_set_power_state'
      
      Cc: Daniel Baluta <daniel.baluta@intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
      0d674449