- 26 Jun, 2017 2 commits
-
-
Deepa Dinamani authored
As we change the user space type for the timerfd and posix timer functions to newer data types, we need some form of conversion helpers to avoid duplicating that logic. Suggested-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
Deepa Dinamani <deepa.kernel@gmail.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
Deepa Dinamani authored
Add helper functions to convert between struct timespec64 and struct timespec at userspace boundaries. This is a preparatory patch to use timespec64 as the basic type internally in the kernel as timespec is not y2038 safe on 32 bit systems. The patch helps the cause by containing all data conversions at the userspace boundaries within these functions. Suggested-by:
-
- 13 Jun, 2017 18 commits
-
-
Thomas Gleixner authored
No nanosleep implementation modifies the rqtp argument. Mark is const. Signed-off-by:Thomas Gleixner <tglx@linutronix.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: John Stultz <john.stultz@linaro.org> Cc: Peter Zijlstra <peterz@infradead.org>
-
Thomas Gleixner authored
No point in converting the expiry time back and forth. No point either to update the value in the caller supplied variable. mark the rqtp argument const. Signed-off-by: -
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Move them to the native implementations and get rid of the set_fs() hackery. Signed-off-by:
-
Al Viro authored
get rid of set_fs(), sanitize compat copyin/copyout. Signed-off-by:
-
Al Viro authored
... and get rid of set_fs() in there Signed-off-by:
-
Al Viro authored
... and get rid of set_fs() in there Signed-off-by:
-
Al Viro authored
Get rid of set_fs() mess and sanitize compat_{get,put}_timex(), while we are at it. Signed-off-by: -
Al Viro authored
No more users. Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Turn restart_block.nanosleep.{rmtp,compat_rmtp} into a tagged union (kind = 1 -> native, kind = 2 -> compat, kind = 0 -> nothing) and make the places doing actual copyout handle compat as well as native (that will become a helper in the next commit). Result: compat wrappers, messing with reassignments, etc. are gone. [ tglx: Folded in a variant of Peter Zijlstras enum patch ] Signed-off-by: -
Al Viro authored
... instead of doing that in every ->nsleep() instance Signed-off-by:
-
Al Viro authored
The hrtimer nanosleep() implementation can be simplified by moving the copy out of the remaining time to do_nanosleep() which is shared between the real nanosleep function and the restart function. The pointer to the timespec64 which is updated is already stored in the restart block at the call site, so the seperate handling of nanosleep and restart function can be avoided. [ tglx: Added changelog ] Signed-off-by:
-
Al Viro authored
Store the pointer to the timespec which gets updated with the remaining time in the restart block and remove the function argument. [ tglx: Added changelog ] Signed-off-by:
-
Al Viro authored
The alarmtimer nanosleep() implementation can be simplified by moving the copy out of the remaining time to alarmtimer_do_nsleep() which is shared between the real nanosleep function and the restart function. The pointer to the timespec64 which is updated has to be stored in the restart block anyway. Instead of storing it only in the restart case, store it before calling alarmtimer_do_nsleep() and copy the remaining time in the signal exit path. [ tglx: Added changelog ] Signed-off-by:
-
Al Viro authored
The posix-cpu-timer nanosleep() implementation can be simplified by moving the copy out of the remaining time to do_cpu_nanosleep() which is shared between the real nanosleep function and the restart function. The pointer to the timespec64 which is updated has to be stored in the restart block anyway. Instead of storing it only in the restart case, store it before calling do_cpu_nanosleep() and copy the remaining time in the signal exit path. [ tglx: Added changelog ] Signed-off-by:
-
- 12 Jun, 2017 3 commits
-
-
Thomas Gleixner authored
The recent rework of the posix timer internals broke the magic posix mechanism, which requires that relative timers are not affected by modifications of the underlying clock. That means relative CLOCK_REALTIME timers cannot use CLOCK_REALTIME, because that can be set and adjusted. The underlying hrtimer switches the clock for these timers to CLOCK_MONOTONIC. That still works, but reading the remaining time of such a timer has been broken in the rework. The old code used the hrtimer internals directly and avoided the posix clock callbacks. Now common_timer_get() uses the underlying kclock->timer_get() callback, which is still CLOCK_REALTIME based. So the remaining time of such a timer is calculated against the wrong time base. Handle it by switching the k_itimer->kclock pointer according to the resulting hrtimer mode. k_itimer->it_clock still contains CLOCK_REALTIME because the timer might be set with ABSTIME later and then it needs to switch back to the realtime posix clock implementation. Fixes: eae1c4ae ("posix-timers: Make use of cancel/arm callbacks") Reported-by:
Andrei Vagin <avagin@virtuozzo.com> Signed-off-by:
-
Thomas Gleixner authored
The recent posix timer rework moved the clearing of the itimerspec to the real syscall implementation, but forgot that the kclock->timer_get() is used by timer_settime() as well. That results in an uninitialized variable and bogus values returned to user space. Add the missing memset to timer_settime(). Fixes: eabdec04 ("posix-timers: Zero settings value in common code") Reported-by:
-
Thomas Gleixner authored
The refactoring of the posix-timer core to allow better code sharing introduced inverted logic vs. SIGEV_NONE timers in common_timer_get(). That causes hrtimer_forward() to be called on active timers, which rightfully triggers the warning hrtimer_forward(). Make sig_none what it says: signal mode == SIGEV_NONE. Fixes: 91d57bae ("posix-timers: Make use of forward/remaining callbacks") Reported-by:
Ye Xiaolong <xiaolong.ye@intel.com> Signed-off-by:
-
- 04 Jun, 2017 17 commits
-
-
Thomas Gleixner authored
All required callbacks are in place. Switch the alarm timer based posix interval timer callbacks to the common implementation and remove the incorrect private implementation. Signed-off-by:
-
Thomas Gleixner authored
Preparatory change to utilize the common posix timer mechanisms. Signed-off-by:
-
Thomas Gleixner authored
Preparatory change to utilize the common posix timer mechanisms. Signed-off-by:
-
Thomas Gleixner authored
Preparatory change to utilize the common posix timer mechanisms. Signed-off-by:
-
Thomas Gleixner authored
Preparatory change to utilize the common posix timer mechanisms. Signed-off-by:
-
Thomas Gleixner authored
Preparatory change to utilize the common posix timer mechanisms. Signed-off-by:
-
Thomas Gleixner authored
Replace the hrtimer calls by calls to the new try_to_cancel()/arm() kclock callbacks and move the hrtimer specific implementation into the corresponding callback functions. Signed-off-by:
-
Thomas Gleixner authored
Add timer_try_to_cancel() and timer_arm() callbacks to kclock which allow to make common_timer_set() usable by both hrtimer and alarmtimer based clocks. Signed-off-by:
-
Thomas Gleixner authored
Zero out the settings struct in the common code so the callbacks do not have to do it themself. Signed-off-by:
-
Thomas Gleixner authored
Replace the hrtimer calls by calls to the new forward/remaining kclock callbacks and move the hrtimer specific implementation into the corresponding callback functions. Signed-off-by:
-
Thomas Gleixner authored
Add two callbacks to kclock which allow using common_)timer_get() for both hrtimer and alarm timer based clocks. Signed-off-by:
-
Thomas Gleixner authored
Keep track of the activation state of posix timers. This is a preparatory change for making common_timer_get() usable by both hrtimer and alarm timer implementations. Signed-off-by:
-
Thomas Gleixner authored
Use the new timer_rearm() callback to replace the conditional hardcoded calls into the hrtimer and cpu timer code. This allows later to bring the same logic to alarmtimers. Signed-off-by:
-
Thomas Gleixner authored
That function is a misnomer. Rename it with a proper prefix to posixtimer_rearm(). Signed-off-by:
-
Thomas Gleixner authored
Add a timer_rearm() callback which is used to make the rescheduling of posix interval timers independent of the underlying clock implementation. Signed-off-by:
-
Thomas Gleixner authored
Having the k_clock pointer in the k_itimer struct avoids the lookup in several code pathes and makes the next steps of unification of the hrtimer and alarmtimer based posix timers simpler. Signed-off-by:
-
Thomas Gleixner authored
Preparatory patch to unify the alarm timer and hrtimer based posix interval timer handling. The interval is used as a criteria for rearming decisions so moving it out of the clock specific data structures allows later unification. Signed-off-by:
-
