- 17 May, 2011 40 commits
-
-
Julia Lawall authored
A call to cfg80211_get_bss hould be accompanied by a call to cfg80211_put_bss in error-handling code. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ local idexpression struct cfg80211_bss * x; expression ra,rr; position p1,p2; @@ x = cfg80211_get_bss@p1(...) ... when != x = rr when != cfg80211_put_bss(x,...) when != if (...) { ... cfg80211_put_bss(x,...) ...} if(...) { ... when != x = ra when forall when != cfg80211_put_bss(x,...) \(return <+...x...+>; \| return@p2...; \) } @script:python@ p1 << r.p1; p2 << r.p2; @@ cocci.print_main("cfg80211_get_bss",p1) cocci.print_secs("return",p2) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Clemens Noss authored
to clarify the intention: On Sun, May 15, 2011 at 09:54:26PM +0200, Arend van Spriel wrote: > On 05/15/2011 08:10 PM, Hauke Mehrtens wrote: [...] >> Why don't you use the correct pointer type here instead of casting then >> around and the parameter names are meaningless too. >> >> static bool cb_del_ampdu_pkt(struct sk_buff *mpdu, struct >> cb_del_ampdu_pars *ampdu_pars) [...] > Actually this is a generic callback mechanism in which an additional > parameter can be passed, which can be of *any* type hence a void pointer > seems justified here and a meaningless name is used. I do agree that the > txi parameter will always be a struct sk_buff and should be indicated as > such. Reported-by:
Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by:
Clemens Noss <cnoss@gmx.de> Acked-by:
Roland Vossen <rvossen@broadcom.com> Signed-off-by:
-
Clemens Noss authored
bcm_pktq_flush and related functions only ever get 0 or a pointer for arg, so make it a pointer. This might fix a crash on 64bit. Signed-off-by:
-
Rahul Tank authored
--bcaec50161b317392804a33628dd Content-Type: text/plain; charset=ISO-8859-1 Hi Greg, Please find patch attached . Thanks, Rahul Hi Greg,<br><br> Please find patch attached .<br><br>Thanks,<br> Rahul<br> From ba1dbafaef1a87c1338c5bb0e6bba3be06071c90 Mon Sep 17 00:00:00 2001 From: Rahul Tank <rahul.tank@gmail.com> Date: Sat, 14 May 2011 11:28:25 +0530 Subject: [PATCH] Trivial indentation cleanup Signed-off-by:
Rahul Tank <rahul.tank@gmail.com> Signed-off-by:
-
matt mooney authored
Add -Werror, remove -Wstrict-prototypes, and change -W to -Wextra. Signed-off-by:
matt mooney <mfm@muteddisk.com> Signed-off-by:
-
matt mooney authored
There are a standard set of cflags that are used in each makefile so let's set those in EXTRA_CFLAGS and enforce them for the entire project. Signed-off-by:
-
matt mooney authored
The warnings were for unused parameters, so __attribute__((unused)) has been added until it can be determined they are truly unneeded. Signed-off-by:
-
matt mooney authored
This is git not CVS! Signed-off-by:
-
matt mooney authored
Move libusbip version setting to configure.ac so that version numbers can be found in a single location. Signed-off-by:
-
matt mooney authored
Remove unneeded comments; change deprecated flag INCLUDE to AM_CPPFLAGS and put -D option in *_CPPFLAGS; and use "simply expanded variables" in assignments. Signed-off-by:
-
matt mooney authored
All parameters have been quoted; and autoscan was rerun so new headers, types, and functions were added. The deprecated macros AM_CONFIG_HEADER and AM_PROG_LIBTOOL were changed to AC_CONFIG_HEADERS and LT_INIT, respectively. The AS_HELP_STRING macro is used to avoid arbitrary spacing for proper help menu alignment, and AS_CASE to avoid quoting issues. And finally, the macros were realigned to allow mere mortals the ability to read them. Signed-off-by:
-
matt mooney authored
Change all references to the kernel modules to correspond with the new names. Signed-off-by:
-
matt mooney authored
Signed-off-by:
-
matt mooney authored
Remove ChangeLog and NEWS. Signed-off-by:
-
matt mooney authored
Rename cmd/ to src/ and lib/ to libsrc/. Signed-off-by:
-
matt mooney authored
Signed-off-by:
-
Takahiro Hirofuchi authored
Add userspace code from svn trunk revision 175. Located at https://usbip.svn.sourceforge.net/svnroot/usbip/linux/trunk/src. Signed-off-by:
-
K. Y. Srinivasan authored
Make netvsc_drv_exit() the module exit function. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Abhishek Kane <v-abkane@microsoft.com> Signed-off-by:
Hank Janssen <hjanssen@microsoft.com> Signed-off-by:
-
K. Y. Srinivasan authored
Now make netvsc_drv_init the module init function. Signed-off-by:
-
K. Y. Srinivasan authored
In preparation to eliminating netvsc_init(), move the dmi_check code to netvsc_drv_init(). Signed-off-by:
-
K. Y. Srinivasan authored
Change the signature of netvsc_drv_init(). Signed-off-by:
-
K. Y. Srinivasan authored
Move the dmi table declaration to earlier in the file. Signed-off-by:
-
K. Y. Srinivasan authored
Now, get rid of the unused type struct netvsc_driver. Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of the unused function drv_to_netvscdrv(). Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of the empty function rndis_filter_init(). Signed-off-by:
-
K. Y. Srinivasan authored
After the cleanup that has been done, some code in rndis_filter.c is no longer needed; get rid of it. Signed-off-by:
-
K. Y. Srinivasan authored
In preparation to getting rid of struct netvsc_driver, make the variable netvsc_drv an instance of struct hv_driver. Signed-off-by:
-
K. Y. Srinivasan authored
Now get rid of unused state (ring_buf_size) from struct netvsc_driver. Signed-off-by:
-
K. Y. Srinivasan authored
Since we pass ring size information differently, this assignment is not needed. Signed-off-by:
-
K. Y. Srinivasan authored
Get the ring size information from struct netvsc_device_info. Signed-off-by:
-
K. Y. Srinivasan authored
Add ring_size element to struct netvsc_device_info. Signed-off-by:
-
K. Y. Srinivasan authored
Now, get rid of unused state (req_ext_size) from struct netvsc_driver. Signed-off-by:
-
K. Y. Srinivasan authored
Now that we compute the size of struct rndis_filter_packet where it is needed, get rid of the unnecessary assignment. Signed-off-by:
-
K. Y. Srinivasan authored
Directly get the size of rndis_filter_packet. Signed-off-by:
-
K. Y. Srinivasan authored
Move the definition of struct rndis_filter_packet to hyperv_net.h. Signed-off-by:
-
K. Y. Srinivasan authored
Since the function pointers in struct netvsc_driver are no longer used (as these are invoked directly), get rid of this unused state. Signed-off-by:
-
K. Y. Srinivasan authored
Directly invoke the function rndis_filter_receive(). Signed-off-by:
-
K. Y. Srinivasan authored
Directly invoke the function netvsc_recv_callback(). Signed-off-by:
-
K. Y. Srinivasan authored
Invoke netvsc_linkstatus_callback directly. Signed-off-by:
-
K. Y. Srinivasan authored
Invoke netvsc_send() directly. Signed-off-by:
-
