Commits · df72ac93ee22daf1595e93b45de9e6804af0afde · Kirill Smelkov / linux

18 Jul, 2014 5 commits

staging: rtl8723au: Use rtl8723au_set_media_status() to replace _InitNetworkType() · df72ac93

Jes Sorensen authored Jul 17, 2014

Reduce yet another duplicate implementation of set_media_status()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

df72ac93

staging: rtl8723au: Reduce number of duplicate defines for link state · 6ec26273

Jes Sorensen authored Jul 17, 2014

We use the MSR bits to define link state anyway, so no point having an
additional two sets of defines for the same thing.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6ec26273

staging: rtl8723au: Eliminate Set_MSR() wrapper call · ee225f0f

Jes Sorensen authored Jul 17, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ee225f0f

staging: xillybus: Removed outdated part in README · 44909e65

Eli Billauer authored Jul 17, 2014

The dedicated memory management routines have been replaced with devres API,
so the related part is removed from the doc.
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

44909e65

staging: xillybus: Fix if-else coding style errors · 84590b1a

Eli Billauer authored Jul 17, 2014

According to Documentation/CodingStyle, when one branch of an if-else
statement has multiple statements, both branches should be enclosed in curly
brackets.
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

84590b1a

16 Jul, 2014 35 commits

staging: comedi: ni_labpc.h: checkpatch.pl cleanup (unnecessary space) · 736221ef

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Unnecessary space before function pointer arguments
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

736221ef

staging: comedi: ni_tio: checkpatch.pl cleanup (braces not necessary) · 2b28a540

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warnings:

WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2b28a540

staging: comedi: ni_mio_common: checkpatch.pl cleanup (braces not necessary) · a6266977

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warnings:

WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a6266977

staging: comedi: ni_660x: checkpatch.pl cleanup (space prohibited) · 56e9bef5

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: space prohibited before semicolon
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

56e9bef5

staging: comedi: ni_660x: checkpatch.pl cleanup (trailing whitespace) · c8c8ff88

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl error:

ERROR: trailing whitespace
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c8c8ff88

staging: comedi: pcl724: checkpatch.pl cleanup (foo*/foo *) · f14b6226

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl error:

ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f14b6226

staging: comedi: serial2000: checkpatch.pl cleanup (kmalloc_array) · 205781b7

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Prefer kmalloc_array over kmalloc with multiply
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

205781b7

staging: comedi: me4000: checkpatch.pl cleanup (complex macro) · e685d726

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl error:

ERROR: Macros with complex values should be enclosed in parenthesis

This define is not used in the driver. Just remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e685d726

staging: comedi: das1800: remove 'volatile' from private data · 04a4da61

H Hartley Sweeten authored Jul 16, 2014

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

04a4da61

staging: comedi: das16m1: remove 'volatile' from private data · e3ebc55f

H Hartley Sweeten authored Jul 16, 2014

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e3ebc55f

staging: comedi: daqboard2000: checkpatch.pl cleanup (space before tab) · 6691844c

H Hartley Sweeten authored Jul 16, 2014

Fix these checkpatch.pl warnings:

WARNING: please, no space before tabs
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6691844c

staging: comedi: cb_pcidas64: remove 'volatile' from set_dac_range_bits() param · 350a3276

H Hartley Sweeten authored Jul 16, 2014

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The 'bits' parameter to this function does not need to
be volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

350a3276

staging: comedi: cb_pcidas64: remove 'volatile' from private data · 0f99981a

H Hartley Sweeten authored Jul 16, 2014

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0f99981a

staging: comedi: amcc_s5933.h: checkpatch.pl cleanup (space prohibited) · 931a9c73

H Hartley Sweeten authored Jul 16, 2014

Fix this checkpatch.pl warning:

WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

931a9c73

staging: comedi: adv_pci_dio: checkpatch.pl cleanup (fallthrough) · de33276b

H Hartley Sweeten authored Jul 16, 2014

Fix these checkpatch.pl warnings:

WARNING: Possible switch case/default not preceeded by break or fallthrough comment
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

de33276b

staging: comedi: adv_pci_dio: checkpatch.pl cleanup (missing blank line) · 11828ce9

H Hartley Sweeten authored Jul 16, 2014

Fix this checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

11828ce9

staging: comedi: ni_tio: checkpatch.pl cleanup (missing blank line) · 4318d1d3

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warnings:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4318d1d3

staging: comedi: mite: checkpatch.pl cleanup (missing blank line) · 9a7c5693

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warnings:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9a7c5693

staging: comedi: ni_mio_common: checkpatch.pl cleanup (missing blank line) · f7401979

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warnings:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f7401979

staging: comedi: ni_pcidio: checkpatch.pl cleanup (missing blank line) · fd28703c

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fd28703c

staging: comedi: ni_660x: checkpatch.pl cleanup (missing blank line) · c4c2c67a

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c4c2c67a

staging: comedi: multiq3: checkpatch.pl cleanup (missing blank line) · 385aea35

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

385aea35

staging: comedi: pcmuio: checkpatch.pl cleanup (missing blank line) · c1f946a2

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c1f946a2

staging: comedi: ni_at_a2150: checkpatch.pl cleanup (missing blank line) · a95b7ccf

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a95b7ccf

staging: comedi: serial2000: reduce indent level of serial2002_setup_subdevs() · 624e6446

H Hartley Sweeten authored Jul 16, 2014

Tidy up this function a bit to reduce the indent level.

This also fixex the checkpatch.pl warning:

WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

624e6446

staging: comedi: serial2000: checkpatch.pl cleanup (missing blank line) · 96afd186

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

96afd186

staging: comedi: comedi_test: checkpatch.pl cleanup (break is not useful) · f06d145f

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f06d145f

staging: comedi: jr3_pci: checkpatch.pl cleanup (missing blank line) · cd9da617

H Hartley Sweeten authored Jul 16, 2014

Fix checkpatch.pl warnings:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

cd9da617

staging: comedi: dt9812: checkpatch.pl cleanup (missing blank line) · 98039f8a

H Hartley Sweeten authored Jul 16, 2014

Fix checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

98039f8a

staging: comedi: dt2815: checkpatch.pl cleanup (missing blank line) · f61b57a4

H Hartley Sweeten authored Jul 16, 2014

Fix checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f61b57a4

staging: comedi: das1800: checkpatch.pl cleanup (void function return) · bb905ab1

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

bb905ab1

staging: comedi: das16: checkpatch.pl cleanup (missing blank line) · d7e31e56

H Hartley Sweeten authored Jul 16, 2014

Fix thess checkpatch.pl warnings:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d7e31e56

staging: comedi: cd_pcidas64: checkpatch.pl cleanup (void function return) · a8fa9200

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning:

WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a8fa9200

staging: comedi: cb_pcidas64: checkpatch.pl cleanup (missing blank line) · 43358ed0

H Hartley Sweeten authored Jul 16, 2014

Fix this checkpatch.pl warning:

WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

43358ed0

staging: comedi: amplc_pci230: checkpatch.pl cleanup (void function return) · 0a9e58d6

H Hartley Sweeten authored Jul 16, 2014

Fix the checkpatch.pl warning in this file:

WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0a9e58d6