1. 01 Mar, 2022 7 commits
  2. 28 Feb, 2022 8 commits
    • Thomas Hellström's avatar
      drm/i915: Clarify vma lifetime · c03d9826
      Thomas Hellström authored
      It's unclear what reference the initial vma kref reference refers to.
      A vma can have multiple weak references, the object vma list,
      the vm's bound list and the GT's closed_list, and the initial vma
      reference can be put from lookups of all these lists.
      
      With the current implementation this means
      that any holder of yet another vma refcount (currently only
      i915_gem_object_unbind()) needs to be holding two of either
      *) An object refcount,
      *) A vm open count
      *) A vma open count
      
      in order for us to not risk leaking a reference by having the
      initial vma reference being put twice.
      
      Address this by re-introducing i915_vma_destroy() which removes all
      weak references of the vma and *then* puts the initial vma refcount.
      This makes a strong vma reference hold on to the vma unconditionally.
      
      Perhaps a better name would be i915_vma_revoke() or i915_vma_zombify(),
      since other callers may still hold a refcount, but with the prospect of
      being able to replace the vma refcount with the object lock in the near
      future, let's stick with i915_vma_destroy().
      
      Finally this commit fixes a race in that previously i915_vma_release() and
      now i915_vma_destroy() could destroy a vma without taking the vm->mutex
      after an advisory check that the vma mm_node was not allocated.
      This would race with the ungrab_vma() function creating a trace similar
      to the below one. This was fixed in one of the __i915_vma_put() callsites
      in
      commit bc1922e5 ("drm/i915: Fix a race between vma / object destruction and unbinding")
      but although not seemingly triggered by CI, that
      is not sufficient. This patch is needed to fix that properly.
      
      [823.012188] Console: switching to colour dummy device 80x25
      [823.012422] [IGT] gem_ppgtt: executing
      [823.016667] [IGT] gem_ppgtt: starting subtest blt-vs-render-ctx0
      [852.436465] stack segment: 0000 [#1] PREEMPT SMP NOPTI
      [852.436480] CPU: 0 PID: 3200 Comm: gem_ppgtt Not tainted 5.16.0-CI-CI_DRM_11115+ #1
      [852.436489] Hardware name: Intel Corporation Alder Lake Client Platform/AlderLake-P DDR5 RVP, BIOS ADLPFWI1.R00.2422.A00.2110131104 10/13/2021
      [852.436499] RIP: 0010:ungrab_vma+0x9/0x80 [i915]
      [852.436711] Code: ef e8 4b 85 cf e0 e8 36 a3 d6 e0 8b 83 f8 9c 00 00 85 c0 75 e1 5b 5d 41 5c 41 5d c3 e9 d6 fd 14 00 55 53 48 8b af c0 00 00 00 <8b> 45 00 85 c0 75 03 5b 5d c3 48 8b 85 a0 02 00 00 48 89 fb 48 8b
      [852.436727] RSP: 0018:ffffc90006db7880 EFLAGS: 00010246
      [852.436734] RAX: 0000000000000000 RBX: ffffc90006db7598 RCX: 0000000000000000
      [852.436742] RDX: ffff88815349e898 RSI: ffff88815349e858 RDI: ffff88810a284140
      [852.436748] RBP: 6b6b6b6b6b6b6b6b R08: ffff88815349e898 R09: ffff88815349e8e8
      [852.436754] R10: 0000000000000001 R11: 0000000051ef1141 R12: ffff88810a284140
      [852.436762] R13: 0000000000000000 R14: ffff88815349e868 R15: ffff88810a284458
      [852.436770] FS:  00007f5c04b04e40(0000) GS:ffff88849f000000(0000) knlGS:0000000000000000
      [852.436781] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [852.436788] CR2: 00007f5c04b38fe0 CR3: 000000010a6e8001 CR4: 0000000000770ef0
      [852.436797] PKRU: 55555554
      [852.436801] Call Trace:
      [852.436806]  <TASK>
      [852.436811]  i915_gem_evict_for_node+0x33c/0x3c0 [i915]
      [852.437014]  i915_gem_gtt_reserve+0x106/0x130 [i915]
      [852.437211]  i915_vma_pin_ww+0x8f4/0xb60 [i915]
      [852.437412]  eb_validate_vmas+0x688/0x860 [i915]
      [852.437596]  i915_gem_do_execbuffer+0xc0e/0x25b0 [i915]
      [852.437770]  ? deactivate_slab+0x5f2/0x7d0
      [852.437778]  ? _raw_spin_unlock_irqrestore+0x50/0x60
      [852.437789]  ? i915_gem_execbuffer2_ioctl+0xc6/0x2c0 [i915]
      [852.437944]  ? init_object+0x49/0x80
      [852.437950]  ? __lock_acquire+0x5e6/0x2580
      [852.437963]  i915_gem_execbuffer2_ioctl+0x116/0x2c0 [i915]
      [852.438129]  ? i915_gem_do_execbuffer+0x25b0/0x25b0 [i915]
      [852.438300]  drm_ioctl_kernel+0xac/0x140
      [852.438310]  drm_ioctl+0x201/0x3d0
      [852.438316]  ? i915_gem_do_execbuffer+0x25b0/0x25b0 [i915]
      [852.438490]  __x64_sys_ioctl+0x6a/0xa0
      [852.438498]  do_syscall_64+0x37/0xb0
      [852.438507]  entry_SYSCALL_64_after_hwframe+0x44/0xae
      [852.438515] RIP: 0033:0x7f5c0415b317
      [852.438523] Code: b3 66 90 48 8b 05 71 4b 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 41 4b 2d 00 f7 d8 64 89 01 48
      [852.438542] RSP: 002b:00007ffd765039a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
      [852.438553] RAX: ffffffffffffffda RBX: 000055e4d7829dd0 RCX: 00007f5c0415b317
      [852.438562] RDX: 00007ffd76503a00 RSI: 00000000c0406469 RDI: 0000000000000017
      [852.438571] RBP: 00007ffd76503a00 R08: 0000000000000000 R09: 0000000000000081
      [852.438579] R10: 00000000ffffff7f R11: 0000000000000246 R12: 00000000c0406469
      [852.438587] R13: 0000000000000017 R14: 00007ffd76503a00 R15: 0000000000000000
      [852.438598]  </TASK>
      [852.438602] Modules linked in: snd_hda_codec_hdmi i915 mei_hdcp x86_pkg_temp_thermal snd_hda_intel snd_intel_dspcfg drm_buddy coretemp crct10dif_pclmul crc32_pclmul snd_hda_codec ttm ghash_clmulni_intel snd_hwdep snd_hda_core e1000e drm_dp_helper ptp snd_pcm mei_me drm_kms_helper pps_core mei syscopyarea sysfillrect sysimgblt fb_sys_fops prime_numbers intel_lpss_pci smsc75xx usbnet mii
      [852.440310] ---[ end trace e52cdd2fe4fd911c ]---
      
      v2: Fix typos in the commit message.
      
      Fixes: 7e00897b ("drm/i915: Add object locking to i915_gem_evict_for_node and i915_gem_evict_something, v2.")
      Fixes: bc1922e5 ("drm/i915: Fix a race between vma / object destruction and unbinding")
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Signed-off-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220222133209.587978-1-thomas.hellstrom@linux.intel.com
      c03d9826
    • Matthew Auld's avatar
      drm/i915/selftests: mock test io_size · 2d45f668
      Matthew Auld authored
      Check that mappable vs non-mappable matches our expectations.
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225145502.331818-7-matthew.auld@intel.com
      2d45f668
    • Matthew Auld's avatar
      drm/i915/buddy: tweak 2big check · f199bf55
      Matthew Auld authored
      Otherwise we get -EINVAL, instead of the more useful -E2BIG if the
      allocation doesn't fit within the pfn range, like with mappable lmem.
      The hugepages selftest, for example, needs this to know if a smaller
      size is needed.
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Acked-by: default avatarNirmoy Das <nirmoy.das@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225145502.331818-6-matthew.auld@intel.com
      f199bf55
    • Matthew Auld's avatar
      drm/i915/buddy: adjust res->start · f9eb7429
      Matthew Auld authored
      Differentiate between mappable vs non-mappable resources, also if this
      is an actual range allocation ensure we set res->start as the starting
      pfn. Later when we need to do non-mappable -> mappable moves then we
      want TTM to see that the current placement is not compatible, which
      should result in an actual move, instead of being turned into a noop.
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Acked-by: default avatarNirmoy Das <nirmoy.das@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225145502.331818-5-matthew.auld@intel.com
      f9eb7429
    • Matthew Auld's avatar
      drm/i915/buddy: track available visible size · 26ffcbbe
      Matthew Auld authored
      Track the total amount of available visible memory, and also track
      per-resource the amount of used visible memory. For now this is useful
      for our debug output, and deciding if it is even worth calling into the
      buddy allocator. In the future tracking the per-resource visible usage
      will be useful for when deciding if we should attempt to evict certain
      buffers.
      
      v2:
       - s/place->lpfn/lpfn/, that way we can avoid scanning the list if the
         entire range is already mappable.
       - Move the end declaration inside the if block(Thomas).
       - Make sure to also account for reserved memory.
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Acked-by: default avatarNirmoy Das <nirmoy.das@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225145502.331818-4-matthew.auld@intel.com
      26ffcbbe
    • Matthew Auld's avatar
      drm/i915: add I915_BO_ALLOC_GPU_ONLY · 30b9d1b3
      Matthew Auld authored
      If the user doesn't require CPU access for the buffer, then
      ALLOC_GPU_ONLY should be used, in order to prioritise allocating in the
      non-mappable portion of LMEM, on devices with small BAR.
      
      v2(Thomas):
        - The BO_ALLOC_TOPDOWN naming here is poor, since this is pure lies on
          systems that don't even have small BAR. A better name is GPU_ONLY,
          which is accurate regardless of the configuration.
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Acked-by: default avatarNirmoy Das <nirmoy.das@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225145502.331818-3-matthew.auld@intel.com
      30b9d1b3
    • Matthew Auld's avatar
      drm/i915/ttm: require mappable by default · 3312a4ac
      Matthew Auld authored
      On devices with non-mappable LMEM ensure we always allocate the pages
      within the mappable portion. For now we assume that all LMEM buffers
      will require CPU access, which is also inline with pretty much all
      current kernel internal users. In the next patch we will introduce a new
      flag to override this behaviour.
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Acked-by: default avatarNirmoy Das <nirmoy.das@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225145502.331818-2-matthew.auld@intel.com
      3312a4ac
    • Matthew Auld's avatar
      drm/i915: add io_size plumbing · 235582ca
      Matthew Auld authored
      With small LMEM-BAR we need to be able to differentiate between the
      total size of LMEM, and how much of it is CPU mappable. The end goal is
      to be able to utilize the entire range, even if part of is it not CPU
      accessible.
      
      v2: also update intelfb_create
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Acked-by: default avatarNirmoy Das <nirmoy.das@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225145502.331818-1-matthew.auld@intel.com
      235582ca
  3. 26 Feb, 2022 1 commit
    • Matthew Auld's avatar
      drm/i915: apply PM_EARLY for non-GTT mappable objects · d2cc01e1
      Matthew Auld authored
      On DG2 we allow objects that are smaller than the min_page_size, under
      the premise that these are never mapped by the GTT, like with the paging
      structures. Currently the suspend-resume path will try to map such
      objects through the migration vm, which hits:
      
      [  560.529217] kernel BUG at drivers/gpu/drm/i915/gt/intel_migrate.c:431!
      [  560.536081] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
      [  560.541629] CPU: 4 PID: 2062 Comm: rtcwake Tainted: G        W         5.17.0-rc5-demarchi+ #175
      [  560.550716] Hardware name: Intel Corporation CoffeeLake Client Platform/CoffeeLake S UDIMM RVP, BIOS CNLSFWR1.R00.X220.B00.2103302221 03/30/2021
      [  560.563627] RIP: 0010:emit_pte+0x2e7/0x380 [i915]
      [  560.568665] Code: ee 02 48 89 69 04 83 c6 05 83 c0 05 39 f0 0f 4f c6 48 8b 73 08 39 d0 0f 4f c2 44 89 f2 4c 8d 4a ff 49 85 f1 0f 84 62 fe ff ff <0f> 0b 48 c7 03 00 00 00 00 4d 89 c6 8b 01 48 29 ce 48 8d 57 0c 48
      [  560.587691] RSP: 0018:ffffc9000104f8a0 EFLAGS: 00010206
      [  560.592906] RAX: 0000000000000040 RBX: ffffc9000104f908 RCX: ffffc900025114d0
      [  560.600024] RDX: 0000000000010000 RSI: 00000003f9fe2000 RDI: ffffc900025114dc
      [  560.607458] RBP: 0000000001840000 R08: ffff88810f335540 R09: 000000000000ffff
      [  560.614865] R10: 000000000000081b R11: 0000000000000001 R12: 000000000000081b
      [  560.622300] R13: 0000000000000000 R14: 0000000000010000 R15: ffff888107c3e240
      [  560.629716] FS:  00007f5b7c086580(0000) GS:ffff88846dc00000(0000) knlGS:0000000000000000
      [  560.638090] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [  560.644132] CR2: 00007f3ab0a133a8 CR3: 000000010a43e003 CR4: 00000000003706e0
      [  560.651590] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      [  560.659002] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      [  560.666438] Call Trace:
      [  560.668885]  <TASK>
      [  560.670983]  intel_context_migrate_copy+0x1b1/0x4c0 [i915]
      [  560.676794]  __i915_ttm_move+0x628/0x790 [i915]
      [  560.681704]  ? dma_resv_iter_next+0x8f/0xb0
      [  560.686223]  ? dma_resv_iter_first+0xe5/0x140
      [  560.690894]  ? i915_deps_add_resv+0x4b/0x110 [i915]
      [  560.696147]  ? dma_resv_reserve_shared+0x161/0x310
      [  560.701228]  i915_gem_obj_copy_ttm+0x10f/0x220 [i915]
      [  560.706650]  i915_ttm_backup+0x191/0x2f0 [i915]
      [  560.711558]  i915_gem_process_region+0x266/0x3b0 [i915]
      [  560.717153]  ? verify_cpu+0xf0/0x100
      [  560.721040]  ? pci_pm_resume_early+0x20/0x20
      [  560.725603]  i915_ttm_backup_region+0x47/0x70 [i915]
      [  560.730927]  i915_gem_backup_suspend+0x141/0x170 [i91
      
      For now let's just force the memcpy path for such objects during
      suspend-resume.
      
      Fixes: 00e27ad8 ("drm/i915/migrate: add acceleration support for DG2")
      Reported-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
      Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220225103443.225228-1-matthew.auld@intel.com
      d2cc01e1
  4. 25 Feb, 2022 18 commits
  5. 24 Feb, 2022 2 commits
    • Dave Airlie's avatar
      Merge tag 'drm-misc-next-2022-02-23' of git://anongit.freedesktop.org/drm/drm-misc into drm-next · 54f43c17
      Dave Airlie authored
      drm-misc-next for v5.18:
      
      UAPI Changes:
      
      Cross-subsystem Changes:
      - Split out panel-lvds and lvds dt bindings .
      - Put yes/no on/off disabled/enabled strings in linux/string_helpers.h
        and use it in drivers and tomoyo.
      - Clarify dma_fence_chain and dma_fence_array should never include eachother.
      - Flatten chains in syncobj's.
      - Don't double add in fbdev/defio when page is already enlisted.
      - Don't sort deferred-I/O pages by default in fbdev.
      
      Core Changes:
      - Fix missing pm_runtime_put_sync in bridge.
      - Set modifier support to only linear fb modifier if drivers don't
        advertise support.
      - As a result, we remove allow_fb_modifiers.
      - Add missing clear for EDID Deep Color Modes in drm_reset_display_info.
      - Assorted documentation updates.
      - Warn once in drm_clflush if there is no arch support.
      - Add missing select for dp helper in drm_panel_edp.
      - Assorted small fixes.
      - Improve fb-helper's clipping handling.
      - Don't dump shmem mmaps in a core dump.
      - Add accounting to ttm resource manager, and use it in amdgpu.
      - Allow querying the detected eDP panel through debugfs.
      - Add helpers for xrgb8888 to 8 and 1 bits gray.
      - Improve drm's buddy allocator.
      - Add selftests for the buddy allocator.
      
      Driver Changes:
      - Add support for nomodeset to a lot of drm drivers.
      - Use drm_module_*_driver in a lot of drm drivers.
      - Assorted small fixes to bridge/lt9611, v3d, vc4, vmwgfx, mxsfb, nouveau,
        bridge/dw-hdmi, panfrost, lima, ingenic, sprd, bridge/anx7625, ti-sn65dsi86.
      - Add bridge/it6505.
      - Create DP and DVI-I connectors in ast.
      - Assorted nouveau backlight fixes.
      - Rework amdgpu reset handling.
      - Add dt bindings for ingenic,jz4780-dw-hdmi.
      - Support reading edid through aux channel in ingenic.
      - Add a drm driver for Solomon SSD130x OLED displays.
      - Add simple support for sharp LQ140M1JW46.
      - Add more panels to nt35560.
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      
      From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/686ec871-e77f-c230-22e5-9e3bb80f064a@linux.intel.com
      54f43c17
    • Dave Airlie's avatar
      Merge tag 'drm-intel-next-2022-02-23' of git://anongit.freedesktop.org/drm/drm-intel into drm-next · 7f44571b
      Dave Airlie authored
      Linux core:
      -----------
      iosys-map: Add offset to iosys_map_memcpy_to() (Lucas)
      iosys-map: Add a few more helpers (Lucas)
      
      i915 (display and core changes on drm-intel-next):
      --------------------------------------------------
      
      - Display's DBuf and watermark related fixes and improvements (Ville)
      - More i915 header and other code clean-up (Jani)
      - Display IPS fixes and improvements (Ville)
      - OPRegion fixes and cleanups (Jani)
      - Fix the plane end Y offset check for FBC (Ville)
      - DP 128b/132b updates (Jani)
      - Disable runtime pm wakeref tracking for the mock device selftest (Ville)
      - Many display code clean-up while targeting to fix up DP DFP 4:2:0 handling (Ville)
      - Bigjoiner state tracking and more bigjoiner related work (Ville)
      - Update DMC_DEBUG3 register for DG1 (Chuansheng)
      - SAGV fixes (Ville)
      - More GT register cleanup (Matt)
      - Fix build issue when using clang (Tong)
      - Display DG2 fixes (Matt)
      - ADL-P PHY related fixes (Imre)
      - PSR2 fixes (Jose)
      - Add PCH Support for Alder Lake N (Tejas)
      
      drm-intel-gt-next (drm-intel-gt-next-2022-02-17):
      -------------------------------------------------
      UAPI Changes:
      
      - Weak parallel submission support for execlists
      
        Minimal implementation of the parallel submission support for
        execlists backend that was previously only implemented for GuC.
        Support one sibling non-virtual engine.
      
      Core Changes:
      
      - Two backmerges of drm/drm-next for header file renames/changes and
        i915_regs reorganization
      
      Driver Changes:
      
      - Add new DG2 subplatform: DG2-G12 (Matt R)
      - Add new DG2 workarounds (Matt R, Ram, Bruce)
      - Handle pre-programmed WOPCM registers for DG2+ (Daniele)
      - Update guc shim control programming on XeHP SDV+ (Daniele)
      - Add RPL-S C0/D0 stepping information (Anusha)
      - Improve GuC ADS initialization to work on ARM64 on dGFX (Lucas)
      
      - Fix KMD and GuC race on accessing PMU busyness (Umesh)
      - Use PM timestamp instead of RING TIMESTAMP for reference in PMU with GuC (Umesh)
      - Report error on invalid reset notification from GuC (John)
      - Avoid WARN splat by holding RPM wakelock during PXP unbind (Juston)
      - Fixes to parallel submission implementation (Matt B.)
      - Improve GuC loading status check/error reports (John)
      - Tweak TTM LRU priority hint selection (Matt A.)
      - Align the plane_vma to min_page_size of stolen mem (Ram)
      
      - Introduce vma resources and implement async unbinding (Thomas)
      - Use struct vma_resource instead of struct vma_snapshot (Thomas)
      - Return some TTM accel move errors instead of trying memcpy move (Thomas)
      - Fix a race between vma / object destruction and unbinding (Thomas)
      - Remove short-term pins from execbuf (Maarten)
      - Update to GuC version 69.0.3 (John, Michal Wa.)
      - Improvements to GT reset paths in GuC backend (Matt B.)
      - Use shrinker_release_pages instead of writeback in shmem object hooks (Matt A., Tvrtko)
      - Use trylock instead of blocking lock when freeing GEM objects (Maarten)
      - Allocate intel_engine_coredump_alloc with ALLOW_FAIL (Matt B.)
      - Fixes to object unmapping and purging (Matt A)
      - Check for wedged device in GuC backend (John)
      - Avoid lockdep splat by locking dpt_obj around set_cache_level (Maarten)
      - Allow dead vm to unbind vma's without lock (Maarten)
      - s/engine->i915/i915/ for DG2 engine workarounds (Matt R)
      
      - Use to_gt() helper for GGTT accesses (Michal Wi.)
      - Selftest improvements (Matt B., Thomas, Ram)
      - Coding style and compiler warning fixes (Matt B., Jasmine, Andi, Colin, Gustavo, Dan)
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      
      From: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/YhbDan8wNZBR6FzF@intel.com
      7f44571b
  6. 23 Feb, 2022 4 commits
    • Rodrigo Vivi's avatar
      Merge tag 'drm-intel-gt-next-2022-02-17' of... · 30424eba
      Rodrigo Vivi authored
      Merge tag 'drm-intel-gt-next-2022-02-17' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-next
      
      UAPI Changes:
      
      - Weak parallel submission support for execlists
      
        Minimal implementation of the parallel submission support for
        execlists backend that was previously only implemented for GuC.
        Support one sibling non-virtual engine.
      
      Core Changes:
      
      - Two backmerges of drm/drm-next for header file renames/changes and
        i915_regs reorganization
      
      Driver Changes:
      
      - Add new DG2 subplatform: DG2-G12 (Matt R)
      - Add new DG2 workarounds (Matt R, Ram, Bruce)
      - Handle pre-programmed WOPCM registers for DG2+ (Daniele)
      - Update guc shim control programming on XeHP SDV+ (Daniele)
      - Add RPL-S C0/D0 stepping information (Anusha)
      - Improve GuC ADS initialization to work on ARM64 on dGFX (Lucas)
      
      - Fix KMD and GuC race on accessing PMU busyness (Umesh)
      - Use PM timestamp instead of RING TIMESTAMP for reference in PMU with GuC (Umesh)
      - Report error on invalid reset notification from GuC (John)
      - Avoid WARN splat by holding RPM wakelock during PXP unbind (Juston)
      - Fixes to parallel submission implementation (Matt B.)
      - Improve GuC loading status check/error reports (John)
      - Tweak TTM LRU priority hint selection (Matt A.)
      - Align the plane_vma to min_page_size of stolen mem (Ram)
      
      - Introduce vma resources and implement async unbinding (Thomas)
      - Use struct vma_resource instead of struct vma_snapshot (Thomas)
      - Return some TTM accel move errors instead of trying memcpy move (Thomas)
      - Fix a race between vma / object destruction and unbinding (Thomas)
      - Remove short-term pins from execbuf (Maarten)
      - Update to GuC version 69.0.3 (John, Michal Wa.)
      - Improvements to GT reset paths in GuC backend (Matt B.)
      - Use shrinker_release_pages instead of writeback in shmem object hooks (Matt A., Tvrtko)
      - Use trylock instead of blocking lock when freeing GEM objects (Maarten)
      - Allocate intel_engine_coredump_alloc with ALLOW_FAIL (Matt B.)
      - Fixes to object unmapping and purging (Matt A)
      - Check for wedged device in GuC backend (John)
      - Avoid lockdep splat by locking dpt_obj around set_cache_level (Maarten)
      - Allow dead vm to unbind vma's without lock (Maarten)
      - s/engine->i915/i915/ for DG2 engine workarounds (Matt R)
      
      - Use to_gt() helper for GGTT accesses (Michal Wi.)
      - Selftest improvements (Matt B., Thomas, Ram)
      - Coding style and compiler warning fixes (Matt B., Jasmine, Andi, Colin, Gustavo, Dan)
      
      From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/Yg4i2aCZvvee5Eai@jlahtine-mobl.ger.corp.intel.comSigned-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
      [Fixed conflicts while applying, using the fixups/drm-intel-gt-next.patch
      from drm-rerere's 1f2b1742abdd ("2022y-02m-23d-16h-07m-57s UTC: drm-tip
      rerere cache update")]
      30424eba
    • José Roberto de Souza's avatar
      drm/i915/rps/tgl+: Remove RPS interrupt support · bbd57d16
      José Roberto de Souza authored
      TGL+ and newer platforms don't support RPS up and low interruption
      limits.
      It is not used for broadwell and newer plaforms that supports
      execlist but here making sure that it is explicit not used even in
      debug scenarios.
      
      BSpec: 33301
      BSpec: 52069
      BSpec: 9520
      HSD: 1405911647
      Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
      Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
      Reviewed-by: default avatarAnusha Srivatsa <anusha.srivatsa@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220218210330.48653-1-jose.souza@intel.com
      bbd57d16
    • José Roberto de Souza's avatar
      drm/i915/tgl: Simply subplatform detection · b9ef8939
      José Roberto de Souza authored
      In the past we had a need to differentiate TGL U and TGL Y, there
      was a different voltage swing table for each subplatform and some PCI
      ids of this subplatforms are shared but it turned out that it was a
      specification mistake and the voltage swing table was indeed the same
      but we went ahead with that patch because we needed to differentiate
      TGL U and Y from TGL H and by that time TGL H was embargoed so that
      was the perfect way to land it upstream.
      
      Now the embargo for TGL H is long past and now we even have
      INTEL_TGL_12_GT1_IDS with all TGL H ids, so we can drop this PCI root
      check and only rely in the PCI ids to differentiate TGL U and Y from
      TGL H that actually has code differences.
      
      Besides the simplification this will fix issues in virtualization
      environments where the PCI root is virtualized and don't have the same
      id as actual hardware.
      
      v2:
      - add and set INTEL_SUBPLATFORM_UY
      
      Cc: Fred Gao <fred.gao@intel.com>
      Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
      Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
      Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
      Tested-by: default avatarYu He <yu.he@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220222141424.35165-1-jose.souza@intel.com
      b9ef8939
    • Ville Syrjälä's avatar
      drm/i915: Extract intel_bw_check_data_rate() · 6d8ebef5
      Ville Syrjälä authored
      Extract the data rate calculation loop out from
      intel_bw_atomic_check() to make it a bit less confusing.
      
      v2: Deal with 'bool changed'
      
      Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> #v1
      Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20220218064039.12834-7-ville.syrjala@linux.intel.com
      6d8ebef5