Commits · e5b2a429f06df64ce3b13c9f0394a4b90f1dacce · Kirill Smelkov / linux

23 May, 2014 40 commits

staging: rl8723au: rtw_make_wlanhdr(): Use ieee80211_qos_hdr · e5b2a429

Jes Sorensen authored May 21, 2014

Use the kernel provided struct and defines to fill in qos_ctrl
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e5b2a429

staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl · ec3f4e2a
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ec3f4e2a

staging: rtl8723au: rtl8723a_update_ramask(): Get rid of annoying debug message · 316f6211

Jes Sorensen authored May 21, 2014

There really is no need to print this message for anyone not trying to
debug the driver:

  rtl8723a_update_ramask => mac_id:0, networkType:0x0b, mask:0x000fffff
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

316f6211

staging: rtl8723au: Get rid of SetPrivacy()/SetPwrMgt()/SetMData() macros · c6716e1f

Jes Sorensen authored May 21, 2014

Set these bits directly in the code instead of fiddling with wrapper
macros.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c6716e1f

staging: rtl8723au: Get rid of ugly SetDuration() macro usage · fd602993

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fd602993

staging: rtl8723au: wifi.h: Remove unused SetFragNum() macro · 2bdbf939

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2bdbf939

staging: rtl8723au: Get rid of SetSeqNum() · aeda8250

Jes Sorensen authored May 21, 2014

In every last use case, the header was just cleared with memset() so
there is no need to use the complex SetSeqNum() macro when
cpu_to_le16(IEEE80211_SN_TO_SEQ()) output will do just fine.

In addition, get rid of __le16 *fctrl usage when there is no need for
it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

aeda8250

staging: rtl8723au: Declare rtw_make_wlanhdr() static · 39ef8915

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

39ef8915

staging: rtl8723au: rtw_make_wlanhdr23a(): Use IEEE80211_SN_TO_SEQ() to set seq_ctrl · 670ce688
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
670ce688

staging: rtl8723au: rtl8723a_cmd.c: Properly initialize seq_ctrl · 0b218f4c

Jes Sorensen authored May 21, 2014

Control frames will not be fragmented, so we should fully initialize
the seq_ctrl field to zero. This avoids leftover stack bits remaining
set in the generated frame's seq_ctrl field.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0b218f4c

staging: rtl8723au: ioctl_cfg80211.c: Properly initialize seq_ctrl · 1daffaee

Jes Sorensen authored May 21, 2014

Using SetSeqNum() on an uninitialized stack frame leaves us open to
leaving random fragment bits set in seq_ctrl in the frame header.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1daffaee

staging: rtl8723au: rtw_cfg80211_inform_bss(): Use get_unaligned_le16() · 9a7e35f1
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
9a7e35f1

staging: rtl8723au: ioctl_cfg80211.c: Rip out < 3.14 kernel support · 14423cd7

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

14423cd7

staging: rtl8723au: cfg80211_rtw_mgmt_tx(): type is always -1 · aa69fa65

Jes Sorensen authored May 21, 2014

Rip out P2P defines since they are effectively never used.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

aa69fa65

staging: rtl8723au: Get rid of last HT OP mode duplicate defines · c3899287

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c3899287

staging: rtl8723au: wifi.h: Remove a pile of unused WDS_ defines · 95a4c8c2

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

95a4c8c2

staging: rtl8723au: Remove unused enum WIFI_REG_DOMAIN · 15b4ff5d

Jes Sorensen authored May 21, 2014

Must be the 17th duplicate of this list in the kernel
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

15b4ff5d

staging: rtl8723au: Use kernel provided IEEE80211_HT_PARAM_* defines · 7e14ed5f

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7e14ed5f

staging: rtl8723au: Use kernel provided IEEE80211_HT_OP_MODE_* defines · 2c50c7cb

Jes Sorensen authored May 21, 2014

In addition remove unused HT_INFO_STBC_PARAM_* defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2c50c7cb

staging: rtl8723au: Use kernel provided WLAN_CAPABILITY_* definitions · e1c04628

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e1c04628

staging: rtl8723au: wifi.h: Remove unused SetRetry() + SetAMsdu() macros · e80c2859
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
e80c2859

staging: rtl8723au: Get rid of ClearMFrag/SetMFrag · 8e3ddadf

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

8e3ddadf

staging: rtl8723au: wlan_bssdef.h: Remove some more unused #defines · 5acab752

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5acab752

staging: rtl8723au: Get rid of struct ndis_802_11_var_ies · b171da3c

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b171da3c

staging: rtli8723au: Get rid of struct ndis_802_11_fixed_ies · c164bcff

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c164bcff

staging: rtl8723au: Get rid of struct ndis_802_11_config · 37cb982c

Jes Sorensen authored May 21, 2014

This exposed a nice endian bug in collect_bss_info23a() where two
bytes in little-endian order were copied into a u32 and afterwards
le32_to_cpu() was applied to it....
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

37cb982c

staging: rtl8723au: Get rid of unused struct ndis_802_11_configuration_fh · 9a3c0568
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
9a3c0568

staging: rtl8723au: Make rtw_cfg80211_add_wep() take a struct rtw_wep_key · deff1155

Jes Sorensen authored May 21, 2014

This allows the removal of the ugly struct ndis_8802_11_wep and simplify
rtw_cfg80211_add_wep(). In addition remove unused element ndiswep from
struct security_priv.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

deff1155

staging: rtl8723au: rtw_cfg80211_add_wep(): Get rid of unused keyindex flags · 6893c8eb
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
6893c8eb

staging: rtl8723au: Move rtw_set_802_11_add_wep23a() to ioctl_cfg80211.c · 1e6e7f60

Jes Sorensen authored May 21, 2014

This is only called from ioctl_cfg80211.c so we can move it here and
declare it static.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1e6e7f60

staging: rtl8723au: Introduce struct rtw_wep_key to store our wep keys · e0827909

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e0827909

staging: rtl8723au: Use WLAN_CIPHER_SUITE_* to mark crypto type · 9e3d6df2

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9e3d6df2

staging: rtl8723au: Remove unused enum odm_security · 07a4b1b1

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

07a4b1b1

staging: rtl8723au: We don't support SMS4 or WEP+WPA mixed encryption · 1de36ec3

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1de36ec3

staging: rtl8723au: Store algorithm type in a u32 · 7989bcf3

Jes Sorensen authored May 21, 2014

This will allow us to switch to using WLAN_CIPHER_SUITE_* later
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7989bcf3

staging: rtl8723au: Add -Wtype-limits to CFLAGS · af97d6cd

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

af97d6cd

staging: rtl8723au: Fix up some random bit-flag handling · 9216c517

Jes Sorensen authored May 21, 2014

Randomly mixing true/false/_FAIL/0/1 is a recipe for disaster
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9216c517

staging: rtl8723au: HalEEValueCheck(): content of a u8 is always >= 0 · 3e3a1adf

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3e3a1adf

staging: rtl8723au: Get rid of write only NetworkTypeInUse and matching enum · 409b47c4
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
409b47c4

staging: rtl8723au: Use nl80211_iftype instead of driver's own custom types · efc7144f

Jes Sorensen authored May 21, 2014

In addition move rtw_set_802_11_infrastructure_mode23a() to
ioctl_cfg80211.c and declare it static.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

efc7144f