- 01 May, 2013 18 commits
-
-
David Howells authored
Clean up some of the problems with the rtas_flash driver: (1) It shouldn't fiddle with the internals of the procfs filesystem (altering pde->count). (2) If pid namespaces are in effect, then you can get multiple inodes connected to a single pde, thereby rendering the pde->count > 2 test useless. (3) The pde->count fudging doesn't work for forked, dup'd or cloned file descriptors, so add static mutexes and use them to wrap access to the driver through read, write and release methods. (4) The driver can only handle one device, so allocate most of the data previously attached to the pde->data as static variables instead (though allocate the validation data buffer with kmalloc). (5) We don't need to save the pde pointers as long as we have the filenames available for removal. (6) Don't try to multiplex what the update file read method does based on the filename. Instead provide separate file ops and split the function. Whilst we're at it, tabulate the procfile information and loop through it when creating or destroying them rather than manually coding each one. [Folded fixes from Vasant Hegde <hegdevasant@linux.vnet.ibm.com>] Signed-off-by:
David Howells <dhowells@redhat.com> cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> cc: Paul Mackerras <paulus@samba.org> cc: Anton Blanchard <anton@samba.org> cc: linuxppc-dev@lists.ozlabs.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Use remove_proc_subtree() rather than remove_proc_entry() to remove a device-specific proc directory and all its children. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Jouni Malinen <j@w1.fi> cc: Johannes Berg <johannes@sipsolutions.net> cc: linux-wireless@vger.kernel.org cc: devel@driverdev.osuosl.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Use remove_proc_subtree() rather than remove_proc_entry() to remove a minor-specific drm proc directory and all its children. Things could theoretically be improved by storing the drm_minor pointer in the minor-specific dir proc_dir_entry struct data and then scrapping the list of proc files - but that's shared with the debugfs interface where you can't do that, so I don't see an easy way of doing it. Signed-off-by:
David Howells <dhowells@redhat.com> cc: dri-devel@lists.freedesktop.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Use minor->index to label things, not the name field from the proc_dir_entry of the /proc/dwm/<minor>/ directory. Also, use "%u" not "%d" to render the value and use a 12-byte buffer in which to render the integer, not a 16-byte buffer. The longest string an unsigned int can give you is 10 chars (4294967295) plus a NUL, so round up to 12 as the stack is likely to be 4- or 8-byte aligned. Signed-off-by:
David Howells <dhowells@redhat.com> cc: dri-devel@lists.freedesktop.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Constify drm_proc_list[] and related pointers. Signed-off-by:
David Howells <dhowells@redhat.com> cc: dri-devel@lists.freedesktop.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't print proc_dir_entry data in debug as we're soon to have no direct access to the contents of the PDE. Print what was put in there instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: mjpeg-users@lists.sourceforge.net cc: linux-media@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't access the proc_dir_entry in ReiserFS's r_open(), r_start() r_show() procfs interface functions. ReiserFS stores the ->show() method pointer in PDE->data and the super_block pointer in PDE->parent->data. This isn't changing. Currently, ReiserFS passes the PDE pointer into seq_file::private from r_open() so that r_start() and r_show() can then access it. Instead, use seq_open_private() to allocate a two-pointer struct that's passed through seq_file::private and put the ->show() method and the sb pointers in there. Signed-off-by:
David Howells <dhowells@redhat.com> cc: reiserfs-devel@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Supply an accessor function for getting the private data from the parent proc_dir_entry struct of the proc_dir_entry struct associated with an inode. ReiserFS, for instance, stores the super_block pointer in the proc directory it makes for that super_block, and a pointer to the respective seq_file show function in each of the proc files in that directory. This allows a reduction in the number of file_operations structs, open functions and seq_operations structs required. The problem otherwise is that each show function requires two pieces of data but only has storage for one per PDE (and this has no release function). Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Mauro Carvalho Chehab <mchehab@redhat.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Jerry Chuang <jerry-chuang@realtek.com> cc: Maxim Mikityanskiy <maxtram95@gmail.com> cc: YAMANE Toshiaki <yamanetoshi@gmail.com> cc: linux-wireless@vger.kernel.org cc: linux-scsi@vger.kernel.org cc: devel@driverdev.osuosl.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Use remove_proc_subtree() to remove the airo device subdir and all its children instead of doing it manually. Signed-off-by:
David Howells <dhowells@redhat.com> cc: linux-wireless@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't need to save the PDE of a directory created under /proc/net/rtl8192/ as we can use proc subtree deletion to get rid of it and all its children. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Mauro Carvalho Chehab <mchehab@redhat.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Jerry Chuang <jerry-chuang@realtek.com> cc: linux-wireless@vger.kernel.org cc: devel@driverdev.osuosl.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Create a dir under /proc/net/r8180/ named for the device and create that device's files under there. This means that there won't be a problem for multiple devices in the system (if such is possible) and it means we don't need to save the 'device directory' PDE any more as we can just do a proc subtree removal. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Maxim Mikityanskiy <maxtram95@gmail.com> cc: YAMANE Toshiaki <yamanetoshi@gmail.com> cc: linux-wireless@vger.kernel.org cc: devel@driverdev.osuosl.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Add proc_mkdir_data() to allow procfs directories to be created that are annotated at the time of creation with private data rather than doing this post-creation. This means no access is then required to the proc_dir_entry struct to set this. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Mauro Carvalho Chehab <mchehab@redhat.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Neela Syam Kolli <megaraidlinux@lsi.com> cc: Jerry Chuang <jerry-chuang@realtek.com> cc: linux-scsi@vger.kernel.org cc: devel@driverdev.osuosl.org cc: linux-wireless@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Move some bits from linux/proc_fs.h to linux/of.h, signal.h and tty.h. Also move proc_tty_init() and proc_device_tree_init() to fs/proc/internal.h as they're internal to procfs. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by:
Grant Likely <grant.likely@secretlab.ca> cc: devicetree-discuss@lists.ozlabs.org cc: linux-arch@vger.kernel.org cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Jri Slaby <jslaby@suse.cz> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Move PDE_NET() to fs/proc/proc_net.c as that's where the only user is. Signed-off-by:
David Howells <dhowells@redhat.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Split the proc namespace stuff out into linux/proc_ns.h. Signed-off-by:
David Howells <dhowells@redhat.com> cc: netdev@vger.kernel.org cc: Serge E. Hallyn <serge.hallyn@ubuntu.com> cc: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Move proc_fd() to fs/proc/fd.h. Signed-off-by:
David Howells <dhowells@redhat.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Uninline pid_delete_dentry() as it's only used by three function pointers. Signed-off-by:
David Howells <dhowells@redhat.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Supply accessor functions to set attributes in proc_dir_entry structs. The following are supplied: proc_set_size() and proc_set_user(). Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Mauro Carvalho Chehab <mchehab@redhat.com> cc: linuxppc-dev@lists.ozlabs.org cc: linux-media@vger.kernel.org cc: netdev@vger.kernel.org cc: linux-wireless@vger.kernel.org cc: linux-pci@vger.kernel.org cc: netfilter-devel@vger.kernel.org cc: alsa-devel@alsa-project.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
- 29 Apr, 2013 22 commits
-
-
David Howells authored
Split kcore bits from linux/procfs.h into linux/kcore.h. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Acked-by:
Ralf Baechle <ralf@linux-mips.org> cc: linux-mips@linux-mips.org cc: sparclinux@vger.kernel.org cc: x86@kernel.org cc: linux-mm@kvack.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Include missing linux/magic.h inclusions where the source file is currently expecting to get magic numbers through linux/proc_fs.h. Signed-off-by:
David Howells <dhowells@redhat.com> cc: linux-efi@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Include missing linux/slab.h inclusions where the source file is currently expecting to get kmalloc() and co. through linux/proc_fs.h. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-s390@vger.kernel.org cc: sparclinux@vger.kernel.org cc: linux-efi@vger.kernel.org cc: linux-mtd@lists.infradead.org cc: devel@driverdev.osuosl.org cc: x86@kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Delete create_proc_read_entry() as it no longer has any users. Also delete read_proc_t, write_proc_t, the read_proc member of the proc_dir_entry struct and the support functions that use them. This saves a pointer for every PDE allocated. Signed-off-by:
David Howells <dhowells@redhat.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Russell King <linux@arm.linux.org.uk> cc: Kevin Hilman <khilman@deeprootsystems.com> cc: Tony Lindgren <tony@atomide.com> cc: linux-arm-kernel@lists.infradead.org cc: linux-omap@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
Tony Lindgren authored
There's no need to keep this entry in proc, it is PM related debug only entry. Let's move it into debugfs. Based on an earlier patch David Howells <dhowells@redhat.com> to use seq_printf and to update to use create_proc_read_entry(). Signed-off-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
David Howells <dhowells@redhat.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Jesper Nilsson <jesper.nilsson@axis.com> cc: Mikael Starvik <starvik@axis.com> cc: linux-cris-kernel@axis.com Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Yoshinori Sato <ysato@users.sourceforge.jp> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Tony Luck <tony.luck@intel.com> cc: Fenghua Yu <fenghua.yu@intel.com> cc: linux-ia64@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Ralf Baechle <ralf@linux-mips.org> cc: linux-mips@linux-mips.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: "James E.J. Bottomley" <jejb@parisc-linux.org> cc: Helge Deller <deller@gmx.de> cc: linux-parisc@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Paul Mundt <lethal@linux-sh.org> cc: linux-sh@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Neela Syam Kolli <megaraidlinux@lsi.com> cc: James E.J. Bottomley <JBottomley@parallels.com> cc: linux-scsi@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Jouni Malinen <j@w1.fi> cc: John W. Linville <linville@tuxdriver.com> cc: Johannes Berg <johannes@sipsolutions.net> cc: linux-wireless@vger.kernel.org cc: netdev@vger.kernel.org cc: devel@driverdev.osuosl.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Simon Kelley <simon@thekelleys.org.uk> cc: John W. Linville <linville@tuxdriver.com> cc: linux-wireless@vger.kernel.org cc: netdev@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Arnd Bergmann <arnd@arndb.de> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Arnd Bergmann <arnd@arndb.de> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Arnd Bergmann <arnd@arndb.de> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Brian S. Julin <bri@calyx.com> cc: Helge Deller <deller@gmx.de> cc: linux-m68k@lists.linux-m68k.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: linux-m68k@lists.linux-m68k.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Li Yang <leoli@freescale.com> cc: Felipe Balbi <balbi@ti.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-usb@vger.kernel.org cc: linuxppc-dev@lists.ozlabs.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
David Howells authored
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by:
David Howells <dhowells@redhat.com> cc: Felipe Balbi <balbi@ti.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-usb@vger.kernel.org Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-