- 29 Sep, 2017 17 commits
-
-
Colin Ian King authored
Variable j is being assigned to loop_j and then later being assigned to a new value in for loops. The first initialization is therefore redundant and can be removed. Cleans up clang warning: warning: Value stored to 'j' is never read Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Colin Ian King authored
The functions hns_roce_table_mhop_get, hns_roce_table_mhop_put, hns_roce_cleanup_mhop_hem_table, hns_roce_v1_post_mbox, hns_roce_cmq_setup_basic_desc, hns_roce_cmq_send, hns_roce_cmq_query_hw_info are all local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'hns_roce_table_mhop_get' was not declared. Should it be static? symbol 'hns_roce_table_mhop_put' was not declared. Should it be static? symbol 'hns_roce_cleanup_mhop_hem_table' was not declared. Should it be static? symbol 'hns_roce_v1_post_mbox' was not declared. Should it be static? symbol 'hns_roce_cmq_setup_basic_desc' was not declared. Should it be static? symbol 'hns_roce_cmq_send' was not declared. Should it be static? symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be static? Signed-off-by:
-
Dan Carpenter authored
These lines were indented too far by mistake. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Leon Romanovsky <leonro@mellanox.com> Acked-by:
Shiraz Saleem <shiraz.saleem@intel.com> Signed-off-by:
-
Ajaykumar Hotchandani authored
Vendor error print should be consistent across protocols to avoid any confusion. This patch corrects that. Suggested-by:
Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by:
Ajaykumar Hotchandani <ajaykumar.hotchandani@oracle.com> Reviewed-by:
Wengang Wang <wen.gang.wang@oracle.com> Reviewed-by:
Yuval Shaia <yuval.shaia@oracle.com> Signed-off-by:
Sagi Grimberg <sagi@grimberg.me> Acked-by:
Roi Dayan <roid@mellanox.com> Signed-off-by:
-
Himanshu Jha authored
Use setup_timer and mod_timer API instead of structure assignments. This is done using Coccinelle and semantic patch used for this as follows: @@ expression x,y,z,a,b; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); Signed-off-by:
Himanshu Jha <himanshujha199640@gmail.com> Signed-off-by:
-
Kalderon, Michal authored
Initialize the rdma_type (iWARP or RoCE) which is set according to device configuration in qed. Fixes: e6a38c54 ("RDMA/qedr: Add support for registering an iWARP device") Signed-off-by:
Michal Kalderon <Michal.Kalderon@cavium.com> Signed-off-by:
Ariel Elior <Ariel.Elior@cavium.com> Signed-off-by:
-
Doug Ledford authored
Signed-off-by: -
Doug Ledford authored
Signed-off-by: -
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor reset_ctxt() to be a bit more manageable. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Michael J. Ruhl <michael.j.ruhl@intel.com> Signed-off-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
-
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor to a common pattern. Refactor _RECV_CTRL, _POLL_TYPE, _ACK_EVENT and _SET_PKEY IOCTLs to a common pattern. Reviewed-by:
-
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor to a common pattern. Refactor _TID_INVAL_READ IOCTLs. Reviewed-by:
-
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor to a common pattern. Refactor the _TID_FREE IOCTL. Reviewed-by:
-
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor to a common pattern. Refactor the _TID_UPDATE IOCTL. Reviewed-by:
-
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor to a common pattern. Reviewed-by:
-
Michael J. Ruhl authored
In preparation to refactoring get_base_info(), cleanup some checkpatch issues. Reviewed-by:
-
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor to a common pattern. Reviewed-by:
-
Michael J. Ruhl authored
The IOCTL is a bit unwieldy. Refactor to a common pattern. Refactor the assign_ctxt() IOCTL. Reviewed-by:
-
- 27 Sep, 2017 23 commits
-
-
Michael J. Ruhl authored
hfi1_rcd_get_by_index assumes that the given index is in the correct range. In most cases this is correct because the index is bounded by a loop. For these cases, adding a range check to the function is redundant. For the use case that is not bounded by the loop range, a _safe wrapper function is needed to validate the index before accessing the rcd array. Add a _safe wrapper to _get_by_index to validate the index range. Update appropriate call sites with the new _safe function. Reviewed-by:
-
Mike Marciniszyn authored
The etype field from the rhf can have more values than just IB and BYPASS. Extend the current tracing to report a symbolic for the etype field for non-bypass packets. Bypass packets will continue to report the l2. As part of this fix the etype and the l2 are added to the tracing struct and are available for trigger and filter operations. Fixes: Commit 863cf89d ("IB/hfi1: Add 16B trace support") Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Signed-off-by:
Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by:
-
Jan Sokolowski authored
Following variables: hfi1_cpulist and hfi1_cpulist_count are unused. Remove them. Reviewed-by:
Harish Chegondi <harish.chegondi@intel.com> Reviewed-by:
Jakub Byczkowski <jakub.byczkowski@intel.com> Signed-off-by:
Jan Sokolowski <jan.sokolowski@intel.com> Signed-off-by:
-
Michael J. Ruhl authored
Calculating the offset to a context is done several times throughout the code. Create a common inlined function for doing this calculation. Reviewed-by:
-
Jan Sokolowski authored
Per-cpu variables int_counter, rcv_limit, and send_schedule print unnecessary error messages on failed allocations. Remove the error messages. Reviewed-by:
-
Ira Weiny authored
devdata->link_default is no longer variable Maintain number of holes by moving dc_shutdown Reviewed-by:
Sebastian Sanchez <sebastian.sanchez@intel.com> Signed-off-by:
-
Ira Weiny authored
There is no reason to set the default descriptor flag on every SDMA engine initialization. Reviewed-by:
-
Michael J. Ruhl authored
The HFI PCI IRQ code uses an obsolete PCI API. Update the code to use the new PCI IRQ API and any necessary changes because of the new API. Reviewed-by:
-
Michael J. Ruhl authored
The QIB PCI IRQ code uses an obsolete PCI API. Updating the code to use the new PCI IRQ API and any necessary changes because of the new API. Reviewed-by:
-
Harish Chegondi authored
Remove the debug trace statement in pin_sdma_pages() that gets executed when there is a memory allocation failure as the trace message doesn't help with debugging the memory allocation failure. Cc: Leon Romanovsky <leon@kernel.org> Reviewed-by:
-
Harish Chegondi authored
AHG_HEADER_SET macro doesn't conform to the coding standards as it can affect the control flow. Convert the macro AHG_HEADER_SET into an inline function ahg_header_set(). Cc: Leon Romanovsky <leon@kernel.org> Reviewed-by:
-
Jakub Byczkowski authored
Add state decodes for link width negotiation, verify cap time out and secure data resolution failures. Reviewed-by:
-
Niranjana Vishwanathapura authored
Add protocol specific routing control information in the encapsulation header as per the configuration. Reviewed-by:
Sudeep Dutt <sudeep.dutt@intel.com> Signed-off-by:
Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> Signed-off-by:
Scott Franco <safranco@intel.com> Signed-off-by:
-
Niranjana Vishwanathapura authored
Update eth_link_status and operating status information to represent the overall status of the virtual Ethernet switch port. Reviewed-by:
-
Scott Franco authored
Clear the MAC table digest when the MAC table is freed. Reviewed-by:
-
Niranjana Vishwanathapura authored
Do not include EM specified MAC address in total MACs of the UC MAC list. Reviewed-by:
-
Niranjana Vishwanathapura authored
Ensure MAC address is reset while deleting the vesw port. Reviewed-by:
-
Niranjana Vishwanathapura authored
Set power on default value of 1500 for eth_mtu. Reviewed-by:
-
Niranjana Vishwanathapura authored
Per pcp mtu fields are not used, mark them as reserved. Reviewed-by:
-
Doug Ledford authored
Signed-off-by: -
Bharat Potnuri authored
Error logs of iw_cxgb4 needs to be printed by default. This patch changes the necessary pr_debug() to appropriate pr_<log level>. Signed-off-by:
Potnuri Bharat Teja <bharat@chelsio.com> Reviewed-by:
Steve Wise <swise@opengridcomputing.com> Signed-off-by:
-
Bharat Potnuri authored
pr_debug() can be enabled to print function names, So removing the unwanted __func__ parameters from debug logs. Realign function parameters. Signed-off-by:
-
Arvind Yadav authored
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by:
Arvind Yadav <arvind.yadav.cs@gmail.com> Reviewed-by:
-
