- 12 Sep, 2011 30 commits
-
-
Roland Vossen authored
brcmf_sdcard_iovar_op was only called with iovar "sd_rxchain", and always returns 'false' as the queried value. Thus, the entire function, related iovar tables and related functions could be removed. Reported-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Linux will never call brcmf_netdev_ioctl_entry() with the value BRCMF_IOCTL_MAGIC in a user space buffer. Thus, unused code could be removed. Reported-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Substituted/moved/removed macro's. Reported-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Substituted/removed macro's. Reported-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Substituted/removed macro's. Reported-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Substituted/removed macro's. Reported-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Use work queue instead. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Howard Harte <hharte@broadcom.com> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete redundant casts from mtrr_add() call. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
The condition for printk() is wrong. Also change it to dev_info(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
MTRR region should be deleted on probe failure and driver removal. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Arvydas Sidorenko authored
crystalhd_fw_if.h: indentation fix (spaces to tabs) The rest are brackets. NOTE: there are quite some 80 character warnings, but they look in place, comments mostly on the right next to the constants and stuff like that. I haven't touched them, since this rule is 'going away', but in case you would like it to be fixed, let me know. I'm sending 2 patches, but it they aren't connected in any way, so doesn't matter the apply order. It's just a cleanup. P.S sorry for the first lame patches a couple of days ago Signed-off-by: Arvydas Sidorenko <asido4@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix long lines in cx25821-video-upstream.h Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix long lines in cx25821-video-upstream.c Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix long lines in cx25821-video-upstream-ch2.h Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix long lines in cx25821-video-upstream-ch2.c Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change obscure line endings to less obscure ones. Rationale: improve readability. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Delete whitespace characters before labels. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Replace :? operator by if-else equivalent where it improves readability. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix long lines in cx25821-audio-upstream.h Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix long lines in cx25821-audio-upstream.c Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change obscure line endings to less obscure ones. Rationale: more readable. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix too long lines in cx25821-audio.h Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix wrong brace placement and statement indent in cx25821-i2c.c Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix wrong brace placement and statement indent in cx25821-core.c Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix wrong brace placement and statement indent in cx25821-cards.c Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Delete file cx25821-gpio.h since it is not used. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Rename _audio_upstream_channel_select to _audio_upstream_channel in in struct cx25821_dev in cx25821.h and all usages of that struct member as well, because _audio_upstream_channel_select is seems to be too long for a variable name. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Get rid of typedef in cx25821.h Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
- 09 Sep, 2011 10 commits
-
-
Nitin Gupta authored
Fixes sparse warning: zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not declared. Should it be static? Also, max_zpage_size is now size_t just to be consistent with data-type of other variables maintaining sizes of various kinds. Signed-off-by: Nitin Gupta <ngupta@vflare.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Jonathan Cameron authored
V3 is a straightforward forward port to teh current tree of V2. Simple fix is to just not cache REG_TEST (offset 8). Cache doesn't help REG_TEST anyway since we write all 8 bits exactly once (at resume/init time). Also fix an "off-by-one" allocation of reg_cache[] array size that was in the original code before I touched it. Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Grant Grundler <grundler@chromium.org> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
Cleanup dated comments in channel_mgmt.c. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
The vmbus devices are NOT child devices; rename vmbus_child_device_unregister to reflect this. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
The vmbus devices are NOT child devices; rename vmbus_child_device_register to reflect this. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
The vmbus devices are NOT child devices; rename vmbus_child_device_create to reflect this. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
H Hartley Sweeten authored
There is no reason to cache the irq_handler in struct dt3155_priv. Just pass the function directly in request_irq. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
H Hartley Sweeten authored
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
H Hartley Sweeten authored
Most of the printk's in this driver are just noise. Proper error codes are being returned so just remove the noise and clean up the whitespace in the code due to the removal. The two messages left in the probe are useful. Convert them to dev_info messages. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: Hans Verkuil <hverkuil@xs4all.nl> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Oren Weil authored
Signed-off-by: Oren Weil <oren.jer.weil@intel.com> Acked-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-