- 05 Dec, 2003 5 commits
-
-
David Brownell authored
A while back there were some reports of ohci reporting a "bad entry" diagnostic, mostly with ISO transfers, which were mysterious until I recently found an easy way to reproduce it. This patch: - Fixes at least one cause of that "bad entry" diagnostic by waiting for INTR_WDH before completing ED unlink processing. (Else URB unlinking could free TDs on the donelist, so the WDH processing would see those entries as "bad".) - Merges the patch from Darwin Rambo <drambo@broadcom.com>, coping with CPUs that can't do 16 bit accesses (MIPS). - Renames a function as start_ed_unlink(), matching its role. - Fixes minor debug output issues, including a FIXME to tell more info about TDs on the periodic schedule. And adding some missing newlines (makes this patch seem big). Nobody's complained much about that "bad entry" issue lately, but if necessary that part would be particularly easy to split out. Please merge to the next kernel that gets USB patches.
-
Alan Stern authored
This patch fixes a simple logic error in the routine that copies data from a driver buffer to a scatter-gather user buffer.
-
Alan Stern authored
This patch does 2 things (bad, I know -- but they're both pretty small and pretty obscure). The CBI specification states in section 2.4.3.1.3 that ... the host shall also issue Clear Feature for Endpoint Halt to the Bulk In pipe if the device reports that the Data In command block has Failed. along with a note in section 2.5.3 that Data Out commands should work analogously. This patch does that, along with cleaning up the status detection logic a little. For Bulk-only transfers we currently ignore the dResidue field in the CSW, except for reporting it (without byte-swapping!) in a debug message. The patch uses it to compute the residue value returned to the SCSI layer. Note that the Bulk-only spec allows devices to transfer more data than they actually use (i.e., they may add padding or ignore stuff) and then inform the host of this by means of the dResidue value. The logic used is simple: our reported residue is the larger of what the device claims and what we didn't transfer, except that it can't be larger than the total transfer length.
-
Alan Stern authored
This patch updates the sdd09 subdriver to make it return Command Failure with appropriate sense data (rather than Tranport Error) when: a MODE-SENSE command requests an unsupported page; a CDB includes an unrecognized command code. This should help prevent confusion and excessive retrying by the SCSI drivers.
-
Ahmon Dancy authored
-
- 04 Dec, 2003 3 commits
-
-
Pete Zaitcev authored
I know Linus is not taking cleanups at this point, but perhaps you can delete it in your tree. Seems like someone (Oliver?) fixed all the garbage in old printer.c, so the comment is not needed anymore. I reviewed changes, and usblp.c looks correct. I'm doing backport to 2.4 for Fedora right now.
-
David Brownell authored
Just for cdc-acm, it pushes RX URB processing into a tasklet; and has minor cleanups. I cc'd Vojtech since he's this driver's maintainer. If this checks out, usb-serial will need similar changes. p.s. the issue is a WARN_ON that tells us: >> [<c012046c>] local_bh_enable+0x8c/0x90 >> [<f8991452>] ppp_asynctty_receive+0x62/0xb0 [ppp_async] >> [<c02144f3>] flush_to_ldisc+0xa3/0x120 >> [<f891f20f>] acm_read_bulk+0xbf/0x140 [cdc_acm] >> [<c02684c9>] usb_hcd_giveback_urb+0x29/0x50 >> [<c027670c>] dl_done_list+0x11c/0x130 >> [<c0277075>] ohci_irq+0x85/0x170 >> [<c0268526>] usb_hcd_irq+0x36/0x60 >> [<c010aeba>] handle_IRQ_event+0x3a/0x70 >> [<c010b227>] do_IRQ+0x97/0x140 >> [<c0109624>] common_interrupt+0x18/0x20
-
bk://linuxusb@linuxusb.bkbits.net/usb-devel-2.6Greg Kroah-Hartman authored
into kroah.com:/home/greg/linux/BK/usb-new_drivers-2.6
-
- 03 Dec, 2003 6 commits
-
-
Greg Kroah-Hartman authored
into kroah.com:/home/greg/linux/BK/usb-new_drivers-2.6
-
Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
Ingo Molnar authored
The pid_alive() check within the loop is incorrect. If we are within the tasklist lock and the thread group leader is valid then the thread chain will be fully intact. Instead, the check should be _outside_ the loop, since if the group leader no longer exists, the whole list is gone and we must not try to access it. Move the check around, and add comment. Bug-hunting and fix by Srivatsa Vaddagiri
-
Pavlin Radoslavov authored
-
Harald Welte authored
-
Hideaki Yoshifuji authored
-
- 02 Dec, 2003 2 commits
-
-
Linus Torvalds authored
-
Linus Torvalds authored
-
- 01 Dec, 2003 2 commits
-
-
Ingo Molnar authored
When doing sync wakeups we must not skip the notification of other cpus if the task is not on this runqueue.
-
Hirofumi Ogawa authored
We need to initialize st->state in tcp_seq_start(). Otherwise tcp_seq_stop() is run with previous st->state, and it calls the unneeded unlock etc, causing a kernel crash.
-
- 26 Nov, 2003 2 commits
-
-
Linus Torvalds authored
-
Ben Collins authored
I've got a lot more changes than what's included here. I've put this down to the bear minimum to get things working sanely. Mainly, I just want to get all the people hit by this a chance to use 2.6.0 without having to get our tree. Changes itemized: - Fix deadlock possibility in csr.c:read_maps() - Fix kmalloc to use ATOMIC in highlevel.c. - s/in_interrupt/irqs_disabled/ in ieee1394_transactions.c to fix warnings when transactions occured. - Introduce a release callback for the host driver and use it correctly. - Reorganize the nodemgr probe so we do an initial scan to discover devices, check IRM/CycleMaster, then do a final full probe when things are kosher. Fixes a problem where device registration and hotplug would cause some serious problems when a bus reset was forced in the middle of the probe.
-
- 25 Nov, 2003 15 commits
-
-
Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
http://lia64.bkbits.net/to-linus-2.5Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
Stephen Hemminger authored
There are /proc handles there setup by proc_tty_register_driver, but there is no module ownership association, so anything that reads after module unload will blow. The trivial fix is to propagate the owner of tty_driver to proc entry.
-
Jan Marek authored
This fixes a small, but important bug in smsc-ircc2.c. Without this the driver tries release the same region twice.
-
David Mosberger authored
Tracked down by Rohit Seth.
-
David Mosberger authored
-
Jean Tourrilhes authored
Do not special case ENOMEM as an error code, we should free up the packet for all errors.
-
Pete Zaitcev authored
Most of the breakage came from cset 1.838.10.3
-
Pete Zaitcev authored
-
Bart De Schuymer authored
The br_netfilter_{init,fini}() calls need to be guarded by BRIDGE_NETFILTER, from Michal Janusz Miroslaw.
-
Hideaki Yoshifuji authored
When bringing an interface down do not forget to clear the IF_RS_SENT and IF_RA_RCVD flags.
-
bk://gkernel.bkbits.net/libata-2.5Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
Dave Kleikamp authored
This fixes an oops that can occur if JFS is used as the root filesystem. Writes to a device node may cause a ->write_inode to be called during a read-only mount. JFS needs to check for NULL log in jfs_flush_journal.
-
Linus Torvalds authored
-
- 24 Nov, 2003 5 commits
-
-
Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
David S. Miller authored
Also, make sure NET_RX_DROP is returned if we did not accept the packet.
-
David S. Miller authored
-
David S. Miller authored
In implementations that use no socket locking, such as RAW sockets, once we queue the SKB to the socket another cpu can remove the SKB from the socket queue and free up the SKB making the skb->len access touch freed memory. Based upon a report from Burton Windle, kernel bugzilla #937
-
bk://linux-scsi.bkbits.net/scsi-bugfixes-2.6Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-