- 25 Aug, 2017 40 commits
-
-
Hannes Reinecke authored
VMWare ESXi emulates an mptsas HBA, but exposes all drives as direct-attached SAS drives. This it not how the driver originally envisioned things; SAS drives were supposed to be connected via an expander, and only SATA drives would be direct attached. As such, any hotplug event for direct-attach SAS drives was silently ignored, and the guest failed to detect new drives from within a VMWare ESXi environment. [mkp: typos] Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1030850Signed-off-by:
Hannes Reinecke <hare@suse.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Bhumika Goyal authored
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
weiping zhang authored
gd->minors has been set when call alloc_disk() in sd_probe. Signed-off-by:
weiping zhang <zhangweiping@didichuxing.com> Signed-off-by:
-
Hannes Reinecke authored
Just displaying some different information; drop it. Signed-off-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by:
-
Hannes Reinecke authored
There's no need to keep the private data for a device in a separate list; better to store it in ->hostdata and do away with the additional list. Signed-off-by:
David Kershner <david.kershner@unisys.com> Signed-off-by:
-
Hannes Reinecke authored
megaraid_mbox only has one reset function, and that is a host reset. So drop the duplicate bus reset and device reset functions. Signed-off-by:
-
Hannes Reinecke authored
Never used anywhere. Signed-off-by:
-
Hannes Reinecke authored
bus reset always returns SUCCESS, meaning host reset was never tested. At the same time the only difference to the HBA is a missing call to NCR_700_chip_reset(). So add the missing call to bus reset, drop host reset, and move bus reset to host reset. Signed-off-by:
-
Hannes Reinecke authored
The driver has both a bus and a host reset, where the host reset does a bus reset followed by an attempt to reset the chip registers to a default state. However, as the bus reset always returned SUCCESS the host reset was never called, so the functionality of the register reset function was never validated. Additionally, tha AIC-6260 chip has a hard reset line, which actually should be preferred for a host reset. But I haven't found a way how this can be triggered via software, so take the safe approach and drop the host reset. [mkp: typo] Signed-off-by:
-
Hannes Reinecke authored
bus reset is a host reset without nsp32hw_init(), and will always return SUCCESS, thus disabling the use of host reset. So drop bus reset in favour of host reset. Signed-off-by:
-
Hannes Reinecke authored
qedf has a host reset handler, but as the bus reset handler is a stub always returning SUCCESS the host reset is never invoked. So drop the bus reset handler. Signed-off-by:
Chad Dupuis <chad.dupuis@cavium.com> Signed-off-by:
-
Hannes Reinecke authored
bus_reset and host_reset are the same functions, so drop bus_reset. Signed-off-by:
-
Hannes Reinecke authored
host_reset and bus_reset is the same function, so drop bus reset. Signed-off-by:
-
Hannes Reinecke authored
The bus reset handler is really a host reset. Signed-off-by:
-
Hannes Reinecke authored
The bus reset handler really is a host reset, so move it to eh_bus_reset_handler. Signed-off-by:
Finn Thain <fthain@telegraphics.com.au> Reviewed-by:
-
Hannes Reinecke authored
The bus reset function is really a host reset, so move it to eh_host_reset_handler. Signed-off-by:
-
Hannes Reinecke authored
The bus reset function really is a host reset, so move it to eh_host_reset_handler(). Signed-off-by:
-
Hannes Reinecke authored
Function is a stub, so can as well be dropped. Signed-off-by:
-
Hannes Reinecke authored
The bus reset function is just a wrapper calling host reset under the host lock. So move taking of the host lock into the host reset function and drop bus reset. Signed-off-by:
-
Hannes Reinecke authored
The bus reset function really is a host reset, so move it to eh_host_reset_handler(). Signed-off-by:
-
Hannes Reinecke authored
The Highpoint driver only has one reset function, and that is a host reset. So stop pretending we're doing anything else. Signed-off-by:
-
Hannes Reinecke authored
The bus reset handler is just calling target reset on all targets, which is exactly what SCSI EH will be doing anyway. So move the bus reset function to target reset and drop the loop. Signed-off-by:
-
Hannes Reinecke authored
The bus reset handler is calling I_T Nexus reset, which logically is a target reset as it need to specify both the initiator and the target. So move it to target reset. Signed-off-by:
-
Hannes Reinecke authored
The bus_reset handler is really a device reset, so move it to eh_device_reset_handler(). Signed-off-by:
-
Hannes Reinecke authored
Command abort already returns FAILED, which will then be escalated to a host reset. So no need to call host_reset directly. Signed-off-by:
-
Hannes Reinecke authored
When calling host reset we're resetting all ports anyway, so there is no point in waiting for the ports to become unblocked. Signed-off-by:
-
Hannes Reinecke authored
When we're resetting the host any remote port states will be reset anyway, so it's pointless to wait for dev_loss_tmo during host reset. Signed-off-by:
Hannes Reinecke <hare@suse.de> Reviewed-by:
-
Hannes Reinecke authored
When we're resetting the host any remote port states will be reset anyway, so it's pointless to wait for dev_loss_tmo during host reset. Signed-off-by:
-
Hannes Reinecke authored
The function returns '0' if successful; with the original comment the function doesn't have a way to indicate success ... Signed-off-by:
Bart van Assche <bvanassche@wdc.com> Reviewed-by:
-
Bart Van Assche authored
This patch avoids that gcc reports the following warning when building with W=1: drivers/scsi/iscsi_tcp.c:166:24: warning: variable ?session? set but not used [-Wunused-but-set-variable] Signed-off-by:
Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by:
-
Bart Van Assche authored
This patch avoids that gcc reports the following warning when building with W=1: drivers/scsi/scsi_debug.c:2264:15: warning: variable ?pcontrol? set but not used [-Wunused-but-set-variable] Signed-off-by:
-
Bart Van Assche authored
Avoid that the following compiler warning is reported when building with W=1: drivers/scsi/scsi_transport_srp.c:92:19: warning: comparison is always false due to limited range of data type [-Wtype-limits] Signed-off-by:
-
Bart Van Assche authored
Check whether memory allocation succeeded before dereferencing the pointer to the allocated memory. Signed-off-by:
-
Bart Van Assche authored
Signed-off-by:
-
Bart Van Assche authored
This was detected by building with W=1. Signed-off-by:
-
Bart Van Assche authored
This patch avoids that smatch reports the following: drivers/scsi/libiscsi.c:1081: iscsi_handle_reject() warn: inconsistent indenting Signed-off-by:
-
Bart Van Assche authored
Avoid that sparse reports the following: drivers/scsi/sg.c:1114:41: warning: incorrect type in argument 5 (different address spaces) drivers/scsi/sg.c:1114:41: expected char [noderef] <asn:1>*arg drivers/scsi/sg.c:1114:41: got char *<noident> This patch does not change any functionality. Signed-off-by:
-
Bart Van Assche authored
This patch avoids that gcc reports the following warning when building with W=1: drivers/scsi/sd.c:315:10: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if (val >= 0 && val <= T10_PI_TYPE3_PROTECTION) Signed-off-by:
-
Bart Van Assche authored
This patch avoids that smatch reports the following: drivers/scsi/sd.c:3540: sd_suspend_common() warn: inconsistent indenting Signed-off-by:
-
Bart Van Assche authored
Before scsi_prep_fn() calls the ULP .init_command() callback function it stores the SCSI command pointer in request.special. This means that the SCpnt = rq->special assignments in the sd and sr drivers assign a pointer to itself. Hence convert these two assignment statements into warning statements. Signed-off-by:
Bart Van Assche <bart.vanassche@sandisk.com> Reviewed-by:
-
