- 05 Jan, 2014 8 commits
-
-
Sergei Shtylyov authored
phy_scan_fixups() isn't and shouldn't be called by the drivers directly, so unexport it. And since Florian Fainelli's recent patches, the function is only called locally, so we can make it static as well. Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Sergei Shtylyov authored
Remove adjust_state() callback from 'struct phy_device' since it seems to have never been really used from the inception: phy_start_machine() has been always called with 2nd argument equal to NULL. Signed-off-by:
-
Sergei Shtylyov authored
Remove excess empty lines such as those between a function call and its result check and just duplicate ones between functions. Signed-off-by:
-
Sergei Shtylyov authored
Remove some excess code: - convert assignments to initializers; - kill useless assignments before *return*. Signed-off-by:
-
Sergei Shtylyov authored
A number of functions (especially in phy.c) has local variables that were hardly needed in the first place -- remove them. Signed-off-by:
-
Sergei Shtylyov authored
Running 'checkpatch.pl' gives some errors and warnings: - no spaces around =; - * separated by space from the function name; - { in function definition not on a separate line; - line over 80 characters. While fixing these, also fix the following style issues: - file name in the heading comment; - alignment not matching open paren. Signed-off-by: -
Sergei Shtylyov authored
The recent patch from Florian Fainelli fixed all 'checkpatch.pl' errors but left some warnings like: - including <asm/io.h> instead of <linux/io.h>; - including <asm/uaccess.h> instead of <linux/uaccess.h>; - block comments using empty /* line; - 'struct dev_pm_ops' variable not being *const*. While fixing these, also fix the following style issues (some of which were found running 'checkpatch.pl --strict'): - alignment not matching open paren; - file name in the heading comment. Signed-off-by:
-
Sergei Shtylyov authored
The recent patch from Florian Fainelli fixed all 'checkpatch.pl' errors but left the numerous warnings: - including <asm/io.h> instead of <linux/io.h>; - including <asm/uaccess.h> instead of <linux/uaccess.h>; - *extern* declaration in .c file; - block comments using empty /* line; - block comments not starting with * on the middle lines; - block comments not having trailing */ on a separate line; - EXPORT_SYMBOL() not immediately following its function; - unnecessary {} for signle statement block; - spaces before tabs. While fixing these, also fix the following style issues (some of which were found running 'checkpatch.pl --strict'): - alignment not matching open paren; - missing {} on one of the *if* arms where another has them; - use of sizeof(struct structure) instead of sizeof(*variable); - multiple assignments on one line; - empty line before }; - file names in the heading comments; - missing spaces around operators; - no {} around multi-line *if* operator's arm; - unneeded () around subexpressions; - incomplete kernel-doc comment style; - comment line exceeding 80 characters; - missing empty line after declarations. Signed-off-by:
-
- 04 Jan, 2014 22 commits
-
-
David S. Miller authored
Scott Feldman says: ==================== bonding: final set of netlink patches v2: - per Jiri's comment, fix ad_select checking against parm table by spliting bond_parse_parm() into several funcs. Go ahead and apply same technique to all parameters using parm table. - fix netlink msg size to including missing nest attr - drop the last patch for active_slaves. This patch needs to be reworked per Jiri's comments and shouldn't hold up finalizing the conversion of the existing parameter to netlink attributes. Ding, assuming this patch set goes in, you should have all you need to start converting module parameter setting/checking over to funcs in *_options.c. I'll send iproute2 patch for bonding netlink support once this patch set is accepted. v1: The following series implements the last set of bonding netlink attributes for 802.3ad mode: lacp_rate ad_select ad_info, nest of: ad_aggregator ad_num_ports ad_actor_key ad_partner_key ad_partner_mac The last patch adds an additional netlink attribute, active_slaves, which is a nested list of ifindices for current active slaves. We're using this list to enable/disable hashing of ports in a hardware LAG implementation. In the same way bonding driver includes/excludes ports for 802.3ad egress hashing, hardware ports are included/excluded from egress hashing by hardware based on port active status. Yes, data path offloaded to hardware, control path remains in kernel via bonding driver. ==================== Signed-off-by: -
sfeldma@cumulusnetworks.com authored
Add bounds checking for params defined with parm tbl. Signed-off-by:
Scott Feldman <sfeldma@cumulusnetworks.com> Signed-off-by:
-
sfeldma@cumulusnetworks.com authored
Add missing space for IFLA_BOND_ARP_IP_TARGET nest header. Signed-off-by:
-
sfeldma@cumulusnetworks.com authored
Add nested IFLA_BOND_AD_INFO for bonding 802.3ad info. Signed-off-by:
-
sfeldma@cumulusnetworks.com authored
Add IFLA_BOND_AD_SELECT to allow get/set of bonding parameter ad_select via netlink. Signed-off-by:
-
sfeldma@cumulusnetworks.com authored
Add IFLA_BOND_AD_LACP_RATE to allow get/set of bonding parameter lacp_rate via netlink. Signed-off-by:
-
David S. Miller authored
Nithin Nayak Sujir says: ==================== tg3: Unicast filter support and misc fixes Michael Chan (2): tg3: Refactor __tg3_set_mac_addr() tg3: Add unicast filtering support. Nithin Nayak Sujir (3): tg3: Set the MAC clock to the fastest speed during boot code load tg3: Poll cpmu link state on APE + ASF enabled devices tg3: Update version to 3.136 ==================== Signed-off-by: -
Nithin Sujir authored
Signed-off-by:
Michael Chan <mchan@broadcom.com> Signed-off-by:
Nithin Nayak Sujir <nsujir@broadcom.com> Signed-off-by:
-
Nithin Sujir authored
On ASF enabled devices where the mgmt firmware runs on the application processing engine, there is a race between the tg3 driver processing a link change event and the ASF firmware clearing the link changed bit in the EMAC status register. This leads to link notifications to the driver sometimes getting lost. Poll the CPMU link state as a backup for the normal interrupt path update if ASF is enabled. Signed-off-by:
-
Nithin Sujir authored
On the 5717, 5718 and 5719 devices, the bootcode runs slower when any port doesn't have a link due to clock speed slowing down as part of the link-aware feature. This leads to the driver timing out waiting for the bootcode signature. This patch overrides the clock policy to the highest frequency just before reset and restores it after the bootcode is up. Signed-off-by:
-
Michael Chan authored
Up to 3 additional unicast addresses can be added to the perfect match filter table. Signed-off-by:
-
Michael Chan authored
so that individual MAC address filter entries can be set. Signed-off-by:
-
stephen hemminger authored
The llc_sap_list_lock does not need to be global, only acquired in core. Signed-off-by:
Stephen Hemminger <stephen@networkplumber.org> Signed-off-by:
-
stephen hemminger authored
Namespace related cleaning * make cred_to_ucred static * remove unused sock_rmalloc function Signed-off-by:
-
Sergei Shtylyov authored
Running 'scripts/checkpatch.pl' on the driver files gives numerous warnings: - block comments using empty /* line; - unneeded \ at end of lines; - message string split across lines; - use of __attribute__((aligned(n))) instead of __aligned(n) macro; - use of __attribute__((packed)) instead of __packed macro. Additionally, running 'scripts/checkpatch.pl --strict' gives more complaints: - including the paragraph about writing to FSF into the heading comment; - alignment not matching open paren; - multiple assignments on one line; - use of CamelCase names; - missing {} on one of the *if* arms where another has them; - spinlock definition without a comment. While fixing these, also do some more style cleanups: - remove useless () around expressions; - add {} around multi-line *if* operator's arm; - remove space before comma; - add spaces after /* and before */; - properly align continuation lines of broken up expressions; - realign comments to the structure fields. Signed-off-by: -
hayeswang authored
The return value should be the boolean value, not the error code. Signed-off-by:
Hayes Wang <hayeswang@realtek.com> Spotted-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e1,e2; @@ pci_enable_wake(e1, - 0 + PCI_D0 ,e2) // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
David S. Miller authored
Tom Herbert says: ==================== ipv4: Cache dst in tunnels Version 3 of caching routes in tunnels. Addressed some comments from Eric in this series. There are two patches (variants) in the series: 1) One dst cached for each tunnel. 2) Percpu dst cache per tunnel to avoid false sharing Testing with GRE tunnels on a 32 CPU host with bnx2x (RSS support for GRE) shows a modest improvement in CPU utilization with these patches running 200 TCP_RR netperf clients. Without patches 71.22% CPU utilization 138/180/244 90/95/99% latencies 1.30465e+06 CPU/tps 18318 CPU/tps With patches 69.84% 142/186/249 90/95/99% latencies 1.30827e+06 18732 CPU/tps ==================== Signed-off-by: -
Tom Herbert authored
percpu route cache eliminates share of dst refcnt between CPUs. Signed-off-by:
Tom Herbert <therbert@google.com> Signed-off-by:
-
Tom Herbert authored
Avoid doing a route lookup on every packet being tunneled. In ip_tunnel.c cache the route returned from ip_route_output if the tunnel is "connected" so that all the rouitng parameters are taken from tunnel parms for a packet. Specifically, not NBMA tunnel and tos is from tunnel parms (not inner packet). Signed-off-by:
-
Neil Horman authored
Recently I updated the sctp socket option deprecation warnings to be both a bit more clear and ratelimited to prevent user processes from spamming the log file. Ben Hutchings suggested that I add the process name and pid to these warnings so that users can tell who is responsible for using the deprecated apis. This patch accomplishes that. Signed-off-by:
Neil Horman <nhorman@tuxdriver.com> CC: Vlad Yasevich <vyasevich@gmail.com> CC: Ben Hutchings <bhutchings@solarflare.com> CC: "David S. Miller" <davem@davemloft.net> CC: netdev@vger.kernel.org Signed-off-by:
-
Julia Lawall authored
Netdev_priv performs an addition, not a pointer dereference, so it seems quite unlikely that its result would ever be NULL. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ statement S; @@ - if (!netdev_priv(...)) S // </smpl> Signed-off-by:
Grant Grundler <grundler@parisc-linux.org> Signed-off-by:
-
- 03 Jan, 2014 1 commit
-
-
Cong Wang authored
This reverts commit de6fb288. Otherwise we got: net/sched/cls_cgroup.c:106:29: error: static declaration of ‘net_cls_subsys’ follows non-static declaration static struct cgroup_subsys net_cls_subsys = { ^ In file included from include/linux/cgroup.h:654:0, from net/sched/cls_cgroup.c:18: include/linux/cgroup_subsys.h:35:29: note: previous declaration of ‘net_cls_subsys’ was here SUBSYS(net_cls) ^ make[2]: *** [net/sched/cls_cgroup.o] Error 1 Cc: Stephen Hemminger <stephen@networkplumber.org> Cc: David S. Miller <davem@davemloft.net> Signed-off-by:
Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by:
-
- 02 Jan, 2014 9 commits
-
-
stephen hemminger authored
Doesn't need to be global. Signed-off-by:
-
stephen hemminger authored
No need to export functions only used in one file. Signed-off-by:
Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by:
-
Shawn Bohrer authored
If the hwtstamp_config matches what is currently set for the device then simply return. Without this change any program that tries to enable hardware timestamps will cause the link to cycle even if hardware timstamps were already enabled. Signed-off-by:
Shawn Bohrer <sbohrer@rgmadvisors.com> Acked-By:
Hadar Hen Zion <hadarh@mellanox.com> Acked-by:
Richard Cochran <richardcochran@gmail.com> Signed-off-by:
-
Shawn Bohrer authored
This adds a PHC to the mlx4_en driver. We use reader/writer spinlocks to protect the timecounter since every packet received needs to call timecounter_cycle2time() when timestamping is enabled. This can become a performance bottleneck with RSS and multiple receive queues if normal spinlocks are used. This driver has been tested with both Documentation/ptp/testptp and the linuxptp project (http://linuxptp.sourceforge.net/) on a Mellanox ConnectX-3 card. Signed-off-by:
-
Weilong Chen authored
Signed-off-by:
Weilong Chen <chenweilong@huawei.com> Signed-off-by:
-
Weilong Chen authored
Signed-off-by:
-
Sachin Kamat authored
Commit 2960ed34 ("ARM: netx: move platform_data definitions") moved the file to the current location but forgot to remove the pointer to its previous location. Clean it up. While at it also change the header file protection macros appropriately. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by:
-
Julia Lawall authored
Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by:
-
Julia Lawall authored
Set the return variable to propagate any error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by:
-
