• Shivji Kumar Jha's avatar
    BUG#15965353- RPL.RPL_ROW_UNTIL FAILS ON PB2, · 5fcf40a2
    Shivji Kumar Jha authored
                  PLATFORM= MACOSX10.6 X86_64 MAX
    
    Problem: The test was failing on pb2's mac machine because
             it was not cleaned up properly. The test checks if
             the command 'start slave until' throws a proper
             error when issued with a wrong number/type of
             parameters. After this,the replication stream was
             stopped using the include file 'rpl_end.inc'.
             The errors thrown earlier left the slave in an
             inconsistent state to be closed by the include
             file which was caught by the mac machine.
    
    Fix: Started slave by invoking start_slave.inc to have a
         working slave before calling rpl_reset.inc
    
    Problem: The test file was not in a good shape. It tested
             start slave until relay log file/pos combination 
             wrongly. A couple of commands were executed at 
             master and replicated at slave. Next, the 
             coordinates in terms of relay log file and pos 
             were noted down followed by reset slave and start
             slave until saved relay log file/pos. Reset slave
             deletes  all relay log files and makes the slave 
             forget its replication position. So, using the 
             saved coordiantes after reset slave is wrong.
    
    Fix: Split the test in two parts:
         a) Test for start slave until master log file/pos and
            checking for correct errors in the failure 
            scenarios.
         b) Test for start slave until relay log file/pos.
    
    Problem: The variables auto_increment_increment and 
             auto_increment_offset were set in the the include
             file rpl_init.inc. This was only configured for 
             some connections that are rarely used by test 
             cases, so likely that it will cause confusion. 
             If replication tests want to setup these variables
             they should do so explicitly.
    
    Fix:
         a) Removed code to set the variables
            auto_increment_increment and auto_increment_offset
            in the include file.
         b) Updated tests files using the same.
    5fcf40a2
rpl_init.inc 7.08 KB