WL#4380: abi_check rule (using gcc -E) for storage engine API
Added a rule that uses gcc to generate preprocessor output (gcc -E) that can be compared to an already generated output using the diff utility. icheck has been removed and replaced by gcc -E because icheck does not support C++. Makefile.am: Added a rule for checking that the abi/api has not changed. The following rules are followed in the rule in makefile.am 1) Generate preprocessor output for the files that need to be tested for abi/ api changes. use -nostdinc to prevent generation of preprocessor output for system headers. This results in messages in stderr saying that these headers were not found. Redirect the stderr output to /dev/null to prevent seeing these messages. 2) sed the output to 2.1) remove blank lines and lines that begin with "# " 2.2) When gcc -E is run on the Mac OS and solaris sparc platforms it introduces a line of output that shows up as a difference between the .pp and .out files. Remove these OS specific preprocessor text inserted by the preprocessor. 3) diff the generated file and the canons (.pp files already in the repository). 4) delete the .out file that is generated. If the diff fails, the generated file is not removed. This will be useful for analysis of ABI differences (e.g. using a visual diff tool). A ABI change that causes a build to fail will always be accompanied by new canons (.out files). The .out files that are not removed will be replaced as the new .pp files. e.g. If include/mysql/plugin.h has an ABI change then this rule would leave a <build directory>/abi_check.out file. A developer with a justified API change will then do a mv <build directory>/abi_check.out include/mysql/plugin.pp to replace the old canons with the new ones. configure.in: 1) Removed the part of the file that was icheck related 2) Added an entry for the configure variable DIFF 3) Ensured that the abi_check rule is run only if gcc is available include/Makefile.am: 1) Removed the icheck related entries include/mysql.h.pp: The pre-processor output cannon file for include/mysql.h include/mysql/plugin.h.pp: The pre-processor output cannon file for include/mysql/plugin.h include/mysql_h.ic: Removed the cannon file related to icheck. sql/mysql_priv.h.pp: The pre-processor output cannon file for sql/mysql_priv.h
Showing
include/mysql.h.pp
0 → 100644
include/mysql/plugin.h.pp
0 → 100644
include/mysql_h.ic
deleted
100644 → 0
sql/mysql_priv.h.pp
0 → 100644
This source diff could not be displayed because it is too large. You can view the blob instead.
Please register or sign in to comment