Commit 1bd50ced authored by unknown's avatar unknown

Cleanup testcases

 - Add  missing drop(s)
 - Reset changed variables

NOTE! These kind of problems are easily found with --check-testcases options to mysql-test-run.pl 


mysql-test/extra/rpl_tests/rpl_insert_id_pk.test:
  Add missing drop table
mysql-test/extra/rpl_tests/rpl_loaddata.test:
  Add missing drop table
mysql-test/extra/rpl_tests/rpl_log.test:
  Tables where only dropped on slave, switch to master connection before dropping them
mysql-test/extra/rpl_tests/rpl_multi_update3.test:
  Add missing drop table
mysql-test/extra/rpl_tests/rpl_row_sp006.test:
  Add missing drop database
mysql-test/include/check-testcase.test:
  Add option "--skip-lock-tables" when dumping tables, as noone else is using the tables anyway
mysql-test/r/ndb_cache_multi.result:
  Reset query_cache_size after test on both master and "second" master mysqld
mysql-test/r/partition.result:
  Add missing drop procedure
mysql-test/r/rpl_drop_db.result:
  Add missing drop table
mysql-test/r/rpl_multi_update3.result:
  Add missing drop table
mysql-test/r/rpl_ndb_multi_update3.result:
  Add missing drop table
mysql-test/r/rpl_ndb_sp006.result:
  Add missing drop database
mysql-test/r/rpl_stm_no_op.result:
  Add missing drop table
mysql-test/r/rpl_variables.result:
  Reset slave_net_timeout to it's default value after test
mysql-test/t/ndb_cache_multi.test:
  Reset query_cahche_size after test
mysql-test/t/partition.test:
  Add missing drop procedure
mysql-test/t/rpl_drop_db.test:
  Add missing drop table
mysql-test/t/rpl_stm_no_op.test:
  Add missing drop table
mysql-test/t/rpl_variables.test:
  Reset slave_net_timeout to it's default value after test
parent 9186349e
...@@ -83,5 +83,6 @@ SET FOREIGN_KEY_CHECKS=0; ...@@ -83,5 +83,6 @@ SET FOREIGN_KEY_CHECKS=0;
--error 1022, 1062 --error 1022, 1062
INSERT INTO t1 VALUES (1),(1); INSERT INTO t1 VALUES (1),(1);
sync_slave_with_master; sync_slave_with_master;
connection master;
drop table t1;
# End of 4.1 tests # End of 4.1 tests
...@@ -152,5 +152,5 @@ wait_for_slave_to_stop; ...@@ -152,5 +152,5 @@ wait_for_slave_to_stop;
drop table t2; drop table t2;
connection master; connection master;
drop table t2; drop table t2;
drop table t1;
# End of 4.1 tests # End of 4.1 tests
...@@ -126,7 +126,7 @@ show slave status; ...@@ -126,7 +126,7 @@ show slave status;
show binlog events in 'slave-bin.000005' from 4; show binlog events in 'slave-bin.000005' from 4;
# The table drops caused Cluster Replication wrapper to fail as event ID would never be the same.# Moving drops here. # The table drops caused Cluster Replication wrapper to fail as event ID would never be the same.# Moving drops here.
connection master;
DROP TABLE t1; DROP TABLE t1;
DROP TABLE t2; DROP TABLE t2;
DROP TABLE t3; DROP TABLE t3;
...@@ -217,4 +217,6 @@ select "-- SLAVE AFTER JOIN --" as ""; ...@@ -217,4 +217,6 @@ select "-- SLAVE AFTER JOIN --" as "";
select * from t1; select * from t1;
select * from t2; select * from t2;
connection master;
DROP TABLE t1, t2;
# End of 4.1 tests # End of 4.1 tests
...@@ -76,6 +76,7 @@ DROP PROCEDURE IF EXISTS mysqltest1.p1; ...@@ -76,6 +76,7 @@ DROP PROCEDURE IF EXISTS mysqltest1.p1;
DROP PROCEDURE IF EXISTS mysqltest1.p2; DROP PROCEDURE IF EXISTS mysqltest1.p2;
DROP TABLE IF EXISTS mysqltest1.t1; DROP TABLE IF EXISTS mysqltest1.t1;
DROP TABLE IF EXISTS mysqltest1.t2; DROP TABLE IF EXISTS mysqltest1.t2;
DROP DATABASE mysqltest1;
# Lets compare. Note: If they match test will pass, if they do not match # Lets compare. Note: If they match test will pass, if they do not match
# the test will show that the diff statement failed and not reject file # the test will show that the diff statement failed and not reject file
......
...@@ -21,13 +21,13 @@ show databases; ...@@ -21,13 +21,13 @@ show databases;
# #
# Dump the "test" database, all it's tables and their data # Dump the "test" database, all it's tables and their data
# #
--exec $MYSQL_DUMP --skip-comments test --exec $MYSQL_DUMP --skip-comments --skip-lock-tables test
# #
# Dump the "mysql" database and it's tables # Dump the "mysql" database and it's tables
# Select data separately to add "order by" # Select data separately to add "order by"
# #
--exec $MYSQL_DUMP --skip-comments --no-data mysql --exec $MYSQL_DUMP --skip-comments --skip-lock-tables --no-data mysql
use mysql; use mysql;
select * from columns_priv; select * from columns_priv;
select * from db order by host, db, user; select * from db order by host, db, user;
......
...@@ -70,3 +70,5 @@ show status like "Qcache_hits"; ...@@ -70,3 +70,5 @@ show status like "Qcache_hits";
Variable_name Value Variable_name Value
Qcache_hits 0 Qcache_hits 0
drop table t1, t2; drop table t1, t2;
set GLOBAL query_cache_size=0;
set GLOBAL query_cache_size=0;
...@@ -717,6 +717,7 @@ CALL test.p1(13); ...@@ -717,6 +717,7 @@ CALL test.p1(13);
Warnings: Warnings:
Warning 1196 Some non-transactional changed tables couldn't be rolled back Warning 1196 Some non-transactional changed tables couldn't be rolled back
drop table t1; drop table t1;
drop procedure test.p1;
CREATE TABLE t1 (a int not null) CREATE TABLE t1 (a int not null)
partition by key(a) partition by key(a)
(partition p0 COMMENT='first partition'); (partition p0 COMMENT='first partition');
......
...@@ -33,3 +33,5 @@ n ...@@ -33,3 +33,5 @@ n
1234 1234
DROP DATABASE mysqltest1; DROP DATABASE mysqltest1;
stop slave; stop slave;
use test;
drop table t1;
...@@ -194,3 +194,4 @@ idpro price nbprice ...@@ -194,3 +194,4 @@ idpro price nbprice
1 1.0000 3 1 1.0000 3
2 1.0000 2 2 1.0000 2
3 2.0000 1 3 2.0000 1
DROP TABLE t1, t2;
...@@ -194,3 +194,4 @@ idpro price nbprice ...@@ -194,3 +194,4 @@ idpro price nbprice
1 1.0000 3 1 1.0000 3
2 1.0000 2 2 1.0000 2
3 2.0000 1 3 2.0000 1
DROP TABLE t1, t2;
...@@ -43,3 +43,4 @@ DROP PROCEDURE IF EXISTS mysqltest1.p1; ...@@ -43,3 +43,4 @@ DROP PROCEDURE IF EXISTS mysqltest1.p1;
DROP PROCEDURE IF EXISTS mysqltest1.p2; DROP PROCEDURE IF EXISTS mysqltest1.p2;
DROP TABLE IF EXISTS mysqltest1.t1; DROP TABLE IF EXISTS mysqltest1.t1;
DROP TABLE IF EXISTS mysqltest1.t2; DROP TABLE IF EXISTS mysqltest1.t2;
DROP DATABASE mysqltest1;
...@@ -49,4 +49,4 @@ select * from t1; ...@@ -49,4 +49,4 @@ select * from t1;
a b a b
select * from t2; select * from t2;
a b a b
drop table t1; drop table t1, t2;
...@@ -15,3 +15,4 @@ slave_load_tmpdir SLAVE_LOAD_TMPDIR ...@@ -15,3 +15,4 @@ slave_load_tmpdir SLAVE_LOAD_TMPDIR
show variables like 'slave_skip_errors'; show variables like 'slave_skip_errors';
Variable_name Value Variable_name Value
slave_skip_errors 3,100,137,643,1752 slave_skip_errors 3,100,137,643,1752
set global slave_net_timeout=default;
...@@ -63,3 +63,10 @@ show status like "Qcache_hits"; ...@@ -63,3 +63,10 @@ show status like "Qcache_hits";
drop table t1, t2; drop table t1, t2;
# Turn off query cache on server1
connection server1;
set GLOBAL query_cache_size=0;
# Turn off query cache on server2
connection server2;
set GLOBAL query_cache_size=0;
...@@ -846,6 +846,7 @@ delimiter ;| ...@@ -846,6 +846,7 @@ delimiter ;|
CALL test.p1(12); CALL test.p1(12);
CALL test.p1(13); CALL test.p1(13);
drop table t1; drop table t1;
drop procedure test.p1;
# #
# Bug 13520: Problem with delimiters in COMMENT DATA DIRECTORY .. # Bug 13520: Problem with delimiters in COMMENT DATA DIRECTORY ..
......
...@@ -56,3 +56,7 @@ connection slave; ...@@ -56,3 +56,7 @@ connection slave;
stop slave; stop slave;
#system rm -rf $MYSQLTEST_VARDIR/master-data/mysqltest1; #system rm -rf $MYSQLTEST_VARDIR/master-data/mysqltest1;
connection master;
use test;
drop table t1;
...@@ -89,5 +89,5 @@ select * from t2; ...@@ -89,5 +89,5 @@ select * from t2;
# cleanup # cleanup
connection master; connection master;
drop table t1; drop table t1, t2;
sync_slave_with_master; sync_slave_with_master;
...@@ -12,3 +12,6 @@ show variables like 'slave_load_tmpdir'; ...@@ -12,3 +12,6 @@ show variables like 'slave_load_tmpdir';
# We just set some arbitrary values in variables-master.opt so we can test # We just set some arbitrary values in variables-master.opt so we can test
# that a list of values works correctly # that a list of values works correctly
show variables like 'slave_skip_errors'; show variables like 'slave_skip_errors';
# Cleanup
set global slave_net_timeout=default;
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment