BUG#18962: Crash of ALTER TABLE .. DROP PARTITION ...

Review fixes


sql/partition_info.cc:
  Review fixes
sql/partition_info.h:
  Review fixes

sql/partition_info.cc

@@ -88,7 +88,7 @@ partition_info *partition_info::get_clone()
     The external routine needing this code is check_partition_info
 */
 
-#define MAX_PART_NAME_SIZE 16
+#define MAX_PART_NAME_SIZE 8
 
 char *partition_info::create_default_partition_names(uint part_no, uint no_parts, 
                                                      uint start_no)
@@ -125,7 +125,8 @@ char *partition_info::create_default_partition_names(uint part_no, uint no_parts
     0                           Memory allocation error
 */
 
-char *create_subpartition_name(uint subpart_no, const char *part_name)
+char *partition_info::create_subpartition_name(uint subpart_no,
+                                               const char *part_name)
 {
   uint size_alloc= strlen(part_name) + MAX_PART_NAME_SIZE;
   char *ptr= sql_calloc(size_alloc);

sql/partition_info.h

@@ -257,6 +257,7 @@ private:
   bool set_up_default_subpartitions(handler *file, ulonglong max_rows);
   char *create_default_partition_names(uint part_no, uint no_parts,
                                        uint start_no);
+  char *create_subpartition_name(uint subpart_no, const char *part_name);
   bool has_unique_name(partition_element *element);
 };