Commit 66ff0361 authored by marko's avatar marko

branches/zip: Non-functional change: Tighten debug assertions and

remove dead code.

buf_flush_ready_for_flush(), buf_flush_try_page(): Assert that
flush_type is one of BUF_FLUSH_LRU or BUF_FLUSH_LIST.  The flush_type
comes from buf_flush_batch(), which already asserts this.  The
assertion holds for all calls in the source code.

buf_flush_try_page(): Remove the dead case BUF_FLUSH_SINGLE_PAGE
of switch (flush_type).
parent d66ffab4
...@@ -153,6 +153,7 @@ buf_flush_ready_for_flush( ...@@ -153,6 +153,7 @@ buf_flush_ready_for_flush(
ut_a(buf_page_in_file(bpage)); ut_a(buf_page_in_file(bpage));
ut_ad(buf_pool_mutex_own()); ut_ad(buf_pool_mutex_own());
ut_ad(mutex_own(buf_page_get_mutex(bpage))); ut_ad(mutex_own(buf_page_get_mutex(bpage)));
ut_ad(flush_type == BUF_FLUSH_LRU || BUF_FLUSH_LIST);
if (bpage->oldest_modification != 0 if (bpage->oldest_modification != 0
&& buf_page_get_io_fix(bpage) == BUF_IO_NONE) { && buf_page_get_io_fix(bpage) == BUF_IO_NONE) {
...@@ -736,15 +737,14 @@ buf_flush_try_page( ...@@ -736,15 +737,14 @@ buf_flush_try_page(
flushed, 0 otherwise */ flushed, 0 otherwise */
ulint space, /* in: space id */ ulint space, /* in: space id */
ulint offset, /* in: page offset */ ulint offset, /* in: page offset */
enum buf_flush flush_type) /* in: BUF_FLUSH_LRU, BUF_FLUSH_LIST, enum buf_flush flush_type) /* in: BUF_FLUSH_LRU
or BUF_FLUSH_SINGLE_PAGE */ or BUF_FLUSH_LIST */
{ {
buf_page_t* bpage; buf_page_t* bpage;
mutex_t* block_mutex; mutex_t* block_mutex;
ibool is_uncompressed; ibool is_uncompressed;
ut_ad(flush_type == BUF_FLUSH_LRU || flush_type == BUF_FLUSH_LIST ut_ad(flush_type == BUF_FLUSH_LRU || flush_type == BUF_FLUSH_LIST);
|| flush_type == BUF_FLUSH_SINGLE_PAGE);
buf_pool_mutex_enter(); buf_pool_mutex_enter();
...@@ -835,16 +835,6 @@ buf_flush_try_page( ...@@ -835,16 +835,6 @@ buf_flush_try_page(
buf_pool_mutex_exit(); buf_pool_mutex_exit();
break; break;
case BUF_FLUSH_SINGLE_PAGE:
mutex_exit(block_mutex);
buf_pool_mutex_exit();
if (is_uncompressed) {
rw_lock_s_lock_gen(&((buf_block_t*) bpage)->lock,
BUF_IO_WRITE);
}
break;
default: default:
ut_error; ut_error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment