Commit 7f0f32d6 authored by Jon Olav Hauglid's avatar Jon Olav Hauglid

Bug #37521 Row inserted through view not always visible in base

           table immediately after

The problem was that rows inserted in a table by one connection was
not immediately visible if another connection queried the table,
even if the insert had committed.

The reason for the problem was that the server sent a status reply
to the client before it actually did the commit. Therefore it was
possible to get an OK from the server before the changes were made
permanent and visible to other connections.

This patch fixes the problem by not sending status messages to the
server until any changes made have been committed. No test case added
as reproducing the error requires very specific timing betweeen the
server and two or more clients.

This patch also fixes the following (duplicate) bugs:
Bug #29334 pseudo-finished SHOW GLOBAL STATUS
Bug #36618 myisam insert not immediately visible to select from another client
Bug #45864 insert on one connection, immediate query on another produces no result
Bug #51329 Inserts from one connection not immediately visible in second
           connection
Bug #41516 Assertion fails when error returned from
           handler::external_lock(thd, F_UNLCK)
parent 132ccf93
...@@ -1511,13 +1511,13 @@ bool dispatch_command(enum enum_server_command command, THD *thd, ...@@ -1511,13 +1511,13 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
thd->transaction.stmt.reset(); thd->transaction.stmt.reset();
thd->protocol->end_statement();
query_cache_end_of_result(thd);
thd->proc_info= "closing tables"; thd->proc_info= "closing tables";
/* Free tables */ /* Free tables */
close_thread_tables(thd); close_thread_tables(thd);
thd->protocol->end_statement();
query_cache_end_of_result(thd);
if (!thd->is_error() && !thd->killed_errno()) if (!thd->is_error() && !thd->killed_errno())
mysql_audit_general(thd, MYSQL_AUDIT_GENERAL_RESULT, 0, 0); mysql_audit_general(thd, MYSQL_AUDIT_GENERAL_RESULT, 0, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment