Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
de4ec3ed
Commit
de4ec3ed
authored
Jan 13, 2005
by
monty@mysql.com
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix accesses to uninitialized memory (found by valgrind)
parent
a1321dff
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
71 additions
and
54 deletions
+71
-54
mysys/my_alloc.c
mysys/my_alloc.c
+13
-0
sql/filesort.cc
sql/filesort.cc
+6
-1
sql/sql_select.cc
sql/sql_select.cc
+8
-3
sql/sql_view.cc
sql/sql_view.cc
+3
-2
sql/table.cc
sql/table.cc
+41
-48
No files found.
mysys/my_alloc.c
View file @
de4ec3ed
...
@@ -245,6 +245,19 @@ static inline void mark_blocks_free(MEM_ROOT* root)
...
@@ -245,6 +245,19 @@ static inline void mark_blocks_free(MEM_ROOT* root)
/*
/*
Deallocate everything used by alloc_root or just move
Deallocate everything used by alloc_root or just move
used blocks to free list if called with MY_USED_TO_FREE
used blocks to free list if called with MY_USED_TO_FREE
SYNOPSIS
free_root()
root Memory root
MyFlags Flags for what should be freed:
MY_MARK_BLOCKS_FREED Don't free blocks, just mark them free
MY_KEEP_PREALLOC If this is not set, then free also the
preallocated block
NOTES
One can call this function either with root block initialised with
init_alloc_root() or with a bzero()-ed block.
*/
*/
void
free_root
(
MEM_ROOT
*
root
,
myf
MyFlags
)
void
free_root
(
MEM_ROOT
*
root
,
myf
MyFlags
)
...
...
sql/filesort.cc
View file @
de4ec3ed
...
@@ -1176,7 +1176,12 @@ sortlength(SORT_FIELD *sortorder, uint s_length, bool *multi_byte_charset)
...
@@ -1176,7 +1176,12 @@ sortlength(SORT_FIELD *sortorder, uint s_length, bool *multi_byte_charset)
else
else
{
{
sortorder
->
length
=
sortorder
->
field
->
pack_length
();
sortorder
->
length
=
sortorder
->
field
->
pack_length
();
if
(
use_strnxfrm
((
cs
=
sortorder
->
field
->
charset
())))
/*
We must test cmp_type() to ensure that ENUM and SET are sorted
as numbers
*/
if
(
use_strnxfrm
((
cs
=
sortorder
->
field
->
charset
()))
&&
sortorder
->
field
->
cmp_type
()
==
STRING_RESULT
)
{
{
sortorder
->
need_strxnfrm
=
1
;
sortorder
->
need_strxnfrm
=
1
;
*
multi_byte_charset
=
1
;
*
multi_byte_charset
=
1
;
...
...
sql/sql_select.cc
View file @
de4ec3ed
...
@@ -7823,12 +7823,17 @@ create_tmp_table(THD *thd,TMP_TABLE_PARAM *param,List<Item> &fields,
...
@@ -7823,12 +7823,17 @@ create_tmp_table(THD *thd,TMP_TABLE_PARAM *param,List<Item> &fields,
if
(
temp_pool_slot
!=
MY_BIT_NONE
)
// we got a slot
if
(
temp_pool_slot
!=
MY_BIT_NONE
)
// we got a slot
sprintf
(
filename
,
"%s_%lx_%i"
,
tmp_file_prefix
,
sprintf
(
filename
,
"%s_%lx_%i"
,
tmp_file_prefix
,
current_pid
,
temp_pool_slot
);
current_pid
,
temp_pool_slot
);
else
// if we run out of slots or we are not using tempool
else
{
/* if we run out of slots or we are not using tempool */
sprintf
(
filename
,
"%s%lx_%lx_%x"
,
tmp_file_prefix
,
current_pid
,
sprintf
(
filename
,
"%s%lx_%lx_%x"
,
tmp_file_prefix
,
current_pid
,
thd
->
thread_id
,
thd
->
tmp_table
++
);
thd
->
thread_id
,
thd
->
tmp_table
++
);
}
if
(
lower_case_table_names
)
/*
my_casedn_str
(
files_charset_info
,
path
);
No need for change table name to lower case as we are only creating
MyISAM or HEAP tables here
*/
sprintf
(
path
,
"%s%s"
,
mysql_tmpdir
,
filename
);
sprintf
(
path
,
"%s%s"
,
mysql_tmpdir
,
filename
);
if
(
group
)
if
(
group
)
...
...
sql/sql_view.cc
View file @
de4ec3ed
...
@@ -948,11 +948,12 @@ frm_type_enum mysql_frm_type(char *path)
...
@@ -948,11 +948,12 @@ frm_type_enum mysql_frm_type(char *path)
{
{
DBUG_RETURN
(
FRMTYPE_ERROR
);
DBUG_RETURN
(
FRMTYPE_ERROR
);
}
}
length
=
my_read
(
file
,
(
byte
*
)
header
,
10
,
MYF
(
MY_WME
));
length
=
my_read
(
file
,
(
byte
*
)
header
,
sizeof
(
header
)
,
MYF
(
MY_WME
));
my_close
(
file
,
MYF
(
MY_WME
));
my_close
(
file
,
MYF
(
MY_WME
));
if
(
length
==
(
int
)
MY_FILE_ERROR
)
if
(
length
==
(
int
)
MY_FILE_ERROR
)
DBUG_RETURN
(
FRMTYPE_ERROR
);
DBUG_RETURN
(
FRMTYPE_ERROR
);
if
(
!
strncmp
(
header
,
"TYPE=VIEW
\n
"
,
10
))
if
(
length
<
(
int
)
sizeof
(
header
)
||
!
strncmp
(
header
,
"TYPE=VIEW
\n
"
,
sizeof
(
header
)))
DBUG_RETURN
(
FRMTYPE_VIEW
);
DBUG_RETURN
(
FRMTYPE_VIEW
);
DBUG_RETURN
(
FRMTYPE_TABLE
);
// Is probably a .frm table
DBUG_RETURN
(
FRMTYPE_TABLE
);
// Is probably a .frm table
}
}
...
...
sql/table.cc
View file @
de4ec3ed
...
@@ -103,11 +103,11 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -103,11 +103,11 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
O_RDONLY
|
O_SHARE
,
O_RDONLY
|
O_SHARE
,
MYF
(
0
)))
MYF
(
0
)))
<
0
)
<
0
)
goto
err
_w_init
;
goto
err
;
error
=
4
;
error
=
4
;
if
(
my_read
(
file
,(
byte
*
)
head
,
64
,
MYF
(
MY_NABP
)))
if
(
my_read
(
file
,(
byte
*
)
head
,
64
,
MYF
(
MY_NABP
)))
goto
err
_w_init
;
goto
err
;
if
(
memcmp
(
head
,
"TYPE="
,
5
)
==
0
)
if
(
memcmp
(
head
,
"TYPE="
,
5
)
==
0
)
{
{
...
@@ -116,9 +116,9 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -116,9 +116,9 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
if
(
db_stat
&
NO_ERR_ON_NEW_FRM
)
if
(
db_stat
&
NO_ERR_ON_NEW_FRM
)
DBUG_RETURN
(
5
);
DBUG_RETURN
(
5
);
file
=
-
1
;
// caller can't process new .frm
// caller can't process new .frm
goto
err
_w_init
;
goto
err
;
}
}
share
->
blob_ptr_size
=
sizeof
(
char
*
);
share
->
blob_ptr_size
=
sizeof
(
char
*
);
...
@@ -131,21 +131,21 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -131,21 +131,21 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
share
->
path
=
strdup_root
(
&
outparam
->
mem_root
,
name
);
share
->
path
=
strdup_root
(
&
outparam
->
mem_root
,
name
);
outparam
->
alias
=
my_strdup
(
alias
,
MYF
(
MY_WME
));
outparam
->
alias
=
my_strdup
(
alias
,
MYF
(
MY_WME
));
if
(
!
share
->
table_name
||
!
share
->
path
||
!
outparam
->
alias
)
if
(
!
share
->
table_name
||
!
share
->
path
||
!
outparam
->
alias
)
goto
err
_not_open
;
goto
err
;
*
fn_ext
(
share
->
table_name
)
=
'\0'
;
// Remove extension
*
fn_ext
(
share
->
table_name
)
=
'\0'
;
// Remove extension
*
fn_ext
(
share
->
path
)
=
'\0'
;
// Remove extension
*
fn_ext
(
share
->
path
)
=
'\0'
;
// Remove extension
if
(
head
[
0
]
!=
(
uchar
)
254
||
head
[
1
]
!=
1
||
if
(
head
[
0
]
!=
(
uchar
)
254
||
head
[
1
]
!=
1
||
(
head
[
2
]
!=
FRM_VER
&&
head
[
2
]
!=
FRM_VER
+
1
&&
(
head
[
2
]
!=
FRM_VER
&&
head
[
2
]
!=
FRM_VER
+
1
&&
!
(
head
[
2
]
>=
FRM_VER
+
3
&&
head
[
2
]
<=
FRM_VER
+
4
)))
!
(
head
[
2
]
>=
FRM_VER
+
3
&&
head
[
2
]
<=
FRM_VER
+
4
)))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
new_field_pack_flag
=
head
[
27
];
new_field_pack_flag
=
head
[
27
];
new_frm_ver
=
(
head
[
2
]
-
FRM_VER
);
new_frm_ver
=
(
head
[
2
]
-
FRM_VER
);
field_pack_length
=
new_frm_ver
<
2
?
11
:
17
;
field_pack_length
=
new_frm_ver
<
2
?
11
:
17
;
error
=
3
;
error
=
3
;
if
(
!
(
pos
=
get_form_pos
(
file
,
head
,(
TYPELIB
*
)
0
)))
if
(
!
(
pos
=
get_form_pos
(
file
,
head
,(
TYPELIB
*
)
0
)))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
*
fn_ext
(
index_file
)
=
'\0'
;
// Remove .frm extension
*
fn_ext
(
index_file
)
=
'\0'
;
// Remove .frm extension
share
->
frm_version
=
head
[
2
];
share
->
frm_version
=
head
[
2
];
...
@@ -181,7 +181,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -181,7 +181,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
key_info_length
=
(
uint
)
uint2korr
(
head
+
28
);
key_info_length
=
(
uint
)
uint2korr
(
head
+
28
);
VOID
(
my_seek
(
file
,(
ulong
)
uint2korr
(
head
+
6
),
MY_SEEK_SET
,
MYF
(
0
)));
VOID
(
my_seek
(
file
,(
ulong
)
uint2korr
(
head
+
6
),
MY_SEEK_SET
,
MYF
(
0
)));
if
(
read_string
(
file
,(
gptr
*
)
&
disk_buff
,
key_info_length
))
if
(
read_string
(
file
,(
gptr
*
)
&
disk_buff
,
key_info_length
))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
if
(
disk_buff
[
0
]
&
0x80
)
if
(
disk_buff
[
0
]
&
0x80
)
{
{
share
->
keys
=
keys
=
(
disk_buff
[
1
]
<<
7
)
|
(
disk_buff
[
0
]
&
0x7f
);
share
->
keys
=
keys
=
(
disk_buff
[
1
]
<<
7
)
|
(
disk_buff
[
0
]
&
0x7f
);
...
@@ -201,7 +201,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -201,7 +201,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
n_length
=
keys
*
sizeof
(
KEY
)
+
key_parts
*
sizeof
(
KEY_PART_INFO
);
n_length
=
keys
*
sizeof
(
KEY
)
+
key_parts
*
sizeof
(
KEY_PART_INFO
);
if
(
!
(
keyinfo
=
(
KEY
*
)
alloc_root
(
&
outparam
->
mem_root
,
if
(
!
(
keyinfo
=
(
KEY
*
)
alloc_root
(
&
outparam
->
mem_root
,
n_length
+
uint2korr
(
disk_buff
+
4
))))
n_length
+
uint2korr
(
disk_buff
+
4
))))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
bzero
((
char
*
)
keyinfo
,
n_length
);
bzero
((
char
*
)
keyinfo
,
n_length
);
outparam
->
key_info
=
keyinfo
;
outparam
->
key_info
=
keyinfo
;
key_part
=
my_reinterpret_cast
(
KEY_PART_INFO
*
)
(
keyinfo
+
keys
);
key_part
=
my_reinterpret_cast
(
KEY_PART_INFO
*
)
(
keyinfo
+
keys
);
...
@@ -210,7 +210,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -210,7 +210,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
ulong
*
rec_per_key
;
ulong
*
rec_per_key
;
if
(
!
(
rec_per_key
=
(
ulong
*
)
alloc_root
(
&
outparam
->
mem_root
,
if
(
!
(
rec_per_key
=
(
ulong
*
)
alloc_root
(
&
outparam
->
mem_root
,
sizeof
(
ulong
*
)
*
key_parts
)))
sizeof
(
ulong
*
)
*
key_parts
)))
goto
err
_not_open
;
goto
err
;
for
(
i
=
0
;
i
<
keys
;
i
++
,
keyinfo
++
)
for
(
i
=
0
;
i
<
keys
;
i
++
,
keyinfo
++
)
{
{
...
@@ -279,7 +279,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -279,7 +279,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
/* Allocate handler */
/* Allocate handler */
if
(
!
(
outparam
->
file
=
get_new_handler
(
outparam
,
share
->
db_type
)))
if
(
!
(
outparam
->
file
=
get_new_handler
(
outparam
,
share
->
db_type
)))
goto
err
_not_open
;
goto
err
;
error
=
4
;
error
=
4
;
outparam
->
reginfo
.
lock_type
=
TL_UNLOCK
;
outparam
->
reginfo
.
lock_type
=
TL_UNLOCK
;
...
@@ -296,14 +296,14 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -296,14 +296,14 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
share
->
rec_buff_length
=
rec_buff_length
;
share
->
rec_buff_length
=
rec_buff_length
;
if
(
!
(
record
=
(
char
*
)
alloc_root
(
&
outparam
->
mem_root
,
if
(
!
(
record
=
(
char
*
)
alloc_root
(
&
outparam
->
mem_root
,
rec_buff_length
*
records
)))
rec_buff_length
*
records
)))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
share
->
default_values
=
record
;
share
->
default_values
=
record
;
if
(
my_pread
(
file
,(
byte
*
)
record
,
(
uint
)
share
->
reclength
,
if
(
my_pread
(
file
,(
byte
*
)
record
,
(
uint
)
share
->
reclength
,
(
ulong
)
(
uint2korr
(
head
+
6
)
+
(
ulong
)
(
uint2korr
(
head
+
6
)
+
((
uint2korr
(
head
+
14
)
==
0xffff
?
((
uint2korr
(
head
+
14
)
==
0xffff
?
uint4korr
(
head
+
47
)
:
uint2korr
(
head
+
14
)))),
uint4korr
(
head
+
47
)
:
uint2korr
(
head
+
14
)))),
MYF
(
MY_NABP
)))
MYF
(
MY_NABP
)))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
if
(
records
==
1
)
if
(
records
==
1
)
{
{
...
@@ -332,12 +332,13 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -332,12 +332,13 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
}
}
#endif
#endif
VOID
(
my_seek
(
file
,
pos
,
MY_SEEK_SET
,
MYF
(
0
)));
VOID
(
my_seek
(
file
,
pos
,
MY_SEEK_SET
,
MYF
(
0
)));
if
(
my_read
(
file
,(
byte
*
)
head
,
288
,
MYF
(
MY_NABP
)))
goto
err_not_open
;
if
(
my_read
(
file
,(
byte
*
)
head
,
288
,
MYF
(
MY_NABP
)))
goto
err
;
if
(
crypted
)
if
(
crypted
)
{
{
crypted
->
decode
((
char
*
)
head
+
256
,
288
-
256
);
crypted
->
decode
((
char
*
)
head
+
256
,
288
-
256
);
if
(
sint2korr
(
head
+
284
)
!=
0
)
// Should be 0
if
(
sint2korr
(
head
+
284
)
!=
0
)
// Should be 0
goto
err
_not_open
;
// Wrong password
goto
err
;
// Wrong password
}
}
share
->
fields
=
uint2korr
(
head
+
258
);
share
->
fields
=
uint2korr
(
head
+
258
);
...
@@ -359,13 +360,13 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -359,13 +360,13 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
(
share
->
fields
+
interval_parts
+
(
share
->
fields
+
interval_parts
+
keys
+
3
)
*
sizeof
(
my_string
)
+
keys
+
3
)
*
sizeof
(
my_string
)
+
(
n_length
+
int_length
+
com_length
)))))
(
n_length
+
int_length
+
com_length
)))))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
outparam
->
field
=
field_ptr
;
outparam
->
field
=
field_ptr
;
read_length
=
(
uint
)
(
share
->
fields
*
field_pack_length
+
read_length
=
(
uint
)
(
share
->
fields
*
field_pack_length
+
pos
+
(
uint
)
(
n_length
+
int_length
+
com_length
));
pos
+
(
uint
)
(
n_length
+
int_length
+
com_length
));
if
(
read_string
(
file
,(
gptr
*
)
&
disk_buff
,
read_length
))
if
(
read_string
(
file
,(
gptr
*
)
&
disk_buff
,
read_length
))
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
if
(
crypted
)
if
(
crypted
)
{
{
crypted
->
decode
((
char
*
)
disk_buff
,
read_length
);
crypted
->
decode
((
char
*
)
disk_buff
,
read_length
);
...
@@ -398,7 +399,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -398,7 +399,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
uint
count
=
(
uint
)
(
interval
->
count
+
1
)
*
sizeof
(
uint
);
uint
count
=
(
uint
)
(
interval
->
count
+
1
)
*
sizeof
(
uint
);
if
(
!
(
interval
->
type_lengths
=
(
uint
*
)
alloc_root
(
&
outparam
->
mem_root
,
if
(
!
(
interval
->
type_lengths
=
(
uint
*
)
alloc_root
(
&
outparam
->
mem_root
,
count
)))
count
)))
goto
err
_not_open
;
goto
err
;
for
(
count
=
0
;
count
<
interval
->
count
;
count
++
)
for
(
count
=
0
;
count
<
interval
->
count
;
count
++
)
interval
->
type_lengths
[
count
]
=
strlen
(
interval
->
type_names
[
count
]);
interval
->
type_lengths
[
count
]
=
strlen
(
interval
->
type_names
[
count
]);
interval
->
type_lengths
[
count
]
=
0
;
interval
->
type_lengths
[
count
]
=
0
;
...
@@ -459,7 +460,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -459,7 +460,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
charset
=
&
my_charset_bin
;
charset
=
&
my_charset_bin
;
#else
#else
error
=
4
;
// unsupported field type
error
=
4
;
// unsupported field type
goto
err
_not_open
;
goto
err
;
#endif
#endif
}
}
else
else
...
@@ -470,7 +471,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -470,7 +471,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
{
{
error
=
5
;
// Unknown or unavailable charset
error
=
5
;
// Unknown or unavailable charset
errarg
=
(
int
)
strpos
[
14
];
errarg
=
(
int
)
strpos
[
14
];
goto
err
_not_open
;
goto
err
;
}
}
}
}
if
(
!
comment_length
)
if
(
!
comment_length
)
...
@@ -543,7 +544,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -543,7 +544,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
if
(
!
reg_field
)
// Not supported field type
if
(
!
reg_field
)
// Not supported field type
{
{
error
=
4
;
error
=
4
;
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
}
}
reg_field
->
comment
=
comment
;
reg_field
->
comment
=
comment
;
if
(
field_type
==
FIELD_TYPE_BIT
)
if
(
field_type
==
FIELD_TYPE_BIT
)
...
@@ -616,7 +617,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -616,7 +617,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
(
uint
)
key_part
->
length
);
(
uint
)
key_part
->
length
);
#ifdef EXTRA_DEBUG
#ifdef EXTRA_DEBUG
if
(
key_part
->
fieldnr
>
share
->
fields
)
if
(
key_part
->
fieldnr
>
share
->
fields
)
goto
err
_not_open
;
// sanity check
goto
err
;
// sanity check
#endif
#endif
if
(
key_part
->
fieldnr
)
if
(
key_part
->
fieldnr
)
{
// Should always be true !
{
// Should always be true !
...
@@ -767,7 +768,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -767,7 +768,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
if
(
!
(
share
->
blob_field
=
save
=
if
(
!
(
share
->
blob_field
=
save
=
(
uint
*
)
alloc_root
(
&
outparam
->
mem_root
,
(
uint
*
)
alloc_root
(
&
outparam
->
mem_root
,
(
uint
)
(
share
->
blob_fields
*
sizeof
(
uint
)))))
(
uint
)
(
share
->
blob_fields
*
sizeof
(
uint
)))))
goto
err
_not_open
;
goto
err
;
for
(
i
=
0
,
ptr
=
outparam
->
field
;
*
ptr
;
ptr
++
,
i
++
)
for
(
i
=
0
,
ptr
=
outparam
->
field
;
*
ptr
;
ptr
++
,
i
++
)
{
{
if
((
*
ptr
)
->
flags
&
BLOB_FLAG
)
if
((
*
ptr
)
->
flags
&
BLOB_FLAG
)
...
@@ -779,25 +780,25 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -779,25 +780,25 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
error
=
2
;
error
=
2
;
if
(
db_stat
)
if
(
db_stat
)
{
{
int
err
;
int
ha_
err
;
unpack_filename
(
index_file
,
index_file
);
unpack_filename
(
index_file
,
index_file
);
if
((
err
=
(
outparam
->
file
->
if
((
ha_err
=
(
outparam
->
file
->
ha_open
(
index_file
,
ha_open
(
index_file
,
(
db_stat
&
HA_READ_ONLY
?
O_RDONLY
:
O_RDWR
),
(
db_stat
&
HA_READ_ONLY
?
O_RDONLY
:
O_RDWR
),
(
db_stat
&
HA_OPEN_TEMPORARY
?
HA_OPEN_TMP_TABLE
:
(
db_stat
&
HA_OPEN_TEMPORARY
?
HA_OPEN_TMP_TABLE
:
((
db_stat
&
HA_WAIT_IF_LOCKED
)
||
((
db_stat
&
HA_WAIT_IF_LOCKED
)
||
(
specialflag
&
SPECIAL_WAIT_IF_LOCKED
))
?
(
specialflag
&
SPECIAL_WAIT_IF_LOCKED
))
?
HA_OPEN_WAIT_IF_LOCKED
:
HA_OPEN_WAIT_IF_LOCKED
:
(
db_stat
&
(
HA_ABORT_IF_LOCKED
|
HA_GET_INFO
))
?
(
db_stat
&
(
HA_ABORT_IF_LOCKED
|
HA_GET_INFO
))
?
HA_OPEN_ABORT_IF_LOCKED
:
HA_OPEN_ABORT_IF_LOCKED
:
HA_OPEN_IGNORE_IF_LOCKED
)
|
ha_open_flags
))))
HA_OPEN_IGNORE_IF_LOCKED
)
|
ha_open_flags
))))
{
{
/* Set a flag if the table is crashed and it can be auto. repaired */
/* Set a flag if the table is crashed and it can be auto. repaired */
share
->
crashed
=
((
err
==
HA_ERR_CRASHED_ON_USAGE
)
&&
share
->
crashed
=
((
ha_
err
==
HA_ERR_CRASHED_ON_USAGE
)
&&
outparam
->
file
->
auto_repair
()
&&
outparam
->
file
->
auto_repair
()
&&
!
(
ha_open_flags
&
HA_OPEN_FOR_REPAIR
));
!
(
ha_open_flags
&
HA_OPEN_FOR_REPAIR
));
if
(
err
==
HA_ERR_NO_SUCH_TABLE
)
if
(
ha_
err
==
HA_ERR_NO_SUCH_TABLE
)
{
{
/* The table did not exists in storage engine, use same error message
/* The table did not exists in storage engine, use same error message
as if the .frm file didn't exist */
as if the .frm file didn't exist */
...
@@ -806,10 +807,10 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -806,10 +807,10 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
}
}
else
else
{
{
outparam
->
file
->
print_error
(
err
,
MYF
(
0
));
outparam
->
file
->
print_error
(
ha_
err
,
MYF
(
0
));
error_reported
=
TRUE
;
error_reported
=
TRUE
;
}
}
goto
err
_not_open
;
/* purecov: inspected */
goto
err
;
/* purecov: inspected */
}
}
}
}
share
->
db_low_byte_first
=
outparam
->
file
->
low_byte_first
();
share
->
db_low_byte_first
=
outparam
->
file
->
low_byte_first
();
...
@@ -822,15 +823,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -822,15 +823,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
#endif
#endif
DBUG_RETURN
(
0
);
DBUG_RETURN
(
0
);
err_w_init:
err:
/*
Avoid problem with uninitialized data
Note that we don't have to initialize outparam->s here becasue
the caller will check if the pointer exists in case of errors
*/
bzero
((
char
*
)
outparam
,
sizeof
(
*
outparam
));
err_not_open:
x_free
((
gptr
)
disk_buff
);
x_free
((
gptr
)
disk_buff
);
if
(
file
>
0
)
if
(
file
>
0
)
VOID
(
my_close
(
file
,
MYF
(
MY_WME
)));
VOID
(
my_close
(
file
,
MYF
(
MY_WME
)));
...
@@ -843,7 +836,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
...
@@ -843,7 +836,7 @@ int openfrm(THD *thd, const char *name, const char *alias, uint db_stat,
outparam
->
file
=
0
;
// For easier errorchecking
outparam
->
file
=
0
;
// For easier errorchecking
outparam
->
db_stat
=
0
;
outparam
->
db_stat
=
0
;
hash_free
(
&
share
->
name_hash
);
hash_free
(
&
share
->
name_hash
);
free_root
(
&
outparam
->
mem_root
,
MYF
(
0
));
free_root
(
&
outparam
->
mem_root
,
MYF
(
0
));
// Safe to call on bzero'd root
my_free
((
char
*
)
outparam
->
alias
,
MYF
(
MY_ALLOW_ZERO_PTR
));
my_free
((
char
*
)
outparam
->
alias
,
MYF
(
MY_ALLOW_ZERO_PTR
));
DBUG_RETURN
(
error
);
DBUG_RETURN
(
error
);
}
/* openfrm */
}
/* openfrm */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment