.

wcfs/δbtail.go

@@ -1338,6 +1338,7 @@ func xidOf(obj zodb.IPersistent) string {
 
 func (δBtail *ΔBtail) ForgetPast(revCut zodb.Tid) {
 	δBtail.δZtail.ForgetPast(revCut) // XXX stub
+	// XXX clean vδT
 }
 
 
@@ -1394,7 +1395,7 @@ func (δBtail *ΔBtail) Get(ctx context.Context, root *Tree, key Key, at zodb.Ti
 	// either use @tail[key], if it is present, or @head[key]
 	rev = δBtail.Tail()
 	revExact = false
-	value, ok = δTtail.KVAtTail[key]
+	value, ok = δTtail.KVAtTail[key] // XXX kill - just use δvalue.Old from next-to-at entry
 	if ok {
 		return
 	}
@@ -1414,10 +1415,9 @@ func (δBtail *ΔBtail) Get(ctx context.Context, root *Tree, key Key, at zodb.Ti
 	return
 }
 
-// XXX
+// XXX don't need
 func (δBtail *ΔBtail) SliceByRev(lo, hi zodb.Tid) /*readonly*/ []ΔB {
 	δassertSlice(δBtail, lo, hi)
-
 	panic("TODO")
 }
 
@@ -1432,7 +1432,6 @@ func (δBtail *ΔBtail) SliceByRev(lo, hi zodb.Tid) /*readonly*/ []ΔB {
 // Note: contrary to regular go slicing, low is exclusive while high is inclusive.
 func (δBtail *ΔBtail) SliceByRootRev(root *Tree, lo, hi zodb.Tid) /*readonly*/[]ΔTree {
 	δassertSlice(δBtail, lo, hi)
-
 	panic("TODO")
 }
 

wcfs/δbtail_test.go

@@ -601,7 +601,6 @@ func xverifyΔBTail(t *testing.T, subj string, db *zodb.DB, treeRoot zodb.Oid, a
 
 // xverifyΔBTail1 verifies how ΔBTail handles ZODB update at1->at2 from initial
 // tracked state defined by initialTrackedKeys.
-// XXX initialTrackedKeys -> tracked1 ?
 func xverifyΔBTail1(t *testing.T, subj string, db *zodb.DB, treeRoot zodb.Oid, at1,at2 zodb.Tid, xkv1,xkv2 RBucketSet, δZ *zodb.EventCommit, initialTrackedKeys SetKey, kadj map[Key]SetKey) {
 	X := exc.Raiseif
 	tracef("\n>>> Track=%s\n", initialTrackedKeys)
@@ -853,7 +852,7 @@ func testΔBTail(t *testing.T, testq chan ΔBTestEntry) {
 		tracef("\n\n\n**** %s ****\n\n", subj)
 		xverifyΔBTail(t, subj, db, tg.treeRoot, at1,at2, xkv1,xkv2, δZ, test.kadjOK)
 
-		// XXX also verify ΔBtail.Get + ...
+		// XXX also verify ΔBtail.Get + SliceByRootRev
 
 		at1   = at2
 		xkv1  = xkv2

wcfs/δftail.go

@@ -343,14 +343,12 @@ func (δFtail *ΔFtail) update(file *BigFile) {
 
 // ForgetPast discards all δFtail entries with rev ≤ revCut.
 func (δFtail *ΔFtail) ForgetPast(revCut zodb.Tid) {
-	panic("TODO")
-	// XXX -> .δBtail.ForgetPast(recCut)
+	δFtail.δBtail.ForgetPast(revCut)
 }
 
 // XXX don't need
 func (δFtail *ΔFtail) SliceByRev(lo, hi zodb.Tid) /*readonly*/ []ΔF {
 	δassertSlice(δFtail, lo, hi)
-
 	panic("TODO")
 }
 
@@ -367,7 +365,7 @@ func (δFtail *ΔFtail) SliceByFileRev(file *BigFile, lo, hi zodb.Tid) /*readonl
 	δassertSlice(δFtail, lo, hi)
 
 	// FIXME rework to just query .δBtail.SliceByRootRev(file.blktab, lo, hi) +
-	//       merge δZBlk history iwith that.
+	//       merge δZBlk history with that.
 
 	// XXX locking?
 	δFtail.update(file)