Commit f89b0ce2 authored by Kirill Smelkov's avatar Kirill Smelkov

.

parent b8ced44a
...@@ -1008,20 +1008,6 @@ func pathEqual(patha, pathb []zodb.Oid) bool { ...@@ -1008,20 +1008,6 @@ func pathEqual(patha, pathb []zodb.Oid) bool {
return true return true
} }
/*
// vtree returns human-readable representation of Tree data.
func vtree(v []TreeEntry) string {
s := ""
for _, e := range v {
if s != "" {
s += " "
}
s += fmt.Sprintf("%v %s", e.Key(), vnode(e.Child()))
}
return s
}
*/
// vnode returns brief human-readable representation of node. // vnode returns brief human-readable representation of node.
func vnode(node Node) string { func vnode(node Node) string {
kind := "?" kind := "?"
......
...@@ -59,7 +59,7 @@ type setTid = set.Tid ...@@ -59,7 +59,7 @@ type setTid = set.Tid
// nodePathToPath converts path from []Node to []Oid. // nodePathToPath converts path from []Node to []Oid.
// XXX place = ? // XXX place = ? -> δbtail.go/treediff.go (close to pathEqual), or move them both to misc.go
func nodePathToPath(nodePath []Node) (path []zodb.Oid) { func nodePathToPath(nodePath []Node) (path []zodb.Oid) {
// assert nodePath = Tree Tree ... Tree Bucket // assert nodePath = Tree Tree ... Tree Bucket
l := len(nodePath) l := len(nodePath)
......
...@@ -109,7 +109,7 @@ type _ΔTtail struct { ...@@ -109,7 +109,7 @@ type _ΔTtail struct {
// set of nodes that were requested to be tracked in this tree, but for // set of nodes that were requested to be tracked in this tree, but for
// which vδT was not yet rebuilt // which vδT was not yet rebuilt
trackNew blib.PPTreeSubSet trackNew blib.PPTreeSubSet
// XXX + trackNewKeys RangedKeySet // XXX + trackNewKeys RangedKeySet (concurrency)
// index for GetAt queries // index for GetAt queries
lastRevOf map[Key]zodb.Tid // {} key -> last revision lastRevOf map[Key]zodb.Tid // {} key -> last revision
...@@ -233,12 +233,11 @@ func (δBtail *ΔBtail) Tail() zodb.Tid { return δBtail.δZtail.Tail() } ...@@ -233,12 +233,11 @@ func (δBtail *ΔBtail) Tail() zodb.Tid { return δBtail.δZtail.Tail() }
// All path elements must be Tree except last one which must be Bucket. // All path elements must be Tree except last one which must be Bucket.
// //
// Besides key (which might point to value or hole), δBtail will also track all // Besides key (which might point to value or hole), δBtail will also track all
// keys residing in tracked leaf nodes. In particular after request for KeyMax or // keys covered by tracked leaf nodes. In particular after request for KeyMax or
// KeyMin to be tracked, δBtail will keep on tracking changes to maximum or // KeyMin to be tracked, δBtail will keep on tracking changes to maximum or
// minimum keys correspondingly. // minimum keys correspondingly.
// //
// XXX objects in path must be with .PJar().At() == .head // XXX objects in path must be with .PJar().At() == .head
// XXX path -> []oid ?
// //
// XXX catch cycles on add? // XXX catch cycles on add?
// XXX no need to pass in key? (-> all keys, covered by leaf keyrange, will be added to tracking set of keys) // XXX no need to pass in key? (-> all keys, covered by leaf keyrange, will be added to tracking set of keys)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment