slapos_crm: Add test and fixes for Update Monitoring Tickets implementation

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMontoringComputerState.py → master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMonitoringComputerState.py

@@ -8,9 +8,9 @@ portal = context.getPortalObject()
 if context.getSimulationState() == "invalidated":
   return
 
-document = context.getSourceProjectValue()
+computer = context.getAggregateValue()
 
-if document is not None and document.getPortalType() == "Computer":
+if computer is not None and computer.getPortalType() == "Computer":
   memcached_dict = context.getPortalObject().portal_memcached.getMemcachedDict(
     key_prefix='slap_tool',
     plugin_path='portal_memcached/default_memcached_plugin')
@@ -31,19 +31,19 @@ if document is not None and document.getPortalType() == "Computer":
     context.suspend()
 
   # Send Notification message
-  message = """ Suspending this ticket as the computer contacted is contactin again. 
-  """
+  message = """ Suspending this ticket as the computer contacted again. """
 
   notification_reference = "slapos-crm-support-request-suspend-computer-back-notification"
   notification_message = portal.portal_notifications.getDocumentValue(
                  reference=notification_reference)
 
   if notification_message is not None:
-    mapping_dict = {'hosting_subscription_title':document.getTitle(), 
+    mapping_dict = {'computer_title':computer.getTitle(),
+                    'computer_reference':computer.getTitle(),
                     'last_contact' : last_contact }
 
     message = notification_message.asText(
               substitution_method_parameter_dict={'mapping_dict':mapping_dict})
   
   return context.SupportRequest_trySendNotificationMessage(
-              "Hosting Subscription was destroyed was destroyed by the user", message, person)
+              "Computer is contacting again", message, person)

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMontoringComputerState.xml → master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMonitoringComputerState.xml

@@ -54,7 +54,7 @@
         </item>
         <item>
             <key> <string>id</string> </key>
-            <value> <string>SupportRequest_updateMontoringComputerState</string> </value>
+            <value> <string>SupportRequest_updateMonitoringComputerState</string> </value>
         </item>
       </dictionary>
     </pickle>

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMonitoringDestroyRequestedState.py

@@ -4,9 +4,10 @@
 if context.getSimulationState() == "invalidated":
   return
 
-document = context.getSourceProjectValue()
+document = context.getAggregateValue()
 
 if document is not None and document.getSlapState() == "destroy_requested":
+  
   person = context.getDestinationDecision(portal_type="Person")
   if not person:
     return 

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMonitoringHostingSubscriptionState.py

@@ -7,7 +7,7 @@ portal = context.getPortalObject()
 document = context.getSourceProjectValue()
 
 if document is None:
-  return True
+  return
 
 has_error = False
 

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMonitoringState.py

 if context.getSimulationState() == "invalidated":
   return
 
-document = context.getSourceProjectValue()
+document = context.getAggregateValue()
 
 if document is None:
-  return True
+  return 
 
 if document.getPortalType() == "Computer":
-  return context.SupportRequest_updateMontoringComputerState()
+  return context.SupportRequest_updateMonitoringComputerState()
 
 if document.getPortalType() == "Hosting Subscription":
+  if document.getSlapState() == "destroy_requested":
+    return context.SupportRequest_updateMonitoringDestroyRequestedState()
   return context.SupportRequest_updateMonitoringHostingSubscriptionState()

master/bt5/slapos_crm/TestTemplateItem/portal_components/test.erp5.testSlapOSCRMSkins.py

@@ -8,6 +8,7 @@ from functools import wraps
 from Products.ERP5Type.tests.utils import createZODBPythonScript
 import difflib
 import json
+from unittest import skip
 
 def simulate(script_id, params_string, code_string):
   def upperWrap(f):
@@ -27,6 +28,10 @@ def simulate(script_id, params_string, code_string):
     return decorated
   return upperWrap
 
+
+def getFakeSlapState():
+  return "destroy_requested"
+
 class TestSlapOSFolder_getOpenTicketList(testSlapOSMixin):
 
   def beforeTearDown(self):
@@ -3509,5 +3514,175 @@ class TestSupportRequestTrySendNotificationMessage(testSlapOSMixin):
      another_support_request.getRelativeUrl())
 
 
+class TestSupportRequestUpdateMonitoringState(testSlapOSMixin):
+
+  def _makeComputer(self):
+    super(TestSupportRequestUpdateMonitoringState, self)._makeComputer()
+    
+    # Clone computer document
+    self.computer.edit(
+      source_administration_value=self._makePerson()
+    )
+    return self.computer
+
+  def _makePerson(self):
+    # Clone computer document
+    person = self.portal.person_module.template_member\
+         .Base_createCloneDocument(batch_mode=1)
+    person.edit(reference='TESTPERSON-%s' % (self.generateNewId(), ))
+    person.immediateReindexObject()
+    return person
+
+  def _makeHostingSubscription(self):
+    person = self.portal.person_module.template_member\
+         .Base_createCloneDocument(batch_mode=1)
+    hosting_subscription = self.portal\
+      .hosting_subscription_module.template_hosting_subscription\
+      .Base_createCloneDocument(batch_mode=1)
+    hosting_subscription.validate()
+    new_id = self.generateNewId()
+    hosting_subscription.edit(
+        title= "Test hosting sub ticket %s" % new_id,
+        reference="TESTHST-%s" % new_id,
+        destination_section_value=person
+    )
+
+    return hosting_subscription
+
+  def _makeSupportRequest(self):
+    support_request = self.portal.\
+      support_request_module.\
+      slapos_crm_support_request_template_for_monitoring.\
+       Base_createCloneDocument(batch_mode=1)
+    return support_request
+
+
+  @simulate('ERP5Site_isSupportRequestCreationClosed', '','return 0')
+  @simulate('SupportRequest_updateMonitoringComputerState',
+            "",
+    'return "Visited by SupportRequest_updateMonitoringComputerState ' \
+    '%s" % (context.getRelativeUrl(),)')
+  @simulate('SupportRequest_updateMonitoringHostingSubscriptionState',
+            "",
+    'return "Visited by SupportRequest_updateMonitoringHostingSubscriptionState '\
+    '%s" % (context.getRelativeUrl(),)')
+  @simulate('SupportRequest_updateMonitoringDestroyRequestedState',
+            "",
+    'return "Visited by SupportRequest_updateMonitoringDestroyRequestedState '\
+    '%s" % (context.getRelativeUrl(),)')
+  def testSupportRequest_updateMonitoringState(self):
+    support_request = self._makeSupportRequest()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringState())
+    support_request.validate()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringState())
+    # Now try to go to set a computer...
+    support_request.setAggregateValue(self._makeComputer())
+    self.assertEquals(
+      "Visited by SupportRequest_updateMonitoringComputerState %s" % \
+        support_request.getRelativeUrl(), 
+      support_request.SupportRequest_updateMonitoringState())
+    
+    hs = self._makeHostingSubscription()
+    support_request.setAggregateValue(hs)
+    self.assertEquals(
+      "Visited by SupportRequest_updateMonitoringHostingSubscriptionState %s" %\
+        support_request.getRelativeUrl(), 
+      support_request.SupportRequest_updateMonitoringState())
+      
+    hs.getSlapState = getFakeSlapState
+    self.assertEquals(
+      "Visited by SupportRequest_updateMonitoringDestroyRequestedState %s" %\
+        support_request.getRelativeUrl(), 
+      support_request.SupportRequest_updateMonitoringState())
+    
+    support_request.invalidate()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringState())
+
+  @simulate('SupportRequest_trySendNotificationMessage',
+            "message_title, message, source_relative_url",
+     'return "Visited by SupportRequest_trySendNotificationMessage '\
+  '%s %s %s" % (message_title, message, source_relative_url)')
+  def testSupportRequest_updateMonitoringComputerState(self):
+    support_request = self._makeSupportRequest()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringComputerState())
+    support_request.validate()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringComputerState())
+    support_request.setAggregateValue(self._makeHostingSubscription())
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringComputerState())
+    
+    support_request.setAggregateValue(self._makeComputer())
+    memcached_dict = self.portal.portal_memcached.getMemcachedDict(
+        key_prefix='slap_tool',
+        plugin_path='portal_memcached/default_memcached_plugin')
+
+    memcached_dict[support_request.getAggregateValue().getReference()] = json.dumps({
+      "created_at": DateTime().strftime("%Y/%m/%d %H:%M")
+    })
+    # W/o destination decision the ticket is not notified.
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringComputerState())
+    
+    support_request.setDestinationDecisionValue(self._makePerson())
+    expected_text = """Visited by SupportRequest_trySendNotificationMessage Computer is contacting again  Suspending this ticket as the computer contacted again.  %s""" % support_request.getDestinationDecision()
+    self.assertEquals(expected_text, 
+      support_request.SupportRequest_updateMonitoringComputerState())
+    self.assertEquals(support_request.getSimulationState(), "suspended")
+
+  @skip("Missing to finish")
+  @simulate('SupportRequest_trySendNotificationMessage',
+            "message_title, message, source_relative_url",
+     'return "Visited by SupportRequest_trySendNotificationMessage '\
+  '%s %s %s" % (message_title, message, source_relative_url)')
+  def testSupportRequest_updateMonitoringHostingSubscriptionState(self):
+    support_request = self._makeSupportRequest()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringHostingSubscriptionState())
+    support_request.validate()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringHostingSubscriptionState())
+    
+    support_request.setAggregateValue(self._makeComputer())
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringHostingSubscriptionState())
+    
+    support_request.setAggregateValue(self._makeHostingSubscription())
+    support_request.setDestinationDecisionValue(self._makePerson())
+    raise NotImplementedError("Not implemented yet")
+
+  @simulate('SupportRequest_trySendNotificationMessage',
+            "message_title, message, source_relative_url",
+     'return "Visited by SupportRequest_trySendNotificationMessage '\
+  '%s %s %s" % (message_title, message, source_relative_url)')
+  def testSupportRequest_updateMonitoringDestroyRequestedState(self):
+    support_request = self._makeSupportRequest()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringDestroyRequestedState())
+    support_request.validate()
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringDestroyRequestedState())
+    
+    support_request.setAggregateValue(self._makeComputer())
+    self.assertEquals(None, 
+      support_request.SupportRequest_updateMonitoringDestroyRequestedState())
+    
+    hs = self._makeHostingSubscription()
+    support_request.setAggregateValue(hs)
+
+    hs.getSlapState = getFakeSlapState
+    self.commit()
+
+    support_request.setDestinationDecisionValue(self._makePerson())
+    expected_text = """Visited by SupportRequest_trySendNotificationMessage Hosting Subscription was destroyed was destroyed by the user  Closing this ticket as the Hosting Subscription was destroyed by the user. 
+   %s""" % support_request.getDestinationDecision()
+    self.assertEquals(expected_text, 
+      support_request.SupportRequest_updateMonitoringDestroyRequestedState())
     
+    self.assertEquals("invalidated", 
+      support_request.getSimulationState())